coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: util/docker: Add libgpiod-dev to coreboot-sdk for flashrom
by Edward O'Callaghan (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Felix Singer, Martin L Roth. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72371 ) Change subject: util/docker: Add libgpiod-dev to coreboot-sdk for flashrom ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88f7e11fab115487cc44d4b89b3eab4745ad058d Gerrit-Change-Number: 72371 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 10:32:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kano: Update ELAN TS delay time to 150ms
by David Wu (Code Review) 04 Feb '23

04 Feb '23

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72784 ) Change subject: mb/google/brya/var/kano: Update ELAN TS delay time to 150ms ...................................................................... mb/google/brya/var/kano: Update ELAN TS delay time to 150ms ELAN updated the datasheet, the HID/I2C protocol's T3 delay time is 150ms now. Modify the kano's delay time to follow the requiremnet. BUG=b:247944006 TEST=Manually checked touchscreen works after reboot and suspend. Change-Id: I42a7737060a82c0b27717f1510b8ec64abd1465a Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/kano/overridetree.cb 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/72784/1 diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb index 2eca449..97682bd 100644 --- a/src/mainboard/google/brya/variants/kano/overridetree.cb +++ b/src/mainboard/google/brya/variants/kano/overridetree.cb @@ -400,7 +400,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "20" + register "generic.reset_delay_ms" = "150" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" -- To view, visit https://review.coreboot.org/c/coreboot/+/72784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a7737060a82c0b27717f1510b8ec64abd1465a Gerrit-Change-Number: 72784 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: amdfwtool: Change .rom.efs to .rom and .rom to .rom.body
by Bao Zheng (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Hello Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Karthik Ramasubramanian, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72702 to look at the new patch set (#2). Change subject: amdfwtool: Change .rom.efs to .rom and .rom to .rom.body ...................................................................... amdfwtool: Change .rom.efs to .rom and .rom to .rom.body The non-vboot also need to split amdfw. Keep the default filename which is located at EFS. Change-Id: Id77b11422d4549cf57a1cd8980c7a9cf3597d1bc Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M src/soc/amd/mendocino/Makefile.inc M util/amdfwtool/amdfwtool.c 2 files changed, 52 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/72702/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id77b11422d4549cf57a1cd8980c7a9cf3597d1bc Gerrit-Change-Number: 72702 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: treewide: Remove unuseful "_HID: Hardware ID" comment
by Elyes Haouas (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72661 ) Change subject: treewide: Remove unuseful "_HID: Hardware ID" comment ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > If we're going to delete all the comments just because ACPI defines them I'd like to remove them not only because they are already defined in ACPI specs, but also to avoid some mixing styles of comments ( "/*" with "//" at the end or "//" with "*/" at the end) ==> reduce the risk of errors. -- To view, visit https://review.coreboot.org/c/coreboot/+/72661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eb1424e9e6c1fbf20cd0bf68fbb52e1ec97f905 Gerrit-Change-Number: 72661 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 04 Feb 2023 09:06:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/constitution: Add SOLDERDOWN support
by Morris Hsu (Code Review) 04 Feb '23

04 Feb '23

1 0

[M] Change in coreboot[master]: mb/google/brya/var/constitution: Add SOLDERDOWN support
by Morris Hsu (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos. Hello build bot (Jenkins), David Wu, Tarun Tuli, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72775 to look at the new patch set (#6). Change subject: mb/google/brya/var/constitution: Add SOLDERDOWN support ...................................................................... mb/google/brya/var/constitution: Add SOLDERDOWN support Constitution will use SOLDERDOWN. Add memory.c to override baseboard. Add mem_parts_used.txt and generate dram_id.generated.txt and Makefile.inc Memory: SAMSUNG K4U6E3S4AB-MGCL MICRON MT53E1G32D2NP-046 WT:B BUG=b:267539938 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a Change-Id: Id879b2a7491f29e9fca903dcf3c022ec8ffffab4 Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/constitution/Makefile.inc A src/mainboard/google/brya/variants/constitution/memory.c A src/mainboard/google/brya/variants/constitution/memory/Makefile.inc A src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/constitution/memory/mem_parts_used.txt 7 files changed, 147 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/72775/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/72775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id879b2a7491f29e9fca903dcf3c022ec8ffffab4 Gerrit-Change-Number: 72775 Gerrit-PatchSet: 6 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Pablo Ceballos <pceballos(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Pablo Ceballos <pceballos(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Use HI-556W for Proto 1 SKUs
by Subrata Banik (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70225 ) Change subject: mb/google/rex: Use HI-556W for Proto 1 SKUs ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Need to wait for Proto 1 Main build -- To view, visit https://review.coreboot.org/c/coreboot/+/70225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b8ac08adec351a103ac1764d974db4881dc4d6e Gerrit-Change-Number: 70225 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 08:56:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/constitution: Add SOLDERDOWN support
by Morris Hsu (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos. Morris Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72775 ) Change subject: mb/google/brya/var/constitution: Add SOLDERDOWN support ...................................................................... Patch Set 5: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72775/comment/514a6857_a0922e36 PS4, Line 7: SOLDERDOWN > Maybe: Configure for soldered down memory SOLDERDOWN means memory soldered on board. https://review.coreboot.org/c/coreboot/+/72775/comment/d48b2627_ea14443c PS4, Line 7: SOLDERDOWN > Maybe: Configure for soldered down memory SOLDERDOWN means memory soldered on board. File src/mainboard/google/brya/variants/constitution/memory.c: https://review.coreboot.org/c/coreboot/+/72775/comment/51b5f5d4_268bd8f6 PS4, Line 14: /* Baseboard Rcomp target values */ > Where did you get these from? It comes from baseboard brya. https://review.coreboot.org/c/coreboot/+/72775/comment/dc311536_493831eb PS4, Line 14: /* Baseboard Rcomp target values */ > Where did you get these from? Refer to intel doc#573387 to calculate value. https://review.coreboot.org/c/coreboot/+/72775/comment/6300dcd9_79127e2b PS4, Line 15: .targets = {40, 30, 30, 30, 30}, > Below there is a space after { and before }. This format is as same as baseboard brya, do you mean I should delete a space and makes it like .targets={40,30,30,30,30} ? https://review.coreboot.org/c/coreboot/+/72775/comment/d36d9a09_da22790e PS4, Line 18: /* DQ byte map */ > Where did you get these from? Please add the document number to the comment. Refer to intel doc#573387 to calculate value. https://review.coreboot.org/c/coreboot/+/72775/comment/c4318b74_b440ec50 PS4, Line 18: /* DQ byte map */ > Where did you get these from? Please add the document number to the comment. Refer to intel doc#573387 and calculate value. -- To view, visit https://review.coreboot.org/c/coreboot/+/72775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id879b2a7491f29e9fca903dcf3c022ec8ffffab4 Gerrit-Change-Number: 72775 Gerrit-PatchSet: 5 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Pablo Ceballos <pceballos(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Pablo Ceballos <pceballos(a)google.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 08:48:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable MRC Fast Boot
by Subrata Banik (Code Review) 04 Feb '23

04 Feb '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/72745 ) Change subject: soc/intel/meteorlake: Enable MRC Fast Boot ...................................................................... soc/intel/meteorlake: Enable MRC Fast Boot This patch requests FSP to enable the MRC fast boot feature along with FSP v2473. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: If4a621e55c853505f7a702181ae5a70dc56d5b5a Reviewed-on: https://review.coreboot.org/c/coreboot/+/72745 Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/meteorlake/romstage/fsp_params.c 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/soc/intel/meteorlake/romstage/fsp_params.c b/src/soc/intel/meteorlake/romstage/fsp_params.c index c01896f..920eb53 100644 --- a/src/soc/intel/meteorlake/romstage/fsp_params.c +++ b/src/soc/intel/meteorlake/romstage/fsp_params.c @@ -124,6 +124,8 @@ { m_cfg->SaGv = config->sagv; m_cfg->RMT = config->rmt; + /* Enable MRC Fast Boot */ + m_cfg->MrcFastBoot = 1; } static void fill_fspm_cpu_params(FSP_M_CONFIG *m_cfg, -- To view, visit https://review.coreboot.org/c/coreboot/+/72745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4a621e55c853505f7a702181ae5a70dc56d5b5a Gerrit-Change-Number: 72745 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Subrata Banik (Code Review) 04 Feb '23

04 Feb '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70226 ) Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs This patch drops the WFC sensor OV8856 (reused from the Brya chassis) support for Rex and added support for Rex specific UFC sensor OV13B10. BUG=b:267264348 TEST=WFC MIPI cameras have been enabled using google/rex Proto 1. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Reviewed-on: https://review.coreboot.org/c/coreboot/+/70226 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tarun Tuli <taruntuli(a)google.com> --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 28 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Tarun Tuli: Looks good to me, approved Kapil Porwal: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index f3952a2..1672bf6 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -242,7 +242,7 @@ register "device_type" = "INTEL_ACPI_CAMERA_CIO2" register "cio2_num_ports" = "2" - register "cio2_lanes_used" = "{2,2}" # 2 CSI Camera lanes are used + register "cio2_lanes_used" = "{4,2}" # 4 and 2 CSI Camera lanes are used register "cio2_lane_endpoint[0]" = ""^I2C0.CAM0"" register "cio2_lane_endpoint[1]" = ""^I2C5.CAM1"" register "cio2_prt[0]" = "4" @@ -270,19 +270,18 @@ end end chip drivers/intel/mipi_camera - register "acpi_hid" = ""OVTI8856"" + register "acpi_hid" = ""OVTIDB10"" register "acpi_uid" = "0" register "acpi_name" = ""CAM0"" - register "chip_name" = ""Ov 8856 Camera"" + register "chip_name" = ""Ov 13b10 Camera"" register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" - register "ssdb.lanes_used" = "2" + register "ssdb.lanes_used" = "4" register "ssdb.link_used" = "0" register "ssdb.vcm_type" = "0x0C" register "vcm_name" = ""VCM0"" - register "num_freq_entries" = "2" - register "link_freq[0]" = "720 * MHz" # 720 MHz - register "link_freq[1]" = "360 * MHz" # 360 MHz + register "num_freq_entries" = "1" + register "link_freq[0]" = "560 * MHz" # 560 MHz register "remote_name" = ""IPU0"" register "has_power_resource" = "1" @@ -309,7 +308,7 @@ register "off_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" - device i2c 10 on + device i2c 36 on probe WFC WFC_MIPI end end -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023