coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Subrata Banik (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Ivy Jian. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70226 ) Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/70226/comment/d9505a12_3d2198f2 PS7, Line 276: b > fine Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 08:27:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
by Eric Lai (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Subrata Banik, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70226 ) Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/70226/comment/1f51a569_b34bf03b PS7, Line 276: b > > > nit: 13B10 […] fine -- To view, visit https://review.coreboot.org/c/coreboot/+/70226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541 Gerrit-Change-Number: 70226 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 08:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "UPSTREAM: mb/google/rex: Enable SaGv"
by Subrata Banik (Code Review) 04 Feb '23

04 Feb '23

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72774 ) Change subject: Revert "UPSTREAM: mb/google/rex: Enable SaGv" ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72774/comment/7d52ab8d_c5d0b247 PS3, Line 13: TEST=Able to see ChromeOS UI in consecutive boot. > Wasn’t the commit before not tested? (It it indeed misses a TEST= line.) We had tested this with previous FSP v2341. with new FSP this feature got regressed. -- To view, visit https://review.coreboot.org/c/coreboot/+/72774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcc36515f7550c183c40e5af94684f5c3e39a7a Gerrit-Change-Number: 72774 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Vikrant Jadeja Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 04 Feb 2023 08:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src: Move POST_BOOTBLOCK_CAR to common postcodes and use it
by Elyes Haouas (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71596 ) Change subject: src: Move POST_BOOTBLOCK_CAR to common postcodes and use it ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8527334e679a23006b77a5645f919aea76dd4926 Gerrit-Change-Number: 71596 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 07:30:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/constitution: Add SOLDERDOWN support
by Paul Menzel (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Tarun Tuli, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos, Morris Hsu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72775 ) Change subject: mb/google/brya/var/constitution: Add SOLDERDOWN support ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72775/comment/4e94264e_2c2f4e8c PS4, Line 7: SOLDERDOWN > What is SOLDERDOWN? Maybe: Configure for soldered down memory -- To view, visit https://review.coreboot.org/c/coreboot/+/72775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id879b2a7491f29e9fca903dcf3c022ec8ffffab4 Gerrit-Change-Number: 72775 Gerrit-PatchSet: 5 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Pablo Ceballos <pceballos(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Pablo Ceballos <pceballos(a)google.com> Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 07:11:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/constitution: Add SOLDERDOWN support
by Paul Menzel (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Tarun Tuli, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos, Morris Hsu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72775 ) Change subject: mb/google/brya/var/constitution: Add SOLDERDOWN support ...................................................................... Patch Set 4: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72775/comment/9ae6862b_b7db3bb9 PS4, Line 7: SOLDERDOWN What is SOLDERDOWN? File src/mainboard/google/brya/variants/constitution/memory.c: https://review.coreboot.org/c/coreboot/+/72775/comment/e7ecb25a_7fbcd162 PS4, Line 14: /* Baseboard Rcomp target values */ Where did you get these from? https://review.coreboot.org/c/coreboot/+/72775/comment/ac36c8df_ef96c44b PS4, Line 15: .targets = {40, 30, 30, 30, 30}, Below there is a space after { and before }. https://review.coreboot.org/c/coreboot/+/72775/comment/88cdeec4_01282ebc PS4, Line 18: /* DQ byte map */ Where did you get these from? Please add the document number to the comment. File src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt: https://review.coreboot.org/c/coreboot/+/72775/comment/538cc641_87e513ca PS4, Line 8: MT53E1G32D2NP-046 WT:B 1 (0001) Please mention the parts (and vendor) in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/72775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id879b2a7491f29e9fca903dcf3c022ec8ffffab4 Gerrit-Change-Number: 72775 Gerrit-PatchSet: 4 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Pablo Ceballos <pceballos(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Pablo Ceballos <pceballos(a)google.com> Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 07:11:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: test
by Morris Hsu (Code Review) 04 Feb '23

04 Feb '23

Morris Hsu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/72776 ) Change subject: test ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/72776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5abbe07d3a231b88c48049c553dfab5e2b8e77e Gerrit-Change-Number: 72776 Gerrit-PatchSet: 1 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: mb/google/brya/var/constitution: Add SOLDERDOWN support
by Morris Hsu (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Tarun Tuli, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos, Morris Hsu. Hello build bot (Jenkins), David Wu, Tarun Tuli, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72775 to look at the new patch set (#5). Change subject: mb/google/brya/var/constitution: Add SOLDERDOWN support ...................................................................... mb/google/brya/var/constitution: Add SOLDERDOWN support Constitution will use SOLDERDOWN. Add memory.c to override baseboard. Add mem_parts_used.txt and generate dram_id.generated.txt and Makefile.inc BUG=b:267539938 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a Change-Id: Id879b2a7491f29e9fca903dcf3c022ec8ffffab4 Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/constitution/Makefile.inc A src/mainboard/google/brya/variants/constitution/memory.c A src/mainboard/google/brya/variants/constitution/memory/Makefile.inc A src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/constitution/memory/mem_parts_used.txt 7 files changed, 147 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/72775/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/72775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id879b2a7491f29e9fca903dcf3c022ec8ffffab4 Gerrit-Change-Number: 72775 Gerrit-PatchSet: 5 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Pablo Ceballos <pceballos(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Pablo Ceballos <pceballos(a)google.com> Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Revert "UPSTREAM: mb/google/rex: Enable SaGv"
by Paul Menzel (Code Review) 04 Feb '23

04 Feb '23

Attention is currently required from: Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72774 ) Change subject: Revert "UPSTREAM: mb/google/rex: Enable SaGv" ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72774/comment/28f87da7_1df058ad PS3, Line 7: UPSTREAM: This shouldn’t be part of the upstream commit message. https://review.coreboot.org/c/coreboot/+/72774/comment/b8e25b75_db9664eb PS3, Line 10: Mostly likely Most likely https://review.coreboot.org/c/coreboot/+/72774/comment/e6cc559e_906514de PS3, Line 10: MeteorLake Meteor Lake https://review.coreboot.org/c/coreboot/+/72774/comment/63d8c620_6d9a72c8 PS3, Line 13: TEST=Able to see ChromeOS UI in consecutive boot. Wasn’t the commit before not tested? (It it indeed misses a TEST= line.) -- To view, visit https://review.coreboot.org/c/coreboot/+/72774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcc36515f7550c183c40e5af94684f5c3e39a7a Gerrit-Change-Number: 72774 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Vikrant Jadeja Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Sat, 04 Feb 2023 06:48:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: test
by Morris Hsu (Code Review) 04 Feb '23

04 Feb '23

Morris Hsu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/72729 ) Change subject: test ...................................................................... Abandoned not mine -- To view, visit https://review.coreboot.org/c/coreboot/+/72729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88ee8f380513bc6490c9f84f3e41cb044f9a3afb Gerrit-Change-Number: 72729 Gerrit-PatchSet: 2 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023