coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[S] Change in coreboot[master]: mtlrvp: add SI_EC region in flash map
by Deepti Deshatty (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Krishna P Bhat D, V Sowmya. Hello Balaji Manigandan, Deepti Deshatty, Krishna P Bhat D, V Sowmya, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78398?usp=email to look at the new patch set (#4). Change subject: mtlrvp: add SI_EC region in flash map ...................................................................... mtlrvp: add SI_EC region in flash map MTLRVP booted with microchip EC1723 which do not have an internal flash memory similar to the windows RVP designs. Using MEC1723 for chrome helps in RVP BOM convergence. EC, AP shares the same external SPI flash. EC ROM will download the EC firmware from external SPI to internal SRAM for execution. This patch adds SI_EC region similar to windows. Change-Id: I788dbeaad05e5d6904fb2c7c681a0bf653dc7d84 Signed-off-by: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/chromeos.fmd 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/78398/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78398?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I788dbeaad05e5d6904fb2c7c681a0bf653dc7d84 Gerrit-Change-Number: 78398 Gerrit-PatchSet: 4 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/brya/var/taeko: Generate SPD ID for new supported memory part
by Leo Chou (Code Review) 21 Nov '23

21 Nov '23

Leo Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79207?usp=email ) Change subject: mb/google/brya/var/taeko: Generate SPD ID for new supported memory part ...................................................................... mb/google/brya/var/taeko: Generate SPD ID for new supported memory part Add taeko new supported memory parts in mem_parts_used.txt, generate SPD id for this part. 1. Samsung K4UBE3D4AB-MGCL 2. Micron MT53E1G32D2NP-046 WT:B BUG=b:312363368 TEST=Use part_id_gen to generate related settings Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: I221ad3f490f24b43fe1ccd211014787eab5d1038 --- M src/mainboard/google/brya/variants/taeko/memory/Makefile.inc M src/mainboard/google/brya/variants/taeko/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt 3 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/79207/1 diff --git a/src/mainboard/google/brya/variants/taeko/memory/Makefile.inc b/src/mainboard/google/brya/variants/taeko/memory/Makefile.inc index 2ac3e32..458f555 100644 --- a/src/mainboard/google/brya/variants/taeko/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/taeko/memory/Makefile.inc @@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# util/spd_tools/bin/part_id_gen ADL lp4x src/mainboard/google/brya/variants/taeko/memory src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt +# ./util/spd_tools/bin/part_id_gen ADL lp4x src/mainboard/google/brya/variants/taeko/memory/ src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt SPD_SOURCES = SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE, MT53E512M32D1NP-046 WT:B, K4U6E3S4AB-MGCL, H54G46CYRBX267 +SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 1(0b0001) Parts = K4UBE3D4AB-MGCL, MT53E1G32D2NP-046 WT:B diff --git a/src/mainboard/google/brya/variants/taeko/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/taeko/memory/dram_id.generated.txt index fda303c..4787674 100644 --- a/src/mainboard/google/brya/variants/taeko/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/taeko/memory/dram_id.generated.txt @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# util/spd_tools/bin/part_id_gen ADL lp4x src/mainboard/google/brya/variants/taeko/memory src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt +# ./util/spd_tools/bin/part_id_gen ADL lp4x src/mainboard/google/brya/variants/taeko/memory/ src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt DRAM Part Name ID to assign MT53E512M32D2NP-046 WT:E 0 (0000) @@ -10,3 +10,5 @@ MT53E512M32D1NP-046 WT:B 0 (0000) K4U6E3S4AB-MGCL 0 (0000) H54G46CYRBX267 0 (0000) +K4UBE3D4AB-MGCL 1 (0001) +MT53E1G32D2NP-046 WT:B 1 (0001) diff --git a/src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt index dd80fc8..6f7967f 100644 --- a/src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/taeko/memory/mem_parts_used.txt @@ -4,3 +4,5 @@ MT53E512M32D1NP-046 WT:B K4U6E3S4AB-MGCL H54G46CYRBX267 +K4UBE3D4AB-MGCL +MT53E1G32D2NP-046 WT:B -- To view, visit https://review.coreboot.org/c/coreboot/+/79207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I221ad3f490f24b43fe1ccd211014787eab5d1038 Gerrit-Change-Number: 79207 Gerrit-PatchSet: 1 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: mb/google/nissa/var/craaskov: Add 6W and 15W DPTF parameters
by Eric Lai (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Dtrain Hsu, Frank Wu, Ian Feng, John Su, Nick Vaccaro, Subrata Banik, Van Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79183?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add 6W and 15W DPTF parameters ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79183?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02b4187000eec9990bf10a57875b23007f7bdd12 Gerrit-Change-Number: 79183 Gerrit-PatchSet: 3 Gerrit-Owner: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 02:59:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Yidi Lin (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email ) Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 02:59:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/asus/p8z77-m[_pro]: Properly configure early serial
by Keith Hui (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Angel Pons, Nico Huber, Patrick Rudolph, Paul Menzel, Vlado Cibic. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73693?usp=email ) Change subject: mb/asus/p8z77-m[_pro]: Properly configure early serial ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > Devicetrees of these two differ: '-M' enables a UART A, '-M PRO' enables a UART B. […] I looked at -M PRO's devicetree again. Its serial port setup is broken in other ways. As you said it enables UART B, places it at I/O port 0x2f8 like a second serial port should (but didn't match CONFIG_TTYS0_BASE) but didn't program an IRQ, and no superio programming to route any serial port signals out (which the code in question here should have done). And I don't see any other boards that enable UART B and only UART B. It'll need a proper fix and a proper testing by someone with the hardware. So I'm going to split -M off into its own patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/73693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304fc1610740375b59121b6b8784122440795838 Gerrit-Change-Number: 73693 Gerrit-PatchSet: 9 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Vlado Cibic Gerrit-Comment-Date: Tue, 21 Nov 2023 02:36:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards
by Yu-Ping Wu (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Felix Singer, Julius Werner, Nico Huber, Shelley Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79022?usp=email ) Change subject: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/herobrine/Kconfig: https://review.coreboot.org/c/coreboot/+/79022/comment/4f6711d5_4af18091 : PS2, Line 14: config BOARD_GOOGLE_HEROBRINE These should be removed. File src/mainboard/google/trogdor/Kconfig: https://review.coreboot.org/c/coreboot/+/79022/comment/fcf01e7b_a9e6befb : PS2, Line 18: config BOARD_GOOGLE_BUBS These should be removed. -- To view, visit https://review.coreboot.org/c/coreboot/+/79022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Gerrit-Change-Number: 79022 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 02:29:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/geralt: Disable SD card support for Ciri
by Ruihai Zhou (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Paul Menzel. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78958?usp=email ) Change subject: mb/google/geralt: Disable SD card support for Ciri ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78958/comment/77085be3_1d68ea4b : PS4, Line 7: mb/google/geralt: Disable SD card support for Ciri > I don't know if coreboot upstream has documentation describing this. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78958?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4e021e7896d093560f39c40573ac616d76438c2 Gerrit-Change-Number: 78958 Gerrit-PatchSet: 4 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 02:22:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Yu-Ping Wu (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email ) Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/df56a761_7b31c3b8 : PS1, Line 22: select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU > I hope I can still assume that at least Staryu is the variant for all the MIPI boards, though? Yes we can. > I think it would be best to just have an explicit list for each instead. I wrote it that way now, let me know what you think. Agreed. PS2 looks good to me. File src/mainboard/google/geralt/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/51494960_aea1c083 : PS2, Line 74: choice > I removed the `choice` here because a choice always needs to have a prompt, and these kinds of hardw […] Fine by me. -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 02:21:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Ensure RAM stays powered in ACPI S3 suspend
by Keith Hui (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Kevin Keijzer, Paul Menzel. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78205?usp=email ) Change subject: mb/asus/p8z77-m: Ensure RAM stays powered in ACPI S3 suspend ...................................................................... Patch Set 4: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78205/comment/27b461dd_54cac256 : PS2, Line 7: Fix ACPI S3 suspend : > When 3VSBSW# is disabled, the RAM loses power in S3 suspend, so S3 resume fails. […] Done https://review.coreboot.org/c/coreboot/+/78205/comment/4ef014a3_7247451b : PS2, Line 9: Enable 3VSBSW# in NCT6779D super I/O like other variants in the : family. Without it S3 suspend totally fails. > It would be nice to factor in the root cause: S3 resume fails because the RAM was not powered during […] Done https://review.coreboot.org/c/coreboot/+/78205/comment/9ca1b5a7_d6330411 : PS2, Line 10: S3 suspend totally fails > nit: Strictly speaking, it is S3 *resume* that totally fails. […] Acknowledged Patchset: PS2: > @Paul, @Angel, I am holding off resolving the commit message comments because this patch is again no […] ... Patchset: PS4: For the record, this fix works for @Kevin, but didn't work for me at this moment. Seeing that my OS also couldn't power off by software, I may have other bigger problems. -- To view, visit https://review.coreboot.org/c/coreboot/+/78205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia8059b2a263ab5c459e54685f046eeb913776473 Gerrit-Change-Number: 78205 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 02:12:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Julius Werner (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Felix Singer, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email ) Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... Patch Set 2: (4 comments) File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/5df5bf87_7ff2e60a : PS1, Line 22: select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU > I prefer Yu-Ping's idea in the first comment. […] Oh okay, I just kinda assumed here from the existing patterns that there was some expectation that most boards of the same subvariant would use the same bridge. If that's not true, then I agree it would be best to not depend on the subvariant options at all for this. (I hope I can still assume that at least Staryu is the variant for all the MIPI boards, though? Or is that also just coincidence?) I'm also not really convinced about the "everything that's not ANX is Parade", though... don't you think that risks boards that get added in the future being accidentally treated as "Parade" because someone just forgot to add an option. If we expect the two to be roughly even and there's no preset assumption that "most" boards are Parade, I think it would be best to just have an explicit list for each instead. I wrote it that way now, let me know what you think. File src/mainboard/google/geralt/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/ba2f6152_d223e7cd : PS1, Line 5: def_bool BOARD_GOOGLE_GERALT > And `BOARD_GOOGLE_CIRI` (added by a recent patch CB:78954). Done https://review.coreboot.org/c/coreboot/+/79063/comment/6f7cb01c_6fd85507 : PS1, Line 62: SDCARD_INIT > Also modify this for consistency (need to rebase). Done File src/mainboard/google/geralt/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/ed58048c_41e07162 : PS2, Line 74: choice I removed the `choice` here because a choice always needs to have a prompt, and these kinds of hardware description Kconfigs should not show up in menuconfig. I think it's fine to just have two separate `bool` options, but if you think it is important that they're mutually exclusive I could also add a `depends on !THE_OTHER_ONE` to each (or maybe a static assertion to the code... for two it's not a big difference, but when you want to select exactly one out of more than two then `_Static_assert(CONFIG(A) + CONFIG(B) + CONFIG(C) == 1)` is usually the shortest way to check that). -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 02:09:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023