coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Ensure RAM stays powered in ACPI S3 suspend
by Keith Hui (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Kevin Keijzer, Paul Menzel. Hello Angel Pons, Arthur Heymans, Kevin Keijzer, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78205?usp=email to look at the new patch set (#4). Change subject: mb/asus/p8z77-m: Ensure RAM stays powered in ACPI S3 suspend ...................................................................... mb/asus/p8z77-m: Ensure RAM stays powered in ACPI S3 suspend Enable 3VSBSW# in NCT6779D super I/O like other variants in the family, needed to maintain power to memory during S3 suspend. Without it resuming totally fails. (Enabling it in devicetree is OK; it needs not be done in early board init.) TEST=Resuming from S3 works. Change-Id: Ia8059b2a263ab5c459e54685f046eeb913776473 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/78205/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia8059b2a263ab5c459e54685f046eeb913776473 Gerrit-Change-Number: 78205 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards
by Julius Werner (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Felix Singer, Nico Huber, Shelley Chen, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79022?usp=email ) Change subject: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/gru/Kconfig: https://review.coreboot.org/c/coreboot/+/79022/comment/fe3134e5_1aa9e5fd : PS1, Line 3: # Umbrella option to be selected by variant boards. > This comment seems outdated maybe obsolete (two more below) Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Gerrit-Change-Number: 79022 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 02:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Julius Werner (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner, Yu-Ping Wu. Hello Felix Singer, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79063?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... google/*: Clean up Kconfg board selection for Google MTK boards This patch tries to standardize and simplify the Kconfig option layout for Google boards with MediaTek SoCs and align them to the scheme used with other Arm-based Google boards. Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/asurada/Kconfig M src/mainboard/google/cherry/Kconfig M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/mainboard.c M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/chromeos.c M src/mainboard/google/geralt/mainboard.c M src/mainboard/google/kukui/Kconfig M src/mainboard/google/oak/Kconfig 9 files changed, 102 insertions(+), 194 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/79063/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards
by Julius Werner (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Felix Singer, Julius Werner, Nico Huber, Shelley Chen, Yu-Ping Wu. Hello Felix Singer, Nico Huber, Shelley Chen, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79022?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Nico Huber, Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) Change subject: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards ...................................................................... google/*: Clean up Kconfig board selection for non-MTK Google Arm boards This patch unifies and simplifies the Kconfig selection model for the Gru, Herobrine, Trogdor and Veyron boards according to the model discussed in CB:78972. Also add missing license headers to two Kconfig files while I'm here. Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/Kconfig M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/veyron/Kconfig 4 files changed, 60 insertions(+), 74 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/79022/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Gerrit-Change-Number: 79022 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Update fw_config settings
by Tyler Wang (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: David Wu, Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79176?usp=email ) Change subject: mb/google/rex/var/karis: Update fw_config settings ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/rex/variants/karis/overridetree.cb: https://review.coreboot.org/c/coreboot/+/79176/comment/6bedd00a_4faa3dae : PS1, Line 32: THERMAL_SETTING_1 > is there any better term to define `THERMAL_SETTING_1` How about ```THERMAL_SOLUTION_1```? -- To view, visit https://review.coreboot.org/c/coreboot/+/79176?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a8a68b2a6c42045d541690ddb111fbf617b45d6 Gerrit-Change-Number: 79176 Gerrit-PatchSet: 1 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 01:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Robert Chen (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79173/comment/ba5cf6ec_95c7d5c1 : PS3, Line 7: DB_NONE > DB should imply Daughter Board Done https://review.coreboot.org/c/coreboot/+/79173/comment/601ad4ae_87f902b1 : PS3, Line 11: > Please document the schematic version. It's by internal discuss and no release schematic for now. File src/mainboard/google/brya/variants/quandiso/fw_config.c: https://review.coreboot.org/c/coreboot/+/79173/comment/6d5a3a39_180b0c75 : PS3, Line 96: printk(BIOS_INFO, "Disable USBC1 AUX Pins.\n"); > Info level messages should be more elaborate. Maybe add: … according to fw_config. Done https://review.coreboot.org/c/coreboot/+/79173/comment/056928cb_b666b273 : PS3, Line 96: Pins > pins Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 01:53:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shawn Ku <shawnku(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Robert Chen (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Robert Chen, Shawn Ku, Subrata Banik. Hello Eric Lai, Nick Vaccaro, Shawn Ku, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79173?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by Shawn Ku, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard Disable un-used usb ports and configure the AUX pins as NC based on the FW_CONFIG setting when the C1 port is not present on quandiso new daughterboard. BUG=b:312094048 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/quandiso/fw_config.c M src/mainboard/google/brya/variants/quandiso/overridetree.cb 2 files changed, 27 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/79173/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo
by Julius Werner (Code Review) 21 Nov '23

21 Nov '23

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79026?usp=email ) Change subject: soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: (Strange... I don't understand why I didn't get an email for this even though I have notifications for soc/qualcomm enabled.) I don't think this was a good idea and I would prefer to revert this patch. The blobs are essential to make these SoCs run and with this patch people just silently get non-working images back without anything telling them that they need to enable some Kconfig that isn't selected automatically. Can you explain what other cases you have that need this and why they can't just build with the blobs instead? My understanding is that our build tests already build with `abuild -B` (CI testing on these boards has been working just fine for years, after all). I'm not quite sure how Coverity works (does it even build every board individually?) but if it currently is not using these blobs, I don't see why we couldn't just turn them on there. That seems better than tricking people into building broken images by accident. -- To view, visit https://review.coreboot.org/c/coreboot/+/79026?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I249ac477b8f10e7fa0848e967c23a3b3b9bbd27d Gerrit-Change-Number: 79026 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 01:27:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port for DB_NONE
by Shawn Ku (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Robert Chen, Subrata Banik. Shawn Ku has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port for DB_NONE ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79173/comment/57e1a392_76d32605 : PS3, Line 7: DB_NONE > What does DB mean? DB should imply Daughter Board -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 01:19:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/common/psp_verstage: Make SPI ROM mapping configurable
by Tim Van Patten (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Mark Hasemeyer, Matt DeVillier. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79155?usp=email ) Change subject: soc/amd/common/psp_verstage: Make SPI ROM mapping configurable ...................................................................... Patch Set 1: (4 comments) File src/soc/amd/common/psp_verstage/Kconfig: https://review.coreboot.org/c/coreboot/+/79155/comment/fadc3a86_69177da0 : PS1, Line 49: default y if SOC_AMD_CEZANNE Have you tried any earlier boards as well (e.g., Grunt and Zork)? I'm wondering if this is exclusive to just Cezanne boards, or if other boards need it as well. File src/soc/amd/common/psp_verstage/boot_dev.c: https://review.coreboot.org/c/coreboot/+/79155/comment/37dfb085_f9d3f1dd : PS1, Line 40: uint32_t ret; This can be moved inside the `CONFIG` conditional block. File src/soc/amd/common/psp_verstage/fch.c: https://review.coreboot.org/c/coreboot/+/79155/comment/874585b8_ff779839 : PS1, Line 101: if (!CONFIG(PSP_VERSTAGE_MAP_ENTIRE_SPIROM)) : return spi.SpiBiosSmnBase; : : if (spi.SpiBiosSmnBase != 0) : if (svc_map_spi_rom(spi.SpiBiosSmnBase, CONFIG_ROM_SIZE, (void **)&addr)) : printk(BIOS_DEBUG, "Error mapping SPI ROM to address.\n"); : : return addr; Positive logic is easier to read, so I think this should be inverted: ``` if (CONFIG(PSP_VERSTAGE_MAP_ENTIRE_SPIROM)) { if (spi.SpiBiosSmnBase != 0) if (svc_map_spi_rom(spi.SpiBiosSmnBase, CONFIG_ROM_SIZE, (void **)&addr)) printk(BIOS_DEBUG, "Error mapping SPI ROM to address.\n"); return addr; } return spi.SpiBiosSmnBase; ``` File src/soc/amd/common/psp_verstage/psp_verstage.c: https://review.coreboot.org/c/coreboot/+/79155/comment/1cf50ba1_c7b04e3a : PS1, Line 355: boot_dev_base = rdev_mmap_full(boot_device_ro()); Missing the `post_code(POSTCODE_UNMAP_SPI_ROM);` line as well: https://review.coreboot.org/c/coreboot/+/74606/5/src/soc/amd/common/psp_ver… -- To view, visit https://review.coreboot.org/c/coreboot/+/79155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I166ac7b50b367c067e1a743fc94686e69dd07844 Gerrit-Change-Number: 79155 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 23:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023