coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3036 discussions

[M] Change in coreboot[main]: acpi/acpi.h: Add IO Remapping Table structures
by Martin L Roth (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Arthur Heymans, Cliff Huang, Lance Zhao, Naresh Solanki, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77884?usp=email ) Change subject: acpi/acpi.h: Add IO Remapping Table structures ...................................................................... Patch Set 4: Code-Review+2 (3 comments) File src/acpi/Kconfig: https://review.coreboot.org/c/coreboot/+/77884/comment/678d92a8_524f97f0 : PS4, Line 89: config ACPI_IORT What you have here is fine. I started thinking that it should also have a "depends on" for ARM, but honestly it doesn't matter, because when a "select" statement is used, it ignores all of the "depends on" attributes. Maybe add a depends on for ARM platforms as a way of documenting it? Maybe Kconfig will throw an error if it's selected without the dependencies. Your choice. To actually be effective, it needs to have the "if HAVE_ACPI_TABLES" added to where it's selected, but presumably that's another select. Hopefully nobody ever tries to disable it. File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/77884/comment/4d726c6b_53970165 : PS4, Line 81: IORT, We get a lot of conflicts here. We might want to make this table vertical and alphabetize it so that we get fewer conflicts between patches. This patch is definitely conflicting with several others in flight right now. That's probably for another patch, and not really your responsibility, but maybe something we should consider. https://review.coreboot.org/c/coreboot/+/77884/comment/47284941_05403a29 : PS4, Line 1527: /* IORT - IO Remapping Table */ I commented in https://review.coreboot.org/c/coreboot/+/78071/9/src/include/acpi/acpi.h about adding changing our methodology for this file to put the structures for tables into separate headers and just including them into this file. As with that patch, It's something to consider, but that can be done in a separate commit or not at all. We could even do a single commit that separates up the file into a bunch of headers, but that's not your responsibility... -- To view, visit https://review.coreboot.org/c/coreboot/+/77884?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4e8e3323caa714a56882939914cac510bf95d30b Gerrit-Change-Number: 77884 Gerrit-PatchSet: 4 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 19:00:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/smm: Fix get_save_state calculation
by Paul Menzel (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: EliasOfWaffle, Eugene Myers, Jérémy Compostella, Martin L Roth, Michał Żygowski, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email ) Change subject: cpu/x86/smm: Fix get_save_state calculation ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78889/comment/e37a867d_bfcaed72 : PS1, Line 14: This patch addresses the issue identified in CB:76601 and bug #511. Maybe be specific, and write that SMMSTOREv2 now works with STM? https://review.coreboot.org/c/coreboot/+/78889/comment/ab80c624_92f3c264 : PS1, Line 15: It’d be great if you added the tag below: Resolves: https://ticket.coreboot.org/issues/511 -- To view, visit https://review.coreboot.org/c/coreboot/+/78889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Gerrit-Change-Number: 78889 Gerrit-PatchSet: 1 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 18:52:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
by Nico Huber (Code Review) 02 Nov '23

02 Nov '23

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78288?usp=email ) Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume ...................................................................... Patch Set 8: (1 comment) Patchset: PS4: > Ah makes sense, so the training cache is only for S3 resume on these platforms. […] It's still not really nice what we do with this odd static-option-table implementation. There are other things that can corrupt CMOS than a power outage, so if STATIC_OPTION_TABLE needs a quirk, it shouldn't unconditionally disable the code on S3 resume. IOW, I think the condition should be cmos_need_reset = (CONFIG(STATIC_OPTION_TABLE) && !acpi_is_wakeup_s3()) || ... Another thought: Does anybody know what STATIC_OPTION_TABLE is actually supposed to do? Is there a need to involve CMOS at all or was that maybe just a hack because it was doable by altering a single line? If it doesn't need CMOS, we could add another option backend, backed by the CBFS file. That would be more code but much cleaner than adding complexity to the CMOS logic. -- To view, visit https://review.coreboot.org/c/coreboot/+/78288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I533e83f3b95f327b0e24f4d750f8812325b7770b Gerrit-Change-Number: 78288 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 18:46:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/smm: Fix get_save_state calculation
by Matt DeVillier (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: EliasOfWaffle, Eugene Myers, Jérémy Compostella, Martin L Roth, Michał Żygowski, Stefan Reinauer. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email ) Change subject: cpu/x86/smm: Fix get_save_state calculation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Gerrit-Change-Number: 78889 Gerrit-PatchSet: 1 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 18:43:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: acpi: Add PPTT support
by Martin L Roth (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Arthur Heymans, Cliff Huang, David Milosevic, Lance Zhao, Maximilian Brune, Patrick Rudolph, Tim Wawrzynczak. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78071?usp=email ) Change subject: acpi: Add PPTT support ...................................................................... Patch Set 9: (1 comment) File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/78071/comment/17801aad_8aed35e7 : PS9, Line 1392: /* As defined in ACPI 6.4 */ > Good suggestion. […] Absolutely. And I wasn't even trying to say that it's something you needed to do, just thinking with my fingers. :) -- To view, visit https://review.coreboot.org/c/coreboot/+/78071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia119e1ba15756704668116bdbc655190ec94ff10 Gerrit-Change-Number: 78071 Gerrit-PatchSet: 9 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 18:42:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: security/intel/stm: Disable STM if SMMSTORE_V2 driver is enabled
by Eugene Myers (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: EliasOfWaffle, Martin L Roth, Michał Żygowski, Paul Menzel. Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76601?usp=email ) Change subject: security/intel/stm: Disable STM if SMMSTORE_V2 driver is enabled ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: See CB:78889 for a fix -- To view, visit https://review.coreboot.org/c/coreboot/+/76601?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icfad35b4c8fd6bac15adf9346d95f8a75863a939 Gerrit-Change-Number: 76601 Gerrit-PatchSet: 4 Gerrit-Owner: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 18:26:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/smm: Fix get_save_state calculation
by Eugene Myers (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: EliasOfWaffle, Jérémy Compostella, Martin L Roth, Michał Żygowski, Stefan Reinauer. Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email ) Change subject: cpu/x86/smm: Fix get_save_state calculation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is the fix for the STM/SMMSTORE issue -- To view, visit https://review.coreboot.org/c/coreboot/+/78889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Gerrit-Change-Number: 78889 Gerrit-PatchSet: 1 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 18:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/smm: Fix get_save_state calculation
by Eugene Myers (Code Review) 02 Nov '23

02 Nov '23

Eugene Myers has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email ) Change subject: cpu/x86/smm: Fix get_save_state calculation ...................................................................... cpu/x86/smm: Fix get_save_state calculation When the STM is configured, get_save_state returns an incorrect pointer to the cpu save state because the size (rounded up to 0x100) of the processor SMM descriptor needs to be subtracted out in this case. This patch addresses the issue identified in CB:76601 and bug #511. Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Signed-off-by: Eugene D. Myers <edmyers(a)cyberpackventures.com> --- M src/cpu/x86/smm/smm_module_handler.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/78889/1 diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index 3415b02..dfa4bd2f 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -9,6 +9,7 @@ #include <cpu/x86/smm.h> #include <rmodule.h> #include <types.h> +#include <security/intel/stm/SmmStm.h> #if CONFIG(SPI_FLASH_SMM) #include <spi-generic.h> @@ -100,10 +101,18 @@ void *smm_get_save_state(int cpu) { + size_t stm_psd_size = 0; + if (cpu > smm_runtime.num_cpus) return NULL; - return (void *)(smm_runtime.save_state_top[cpu] - smm_runtime.save_state_size); + if (CONFIG(STM)) { + stm_psd_size = ALIGN_UP(sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR), + 0x100); + } + + return (void *)(smm_runtime.save_state_top[cpu] - + (smm_runtime.save_state_size - stm_psd_size)); } uint32_t smm_revision(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/78889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Gerrit-Change-Number: 78889 Gerrit-PatchSet: 1 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: Revert "soc/intel/{tigerlake,meteorlake}: Check ITBT FW version"
by Subrata Banik (Code Review) 02 Nov '23

02 Nov '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78457?usp=email ) Change subject: Revert "soc/intel/{tigerlake,meteorlake}: Check ITBT FW version" ...................................................................... Revert "soc/intel/{tigerlake,meteorlake}: Check ITBT FW version" This reverts commit 2e10a6d6f3ec46bcaf75bd066319d51f001be764. Reason for revert: The FW version check is not supported except for ADL platform. Reverted change broke S0ix functionality; the original CL was added as HW W/A for ADL ONLY. BUG=b:306214725 TEST=S0ix cycles on Rex with TBT Device attached. Change-Id: Ib8eb11d36eac4e1c94a3349386442fa3eeeaef37 Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78457 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Jamie Ryu <jamie.m.ryu(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/meteorlake/acpi/tcss.asl M src/soc/intel/meteorlake/acpi/tcss_dma.asl M src/soc/intel/tigerlake/acpi/tcss.asl M src/soc/intel/tigerlake/acpi/tcss_dma.asl 4 files changed, 2 insertions(+), 20 deletions(-) Approvals: Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified Jamie Ryu: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved diff --git a/src/soc/intel/meteorlake/acpi/tcss.asl b/src/soc/intel/meteorlake/acpi/tcss.asl index fd68744..84e15fd 100644 --- a/src/soc/intel/meteorlake/acpi/tcss.asl +++ b/src/soc/intel/meteorlake/acpi/tcss.asl @@ -452,10 +452,6 @@ /* DMA0 is not in D3Cold now. */ \_SB.PCI0.TDM0.D3CE() /* Enable DMA RTD3 */ - If (\_SB.PCI0.TDM0.IF30 != 1) { - Return - } - Printf("Push TBT RPs to D3Cold together") If (\_SB.PCI0.TRP0.VDID != 0xFFFFFFFF) { /* Put RP0 to D3 cold. */ @@ -511,10 +507,6 @@ /* DMA1 is not in D3Cold now */ \_SB.PCI0.TDM1.D3CE() /* Enable DMA RTD3. */ - If (\_SB.PCI0.TDM1.IF30 != 1) { - Return - } - Printf("Push TBT RPs to D3Cold together") If (\_SB.PCI0.TRP2.VDID != 0xFFFFFFFF) { /* Put RP2 to D3 cold. */ diff --git a/src/soc/intel/meteorlake/acpi/tcss_dma.asl b/src/soc/intel/meteorlake/acpi/tcss_dma.asl index 2586ecb..9082469 100644 --- a/src/soc/intel/meteorlake/acpi/tcss_dma.asl +++ b/src/soc/intel/meteorlake/acpi/tcss_dma.asl @@ -11,8 +11,7 @@ , 6, PMES, 1, /* 15, PME_STATUS */ Offset(0xC8), /* 0xC8, TBT NVM FW Revision */ - , 30, - IF30, 1, /* ITBT FW Version Bit30 */ + , 31, INFR, 1, /* TBT NVM FW Ready */ Offset(0xEC), /* 0xEC, TBT TO PCIE Register */ TB2P, 32, /* TBT to PCIe */ diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl index 2ae7049..5af78ed 100644 --- a/src/soc/intel/tigerlake/acpi/tcss.asl +++ b/src/soc/intel/tigerlake/acpi/tcss.asl @@ -567,10 +567,6 @@ /* DMA0 is not in D3Cold now. */ \_SB.PCI0.TDM0.D3CE() /* Enable DMA RTD3 */ - If (\_SB.PCI0.TDM0.IF30 != 1) { - Return - } - Printf("Push TBT RPs to D3Cold together") If (\_SB.PCI0.TRP0.VDID != 0xFFFFFFFF) { /* Put RP0 to D3 cold. */ @@ -626,10 +622,6 @@ /* DMA1 is not in D3Cold now */ \_SB.PCI0.TDM1.D3CE() /* Enable DMA RTD3. */ - If (\_SB.PCI0.TDM1.IF30 != 1) { - Return - } - Printf("Push TBT RPs to D3Cold together") If (\_SB.PCI0.TRP2.VDID != 0xFFFFFFFF) { /* Put RP2 to D3 cold. */ diff --git a/src/soc/intel/tigerlake/acpi/tcss_dma.asl b/src/soc/intel/tigerlake/acpi/tcss_dma.asl index 951d83d..9082469 100644 --- a/src/soc/intel/tigerlake/acpi/tcss_dma.asl +++ b/src/soc/intel/tigerlake/acpi/tcss_dma.asl @@ -11,8 +11,7 @@ , 6, PMES, 1, /* 15, PME_STATUS */ Offset(0xC8), /* 0xC8, TBT NVM FW Revision */ - , 30, - IF30, 1, /* ITBT FW Version Bit30 */ + , 31, INFR, 1, /* TBT NVM FW Ready */ Offset(0xEC), /* 0xEC, TBT TO PCIE Register */ TB2P, 32, /* TBT to PCIe */ -- To view, visit https://review.coreboot.org/c/coreboot/+/78457?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib8eb11d36eac4e1c94a3349386442fa3eeeaef37 Gerrit-Change-Number: 78457 Gerrit-PatchSet: 10 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: Revert "soc/intel/{tigerlake,meteorlake}: Check ITBT FW version"
by Subrata Banik (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Eran Mitrani, Nick Vaccaro, Paul Menzel, Ravishankar Sarawadi, Sean Rhodes, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78457?usp=email ) Change subject: Revert "soc/intel/{tigerlake,meteorlake}: Check ITBT FW version" ...................................................................... Patch Set 9: (1 comment) Patchset: PS7: > Earlier I did not test with a TBT device connected. > > I will see if I can find a TBT device and verify this CL on Rex. lets merge the CL as there was no bug report w/o this forward port CL. -- To view, visit https://review.coreboot.org/c/coreboot/+/78457?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib8eb11d36eac4e1c94a3349386442fa3eeeaef37 Gerrit-Change-Number: 78457 Gerrit-PatchSet: 9 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 17:25:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023