coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[M] Change in coreboot[master]: arch/arm64/cache: Implement helpers to obtain CPU cache details
by Martin L Roth (Code Review) 02 Nov '23

02 Nov '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78061?usp=email ) Change subject: arch/arm64/cache: Implement helpers to obtain CPU cache details ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/78061?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7022fc3c0035208bc3fdc716fc33f6b78d8e74fc Gerrit-Change-Number: 78061 Gerrit-PatchSet: 1 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/google/rex/var/rex0: update thermal settings to start fan earlier
by Martin L Roth (Code Review) 02 Nov '23

02 Nov '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78180?usp=email ) Change subject: mb/google/rex/var/rex0: update thermal settings to start fan earlier ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/78180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6580652d6165946e98ecf1b46ace3352cd34dcdf Gerrit-Change-Number: 78180 Gerrit-PatchSet: 7 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: mb/lenovo/t520: Drop unused includes
by Martin L Roth (Code Review) 02 Nov '23

02 Nov '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76998?usp=email ) Change subject: mb/lenovo/t520: Drop unused includes ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76998?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1b201fe4dd29bac5feb08f372d1e36353eac161d Gerrit-Change-Number: 76998 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/crystaldrift: Update the STT settings
by Martin L Roth (Code Review) 02 Nov '23

02 Nov '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78507?usp=email ) Change subject: mb/google/skyrim/var/crystaldrift: Update the STT settings ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/78507?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1df9bbf820b5a760007dcfd7bceb21063fc24696 Gerrit-Change-Number: 78507 Gerrit-PatchSet: 1 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chao Gui <chaogui(a)google.com> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: cpu/x86/smm: Fix get_save_state calculation
by Jérémy Compostella (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: EliasOfWaffle, Eugene Myers, Martin L Roth, Michał Żygowski, Paul Menzel, Stefan Reinauer. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email ) Change subject: cpu/x86/smm: Fix get_save_state calculation ...................................................................... Patch Set 2: (1 comment) File src/cpu/x86/smm/smm_module_handler.c: https://review.coreboot.org/c/coreboot/+/78889/comment/69409c9b_cc9d8eab : PS1, Line 104: size_t stm_psd_size = 0; > I feel like the following is more readable but this is totally optional. […] ``` size_t size = smm_runtime.save_state_size; if (cpu > smm_runtime.num_cpus) return NULL; if (CONFIG(STM)) size -= ALIGN_UP(sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR), 0x100); return (void *)(smm_runtime.save_state_top[cpu] - size); ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/78889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Gerrit-Change-Number: 78889 Gerrit-PatchSet: 2 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 19:29:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/lenovo/t520: Drop unused includes
by Martin L Roth (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Keith Hui. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76998?usp=email ) Change subject: mb/lenovo/t520: Drop unused includes ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: Please move to the branch "main". -- To view, visit https://review.coreboot.org/c/coreboot/+/76998?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1b201fe4dd29bac5feb08f372d1e36353eac161d Gerrit-Change-Number: 76998 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 19:28:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Martin L Roth (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78792?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: Please move this patch to the branch "main" -- To view, visit https://review.coreboot.org/c/coreboot/+/78792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78792 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 19:27:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/smm: Fix get_save_state calculation
by Jérémy Compostella (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: EliasOfWaffle, Martin L Roth, Michał Żygowski, Paul Menzel, Stefan Reinauer. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email ) Change subject: cpu/x86/smm: Fix get_save_state calculation ...................................................................... Patch Set 1: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78889/comment/6dccfa3d_d41c89b3 : PS1, Line 9: When the STM is configured, get_save_state returns an incorrect nit: This is more of my rule as I don't think I saw that in coreboot coding style but I usually feel like this is good to define acronyms as they are used in the commit message. I would suggest: `When the SMI Transfer Monitor (STM) is configured` and line 11 `of the processor System Management Mode (SMM) descriptor`. Patchset: PS1: Just a few cosmetic and optional comments. File src/cpu/x86/smm/smm_module_handler.c: https://review.coreboot.org/c/coreboot/+/78889/comment/f404b014_15a69d52 : PS1, Line 12: #include <security/intel/stm/SmmStm.h> includes are usually sorted in alphabetical order. https://review.coreboot.org/c/coreboot/+/78889/comment/90881efc_a0fee3ff : PS1, Line 104: size_t stm_psd_size = 0; I feel like the following is more readable but this is totally optional. ``` size_t size = smm_runtime.save_state_size; if (cpu > smm_runtime.num_cpus) return NULL; if (CONFIG(STM)) size += ALIGN_UP(sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR), 0x100); return (void *)(smm_runtime.save_state_top[cpu] - size); ``` https://review.coreboot.org/c/coreboot/+/78889/comment/e96af259_d2e9f932 : PS1, Line 111: 0x100); It should fit on one line. The coding style states 96 columns. -- To view, visit https://review.coreboot.org/c/coreboot/+/78889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Gerrit-Change-Number: 78889 Gerrit-PatchSet: 1 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 19:26:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/smm: Fix get_save_state calculation
by Eugene Myers (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: EliasOfWaffle, Jérémy Compostella, Martin L Roth, Michał Żygowski, Paul Menzel, Stefan Reinauer. Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email ) Change subject: cpu/x86/smm: Fix get_save_state calculation ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78889/comment/87da2bde_4d5c65e4 : PS1, Line 14: This patch addresses the issue identified in CB:76601 and bug #511. > Maybe be specific, and write that SMMSTOREv2 now works with STM? Done https://review.coreboot.org/c/coreboot/+/78889/comment/58f231e5_6f8b185a : PS1, Line 15: > It’d be great if you added the tag below: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Gerrit-Change-Number: 78889 Gerrit-PatchSet: 2 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 19:25:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/smm: Fix get_save_state calculation
by Eugene Myers (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: EliasOfWaffle, Eugene Myers, Jérémy Compostella, Martin L Roth, Michał Żygowski, Stefan Reinauer. Hello EliasOfWaffle, Jérémy Compostella, Martin L Roth, Matt DeVillier, Michał Żygowski, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78889?usp=email to look at the new patch set (#2). Change subject: cpu/x86/smm: Fix get_save_state calculation ...................................................................... cpu/x86/smm: Fix get_save_state calculation When the STM is configured, get_save_state returns an incorrect pointer to the cpu save state because the size (rounded up to 0x100) of the processor SMM descriptor needs to be subtracted out in this case. This patch addresses the issue identified in CB:76601, which means that SMMSTOREv2 now works with the STM. Resolves: https://ticket.coreboot.org/issues/511 Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Signed-off-by: Eugene D. Myers <edmyers(a)cyberpackventures.com> --- M src/cpu/x86/smm/smm_module_handler.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/78889/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0233c6d13bdffb3853845ac6ef25c066deaab747 Gerrit-Change-Number: 78889 Gerrit-PatchSet: 2 Gerrit-Owner: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: EliasOfWaffle <eliascontato(a)protonmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023