coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[M] Change in coreboot[main]: mb/google/corsola: Add audio codec ALC5650 for Chinchou Devbeep
by Yang Wu (Code Review) 15 Nov '23

15 Nov '23

Yang Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email ) Change subject: mb/google/corsola: Add audio codec ALC5650 for Chinchou Devbeep ...................................................................... mb/google/corsola: Add audio codec ALC5650 for Chinchou Devbeep BUG=b:305828247 TEST=Verify Devbeep at Depthcharge console Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Signed-off-by: wuyang5 <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/mainboard.c M src/soc/mediatek/mt8186/include/soc/pll.h M src/soc/mediatek/mt8186/pll.c 3 files changed, 64 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/79064/1 diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index b2c65eb..8ba5ae3 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -2,10 +2,13 @@ #include <bootmode.h> #include <console/console.h> +#include <delay.h> #include <device/device.h> #include <gpio.h> #include <soc/bl31.h> +#include <soc/i2c.h> #include <soc/msdc.h> +#include <soc/pll.h> #include <soc/spm.h> #include <soc/usb.h> @@ -23,6 +26,23 @@ gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); } +static void configure_audio_ALC5645(void) +{ + mtcmos_audio_power_on(); + + /* Set up I2S */ + gpio_set_mode(GPIO(I2S1_MCK), PAD_I2S1_MCK_FUNC_I2S1_MCK); + gpio_set_mode(GPIO(I2S1_BCK), PAD_I2S1_BCK_FUNC_I2S1_BCK); + gpio_set_mode(GPIO(I2S1_LRCK), PAD_I2S1_LRCK_FUNC_I2S1_LRCK); + gpio_set_mode(GPIO(I2S1_DO), PAD_I2S1_DO_FUNC_I2S1_DO); + + /* Init i2c bus Timing register for audio codecs */ + mtk_i2c_bus_init(5, I2C_SPEED_STANDARD); + + /* set I2S clock to 48KHz */ + mt_pll_set_aud_div(48 * KHz); +} + static void mainboard_init(struct device *dev) { mtk_msdc_configure_emmc(true); @@ -36,7 +56,10 @@ setup_usb_host(); - configure_audio(); + if (CONFIG(BOARD_GOOGLE_CHINCHOU)) + configure_audio_ALC5645(); + else + configure_audio(); if (spm_init()) printk(BIOS_ERR, "spm init failed, system suspend may not work\n"); @@ -67,3 +90,4 @@ struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; + diff --git a/src/soc/mediatek/mt8186/include/soc/pll.h b/src/soc/mediatek/mt8186/include/soc/pll.h index 8df7f96..0fd0e1c 100644 --- a/src/soc/mediatek/mt8186/include/soc/pll.h +++ b/src/soc/mediatek/mt8186/include/soc/pll.h @@ -8,6 +8,7 @@ #ifndef SOC_MEDIATEK_MT8186_PLL_H #define SOC_MEDIATEK_MT8186_PLL_H +#include <assert.h> #include <device/mmio.h> #include <types.h> #include <soc/pll_common.h> @@ -495,6 +496,8 @@ enum { CLK26M_HZ = 26 * MHz, MAINPLL_D5_HZ = MAINPLL_HZ / 5, + APLL1_CK_HZ = APLL1_HZ, + APLL2_CK_HZ = APLL2_HZ, }; /* top_mux rate */ @@ -526,4 +529,5 @@ DEFINE_BITFIELD(USB_TOP_CFG_MACRO_CTRL, 1, 0) +void mt_pll_set_aud_div(u32 rate); #endif /* SOC_MEDIATEK_MT8186_PLL_H */ diff --git a/src/soc/mediatek/mt8186/pll.c b/src/soc/mediatek/mt8186/pll.c index a6165ef..3368610 100644 --- a/src/soc/mediatek/mt8186/pll.c +++ b/src/soc/mediatek/mt8186/pll.c @@ -587,3 +587,38 @@ return 0; } + +void mt_pll_set_aud_div(u32 rate) +{ + u32 mclk_div; + u32 apll_clock = APLL2_CK_HZ; + int apll1 = 0; + + if (rate % 11025 == 0) { + /* use APLL1 instead */ + apll1 = 1; + apll_clock = APLL1_CK_HZ; + } + /* I2S1 clock */ + mclk_div = (apll_clock / 256 / rate) - 1; + assert(apll_clock == rate * 256 * (mclk_div + 1)); + + if (apll1) { + /* mclk */ + clrbits32(&mtk_topckgen->clk_auddiv_0, 1 << 5); + clrsetbits32(&mtk_topckgen->clk_auddiv_1, 0xff << 8, + mclk_div << 8); + /* bclk */ + clrsetbits32(&mtk_topckgen->clk_auddiv_0, 0xf << 24, + 7 << 24); + } else { + /* mclk */ + setbits32(&mtk_topckgen->clk_auddiv_0, 1 << 5); + clrsetbits32(&mtk_topckgen->clk_auddiv_2, 0xff << 8, + mclk_div << 8); + /* bclk */ + clrsetbits32(&mtk_topckgen->clk_auddiv_0, 0xf << 28, + 7 << 28); + } +} + -- To view, visit https://review.coreboot.org/c/coreboot/+/79064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Gerrit-Change-Number: 79064 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/geralt: Create variant Ciri
by Paul Menzel (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Hung-Te Lin, Ruihai Zhou. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/geralt: Create variant Ciri ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78954/comment/b38e6053_fbb769e4 : PS2, Line 9: and enable MAX98390 AMP for it. Maybe state, that it’s an exact copy of *Geralt*. https://review.coreboot.org/c/coreboot/+/78954/comment/b37f1788_f01a1ff3 : PS2, Line 9: a the https://review.coreboot.org/c/coreboot/+/78954/comment/b4a55450_5a522c94 : PS2, Line 10: Please state if future changes are to be expected. https://review.coreboot.org/c/coreboot/+/78954/comment/92d02953_831676a9 : PS2, Line 12: TEST=emerge-geralt coreboot I do not know the Chromium OS tooling, but does this build all the variants? File src/mainboard/google/geralt/Kconfig: https://review.coreboot.org/c/coreboot/+/78954/comment/79aad34e_40753c14 : PS2, Line 73: choice : prompt "Speaker AMP for Geralt" : default USE_MAX98390 if BOARD_GOOGLE_GERALT || BOARD_GOOGLE_CIRI : : config USE_MAX98390 : bool "MAX98390" : : config USE_NAU8318 : bool "NAU8318" Does this make sense to allow the user to select the speaker AMP? -- To view, visit https://review.coreboot.org/c/coreboot/+/78954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25 Gerrit-Change-Number: 78954 Gerrit-PatchSet: 2 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 07:18:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: tests/lib: Enforce ux_locales-test with CONFIG_VBOOT
by Subrata Banik (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Arthur Heymans, Hsuan Ting Chen, Julius Werner, Kapil Porwal, Martin L Roth, Martin Roth, Subrata Banik. Hello Arthur Heymans, Hsuan Ting Chen, Hsuan-ting Chen, Kapil Porwal, Martin L Roth, Martin Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79056?usp=email to look at the new patch set (#4). Change subject: tests/lib: Enforce ux_locales-test with CONFIG_VBOOT ...................................................................... tests/lib: Enforce ux_locales-test with CONFIG_VBOOT The ux_locales-test relies on the ability to determine supported locales for the platform. However, this information is unavailable without VBOOT config being enabled. Therefore, enforce this test for platforms with VBOOT config alone to avoid unnecessary failures. Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M tests/lib/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/79056/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd Gerrit-Change-Number: 79056 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: lib: Update locales for non-VBOOT platforms
by Hsuan-ting Chen (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal, Martin L Roth, Martin Roth, Subrata Banik. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79054?usp=email ) Change subject: lib: Update locales for non-VBOOT platforms ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79054?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7554c8bfd58411f460deeb22cf7218059ca8ba9f Gerrit-Change-Number: 79054 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 05:23:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: tests/lib: Enforce ux_locales-test with CONFIG_VBOOT
by Hsuan-ting Chen (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Arthur Heymans, Hsuan Ting Chen, Julius Werner, Kapil Porwal, Martin L Roth, Martin Roth, Subrata Banik. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79056?usp=email ) Change subject: tests/lib: Enforce ux_locales-test with CONFIG_VBOOT ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd Gerrit-Change-Number: 79056 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 05:23:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: tests/lib: Enforce ux_locales-test with CONFIG_VBOOT
by Subrata Banik (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Arthur Heymans, Hsuan Ting Chen, Hsuan-ting Chen, Julius Werner, Kapil Porwal, Martin L Roth, Martin Roth. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79056?usp=email ) Change subject: tests/lib: Enforce ux_locales-test with CONFIG_VBOOT ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79056/comment/7acf6aad_6aaaef47 : PS2, Line 7: tests/lib: Skip ux_locales-test for !VBOOT platforms > Could we change the title and the comments? like "always use vboot for ux_locales-test" Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/79056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd Gerrit-Change-Number: 79056 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 05:20:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: tests/lib: Enforce ux_locales-test with CONFIG_VBOOT
by Subrata Banik (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Arthur Heymans, Hsuan Ting Chen, Julius Werner, Kapil Porwal, Martin L Roth, Martin Roth, Subrata Banik. Hello Arthur Heymans, Hsuan Ting Chen, Hsuan-ting Chen, Kapil Porwal, Martin L Roth, Martin Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79056?usp=email to look at the new patch set (#3). Change subject: tests/lib: Enforce ux_locales-test with CONFIG_VBOOT ...................................................................... tests/lib: Enforce ux_locales-test with CONFIG_VBOOT The ux_locales-test relies on the ability to determine supported locales for the platform. However, this information is unavailable without VBOOT config being enabled. Therefore, skip this test for platforms without VBOOT config to avoid unnecessary failures. Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M tests/lib/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/79056/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd Gerrit-Change-Number: 79056 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: lib: Update locales for non-VBOOT platforms
by Hsuan-ting Chen (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal, Martin L Roth, Martin Roth, Subrata Banik. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79054?usp=email ) Change subject: lib: Update locales for non-VBOOT platforms ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79054?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7554c8bfd58411f460deeb22cf7218059ca8ba9f Gerrit-Change-Number: 79054 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 05:16:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: tests/lib: Skip ux_locales-test for !VBOOT platforms
by Hsuan-ting Chen (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Arthur Heymans, Hsuan Ting Chen, Julius Werner, Kapil Porwal, Martin L Roth, Martin Roth, Subrata Banik. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79056?usp=email ) Change subject: tests/lib: Skip ux_locales-test for !VBOOT platforms ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79056/comment/f29edb21_5a08ceb9 : PS2, Line 7: tests/lib: Skip ux_locales-test for !VBOOT platforms Could we change the title and the comments? like "always use vboot for ux_locales-test" Patchset: PS2: LGTM for the USE_VBOOT approach. -- To view, visit https://review.coreboot.org/c/coreboot/+/79056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd Gerrit-Change-Number: 79056 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 05:15:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: tests/lib: Skip ux_locales-test for !VBOOT platforms
by Subrata Banik (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Arthur Heymans, Hsuan Ting Chen, Julius Werner, Kapil Porwal, Martin L Roth, Martin Roth. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79056?usp=email ) Change subject: tests/lib: Skip ux_locales-test for !VBOOT platforms ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This will just always skip the tests, then we might as well not have them. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/79056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd Gerrit-Change-Number: 79056 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 05:14:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023