coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[M] Change in coreboot[main]: treewide: Add commonlib/bsd/stdlib.h
by Julius Werner (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Andrey Petrov, Arthur Heymans, Christian Walter, Hung-Te Lin, Jakub Czapiga, Johnny Lin, Maximilian Brune, Ronak Kanabar, Tim Chu, Yidi Lin, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77969?usp=email ) Change subject: treewide: Add commonlib/bsd/stdlib.h ...................................................................... Patch Set 7: (8 comments) File src/commonlib/bsd/include/commonlib/bsd/stdlib.h: https://review.coreboot.org/c/coreboot/+/77969/comment/17ad0ab9_40b14d69 : PS7, Line 10: #if CONFIG(COREBOOT_BUILD) I think this is also not great (I know that that's not your patch, but I think a bunch of things were badly designed when these files were first added and then hardly anything ever used them so nobody cared much, but now if we want to start using them more we should clean stuff up a bit). CONFIG() isn't guaranteed to be defined in the commonlib environment, and I believe would in fact be missing if you tried to use this from cbfstool. I think we should replace this with something that comes directly from the coreboot Makefiles (e.g. set `-D__COREBOOT__` in `CPPFLAGS_common` and then check with `#ifdef` for that here). https://review.coreboot.org/c/coreboot/+/77969/comment/7005b3d8_291079f8 : PS7, Line 30: %s/%s/line %d nit: This may just be my personal nitpick, but I find the `%s:%d %s():` from libpayload nicer than this. File src/commonlib/include/commonlib/stdlib.h: https://review.coreboot.org/c/coreboot/+/77969/comment/81fd5b68_e00e32c6 : PS2, Line 44: int dma_coherent(const void *ptr); > Now I removed the `dma_malloc` and `dma_coherent` declarations from commonlib stdlib. […] Acknowledged File src/drivers/intel/fsp2_0/silicon_init.c: https://review.coreboot.org/c/coreboot/+/77969/comment/4abee7fd_2b4e65de : PS6, Line 8: #include <commonlib/bsd/stdlib.h> > They originally all included commonlib/stdlib.h so I wasn't sure if that was the intention. […] Yeah, that policy isn't cleanly implemented everywhere in coreboot, but it's good to fix up things while you touch them. (This file is still wrong though, in the others you got it right now but this should also be `<stdlib.h>` not `<commonlib/bsd/stdlib.h>`.) File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/77969/comment/52bb0d8a_d91c507d : PS7, Line 5: #include <stdlib.h> already included below File src/soc/intel/xeon_sp/spr/numa.c: https://review.coreboot.org/c/coreboot/+/77969/comment/271d1483_ed355a2c : PS7, Line 4: #include <stdlib.h> Not really necessary for files that already include `<types.h>` (that's our convenience shortcut header for "stdlib, stddef and all that stuff"). File src/soc/mediatek/common/pcie.c: https://review.coreboot.org/c/coreboot/+/77969/comment/252752bb_18a1f495 : PS7, Line 4: #include <stdlib.h> same File src/soc/mediatek/mt8195/pcie.c: https://review.coreboot.org/c/coreboot/+/77969/comment/977e50be_d14fa718 : PS7, Line 3: #include <stdlib.h> same -- To view, visit https://review.coreboot.org/c/coreboot/+/77969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a7ab0d1ddcc7ce9af121a61b4d4eafc9e563a8a Gerrit-Change-Number: 77969 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 01:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/lint: Add linter to keep selects out of Kconfig.name
by Julius Werner (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Martin L Roth, Maximilian Brune, Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78972?usp=email ) Change subject: util/lint: Add linter to keep selects out of Kconfig.name ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS1: > Julius, Your proposal of selecting the baseboard in the Kconfig. […] Okay, sounds like we have a good compromise here. I've uploaded CB:79022 and CB:79063 to align the Google Arm boards to that scheme. -- To view, visit https://review.coreboot.org/c/coreboot/+/78972?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2aab78e296f2958e77a938b1afa40a25a6aa82b0 Gerrit-Change-Number: 78972 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 00:36:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Julius Werner (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email ) Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm trying to align all our Arm boards to a common Kconfig structure and I think this is the cleanest I can come up with, but I know these things can be subjective so let me know if you don't like it. -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 00:34:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Julius Werner (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Yu-Ping Wu, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/79063?usp=email to review the following change. Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... google/*: Clean up Kconfg board selection for Google MTK boards This patch tries to standardize and simplify the Kconfig option layout for Google boards with MediaTek SoCs and align them to the scheme used with other Arm-based Google boards. Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/asurada/Kconfig M src/mainboard/google/cherry/Kconfig M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/mainboard.c M src/mainboard/google/geralt/Kconfig M src/mainboard/google/kukui/Kconfig M src/mainboard/google/oak/Kconfig 7 files changed, 81 insertions(+), 164 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/79063/1 diff --git a/src/mainboard/google/asurada/Kconfig b/src/mainboard/google/asurada/Kconfig index 52aefa4..4971697 100644 --- a/src/mainboard/google/asurada/Kconfig +++ b/src/mainboard/google/asurada/Kconfig @@ -2,7 +2,14 @@ # Umbrella option to be selected by variant boards. config BOARD_GOOGLE_ASURADA_COMMON - def_bool n + def_bool BOARD_GOOGLE_ASURADA || \ + BOARD_GOOGLE_HAYATO || \ + BOARD_GOOGLE_SPHERION + +if BOARD_GOOGLE_ASURADA_COMMON + +config BOARD_SPECIFIC_OPTIONS + def_bool y select RTC select SOC_MEDIATEK_MT8192 select BOARD_ROMSIZE_KB_8192 @@ -24,17 +31,6 @@ select COMMONLIB_STORAGE select COMMONLIB_STORAGE_MMC -config BOARD_GOOGLE_ASURADA - select BOARD_GOOGLE_ASURADA_COMMON - -config BOARD_GOOGLE_HAYATO - select BOARD_GOOGLE_ASURADA_COMMON - -config BOARD_GOOGLE_SPHERION - select BOARD_GOOGLE_ASURADA_COMMON - -if BOARD_GOOGLE_ASURADA_COMMON - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH diff --git a/src/mainboard/google/cherry/Kconfig b/src/mainboard/google/cherry/Kconfig index a99d7a5..1d5f42c 100644 --- a/src/mainboard/google/cherry/Kconfig +++ b/src/mainboard/google/cherry/Kconfig @@ -2,7 +2,14 @@ # Umbrella option to be selected by variant boards. config BOARD_GOOGLE_CHERRY_COMMON - def_bool n + def_bool BOARD_GOOGLE_CHERRY || \ + BOARD_GOOGLE_DOJO || \ + BOARD_GOOGLE_TOMATO + +if BOARD_GOOGLE_CHERRY_COMMON + +config BOARD_SPECIFIC_OPTIONS + def_bool y select RTC select SOC_MEDIATEK_MT8195 select BOARD_ROMSIZE_KB_8192 @@ -23,17 +30,6 @@ select COMMONLIB_STORAGE select COMMONLIB_STORAGE_MMC -config BOARD_GOOGLE_CHERRY - select BOARD_GOOGLE_CHERRY_COMMON - -config BOARD_GOOGLE_DOJO - select BOARD_GOOGLE_CHERRY_COMMON - -config BOARD_GOOGLE_TOMATO - select BOARD_GOOGLE_CHERRY_COMMON - -if BOARD_GOOGLE_CHERRY_COMMON - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index 805a83a..a306294 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -2,7 +2,40 @@ # Umbrella option to be selected by variant boards. config BOARD_GOOGLE_CORSOLA_COMMON - def_bool n + def_bool BOARD_GOOGLE_KINGLER_COMMON || \ + BOARD_GOOGLE_KRABBY_COMMON || \ + BOARD_GOOGLE_STARYU_COMMON + +config BOARD_GOOGLE_KINGLER_COMMON + def_bool BOARD_GOOGLE_KINGLER || \ + BOARD_GOOGLE_PONYTA || \ + BOARD_GOOGLE_STEELIX || \ + BOARD_GOOGLE_VOLTORB + select DRIVER_ANALOGIX_ANX7625 + select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_STEELIX + +config BOARD_GOOGLE_KRABBY_COMMON + def_bool BOARD_GOOGLE_CHINCHOU || \ + BOARD_GOOGLE_KRABBY || \ + BOARD_GOOGLE_MAGIKARP || \ + BOARD_GOOGLE_TENTACRUEL + select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU + select DRIVER_PARADE_PS8640 if !BOARD_GOOGLE_CHINCHOU + +config BOARD_GOOGLE_STARYU_COMMON + def_bool BOARD_GOOGLE_STARMIE + select MIPI_PANEL_STA_HIMAX83102_J02 + select MIPI_PANEL_STA_ILI9882T + +if BOARD_GOOGLE_CORSOLA_COMMON + +config CORSOLA_SDCARD_INIT + def_bool BOARD_GOOGLE_MAGIKARP || \ + BOARD_GOOGLE_TENTACRUEL || \ + BOARD_GOOGLE_KINGLER_COMMON + +config BOARD_SPECIFIC_OPTIONS + def_bool y select SOC_MEDIATEK_MT8186 select BOARD_ROMSIZE_KB_8192 select MAINBOARD_HAS_CHROMEOS @@ -25,58 +58,6 @@ select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI -config BOARD_GOOGLE_KINGLER_COMMON - def_bool n - select BOARD_GOOGLE_CORSOLA_COMMON - -config BOARD_GOOGLE_KRABBY_COMMON - def_bool n - select BOARD_GOOGLE_CORSOLA_COMMON - -config BOARD_GOOGLE_STARYU_COMMON - def_bool n - select BOARD_GOOGLE_CORSOLA_COMMON - -config BOARD_GOOGLE_KINGLER - select BOARD_GOOGLE_KINGLER_COMMON - select DRIVER_ANALOGIX_ANX7625 - -config BOARD_GOOGLE_PONYTA - select BOARD_GOOGLE_KINGLER_COMMON - select DRIVER_ANALOGIX_ANX7625 - -config BOARD_GOOGLE_STEELIX - select BOARD_GOOGLE_KINGLER_COMMON - select DRIVER_ANALOGIX_ANX7625 - select DRIVER_PARADE_PS8640 - -config BOARD_GOOGLE_VOLTORB - select BOARD_GOOGLE_KINGLER_COMMON - select DRIVER_ANALOGIX_ANX7625 - -config BOARD_GOOGLE_KRABBY - select BOARD_GOOGLE_KRABBY_COMMON - select DRIVER_PARADE_PS8640 - -config BOARD_GOOGLE_CHINCHOU - select BOARD_GOOGLE_KRABBY_COMMON - select DRIVER_ANALOGIX_ANX7625 - -config BOARD_GOOGLE_TENTACRUEL - select BOARD_GOOGLE_KRABBY_COMMON - select DRIVER_PARADE_PS8640 - -config BOARD_GOOGLE_MAGIKARP - select BOARD_GOOGLE_KRABBY_COMMON - select DRIVER_PARADE_PS8640 - -config BOARD_GOOGLE_STARMIE - select BOARD_GOOGLE_STARYU_COMMON - select MIPI_PANEL_STA_HIMAX83102_J02 - select MIPI_PANEL_STA_ILI9882T - -if BOARD_GOOGLE_CORSOLA_COMMON - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH @@ -101,13 +82,6 @@ int default 7 -config SDCARD_INIT - bool - default y if BOARD_GOOGLE_MAGIKARP - default y if BOARD_GOOGLE_TENTACRUEL - default y if BOARD_GOOGLE_KINGLER_COMMON - default n if BOARD_GOOGLE_KRABBY_COMMON - config DRIVER_TPM_SPI_BUS hex default 0x2 diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index b2c65eb..ef4225f 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -27,7 +27,7 @@ { mtk_msdc_configure_emmc(true); - if (CONFIG(SDCARD_INIT)) { + if (CONFIG(CORSOLA_SDCARD_INIT)) { printk(BIOS_INFO, "SD card init\n"); /* External SD Card connected via USB */ diff --git a/src/mainboard/google/geralt/Kconfig b/src/mainboard/google/geralt/Kconfig index 6817143..0f1f87d 100644 --- a/src/mainboard/google/geralt/Kconfig +++ b/src/mainboard/google/geralt/Kconfig @@ -2,10 +2,7 @@ # Umbrella option to be selected by variant boards. config BOARD_GOOGLE_GERALT_COMMON - def_bool n - -config BOARD_GOOGLE_GERALT - select BOARD_GOOGLE_GERALT_COMMON + def_bool BOARD_GOOGLE_GERALT if BOARD_GOOGLE_GERALT_COMMON diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index f5ad431..b179791 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -2,75 +2,33 @@ # Umbrella option to be selected by variant boards. config BOARD_GOOGLE_KUKUI_COMMON - def_bool n + def_bool BOARD_GOOGLE_FLAPJACK || \ + BOARD_GOOGLE_JACUZZI_COMMON || \ + BOARD_GOOGLE_KAKADU || \ + BOARD_GOOGLE_KATSU || \ + BOARD_GOOGLE_KODAMA || \ + BOARD_GOOGLE_KRANE || \ + BOARD_GOOGLE_KUKUI config BOARD_GOOGLE_JACUZZI_COMMON - def_bool n - select BOARD_GOOGLE_KUKUI_COMMON + def_bool BOARD_GOOGLE_BURNET || \ + BOARD_GOOGLE_COZMO || \ + BOARD_GOOGLE_DAMU || \ + BOARD_GOOGLE_CERISE || \ + BOARD_GOOGLE_ESCHE || \ + BOARD_GOOGLE_FENNEL || \ + BOARD_GOOGLE_JACUZZI || \ + BOARD_GOOGLE_JUNIPER || \ + BOARD_GOOGLE_KAPPA || \ + BOARD_GOOGLE_MAKOMO || \ + BOARD_GOOGLE_MUNNA || \ + BOARD_GOOGLE_PICO || \ + BOARD_GOOGLE_STERN || \ + BOARD_GOOGLE_WILLOW select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI # All Jacuzzi followers are using ANX7625 except the reference board. select DRIVER_ANALOGIX_ANX7625 if !BOARD_GOOGLE_JACUZZI -config BOARD_GOOGLE_KUKUI - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_KRANE - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_KODAMA - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_KAKADU - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_FLAPJACK - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_KATSU - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_JACUZZI - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_JUNIPER - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_KAPPA - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_DAMU - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_CERISE - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_STERN - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_WILLOW - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_ESCHE - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_BURNET - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_FENNEL - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_COZMO - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_MAKOMO - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_MUNNA - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_PICO - select BOARD_GOOGLE_JACUZZI_COMMON - if BOARD_GOOGLE_KUKUI_COMMON config VBOOT diff --git a/src/mainboard/google/oak/Kconfig b/src/mainboard/google/oak/Kconfig index 900b04b..3eba1f0 100644 --- a/src/mainboard/google/oak/Kconfig +++ b/src/mainboard/google/oak/Kconfig @@ -1,7 +1,14 @@ ## SPDX-License-Identifier: GPL-2.0-only config BOARD_GOOGLE_OAK_COMMON - def_bool n + def_bool BOARD_GOOGLE_ELM || \ + BOARD_GOOGLE_HANA || \ + BOARD_GOOGLE_OAK + +if BOARD_GOOGLE_OAK_COMMON + +config BOARD_SPECIFIC_OPTIONS + def_bool y select SOC_MEDIATEK_MT8173 select BOARD_ROMSIZE_KB_4096 select COMMON_CBFS_SPI_WRAPPER @@ -16,17 +23,6 @@ select MAINBOARD_HAS_CHROMEOS select SPI_FLASH -config BOARD_GOOGLE_OAK - select BOARD_GOOGLE_OAK_COMMON - -config BOARD_GOOGLE_ELM - select BOARD_GOOGLE_OAK_COMMON - -config BOARD_GOOGLE_HANA - select BOARD_GOOGLE_OAK_COMMON - -if BOARD_GOOGLE_OAK_COMMON - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards
by Julius Werner (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Yu-Ping Wu. Hello Yu-Ping Wu, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/79022?usp=email to review the following change. Change subject: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards ...................................................................... google/*: Clean up Kconfig board selection for non-MTK Google Arm boards This patch unifies and simplifies the Kconfig selection model for the Gru, Herobrine, Trogdor and Veyron boards according to the model discussed in CB:78972. Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/Kconfig M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/herobrine/Kconfig.name M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name M src/mainboard/google/veyron/Kconfig 6 files changed, 54 insertions(+), 93 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/79022/1 diff --git a/src/mainboard/google/gru/Kconfig b/src/mainboard/google/gru/Kconfig index 837b06d..d27a99d 100644 --- a/src/mainboard/google/gru/Kconfig +++ b/src/mainboard/google/gru/Kconfig @@ -1,25 +1,12 @@ ## SPDX-License-Identifier: GPL-2.0-only config BOARD_GOOGLE_GRU_COMMON # Umbrella option to be selected by variant boards. - def_bool n - -config BOARD_GOOGLE_KEVIN - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_GRU - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_BOB - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_SCARLET - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_NEFARIO - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_RAINIER - select BOARD_GOOGLE_GRU_COMMON + def_bool BOARD_GOOGLE_BOB || \ + BOARD_GOOGLE_GRU || \ + BOARD_GOOGLE_KEVIN || \ + BOARD_GOOGLE_NEFARIO || \ + BOARD_GOOGLE_RAINIER || \ + BOARD_GOOGLE_SCARLET if BOARD_GOOGLE_GRU_COMMON @@ -27,23 +14,21 @@ # convenience. Explicitly override it when building for earlier Kevins. config GRU_HAS_TPM2 bool "Build for a board revision with a SPI TPM 2.0" - default n if BOARD_GOOGLE_KEVIN - default y + default !BOARD_GOOGLE_KEVIN config GRU_HAS_CENTERLOG_PWM - bool - default y if BOARD_GOOGLE_GRU || BOARD_GOOGLE_KEVIN || BOARD_GOOGLE_BOB - default n + def_bool BOARD_GOOGLE_GRU || \ + BOARD_GOOGLE_KEVIN || \ + BOARD_GOOGLE_BOB config GRU_HAS_WLAN_RESET - bool - default y if BOARD_GOOGLE_GRU || BOARD_GOOGLE_KEVIN || BOARD_GOOGLE_BOB - default n + def_bool BOARD_GOOGLE_GRU || \ + BOARD_GOOGLE_KEVIN || \ + BOARD_GOOGLE_BOB config GRU_BASEBOARD_SCARLET - bool - default y if BOARD_GOOGLE_SCARLET || BOARD_GOOGLE_RAINIER - default n + def_bool BOARD_GOOGLE_SCARLET || \ + BOARD_GOOGLE_RAINIER config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/google/herobrine/Kconfig b/src/mainboard/google/herobrine/Kconfig index a95ac06..43148c3 100644 --- a/src/mainboard/google/herobrine/Kconfig +++ b/src/mainboard/google/herobrine/Kconfig @@ -1,12 +1,19 @@ config BOARD_GOOGLE_HEROBRINE_COMMON # Umbrella option to be selected by variants - def_bool n + def_bool BOARD_GOOGLE_EVOKER || \ + BOARD_GOOGLE_HEROBRINE || \ + BOARD_GOOGLE_HEROBRINE_REV0 || \ + BOARD_GOOGLE_HOGLIN || \ + BOARD_GOOGLE_PIGLIN || \ + BOARD_GOOGLE_SENOR || \ + BOARD_GOOGLE_VILLAGER || \ + BOARD_GOOGLE_ZOGLIN || \ + BOARD_GOOGLE_ZOMBIE if BOARD_GOOGLE_HEROBRINE_COMMON config HEROBRINE_HAS_FINGERPRINT - bool - default y if BOARD_GOOGLE_HEROBRINE || BOARD_GOOGLE_HEROBRINE_REV0 - default n + def_bool BOARD_GOOGLE_HEROBRINE || \ + BOARD_GOOGLE_HEROBRINE_REV0 config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/google/herobrine/Kconfig.name b/src/mainboard/google/herobrine/Kconfig.name index 06530a0..43ff15d 100644 --- a/src/mainboard/google/herobrine/Kconfig.name +++ b/src/mainboard/google/herobrine/Kconfig.name @@ -4,39 +4,30 @@ config BOARD_GOOGLE_HEROBRINE bool "-> Herobrine" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_HEROBRINE_REV0 bool "-> Herobrine_Rev0" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_SENOR bool "-> Senor" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_PIGLIN bool "-> Piglin" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_HOGLIN bool "-> Hoglin" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_VILLAGER bool "-> Villager" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_EVOKER bool "-> Evoker" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_ZOGLIN bool "-> Zoglin" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_ZOMBIE bool "-> Zombie" - select BOARD_GOOGLE_HEROBRINE_COMMON endif diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index 028dc2b..aed48be 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -1,6 +1,18 @@ config BOARD_GOOGLE_TROGDOR_COMMON # Umbrella option to be selected by variants - def_bool n + def_bool BOARD_GOOGLE_BUBS || \ + BOARD_GOOGLE_COACHZ || \ + BOARD_GOOGLE_GELARSHIE || \ + BOARD_GOOGLE_HOMESTAR || \ + BOARD_GOOGLE_KINGOFTOWN || \ + BOARD_GOOGLE_LAZOR || \ + BOARD_GOOGLE_MARZIPAN || \ + BOARD_GOOGLE_MRBLAND || \ + BOARD_GOOGLE_PAZQUEL || \ + BOARD_GOOGLE_POMPOM || \ + BOARD_GOOGLE_QUACKINGSTICK || \ + BOARD_GOOGLE_TROGDOR || \ + BOARD_GOOGLE_WORMDINGLER if BOARD_GOOGLE_TROGDOR_COMMON @@ -8,24 +20,20 @@ def_bool n config TROGDOR_HAS_BRIDGE_BACKLIGHT - bool - default y if BOARD_GOOGLE_HOMESTAR - default n + def_bool BOARD_GOOGLE_HOMESTAR config TROGDOR_HAS_MIPI_PANEL - bool - default y if BOARD_GOOGLE_MRBLAND || BOARD_GOOGLE_QUACKINGSTICK || BOARD_GOOGLE_WORMDINGLER + def_bool BOARD_GOOGLE_MRBLAND || \ + BOARD_GOOGLE_QUACKINGSTICK || \ + BOARD_GOOGLE_WORMDINGLER select MIPI_PANEL_AUO_B101UAN08_3 if BOARD_GOOGLE_MRBLAND || BOARD_GOOGLE_QUACKINGSTICK select MIPI_PANEL_BOE_TV101WUM_N53 if BOARD_GOOGLE_MRBLAND select MIPI_PANEL_INX_HJ110IZ_01A_B2 if BOARD_GOOGLE_WORMDINGLER select MIPI_PANEL_BOE_TV110C9M_LL0 if BOARD_GOOGLE_WORMDINGLER - default n config TROGDOR_HAS_FINGERPRINT - bool - default y if BOARD_GOOGLE_COACHZ - default y if BOARD_GOOGLE_MARZIPAN - default n + def_bool BOARD_GOOGLE_COACHZ || \ + BOARD_GOOGLE_MARZIPAN config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name index db4cff0..41c6e56 100644 --- a/src/mainboard/google/trogdor/Kconfig.name +++ b/src/mainboard/google/trogdor/Kconfig.name @@ -4,55 +4,42 @@ config BOARD_GOOGLE_BUBS bool "-> Bubs" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_COACHZ bool "-> Coachz" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_GELARSHIE bool "-> Gelarshie" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_HOMESTAR bool "-> Homestar" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_KINGOFTOWN bool "-> Kingoftown" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_LAZOR bool "-> Lazor" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_MARZIPAN bool "-> Marzipan" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_MRBLAND bool "-> Mrbland" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_PAZQUEL bool "-> Pazquel" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_POMPOM bool "-> Pompom" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_QUACKINGSTICK bool "-> Quackingstick" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_WORMDINGLER bool "-> Wormdingler" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_TROGDOR bool "-> Trogdor" - select BOARD_GOOGLE_TROGDOR_COMMON endif diff --git a/src/mainboard/google/veyron/Kconfig b/src/mainboard/google/veyron/Kconfig index 0e543e1..08af442 100644 --- a/src/mainboard/google/veyron/Kconfig +++ b/src/mainboard/google/veyron/Kconfig @@ -1,27 +1,11 @@ ## SPDX-License-Identifier: GPL-2.0-only config BOARD_GOOGLE_VEYRON - def_bool n - -config BOARD_GOOGLE_VEYRON_JAQ - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_VEYRON_JERRY - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_VEYRON_MIGHTY - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_VEYRON_MINNIE - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_VEYRON_SPEEDY - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP + def_bool BOARD_GOOGLE_VEYRON_JAQ || \ + BOARD_GOOGLE_VEYRON_JERRY || \ + BOARD_GOOGLE_VEYRON_MIGHTY || \ + BOARD_GOOGLE_VEYRON_MINNIE || \ + BOARD_GOOGLE_VEYRON_SPEEDY if BOARD_GOOGLE_VEYRON @@ -29,11 +13,9 @@ # resistors. These get overpowered by the SoC's internal pull-downs, so we # cannot read those pins as tri-state. They're restricted to binary RAM codes. config VEYRON_FORCE_BINARY_RAM_CODE - bool - default y if BOARD_GOOGLE_VEYRON_JAQ - default y if BOARD_GOOGLE_VEYRON_JERRY - default y if BOARD_GOOGLE_VEYRON_MIGHTY - default n + def_bool BOARD_GOOGLE_VEYRON_JAQ || \ + BOARD_GOOGLE_VEYRON_JERRY || \ + BOARD_GOOGLE_VEYRON_MIGHTY config BOARD_SPECIFIC_OPTIONS def_bool y @@ -48,6 +30,7 @@ select SPI_FLASH_WINBOND select I2C_TPM select MAINBOARD_HAS_TPM1 + select SYSTEM_TYPE_LAPTOP config VBOOT select VBOOT_VBNV_FLASH -- To view, visit https://review.coreboot.org/c/coreboot/+/79022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Gerrit-Change-Number: 79022 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: acpi/acpigen: rework acpigen_pop_len for different size PkgLength
by Jérémy Compostella (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Arthur Heymans, Cliff Huang, Felix Held, Jeremy Compostella, Lance Zhao, Tim Wawrzynczak. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79002?usp=email ) Change subject: acpi/acpigen: rework acpigen_pop_len for different size PkgLength ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79002?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib897b08a05a7cdc52902d51364246c260ea1f206 Gerrit-Change-Number: 79002 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 15 Nov 2023 00:14:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: sbom/Makefile.inc: Change GOPATH
by Martin L Roth (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Maximilian Brune. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77780?usp=email ) Change subject: sbom/Makefile.inc: Change GOPATH ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/77780/comment/c9d8898d_57b014ca : PS3, Line 7: sbom/Makefile.inc Should me make this change wider than just the SBOM? Maybe put it into toolchain.inc or someplace that gives it a wider reach? https://review.coreboot.org/c/coreboot/+/77780/comment/bef9cde3_5be91eb5 : PS3, Line 11: since offline build are still not : possible, because go will fetch the packages at build time Can we do something like we do with the util/crossgcc/tarballs folder where files can be placed to be installed by the coreboot builds even when the system isn't connected to the internet? -- To view, visit https://review.coreboot.org/c/coreboot/+/77780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a35369628454057ea4758cd1225e57f07cb71c8 Gerrit-Change-Number: 77780 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Nov 2023 23:00:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/system76/rpl: Allow 5600 MT/s memory for RPL-HX
by Paul Menzel (Code Review) 14 Nov '23

14 Nov '23

Attention is currently required from: Jeremy Soller, Tim Crawford. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78912?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/system76/rpl: Allow 5600 MT/s memory for RPL-HX ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78912/comment/e3ba2a32_69d421b7 : PS1, Line 13: Crucial SODIMMs Would be nice to add an exact model number. -- To view, visit https://review.coreboot.org/c/coreboot/+/78912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb0435769c70c1db06d2c5cca2dd28eb5331f49 Gerrit-Change-Number: 78912 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ilikenwf <mparnell(a)gmail.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Tue, 14 Nov 2023 22:39:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/cannonlake: Drop entries from soc_acpi_name()
by Felix Held (Code Review) 14 Nov '23

14 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79013?usp=email ) Change subject: soc/intel/cannonlake: Drop entries from soc_acpi_name() ...................................................................... soc/intel/cannonlake: Drop entries from soc_acpi_name() The THRM and SATA PCI devices do not currently have any ACPI devices defined, so drop them from soc_acpi_name() so they do not end up in the LPI constraint list. This eliminates the following errors under Linux: AE_NOT_FOUND: _SB_.PCI0.THRM AE_NOT_FOUND: _SB_.PCI0.SATA TEST= build/boot google/hatch (jinlon) and verify no ACPI errors. Change-Id: I3827b152644e2eaecc1ad288d441d2dad4d76ccb Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79013 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/cannonlake/chip.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/soc/intel/cannonlake/chip.c b/src/soc/intel/cannonlake/chip.c index 2dc39b6..a1ba17e 100644 --- a/src/soc/intel/cannonlake/chip.c +++ b/src/soc/intel/cannonlake/chip.c @@ -85,7 +85,6 @@ case SA_DEVFN_GNA: return "GNA"; case PCH_DEVFN_XHCI: return "XHCI"; case PCH_DEVFN_USBOTG: return "XDCI"; - case PCH_DEVFN_THERMAL: return "THRM"; case PCH_DEVFN_I2C0: return "I2C0"; case PCH_DEVFN_I2C1: return "I2C1"; case PCH_DEVFN_I2C2: return "I2C2"; @@ -95,7 +94,6 @@ case PCH_DEVFN_CSE_IDER: return "CSED"; case PCH_DEVFN_CSE_KT: return "CSKT"; case PCH_DEVFN_CSE_3: return "CSE3"; - case PCH_DEVFN_SATA: return "SATA"; case PCH_DEVFN_UART2: return "UAR2"; case PCH_DEVFN_I2C4: return "I2C4"; case PCH_DEVFN_I2C5: return "I2C5"; -- To view, visit https://review.coreboot.org/c/coreboot/+/79013?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3827b152644e2eaecc1ad288d441d2dad4d76ccb Gerrit-Change-Number: 79013 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: nb/intel/sandybridge: Drop raminit_native.h
by Felix Held (Code Review) 14 Nov '23

14 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78785?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: nb/intel/sandybridge: Drop raminit_native.h ...................................................................... nb/intel/sandybridge: Drop raminit_native.h After commit adaeb1102186 (nb/intel/sandybridge: Clean up post Haswell SPD mapping API migration), no boards use this header anymore and it no longer offers original content. Adjust northbridge code #includes as needed and drop it. Change-Id: I2785e920bd6188dbfc1a6157351083ec4a2526d0 Signed-off-by: Keith Hui <buurin(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78785 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/northbridge/intel/sandybridge/raminit_common.c M src/northbridge/intel/sandybridge/raminit_iosav.c M src/northbridge/intel/sandybridge/raminit_native.c D src/northbridge/intel/sandybridge/raminit_native.h 4 files changed, 1 insertion(+), 14 deletions(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index b3f913ef..c2a3051 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -11,7 +11,6 @@ #include <delay.h> #include <types.h> -#include "raminit_native.h" #include "raminit_common.h" #include "raminit_tables.h" #include "sandybridge.h" diff --git a/src/northbridge/intel/sandybridge/raminit_iosav.c b/src/northbridge/intel/sandybridge/raminit_iosav.c index 12a3be6..fbbbfba 100644 --- a/src/northbridge/intel/sandybridge/raminit_iosav.c +++ b/src/northbridge/intel/sandybridge/raminit_iosav.c @@ -3,7 +3,6 @@ #include <commonlib/helpers.h> #include <types.h> -#include "raminit_native.h" #include "raminit_common.h" #include "raminit_tables.h" #include "sandybridge.h" diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c index a46390c..fbdc27a 100644 --- a/src/northbridge/intel/sandybridge/raminit_native.c +++ b/src/northbridge/intel/sandybridge/raminit_native.c @@ -12,7 +12,7 @@ #include <stdbool.h> #include <stdint.h> -#include "raminit_native.h" +#include "sandybridge.h" #include "raminit_common.h" #include "raminit_tables.h" diff --git a/src/northbridge/intel/sandybridge/raminit_native.h b/src/northbridge/intel/sandybridge/raminit_native.h deleted file mode 100644 index fa0f2ff..0000000 --- a/src/northbridge/intel/sandybridge/raminit_native.h +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef RAMINIT_NATIVE_H -#define RAMINIT_NATIVE_H - -#include "sandybridge.h" -#include <device/dram/ddr3.h> -#include <stdbool.h> -#include <stdint.h> - -#endif /* RAMINIT_NATIVE_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/78785?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2785e920bd6188dbfc1a6157351083ec4a2526d0 Gerrit-Change-Number: 78785 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023