coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: Update amd_blobs submodule to upstream main branch
by Felix Held (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Matt DeVillier. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79065?usp=email ) Change subject: Update amd_blobs submodule to upstream main branch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I860aa04324128199cbc91a5f310fcdf92a2cd65d Gerrit-Change-Number: 79065 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 15:24:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update amd_blobs submodule to upstream main branch
by Matt DeVillier (Code Review) 15 Nov '23

15 Nov '23

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79065?usp=email ) Change subject: Update amd_blobs submodule to upstream main branch ...................................................................... Update amd_blobs submodule to upstream main branch Updating from commit id edd465837e26 (2023-10-20): cezanne: Update PSP binaries to release 0.11.11.75 to commit id e4519efca746 (2023-11-15): Revert "picasso: Update PSP binaries to release 0.8.13.7B" This brings in 1 new commit: e4519efca7 Revert "picasso: Update PSP binaries to release 0.8.13.7B" Change-Id: I860aa04324128199cbc91a5f310fcdf92a2cd65d Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/79065/1 diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index edd4658..e4519ef 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit edd465837e26b6d3d93a141567cd29f452923c7e +Subproject commit e4519efca74615f0f322d595afa7702c64753914 -- To view, visit https://review.coreboot.org/c/coreboot/+/79065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I860aa04324128199cbc91a5f310fcdf92a2cd65d Gerrit-Change-Number: 79065 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/skyrim/frostflow: Drop GPIO override for camera shutter
by Felix Held (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Frank Wu, Jason Nien, Karthik Ramasubramanian, Martin Roth, Matt DeVillier. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77678?usp=email ) Change subject: mb/google/skyrim/frostflow: Drop GPIO override for camera shutter ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/77678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a6ea3b886766bdb055b40949c75bec0264eecc5 Gerrit-Change-Number: 77678 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 15:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: Drop official support for FILO
by Stefan Reinauer (Code Review) 15 Nov '23

15 Nov '23

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76425?usp=email ) Change subject: Drop official support for FILO ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76425?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibb1486b68e3c22622e5900c7e268701dd639c042 Gerrit-Change-Number: 76425 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: mb/google/skyrim/frostflow: Drop GPIO override for camera shutter
by Matt DeVillier (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Frank Wu, Jason Nien, Karthik Ramasubramanian, Martin Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77678?usp=email ) Change subject: mb/google/skyrim/frostflow: Drop GPIO override for camera shutter ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/skyrim/variants/frostflow/gpio.c: https://review.coreboot.org/c/coreboot/+/77678/comment/5448642e_e0b4c081 : PS1, Line 10: /* EN_PWR_WWAN_X => CAM_PSW_L */ : PAD_INT(GPIO_8, PULL_NONE, BOTH_EDGES, STATUS_DELIVERY), > The AGPIO8(CAM_PSW_L) is still defined in the latest schematic in frostflow but resistance is not mo […] marking as resolved since confirmed the GPIO is not connected on the board -- To view, visit https://review.coreboot.org/c/coreboot/+/77678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a6ea3b886766bdb055b40949c75bec0264eecc5 Gerrit-Change-Number: 77678 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 15:15:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/supermicro/x11: Make use of chipset devicetree
by Felix Singer (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Eric Lai, Michael Niewöhner. Hello Eric Lai, Michael Niewöhner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78594?usp=email to look at the new patch set (#12). Change subject: mb/supermicro/x11: Make use of chipset devicetree ...................................................................... mb/supermicro/x11: Make use of chipset devicetree Use the references from the chipset devicetree as this makes the comments superfluous and remove devices which are turned off. Change-Id: I5176aa56ecaa52d0f42455bc7176b0415a6199ec Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssw-f/overridetree.cb 5 files changed, 54 insertions(+), 92 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/78594/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/78594?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5176aa56ecaa52d0f42455bc7176b0415a6199ec Gerrit-Change-Number: 78594 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/supermicro/x11: Make use of chipset devicetree
by Felix Singer (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Eric Lai, Michael Niewöhner. Hello Eric Lai, Michael Niewöhner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78594?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+2 by Eric Lai, Verified+1 by build bot (Jenkins) Change subject: mb/supermicro/x11: Make use of chipset devicetree ...................................................................... mb/supermicro/x11: Make use of chipset devicetree Change-Id: I5176aa56ecaa52d0f42455bc7176b0415a6199ec Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssw-f/overridetree.cb 5 files changed, 54 insertions(+), 92 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/78594/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/78594?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5176aa56ecaa52d0f42455bc7176b0415a6199ec Gerrit-Change-Number: 78594 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: qemu-riscv: Improve Documentation
by Ayan Agrawal (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Daniel Maslowski, Daniel Maslowski, Martin L Roth, ron minnich. Ayan Agrawal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77410?usp=email ) Change subject: qemu-riscv: Improve Documentation ...................................................................... Patch Set 6: (2 comments) This change is ready for review. File src/arch/riscv/romstage.S: https://review.coreboot.org/c/coreboot/+/77410/comment/e668764a_06de824d : PS3, Line 39: > Unrelated to the documentation. […] Done File src/mainboard/emulation/qemu-riscv/memlayout.ld: https://review.coreboot.org/c/coreboot/+/77410/comment/88e0bb6d_f20e502d : PS3, Line 35: > This removal is unrelated to the documentation - Move it to a cleanup patch? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/77410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6dbddb6d8801c456196142c3c7d0a2cbf2ed0fb7 Gerrit-Change-Number: 77410 Gerrit-PatchSet: 6 Gerrit-Owner: Ayan Agrawal <ayanagr03(a)gmail.com> Gerrit-Reviewer: Daniel Maslowski <cyrevolt(a)googlemail.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org> Gerrit-Attention: Daniel Maslowski <cyrevolt(a)googlemail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 14:55:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: qemu-riscv: Improve Documentation
by Ayan Agrawal (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Ayan Agrawal, Daniel Maslowski, Daniel Maslowski, Philipp Hug, ron minnich. Hello Daniel Maslowski, Daniel Maslowski, Philipp Hug, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77410?usp=email to look at the new patch set (#5). Change subject: qemu-riscv: Improve Documentation ...................................................................... qemu-riscv: Improve Documentation The documentation for loading coreboot as kernel doesn't work and is outdated. Should use -bios to load coreboot in QEMU Change-Id: I6dbddb6d8801c456196142c3c7d0a2cbf2ed0fb7 Signed-off-by: Ayan Agrawal <ayanagr03(a)gmail.com> --- M Documentation/mainboard/emulation/qemu-riscv.md 1 file changed, 36 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/77410/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/77410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6dbddb6d8801c456196142c3c7d0a2cbf2ed0fb7 Gerrit-Change-Number: 77410 Gerrit-PatchSet: 5 Gerrit-Owner: Ayan Agrawal <ayanagr03(a)gmail.com> Gerrit-Reviewer: Daniel Maslowski <cyrevolt(a)googlemail.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ayan Agrawal <ayanagr03(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org> Gerrit-Attention: Daniel Maslowski <cyrevolt(a)googlemail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC
by Felix Singer (Code Review) 15 Nov '23

15 Nov '23

Attention is currently required from: Angel Pons, Martin L Roth, Maximilian Brune, Paul Menzel, Subrata Banik, Tim Wawrzynczak. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66545?usp=email ) Change subject: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC ...................................................................... Patch Set 23: (2 comments) File src/mainboard/intel/adlrvp/variants/adlrvp_s_ddr5_udimm_1dpc/overridetree.cb: https://review.coreboot.org/c/coreboot/+/66545/comment/7c8297c6_6799e5e4 : PS23, Line 3: device domain 0 on Use tabs between the device name and the on keyword. https://review.coreboot.org/c/coreboot/+/66545/comment/e92748d1_9f35085f : PS23, Line 23: device ref pcie5_1 off end Remove? -- To view, visit https://review.coreboot.org/c/coreboot/+/66545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic1f62d6dd0b00d26f8c8a71b624ba5fba4c63774 Gerrit-Change-Number: 66545 Gerrit-PatchSet: 23 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Nov 2023 14:14:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023