coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: mb/google/brya/variants/anraggar: Generate RAM IDs
by Weimin Wu (Code Review) 16 Oct '23

16 Oct '23

Weimin Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78389?usp=email ) Change subject: mb/google/brya/variants/anraggar: Generate RAM IDs ...................................................................... mb/google/brya/variants/anraggar: Generate RAM IDs Generate RAM IDs for - MT62F512M32D2DR-031 WT:B (LP5) H9JCNNNBK3MLYR-N6E (LP5) H9JCNNNCP3MLYR-N6E (LP5) BUG=b:304920262 TEST=Run part_id_gen tool without any errors Change-Id: I2968c2f0b9cdd55235f9833a3d3cdb3c83b8601b --- M src/mainboard/google/brya/variants/anraggar/memory/Makefile.inc M src/mainboard/google/brya/variants/anraggar/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/anraggar/memory/mem_parts_used.txt 3 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/78389/1 diff --git a/src/mainboard/google/brya/variants/anraggar/memory/Makefile.inc b/src/mainboard/google/brya/variants/anraggar/memory/Makefile.inc index eace2e4..a6b3edd 100644 --- a/src/mainboard/google/brya/variants/anraggar/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/anraggar/memory/Makefile.inc @@ -1,5 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! -# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. +# Generated by: +# util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/anraggar/memory src/mainboard/google/brya/variants/anraggar/memory/mem_parts_used.txt -SPD_SOURCES = placeholder +SPD_SOURCES = +SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B, H9JCNNNBK3MLYR-N6E +SPD_SOURCES += spd/lp5/set-0/spd-2.hex # ID = 1(0b0001) Parts = H9JCNNNCP3MLYR-N6E diff --git a/src/mainboard/google/brya/variants/anraggar/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/anraggar/memory/dram_id.generated.txt index fa24790..67c86ce 100644 --- a/src/mainboard/google/brya/variants/anraggar/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/anraggar/memory/dram_id.generated.txt @@ -1 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/anraggar/memory src/mainboard/google/brya/variants/anraggar/memory/mem_parts_used.txt + DRAM Part Name ID to assign +MT62F512M32D2DR-031 WT:B 0 (0000) +H9JCNNNBK3MLYR-N6E 0 (0000) +H9JCNNNCP3MLYR-N6E 1 (0001) diff --git a/src/mainboard/google/brya/variants/anraggar/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/anraggar/memory/mem_parts_used.txt index 9621137..bc306e7 100644 --- a/src/mainboard/google/brya/variants/anraggar/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/anraggar/memory/mem_parts_used.txt @@ -9,3 +9,6 @@ # See util/spd_tools/README.md for more details and instructions. # Part Name +MT62F512M32D2DR-031 WT:B +H9JCNNNBK3MLYR-N6E +H9JCNNNCP3MLYR-N6E -- To view, visit https://review.coreboot.org/c/coreboot/+/78389?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2968c2f0b9cdd55235f9833a3d3cdb3c83b8601b Gerrit-Change-Number: 78389 Gerrit-PatchSet: 1 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Tyler Wang (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Subrata Banik, Sumeet R Pawnikar, Tarun, YH Lin. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email ) Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... Patch Set 7: (1 comment) This change is ready for review. Patchset: PS5: > let me know if u want me to merge this CL Please help to merge this CL, thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 7 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 12:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: {commonlib, libpayload}: Add "has_fw_splash_screen" entry
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78388?usp=email ) Change subject: {commonlib, libpayload}: Add "has_fw_splash_screen" entry ...................................................................... {commonlib, libpayload}: Add "has_fw_splash_screen" entry A new coreboot table entry, has_fw_splash_screen, has been added. This entry indicates whether the firmware has rendered the splash screen. This information is useful for overriding the kernel command-line argument fw_splash. If fw_splash=1, the kernel will skip modeset because the splash screen has already been rendered by the firmware. coreboot will gather this information and pass it to the payload using the fw_splash screen entry. The payload (e.g., deptcharge) does not have any other way to determine whether the firmware has initiated screen rendering. BUG= b:284799726 TEST= Built and booted google/rex. Overrode the "fw_splash" kernel command-line based on the has_fw_splash_screen information. Change-Id: I5ef378c4b4ee4845d698184e43d2514410baddc6 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M payloads/libpayload/include/coreboot_tables.h M src/commonlib/include/commonlib/coreboot_tables.h M src/drivers/intel/fsp2_0/graphics.c 3 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/78388/1 diff --git a/payloads/libpayload/include/coreboot_tables.h b/payloads/libpayload/include/coreboot_tables.h index 5c3f0c4..80d122b 100644 --- a/payloads/libpayload/include/coreboot_tables.h +++ b/payloads/libpayload/include/coreboot_tables.h @@ -222,7 +222,8 @@ struct cb_framebuffer_flags { u8 has_external_display : 1; - u8 reserved : 7; + u8 has_fw_splash_screen : 1; + u8 reserved : 6; }; struct cb_framebuffer { diff --git a/src/commonlib/include/commonlib/coreboot_tables.h b/src/commonlib/include/commonlib/coreboot_tables.h index 94985b1..d10f7da 100644 --- a/src/commonlib/include/commonlib/coreboot_tables.h +++ b/src/commonlib/include/commonlib/coreboot_tables.h @@ -277,7 +277,8 @@ struct lb_framebuffer_flags { uint8_t has_external_display : 1; - uint8_t reserved : 7; + uint8_t has_fw_splash_screen : 1; + uint8_t reserved : 6; }; struct lb_framebuffer { diff --git a/src/drivers/intel/fsp2_0/graphics.c b/src/drivers/intel/fsp2_0/graphics.c index a98f3bb..661ecf8 100644 --- a/src/drivers/intel/fsp2_0/graphics.c +++ b/src/drivers/intel/fsp2_0/graphics.c @@ -83,6 +83,7 @@ enum lb_fb_orientation orientation) { size_t size; + enum fw_splash_screen_status status = FW_SPLASH_SCREEN_DISABLED; const struct hob_graphics_info *ginfo; const struct fsp_framebuffer *fbinfo; @@ -92,7 +93,7 @@ */ if (!framebuffer_bar) { printk(BIOS_ALERT, "Framebuffer BAR invalid\n"); - update_fw_splash_screen_event(FW_SPLASH_SCREEN_DISABLED); + update_fw_splash_screen_event(status); return; } @@ -100,18 +101,19 @@ if (!ginfo) { printk(BIOS_ALERT, "Graphics hand-off block not found\n"); - update_fw_splash_screen_event(FW_SPLASH_SCREEN_DISABLED); + update_fw_splash_screen_event(status); return; } if (ginfo->pixel_format >= ARRAY_SIZE(fsp_framebuffer_format_map)) { printk(BIOS_ALERT, "FSP set unknown framebuffer format: %d\n", ginfo->pixel_format); - update_fw_splash_screen_event(FW_SPLASH_SCREEN_DISABLED); + update_fw_splash_screen_event(status); return; } - update_fw_splash_screen_event(FW_SPLASH_SCREEN_ENABLED); + status = FW_SPLASH_SCREEN_ENABLED; + update_fw_splash_screen_event(status); fbinfo = fsp_framebuffer_format_map + ginfo->pixel_format; const struct lb_framebuffer fb = { @@ -132,6 +134,7 @@ .orientation = orientation, .flags = { .has_external_display = fsp_soc_report_external_display(), + .has_fw_splash_screen = status, }, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/78388?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ef378c4b4ee4845d698184e43d2514410baddc6 Gerrit-Change-Number: 78388 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Tyler Wang (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Eric Lai, Kapil Porwal, Paul Menzel, Tarun, YH Lin. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email ) Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78216/comment/9997de93_ac3094e5 : PS5, Line 9: FAN_SETTING_1 > Please elaborate what setting 1 is. Done, thanks. https://review.coreboot.org/c/coreboot/+/78216/comment/945b8adb_296842da : PS5, Line 12: TEST=emerge-rex coreboot > Do you have access to the board? Yes, update test result. -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 7 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 11:26:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Tyler Wang (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Eric Lai, Kapil Porwal, Tarun, Tyler Wang, YH Lin. Hello David Wu, Eran Mitrani, Kapil Porwal, Subrata Banik, Sumeet R Pawnikar, Tarun, YH Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78216?usp=email to look at the new patch set (#7). Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... mb/google/rex/var/karis: Add FAN field in fw_config Update default fan settings(FAN_SETTING_1) in FAN field. Bit 6-7, FAN, 0 --> FAN_SETTING_1 BUG=b:290689824, b:294155897 TEST=Dump ssdt table and check fan settings is existed Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/78216/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 7 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Tyler Wang (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Eric Lai, Kapil Porwal, Tarun, Tyler Wang, YH Lin. Hello David Wu, Eran Mitrani, Kapil Porwal, Subrata Banik, Sumeet R Pawnikar, Tarun, YH Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78216?usp=email to look at the new patch set (#6). Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... mb/google/rex/var/karis: Add FAN field in fw_config Bit 6-7, FAN, 0 --> FAN_SETTING_1(default fan settings) BUG=b:290689824, b:294155897 TEST=emerge-rex coreboot Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/78216/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 6 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Remove I2C2 "on" settings
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Tarun, Tyler Wang. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78339?usp=email ) Change subject: mb/google/rex/var/karis: Remove I2C2 "on" settings ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78339?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0124fd108fbbd87507d252e9caab4dfc16aceddb Gerrit-Change-Number: 78339 Gerrit-PatchSet: 6 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 11:01:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Remove I2C2 "on" settings
by Tyler Wang (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun. Hello David Wu, Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78339?usp=email to look at the new patch set (#6). Change subject: mb/google/rex/var/karis: Remove I2C2 "on" settings ...................................................................... mb/google/rex/var/karis: Remove I2C2 "on" settings GPP_H04/GPP_H05 doesn't use for I2C usage, remove I2C2 "on" settings. BUG=b:294155897 TEST=Check ap firmware log, i2c2 is disabled Change-Id: I0124fd108fbbd87507d252e9caab4dfc16aceddb Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/78339/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/78339?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0124fd108fbbd87507d252e9caab4dfc16aceddb Gerrit-Change-Number: 78339 Gerrit-PatchSet: 6 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Remove 2 on" settings
by Tyler Wang (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78339?usp=email ) Change subject: mb/google/rex/var/karis: Remove 2 on" settings ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/78339?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0124fd108fbbd87507d252e9caab4dfc16aceddb Gerrit-Change-Number: 78339 Gerrit-PatchSet: 5 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 10:47:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: ec/dell/mec5035: Add command to enable/disable radios
by Daniel Maslowski (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Felix Singer, Iru Cai, Nicholas Chin. Daniel Maslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77534?usp=email ) Change subject: ec/dell/mec5035: Add command to enable/disable radios ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Suggestion for a more human speak implementation: ``` // turn the readio on void mec5035_radio_on(enum mec5035_radio_dev dev) { /* From LPC traces and userspace testing with other values, the second byte has to be 2 for an unknown reason. */ u8 buf[3] = {dev, 2, RADIO_ON}; write_mailbox_regs(buf, 2, 3); ec_command(CMD_SET_RADIO); } // turn the readio off void mec5035_radio_off(enum mec5035_radio_dev dev) { /* From LPC traces and userspace testing with other values, the second byte has to be 2 for an unknown reason. */ u8 buf[3] = {dev, 2, RADIO_OFF}; write_mailbox_regs(buf, 2, 3); ec_command(CMD_SET_RADIO); } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/77534?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I173dc197d63cda232dd7ede0cb798ab0a364482b Gerrit-Change-Number: 77534 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 10:41:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023