coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
by Paweł Anikiel (Code Review) 16 Oct '23

16 Oct '23

Paweł Anikiel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78417?usp=email ) Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ...................................................................... drivers/wwan/fm: Wake up modem on PEWAKE# signal change Create an event handler for the PEWAKE# GPIO and notify the device driver to wake up the device. Signed-off-by: Paweł Anikiel <panikiel(a)google.com> Change-Id: Ib5f4cdc2a3dcac419bda4ebb32c13807ac8b686d --- M src/drivers/wwan/fm/acpi_fm350gl.c 1 file changed, 58 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/78417/1 diff --git a/src/drivers/wwan/fm/acpi_fm350gl.c b/src/drivers/wwan/fm/acpi_fm350gl.c index 139fd15..c8db09e 100644 --- a/src/drivers/wwan/fm/acpi_fm350gl.c +++ b/src/drivers/wwan/fm/acpi_fm350gl.c @@ -2,6 +2,10 @@ #include <acpi/acpigen.h> #include <acpi/acpi_device.h> +#include <stdio.h> +#if CONFIG(GENERIC_GPIO_LIB) +#include <gpio.h> +#endif #include "chip.h" #include "soc/intel/common/block/include/intelblocks/acpi.h" #include "soc/intel/common/block/pcie/rtd3/chip.h" @@ -263,6 +267,57 @@ return "PXSX"; } +static void +wwan_fm350gl_acpi_event_interrupts(const struct acpi_gpio *wake_gpio) +{ + acpigen_write_name("_AEI"); + acpigen_write_resourcetemplate_header(); + acpi_device_write_gpio(wake_gpio); + acpigen_write_resourcetemplate_footer(); +} + +static void +wwan_fm350gl_acpi_event_method(const struct device *dev, + const struct acpi_gpio *wake_gpio) +{ + char name[5]; + uint16_t pin; + + pin = wake_gpio->pins[0]; +#if CONFIG(GENERIC_GPIO_LIB) + pin = gpio_acpi_pin(pin); +#endif + + if (pin > 0xff) { + printk(BIOS_ERR, "%s: pins above 0xFF are unsupported\n", + __func__); + return; + } + + snprintf(name, sizeof(name), "_%c%02X", + wake_gpio->irq.mode == ACPI_IRQ_EDGE_TRIGGERED ? 'E' : 'L', pin); + + acpigen_write_method_serialized(name, 0); + acpigen_notify(acpi_device_path(dev), 0x02); /* NOTIFY_DEVICE_WAKE */ + acpigen_write_method_end(); +} + +static void wwan_fm350gl_acpi_gpio_events(const struct device *dev) +{ + const struct drivers_wwan_fm_config *config = config_of(dev); + const struct acpi_gpio *wake_gpio = &config->wake_gpio; + + /* Write into GPIO controller's scope */ +#if CONFIG(GENERIC_GPIO_LIB) + acpigen_write_scope(wake_gpio->resource ? : gpio_acpi_path(wake_gpio->pins[0])); +#else + acpigen_write_scope(wake_gpio->resource); +#endif + wwan_fm350gl_acpi_event_interrupts(wake_gpio); + wwan_fm350gl_acpi_event_method(dev, wake_gpio); + acpigen_write_scope_end(); +} + static void wwan_fm350gl_acpi_fill_ssdt(const struct device *dev) { const struct drivers_wwan_fm_config *config = config_of(dev); @@ -323,6 +378,9 @@ acpigen_write_device_end(); /* Device */ } acpigen_write_scope_end(); /* Scope */ + + if (config->wake_gpio.pin_count && config->wake_gpio.type == ACPI_GPIO_TYPE_INTERRUPT) + wwan_fm350gl_acpi_gpio_events(dev); } static struct device_operations wwan_fm350gl_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/78417?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib5f4cdc2a3dcac419bda4ebb32c13807ac8b686d Gerrit-Change-Number: 78417 Gerrit-PatchSet: 1 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix
by Paweł Anikiel (Code Review) 16 Oct '23

16 Oct '23

Paweł Anikiel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78416?usp=email ) Change subject: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix ...................................................................... mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix Signed-off-by: Paweł Anikiel <panikiel(a)google.com> Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/redrix/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/78416/1 diff --git a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c index 4883a07..07f8dbd 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c @@ -19,7 +19,7 @@ /* A6 : ESPI_ALERT1# ==> SPKR_INT_L */ PAD_CFG_GPI(GPP_A6, NONE, DEEP), /* A7 : SRCCLK_OE7# ==> WWAN_PCIE_WAKE_ODL */ - PAD_CFG_GPI_APIC(GPP_A7, NONE, PLTRST, LEVEL, INVERT), + PAD_CFG_GPI_INT(GPP_A7, NONE, PLTRST, EDGE_SINGLE), /* A8 : SRCCLKREQ7# ==> WWAN_RF_DISABLE_ODL */ PAD_CFG_GPO(GPP_A8, 1, DEEP), /* A9 : ESPI_CLK ==> ESPI_CLK */ diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index cc4961a..f5556f0 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -238,7 +238,7 @@ register "fcpo_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F21)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E16)" register "perst_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E0)" - register "wake_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A7)" + register "wake_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPP_A7)" register "add_acpi_dma_property" = "true" use rp6_rtd3 as rtd3dev device generic 0 alias rp6_wwan on -- To view, visit https://review.coreboot.org/c/coreboot/+/78416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 Gerrit-Change-Number: 78416 Gerrit-PatchSet: 1 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Fix incorrect microcode comments
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Michał Żygowski, Nick Vaccaro, Paul Menzel. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78413?usp=email ) Change subject: soc/intel/alderlake: Fix incorrect microcode comments ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78413?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c848e0dfc40f6c8e26a9b31e7c4cf4c5a09128f Gerrit-Change-Number: 78413 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:48:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: device/device.h: Drop acpi_inject_dsdt
by Tim Wawrzynczak (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Arthur Heymans, Lance Zhao. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78334?usp=email ) Change subject: device/device.h: Drop acpi_inject_dsdt ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78334?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iffefc865901b15fa299931b6ed4c27a9e3a1c330 Gerrit-Change-Number: 78334 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/common/data_fabric_helper: add pre-processor guards for ACPI
by Felix Held (Code Review) 16 Oct '23

16 Oct '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78341?usp=email ) Change subject: soc/amd/common/data_fabric_helper: add pre-processor guards for ACPI ...................................................................... soc/amd/common/data_fabric_helper: add pre-processor guards for ACPI Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Iec6e05bbe9fad7d78002560b78169dc293294af6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78341 Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> --- M src/soc/amd/common/block/data_fabric/data_fabric_helper.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Fred Reitberger: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c index 0426af8..7a6e615 100644 --- a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c +++ b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c @@ -62,6 +62,7 @@ } } +#if CONFIG(HAVE_ACPI_TABLES) static const char *data_fabric_acpi_name(const struct device *dev) { const char *df_acpi_names[8] = { @@ -82,10 +83,13 @@ printk(BIOS_ERR, "%s: Unhandled device id 0x%x\n", __func__, dev->device); return NULL; } +#endif struct device_operations amd_data_fabric_ops = { .read_resources = noop_read_resources, .set_resources = noop_set_resources, +#if CONFIG(HAVE_ACPI_TABLES) .acpi_name = data_fabric_acpi_name, .acpi_fill_ssdt = acpi_device_write_pci_dev, +#endif }; -- To view, visit https://review.coreboot.org/c/coreboot/+/78341?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec6e05bbe9fad7d78002560b78169dc293294af6 Gerrit-Change-Number: 78341 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: soc/amd/common/data_fabric/extended_mmio: fix compile errors
by Felix Held (Code Review) 16 Oct '23

16 Oct '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78340?usp=email ) Change subject: soc/amd/common/data_fabric/extended_mmio: fix compile errors ...................................................................... soc/amd/common/data_fabric/extended_mmio: fix compile errors This code only gets built when the SOC selects SOC_AMD_COMMON_BLOCK_DATA_FABRIC_EXTENDED_MMIO which no SoC before Genoa does. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ia5495ebf0f157fd0c456ce44acaf1ab222a188dd Reviewed-on: https://review.coreboot.org/c/coreboot/+/78340 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> --- M src/soc/amd/common/block/data_fabric/extended_mmio.c 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Fred Reitberger: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/soc/amd/common/block/data_fabric/extended_mmio.c b/src/soc/amd/common/block/data_fabric/extended_mmio.c index d0c3d9f..a18d936 100644 --- a/src/soc/amd/common/block/data_fabric/extended_mmio.c +++ b/src/soc/amd/common/block/data_fabric/extended_mmio.c @@ -10,13 +10,14 @@ { const uint32_t base_reg = data_fabric_broadcast_read32(DF_MMIO_BASE(reg)); const uint32_t limit_reg = data_fabric_broadcast_read32(DF_MMIO_LIMIT(reg)); - const union df_mmio_addr_ext ext_reg.raw = - data_fabric_broadcast_read32(DF_MMIO_ADDR_EXT(reg)); + const union df_mmio_addr_ext ext_reg = { + .raw = data_fabric_broadcast_read32(DF_MMIO_ADDR_EXT(reg)) + }; /* The raw register values in the base and limit registers are bits 47..16 of the actual address. The MMIO address extension register contains the extended MMIO base and limit bits starting with bit 48 of the actual address. */ *mmio_base = (resource_t)ext_reg.base_ext << DF_MMIO_EXT_ADDR_SHIFT | (resource_t)base_reg << DF_MMIO_SHIFT; - *mmio_limit = (resource_t)ext_reg.limit_ext << DF_MMIO_EXT_ADDR_SHIFT | - (((resource_t)limit_reg + 1) << DF_MMIO_SHIFT) - 1; + *mmio_limit = ((resource_t)ext_reg.limit_ext << DF_MMIO_EXT_ADDR_SHIFT | + (((resource_t)limit_reg + 1) << DF_MMIO_SHIFT)) - 1; } -- To view, visit https://review.coreboot.org/c/coreboot/+/78340?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5495ebf0f157fd0c456ce44acaf1ab222a188dd Gerrit-Change-Number: 78340 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: soc/amd/common/data_fabric/extended_mmio: fix compile errors
by Felix Held (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78340?usp=email ) Change subject: soc/amd/common/data_fabric/extended_mmio: fix compile errors ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > may be add the topic "amd_genoa_opensil" ? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78340?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5495ebf0f157fd0c456ce44acaf1ab222a188dd Gerrit-Change-Number: 78340 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:19:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/kconfig: chmod +w before savedefconfig
by Richard Marko (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Martin L Roth, Paul Menzel. Richard Marko has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78415?usp=email ) Change subject: util/kconfig: chmod +w before savedefconfig ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78415/comment/5e5ed8eb_9c5885cb : PS1, Line 9: This prevents a headscratcher when .config in root doesn't have a write > > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78415?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Gerrit-Change-Number: 78415 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Marko <rmarko(a)fedoraproject.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/kahlee: Rework I2S/ACP ACPI for new Windows driver
by Matt DeVillier (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: CoolStar, Jason Nien, Martin Roth, Martin Roth, Nico Huber. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78406?usp=email ) Change subject: mb/google/kahlee: Rework I2S/ACP ACPI for new Windows driver ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: - switch to unix line endings - add newline at end of audio_common.asl - make hiding existing i2s devices separate patch -- To view, visit https://review.coreboot.org/c/coreboot/+/78406?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I51527a1bfae3e12ce5cf1da8a3465bbc9ddfa76e Gerrit-Change-Number: 78406 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:15:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/kconfig: chmod +w before savedefconfig
by Richard Marko (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Martin L Roth, Paul Menzel. Richard Marko has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78415?usp=email ) Change subject: util/kconfig: chmod +w before savedefconfig ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78415/comment/510b97ae_c5cb53de : PS1, Line 9: .config in root doesn't have a write : permission bit set > Do you have a umask not setting it by default? I found about this when trying to do a nix-build of ROM, in which .config came from /nix/store/.. path with 0444 perms and it caused this. It was quite surprising because a normal build was working in another terminal and I didn't see a relation between .config and temporary file permissions at first, had to strace and stare at the output for some time. -- To view, visit https://review.coreboot.org/c/coreboot/+/78415?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Gerrit-Change-Number: 78415 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Marko <rmarko(a)fedoraproject.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023