coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: util/kconfig: chmod +w before savedefconfig
by Richard Marko (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Martin L Roth, Richard Marko. Hello Martin L Roth, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78415?usp=email to look at the new patch set (#2). Change subject: util/kconfig: chmod +w before savedefconfig ...................................................................... util/kconfig: chmod +w before savedefconfig This prevents a headscratcher when .config in root doesn't have a write permission bit set which causes a build failure of savedefconfig not able to write to copied file, for example *** Error while saving defconfig to: build/mainboard/emulation/qemu-i440fx/cbfs-file.eU5E0t.out.tmp2 Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Signed-off-by: Richard Marko <srk(a)48.io> --- M util/kconfig/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/78415/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78415?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Gerrit-Change-Number: 78415 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Marko <rmarko(a)fedoraproject.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Richard Marko <rmarko(a)fedoraproject.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Fix incorrect microcode comments
by Michał Żygowski (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Nick Vaccaro, Paul Menzel, Subrata Banik. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78413?usp=email ) Change subject: soc/intel/alderlake: Fix incorrect microcode comments ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78413/comment/9708167f_18c89c8f : PS1, Line 20: So there is no need to add separate files for ADL and RPL SKUs. > This sounds like you are doing more than just updating comments. Rephrased it to correctly express my intention -- To view, visit https://review.coreboot.org/c/coreboot/+/78413?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c848e0dfc40f6c8e26a9b31e7c4cf4c5a09128f Gerrit-Change-Number: 78413 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:14:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Fix incorrect microcode comments
by Michał Żygowski (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Michał Żygowski, Nick Vaccaro, Subrata Banik. Hello Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78413?usp=email to look at the new patch set (#2). Change subject: soc/intel/alderlake: Fix incorrect microcode comments ...................................................................... soc/intel/alderlake: Fix incorrect microcode comments The microcode for RPL-S C0 and H0 is actually available, however, the name of the file contained a typo: 06-b7-05 vs 06-bf-05. Fix the typos in the comments. Moreover, the ADL-S C0/H0 microcode file 06-97-05 has the same sha256 sum as the equivalent RPL-S C0/H0 microcode file 06-bf-05. The sha256 sum of ADL-S/RPL-S C0/H0 microcode on intel-microcode tag microcode-20230808: 5d8d4a4d5456c43b7cc04937c80aec094ccbf3bd89f34ffa5182913ef944a9f9 Update the comments to correctly indicate supported CPU steppings. Change-Id: I4c848e0dfc40f6c8e26a9b31e7c4cf4c5a09128f Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/soc/intel/alderlake/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/78413/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78413?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c848e0dfc40f6c8e26a9b31e7c4cf4c5a09128f Gerrit-Change-Number: 78413 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: acpi: Reserve hardware ID for custom AMD ACP driver
by Matt DeVillier (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: CoolStar, Felix Held, Martin Roth, Nico Huber. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78405?usp=email ) Change subject: acpi: Reserve hardware ID for custom AMD ACP driver ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78405?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I855b81908ed9ad0587b6367b052c726c36350208 Gerrit-Change-Number: 78405 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:13:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya/variants/anraggar: Generate RAM IDs
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78389?usp=email ) Change subject: mb/google/brya/variants/anraggar: Generate RAM IDs ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78389/comment/6b1ecbe0_4ae7c9f6 : PS2, Line 7: Generate RAM IDs Maybe: > Generate 3 RAM IDs https://review.coreboot.org/c/coreboot/+/78389/comment/5265c420_80936dbb : PS2, Line 10: MT62F512M32D2DR-031 WT:B (LP5) : H9JCNNNBK3MLYR-N6E (LP5) : H9JCNNNCP3MLYR-N6E (LP5) Please also add the vendors, and format it as a list. -- To view, visit https://review.coreboot.org/c/coreboot/+/78389?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2968c2f0b9cdd55235f9833a3d3cdb3c83b8601b Gerrit-Change-Number: 78389 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:11:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms
by Michał Żygowski (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Nick Vaccaro, Paul Menzel, Subrata Banik. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78411?usp=email ) Change subject: soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78411/comment/2a00f4a9_e1f46a9b : PS1, Line 9: is present > To avoid misunderstanding, maybe say where. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77aecd6e2d753732bf6358afe2c7ea0491348387 Gerrit-Change-Number: 78411 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:10:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/alderlake: Fix order of defaults in FSP_HEADER_PATH
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Michał Żygowski, Nick Vaccaro, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78410?usp=email ) Change subject: soc/alderlake: Fix order of defaults in FSP_HEADER_PATH ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8db5ea10c2986ff8d3fa7d616b3f1617d05f0260 Gerrit-Change-Number: 78410 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:10:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms
by Michał Żygowski (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Michał Żygowski, Nick Vaccaro, Subrata Banik. Hello Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78411?usp=email to look at the new patch set (#2). Change subject: soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms ...................................................................... soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms The Client FSP for Raptor Lake-S is present on the Intel FSP repository, so there is no need to restrict Raptor Lake-S FSP binary repository to IoT only. TEST=Build and boot MSI PRO Z790-P Change-Id: I77aecd6e2d753732bf6358afe2c7ea0491348387 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/soc/intel/alderlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/78411/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77aecd6e2d753732bf6358afe2c7ea0491348387 Gerrit-Change-Number: 78411 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Michał Żygowski, Nick Vaccaro, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78411?usp=email ) Change subject: soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78411/comment/2bf6a1fe_f2a10c44 : PS1, Line 9: is present To avoid misunderstanding, maybe say where. -- To view, visit https://review.coreboot.org/c/coreboot/+/78411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77aecd6e2d753732bf6358afe2c7ea0491348387 Gerrit-Change-Number: 78411 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:09:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Fix incorrect ucode comments
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Michał Żygowski, Nick Vaccaro, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78413?usp=email ) Change subject: soc/intel/alderlake: Fix incorrect ucode comments ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78413/comment/1456bf6f_ce5405fd : PS1, Line 20: So there is no need to add separate files for ADL and RPL SKUs. This sounds like you are doing more than just updating comments. -- To view, visit https://review.coreboot.org/c/coreboot/+/78413?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c848e0dfc40f6c8e26a9b31e7c4cf4c5a09128f Gerrit-Change-Number: 78413 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:08:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023