coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS
by Eric Lai (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Subrata Banik, Tarun. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78387?usp=email ) Change subject: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78387/comment/8e53fd54_974d36b0 : PS1, Line 92: BMP_LOGO why need the guard? if no logo, we don't need this? -- To view, visit https://review.coreboot.org/c/coreboot/+/78387?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36af167afa902053a987602d494a8830ad9b1b1a Gerrit-Change-Number: 78387 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 15:51:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/cmn/graphics: Implement API for IGD to join the MBUS
by Eric Lai (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Kapil Porwal, Nick Vaccaro, Paz Zcharya, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78385?usp=email ) Change subject: soc/intel/cmn/graphics: Implement API for IGD to join the MBUS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78385?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I60ae76dc783383e027e66edbcdeeb535472caeb1 Gerrit-Change-Number: 78385 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 15:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: {commonlib, libpayload}: Add "has_fw_splash_screen" entry
by Tim Van Patten (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Andrey Petrov, Eric Lai, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Subrata Banik. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78388?usp=email ) Change subject: {commonlib, libpayload}: Add "has_fw_splash_screen" entry ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78388/comment/d4348fc1_ede6c50e : PS1, Line 13: This information is useful for overriding the kernel command-line : argument fw_splash. If fw_splash=1, the kernel will skip modeset because : the splash screen has already been rendered by the firmware. This is incorrect, because the kernel doesn't recognize or use `fw_splash`. Rather, it's a workaround to pass along the information to user space (`frecon`). This CL should be blocked on the CrOS CL discussing how to use this information: https://crrev.com/c/4893558 https://review.coreboot.org/c/coreboot/+/78388/comment/18919993_814ec794 : PS1, Line 18: fw_splash `has_fw_splash_screen` https://review.coreboot.org/c/coreboot/+/78388/comment/5baf6739_6c657609 : PS1, Line 18: The payload (e.g., deptcharge) does not : have any other way to determine whether the firmware has initiated : screen rendering. The payload doesn't actually care either though. -- To view, visit https://review.coreboot.org/c/coreboot/+/78388?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ef378c4b4ee4845d698184e43d2514410baddc6 Gerrit-Change-Number: 78388 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 15:36:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
by Paweł Anikiel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Subrata Banik. Hello Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78297?usp=email to look at the new patch set (#3). Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ...................................................................... drivers/wwan/fm: Wake up modem on PEWAKE# signal change Create an event handler for the PEWAKE# GPIO and notify the device driver to wake up the device. BUG=b:301150499 TEST=Compiled and tested on google/redrix Signed-off-by: Paweł Anikiel <panikiel(a)google.com> Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e --- M src/drivers/wwan/fm/acpi_fm350gl.c 1 file changed, 58 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/78297/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/78297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e Gerrit-Change-Number: 78297 Gerrit-PatchSet: 3 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix
by Paweł Anikiel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Nick Vaccaro, Subrata Banik. Hello Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78416?usp=email to look at the new patch set (#2). Change subject: mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix ...................................................................... mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix BUG=b:301150499 TEST=Compiled and tested on google/redrix Signed-off-by: Paweł Anikiel <panikiel(a)google.com> Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/redrix/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/78416/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 Gerrit-Change-Number: 78416 Gerrit-PatchSet: 2 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/intel/cmn/gfx: Detect dual display (eDP + HDMI)
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78383?usp=email ) Change subject: soc/intel/cmn/gfx: Detect dual display (eDP + HDMI) ...................................................................... soc/intel/cmn/gfx: Detect dual display (eDP + HDMI) This patch adds support for detecting dual displays (eDP and HDMI) on Intel platforms. This information is useful for setting the `lb_framebuffer.has_external_display` variable, which is used to determine whether depthchage should avoid shutting down when an extended display is present. TEST= Able to build and boot google/rex, where depthchage now successfully avoids shutting down when both eDP and HDMI displays are attached. w/o this patch: with eDP and HDMI attached: .has_external_display=0 with eDP attached: .has_external_display=0 with HDMI attached: .has_external_display=1 w/ this patch: with eDP and HDMI attached: .has_external_display = 1 with eDP attached: .has_external_display=0 with HDMI attached: .has_external_display=1 Change-Id: Ie39d48da75a21e3508a1fbcf09da31caedaa1c0a Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78383 Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/common/block/graphics/graphics.c 1 file changed, 25 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c index 5b2484a..9d541d0 100644 --- a/src/soc/intel/common/block/graphics/graphics.c +++ b/src/soc/intel/common/block/graphics/graphics.c @@ -31,6 +31,14 @@ return NULL; } +static uint32_t graphics_get_ddi_func_ctrl(unsigned long reg) +{ + uint32_t ddi_func_ctrl = graphics_gtt_read(reg); + ddi_func_ctrl &= TRANS_DDI_PORT_MASK; + + return ddi_func_ctrl; +} + /* * Transcoders contain the timing generators for eDP, DP, and HDMI interfaces. * Intel transcoders are based on Quick Sync Video, which offloads video @@ -58,20 +66,31 @@ */ static int get_external_display_status(void) { - uint32_t ddi_func_ctrl = graphics_gtt_read(TRANS_DDI_FUNC_CTL_A); - ddi_func_ctrl &= TRANS_DDI_PORT_MASK; + /* Read the transcoder register for DDI-A (eDP) */ + uint32_t ddi_a_func_ctrl = graphics_get_ddi_func_ctrl(TRANS_DDI_FUNC_CTL_A); + /* Read the transcoder register for DDI-B (HDMI) */ + uint32_t ddi_b_func_ctrl = graphics_get_ddi_func_ctrl(TRANS_DDI_FUNC_CTL_B); /* * Check if transcoder is none or connected to DDI-A port (aka eDP). * Report no external display in both cases. */ - if (ddi_func_ctrl == TRANS_DDI_PORT_NONE) { + if (ddi_a_func_ctrl == TRANS_DDI_PORT_NONE) { return 0; } else { - if (ddi_func_ctrl == TRANS_DDI_SELECT_PORT(PORT_A)) - return 0; - else + if ((ddi_a_func_ctrl == TRANS_DDI_SELECT_PORT(PORT_A)) && + (ddi_b_func_ctrl == TRANS_DDI_SELECT_PORT(PORT_B))) { + /* + * Dual display detected: both DDI-A(eDP) and + * DDI-B(HDMI) pipes are active + */ return 1; + } else { + if (ddi_a_func_ctrl == TRANS_DDI_SELECT_PORT(PORT_A)) + return 0; + else + return 1; + } } } -- To view, visit https://review.coreboot.org/c/coreboot/+/78383?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie39d48da75a21e3508a1fbcf09da31caedaa1c0a Gerrit-Change-Number: 78383 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: superio/smsc/sch5545/acpi/superio.asl: Clear PME status bits on SCI
by Krystian Hebel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Michał Żygowski. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78351?usp=email ) Change subject: superio/smsc/sch5545/acpi/superio.asl: Clear PME status bits on SCI ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/superio/smsc/sch5545/acpi/superio.asl: https://review.coreboot.org/c/coreboot/+/78351/comment/46abc9f9_d3d4b6e6 : PS1, Line 380: Notify (UAR1, 0x02) // Device Wake > Since this assumes existence of UAR1, shouldn't it be guarded by `#ifdef SCH5545_SHOW_UARTA`? Simila […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78351?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64e03d268138a62b46084be41343ef7fb089dfc3 Gerrit-Change-Number: 78351 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 15:18:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
by Paweł Anikiel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Subrata Banik. Paweł Anikiel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78297?usp=email ) Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ...................................................................... Patch Set 2: (1 comment) File src/drivers/wwan/fm/acpi_fm350gl.c: https://review.coreboot.org/c/coreboot/+/78297/comment/f300b1ab_3fefb52e : PS1, Line 374: if (config->wake_gpio.pin_count) > I don't think this check is suffiencient. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e Gerrit-Change-Number: 78297 Gerrit-PatchSet: 2 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 15:14:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kornel Dulęba <korneld(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
by Paweł Anikiel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Nick Vaccaro, Paweł Anikiel, Subrata Banik. Hello Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78297?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ...................................................................... drivers/wwan/fm: Wake up modem on PEWAKE# signal change Create an event handler for the PEWAKE# GPIO and notify the device driver to wake up the device. Signed-off-by: Paweł Anikiel <panikiel(a)google.com> Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e --- M src/drivers/wwan/fm/acpi_fm350gl.c 1 file changed, 58 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/78297/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e Gerrit-Change-Number: 78297 Gerrit-PatchSet: 2 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Kornel Dulęba <korneld(a)google.com> Gerrit-Attention: Paweł Anikiel <panikiel(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
by Paweł Anikiel (Code Review) 16 Oct '23

16 Oct '23

Paweł Anikiel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78417?usp=email ) Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ...................................................................... Abandoned Duplicate of https://review.coreboot.org/c/coreboot/+/78297 -- To view, visit https://review.coreboot.org/c/coreboot/+/78417?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib5f4cdc2a3dcac419bda4ebb32c13807ac8b686d Gerrit-Change-Number: 78417 Gerrit-PatchSet: 1 Gerrit-Owner: Paweł Anikiel <panikiel(a)google.com> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023