coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: util/kconfig: chmod +w before savedefconfig
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Martin L Roth, Richard Marko. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78415?usp=email ) Change subject: util/kconfig: chmod +w before savedefconfig ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78415/comment/5f739cdb_cdf988b7 : PS1, Line 9: This prevents a headscratcher when .config in root doesn't have a write > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` Please fix. https://review.coreboot.org/c/coreboot/+/78415/comment/557f300b_801e93b9 : PS1, Line 9: .config in root doesn't have a write : permission bit set Do you have a umask not setting it by default? https://review.coreboot.org/c/coreboot/+/78415/comment/3ac0da09_b28859a3 : PS1, Line 12: > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` Pastes are allowed to violate the limit. -- To view, visit https://review.coreboot.org/c/coreboot/+/78415?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Gerrit-Change-Number: 78415 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Marko <rmarko(a)fedoraproject.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Richard Marko <rmarko(a)fedoraproject.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:04:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/kconfig: chmod +w before savedefconfig
by Richard Marko (Code Review) 16 Oct '23

16 Oct '23

Richard Marko has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78415?usp=email ) Change subject: util/kconfig: chmod +w before savedefconfig ...................................................................... util/kconfig: chmod +w before savedefconfig This prevents a headscratcher when .config in root doesn't have a write permission bit set which causes a build failure of savedefconfig not able to write to copied file, for example *** Error while saving defconfig to: build/mainboard/emulation/qemu-i440fx/cbfs-file.eU5E0t.out.tmp2 Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Signed-off-by: Richard Marko <srk(a)48.io> --- M util/kconfig/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/78415/1 diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc index 36678da..5f75ba3 100644 --- a/util/kconfig/Makefile.inc +++ b/util/kconfig/Makefile.inc @@ -34,6 +34,7 @@ savedefconfig: $(objk)/conf cp $(DOTCONFIG) $(DEFCONFIG) + chmod +w $(DEFCONFIG) $< --savedefconfig=$(DEFCONFIG) $(KBUILD_KCONFIG) FORCE: -- To view, visit https://review.coreboot.org/c/coreboot/+/78415?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Gerrit-Change-Number: 78415 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Marko <rmarko(a)fedoraproject.org> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: util/kconfig: chmod +w before savedefconfig
by Richard Marko (Code Review) 16 Oct '23

16 Oct '23

Richard Marko has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78414?usp=email ) Change subject: util/kconfig: chmod +w before savedefconfig ...................................................................... util/kconfig: chmod +w before savedefconfig This prevents a headscratcher when .config in root doesn't have a write permission bit set which causes a build failure of savedefconfig not able to write to copied file, for example *** Error while saving defconfig to: build/mainboard/emulation/qemu-i440fx/cbfs-file.eU5E0t.out.tmp2 Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Signed-off-by: Richard Marko <srk(a)48.io> --- M util/kconfig/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/78414/1 diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc index 36678da..5f75ba3 100644 --- a/util/kconfig/Makefile.inc +++ b/util/kconfig/Makefile.inc @@ -34,6 +34,7 @@ savedefconfig: $(objk)/conf cp $(DOTCONFIG) $(DEFCONFIG) + chmod +w $(DEFCONFIG) $< --savedefconfig=$(DEFCONFIG) $(KBUILD_KCONFIG) FORCE: -- To view, visit https://review.coreboot.org/c/coreboot/+/78414?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e7d35c9f6e8add3e7438d163850bc5fda5a99b2 Gerrit-Change-Number: 78414 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Marko <rmarko(a)fedoraproject.org> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Fix incorrect ucode comments
by Michał Żygowski (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Nick Vaccaro, Subrata Banik. Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78413?usp=email ) Change subject: soc/intel/alderlake: Fix incorrect ucode comments ...................................................................... soc/intel/alderlake: Fix incorrect ucode comments The microcode for RPL-S C0 and H0 is actually available, however the name of the file contained a typo: 06-b7-05 vs 06-bf-05. Fix the typos in the comments. Moreover, the ADL-S C0/H0 microcode file 06-97-05 has the same sha256 sum as the equivalent RPL-S C0/H0 microcode file 06-bf-05. The sha256 sum of ADL-S/RPL-S C0/H0 micorcode on intel-microcode tag microcode-20230808: 5d8d4a4d5456c43b7cc04937c80aec094ccbf3bd89f34ffa5182913ef944a9f9 So there is no need to add separate files for ADL and RPL SKUs. Change-Id: I4c848e0dfc40f6c8e26a9b31e7c4cf4c5a09128f Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/soc/intel/alderlake/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/78413/1 diff --git a/src/soc/intel/alderlake/Makefile.inc b/src/soc/intel/alderlake/Makefile.inc index 1da9b38..55fc83ea 100644 --- a/src/soc/intel/alderlake/Makefile.inc +++ b/src/soc/intel/alderlake/Makefile.inc @@ -78,11 +78,11 @@ ifeq ($(CONFIG_SOC_INTEL_ALDERLAKE_PCH_S),y) # 06-97-00, 06-97-01, 06-97-04 are ADL-S Engineering Samples # 06-97-02 are ADL-S/HX Quality Samples but also ADL-HX Engineering Samples -# ADL-S/HX C0 and ADL-S H0 +# 06-b7-00 are RPL-S Engineering Samples +# ADL-S/HX C0/H0 and RPL-S C0/H0 cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-97-05 # RPL-S/HX B0 cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-b7-01 -# 06-b7-00, 06-b7-02, 06-b7-05 RPL-S/HX A0, C0 and H0 missing else ifeq ($(CONFIG_SOC_INTEL_ALDERLAKE_PCH_N),y) cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-be-00 else -- To view, visit https://review.coreboot.org/c/coreboot/+/78413?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c848e0dfc40f6c8e26a9b31e7c4cf4c5a09128f Gerrit-Change-Number: 78413 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mainboard/msi/ms7e06: Remove FSP_TYPE_IOT
by Michał Żygowski (Code Review) 16 Oct '23

16 Oct '23

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78412?usp=email ) Change subject: mainboard/msi/ms7e06: Remove FSP_TYPE_IOT ...................................................................... mainboard/msi/ms7e06: Remove FSP_TYPE_IOT MSI PRO Z790-P is not an IoT platform. FSP_TYPE_IOT was selected only temporarily to allow builds from public components. Now that Client FSP is available, switch to it. TEST=Build and boot MSI PRO Z790-P Change-Id: Ic5d84e48d58c3454b83b9df5eb93076d2ebde000 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/mainboard/msi/ms7e06/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/78412/1 diff --git a/src/mainboard/msi/ms7e06/Kconfig b/src/mainboard/msi/ms7e06/Kconfig index 8dca3fc..d248582 100644 --- a/src/mainboard/msi/ms7e06/Kconfig +++ b/src/mainboard/msi/ms7e06/Kconfig @@ -7,7 +7,6 @@ config BOARD_MSI_MS7E06 def_bool n select SOC_INTEL_RAPTORLAKE_PCH_S - select FSP_TYPE_IOT select BOARD_ROMSIZE_KB_32768 select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SUPERIO_NUVOTON_NCT6687D -- To view, visit https://review.coreboot.org/c/coreboot/+/78412?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5d84e48d58c3454b83b9df5eb93076d2ebde000 Gerrit-Change-Number: 78412 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms
by Michał Żygowski (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Nick Vaccaro, Subrata Banik. Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78411?usp=email ) Change subject: soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms ...................................................................... soc/intel/alderlake: Allow using FSP repo for all RPL-S platforms The Client FSP for Raptor Lake-S is present so there is no need to restrict Raptor Lake-S FSP binary repository to IoT only. TEST=Build and boot MSI PRO Z790-P Change-Id: I77aecd6e2d753732bf6358afe2c7ea0491348387 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/soc/intel/alderlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/78411/1 diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 803744ce..ebeb28c 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -127,7 +127,7 @@ config SOC_INTEL_ALDERLAKE_PCH_S bool select SOC_INTEL_ALDERLAKE - select HAVE_INTEL_FSP_REPO if !SOC_INTEL_RAPTORLAKE_PCH_S || (SOC_INTEL_RAPTORLAKE_PCH_S && FSP_TYPE_IOT) + select HAVE_INTEL_FSP_REPO select PLATFORM_USES_FSP2_3 help Choose this option if your mainboard has a PCH-S chipset. -- To view, visit https://review.coreboot.org/c/coreboot/+/78411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77aecd6e2d753732bf6358afe2c7ea0491348387 Gerrit-Change-Number: 78411 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/alderlake: Fix order of defaults in FSP_HEADER_PATH
by Michał Żygowski (Code Review) 16 Oct '23

16 Oct '23

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78410?usp=email ) Change subject: soc/alderlake: Fix order of defaults in FSP_HEADER_PATH ...................................................................... soc/alderlake: Fix order of defaults in FSP_HEADER_PATH The combination of SOC_INTEL_RAPTORLAKE_PCH_S and FSP_TYPE_IOT is currently broken. By default, e.g. for MSI PRO Z790-P, the FSP_HEADER_PATH does not match the default FSP_FD_PATH. For headers the client FSP is selected, while for the FD file, IoT FSP binary is chosen. The order of default for both headers and FD file must be the same to match the headers and binaries. TEST=Build default MSI PRO Z790-P config and see that FSP_HEADER_PATH matches FSP_FD_PATH FSP variant-wise. Change-Id: I8db5ea10c2986ff8d3fa7d616b3f1617d05f0260 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/soc/intel/alderlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/78410/1 diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 4b960c1..803744ce 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -401,9 +401,9 @@ default "src/vendorcode/intel/fsp/fsp2_0/alderlake_n/" if SOC_INTEL_ALDERLAKE_PCH_N && !FSP_USE_REPO default "src/vendorcode/intel/fsp/fsp2_0/raptorlake/4221.00_google/" if VENDOR_GOOGLE && SOC_INTEL_RAPTORLAKE && !FSP_USE_REPO default "src/vendorcode/intel/fsp/fsp2_0/raptorlake/4301.01/" if SOC_INTEL_RAPTORLAKE && !FSP_USE_REPO + default "3rdparty/fsp/RaptorLakeFspBinPkg/IoT/RaptorLakeS/Include/" if SOC_INTEL_RAPTORLAKE_PCH_S && FSP_TYPE_IOT default "3rdparty/fsp/RaptorLakeFspBinPkg/Client/RaptorLakeP/Include/" if SOC_INTEL_ALDERLAKE_PCH_P && SOC_INTEL_RAPTORLAKE default "3rdparty/fsp/RaptorLakeFspBinPkg/Client/RaptorLakeS/Include/" if SOC_INTEL_ALDERLAKE_PCH_S && SOC_INTEL_RAPTORLAKE - default "3rdparty/fsp/RaptorLakeFspBinPkg/IoT/RaptorLakeS/Include/" if SOC_INTEL_RAPTORLAKE_PCH_S && FSP_TYPE_IOT default "3rdparty/fsp/AlderLakeFspBinPkg/IoT/AlderLakeP/Include/" if SOC_INTEL_ALDERLAKE_PCH_P && FSP_TYPE_IOT default "3rdparty/fsp/AlderLakeFspBinPkg/IoT/AlderLakeS/Include/" if SOC_INTEL_ALDERLAKE_PCH_S && FSP_TYPE_IOT default "3rdparty/fsp/AlderLakeFspBinPkg/Client/AlderLakeP/Include/" if SOC_INTEL_ALDERLAKE_PCH_P -- To view, visit https://review.coreboot.org/c/coreboot/+/78410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8db5ea10c2986ff8d3fa7d616b3f1617d05f0260 Gerrit-Change-Number: 78410 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Sumeet R Pawnikar, Tarun, Tyler Wang, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: please rebase this CL after breaking the chain relationship with parent CL -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 7 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 13:13:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Sumeet R Pawnikar, Tarun, Tyler Wang, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email ) Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS5: > Please help to merge this CL, thanks! Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 7 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 13:13:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya/variants/anraggar: Generate RAM IDs
by Weimin Wu (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu. Hello Eric Lai, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78389?usp=email to look at the new patch set (#2). Change subject: mb/google/brya/variants/anraggar: Generate RAM IDs ...................................................................... mb/google/brya/variants/anraggar: Generate RAM IDs Generate RAM IDs for - MT62F512M32D2DR-031 WT:B (LP5) H9JCNNNBK3MLYR-N6E (LP5) H9JCNNNCP3MLYR-N6E (LP5) BUG=b:304920262 TEST=Run part_id_gen tool without any errors Change-Id: I2968c2f0b9cdd55235f9833a3d3cdb3c83b8601b Signed-off-by: wuweimin <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/memory/Makefile.inc M src/mainboard/google/brya/variants/anraggar/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/anraggar/memory/mem_parts_used.txt 3 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/78389/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78389?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2968c2f0b9cdd55235f9833a3d3cdb3c83b8601b Gerrit-Change-Number: 78389 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023