coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[M] Change in coreboot[main]: soc/ibm/power9/*: add file structure for SOC
by Sergii Dmytruk (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Felix Held, Igor Bagnucki, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Michał Kopeć, Michał Żygowski, Paul Menzel. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67062?usp=email ) Change subject: soc/ibm/power9/*: add file structure for SOC ...................................................................... Patch Set 20: (2 comments) File src/soc/ibm/power9/Kconfig: https://review.coreboot.org/c/coreboot/+/67062/comment/d9586953_ecc3e774 : PS19, Line 4: This SoC is the minimal template working on POWER9 : Talos II platform. > Does this fit in one line? Yes, joined the lines. File src/soc/ibm/power9/timer.c: https://review.coreboot.org/c/coreboot/+/67062/comment/e4e734a3_f5446f79 : PS19, Line 7: // no need to do anything here > Please indent with a tab? Maybe also explain why in the comment? Weird that wrong indentation wasn't caught by any tools. Updated the comment. The implementation will change in future commits (not yet on Gerrit). -- To view, visit https://review.coreboot.org/c/coreboot/+/67062?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie74b1e34f9aebe151d0fdb0e95c003510fd864c3 Gerrit-Change-Number: 67062 Gerrit-PatchSet: 20 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Igor Bagnucki <bagnucki02(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Igor Bagnucki <bagnucki02(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 17:24:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/ibm/power9/*: add file structure for SOC
by Sergii Dmytruk (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Felix Held, Igor Bagnucki, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Hello Felix Held, Igor Bagnucki, Krystian Hebel, Martin L Roth, Michał Kopeć, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67062?usp=email to look at the new patch set (#20). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/ibm/power9/*: add file structure for SOC ...................................................................... soc/ibm/power9/*: add file structure for SOC Boot device is stubbed, to be able to build boards without errors. Change-Id: Ie74b1e34f9aebe151d0fdb0e95c003510fd864c3 Signed-off-by: Igor Bagnucki <bagnucki02(a)gmail.com> Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- A src/soc/ibm/Kconfig A src/soc/ibm/power9/Kconfig A src/soc/ibm/power9/Makefile.inc A src/soc/ibm/power9/bootblock.c A src/soc/ibm/power9/cbmem.c A src/soc/ibm/power9/chip.c A src/soc/ibm/power9/rom_media.c A src/soc/ibm/power9/romstage.c A src/soc/ibm/power9/timer.c 9 files changed, 94 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/67062/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/67062?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie74b1e34f9aebe151d0fdb0e95c003510fd864c3 Gerrit-Change-Number: 67062 Gerrit-PatchSet: 20 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Igor Bagnucki <bagnucki02(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Igor Bagnucki <bagnucki02(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex: Turn off CNVi 3.3v power at romstage
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Bora Guvendik, Cliff Huang, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Tarun, Tyler Wang, Wonkyu Kim. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78122?usp=email ) Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Found it from the Ovis spreadsheet. It is the same GPIO, GPP E22. The signal name is EN_WLAN_RAILS instead of EN_PP3300_WLAN in Ovis. thanks. @jakub/tyler, please review this CL. -- To view, visit https://review.coreboot.org/c/coreboot/+/78122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0 Gerrit-Change-Number: 78122 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 17:17:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: {commonlib, libpayload}: Add "has_fw_splash_screen" entry
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Andrey Petrov, Eric Lai, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Tim Van Patten. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78388?usp=email ) Change subject: {commonlib, libpayload}: Add "has_fw_splash_screen" entry ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78388/comment/65b7945b_e73458c1 : PS1, Line 13: This information is useful for overriding the kernel command-line : argument fw_splash. If fw_splash=1, the kernel will skip modeset because : the splash screen has already been rendered by the firmware. > > As long as fw_splash is a valid argument which can be overridden, I don't see a problem. > > `fw_splash` is not a valid argument. The linux kernel does not support it. > > > as I said earlier, this CL has no relation about how this information can be useful by payload/DC/crosos. We are just keeping this information handy. > > This is dead code if there's no consumer of the information. Specifically, depthcharge doesn't use it, but passes it along via kernel command line arguments, which the kernel doesn't recognize or use either. I'm not sure why you are so concerned about DC being using this flag ? do you know that Tianocore also renders the logo at pre-boot? Having coreboot rendering the FW splash screen and later tianocore also renders yet another FW splash screen would results into a confusion, hence, we could use this information to let tianocore know about skipping the FW splash screen rendering. > > The only reason it's being added is as a workaround to inform user space (frecon) that the display is initialized. However, that's also unnecessary, since we should be using a `cros_config` value to indicate this feature instead. Further, this is all temporary until the necessary kernel CLs exist to query the HW directly to prevent re-initialization. I would request you to read the above comment, as mentioned earlier, the usecase is/can be much wider and DC is not alone the user of such information. -- To view, visit https://review.coreboot.org/c/coreboot/+/78388?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ef378c4b4ee4845d698184e43d2514410baddc6 Gerrit-Change-Number: 78388 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 17:13:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex: Turn off CNVi 3.3v power at romstage
by Cliff Huang (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78122?usp=email ) Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > I just sent request for these two. Found it from the Ovis spreadsheet. It is the same GPIO, GPP E22. The signal name is EN_WLAN_RAILS instead of EN_PP3300_WLAN in Ovis. -- To view, visit https://review.coreboot.org/c/coreboot/+/78122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0 Gerrit-Change-Number: 78122 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 17:11:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS
by Subrata Banik (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78387?usp=email ) Change subject: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78387/comment/50a80b13_3a5c8837 : PS1, Line 92: BMP_LOGO > oh probably add display init check in the .final in last patch? If not init then skip. how do u know if the display is init ? looking at the resolution or framebuffer ? -- To view, visit https://review.coreboot.org/c/coreboot/+/78387?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36af167afa902053a987602d494a8830ad9b1b1a Gerrit-Change-Number: 78387 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 17:09:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex: Turn off CNVi 3.3v power at romstage
by Cliff Huang (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim. Hello Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78122?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage ...................................................................... mb/google/rex: Turn off CNVi 3.3v power at romstage Turn CNVi 3.3v off at romstage so that it will be toggled during warm boot. Cnvi 3.3v is already turned on at ramstage. This is necessary to ensure the device starts in clean state. BUG=286187821 BUG=297293441 TEST= Check the Cnvi is enumerated after warm reboot. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0 --- M src/mainboard/google/rex/variants/karis/gpio.c M src/mainboard/google/rex/variants/ovis/gpio.c M src/mainboard/google/rex/variants/rex0/gpio.c M src/mainboard/google/rex/variants/screebo/gpio.c 4 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/78122/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/78122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0 Gerrit-Change-Number: 78122 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex: Enable sending EOP from payload
by Kapil Porwal (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Subrata Banik, Tarun Tuli. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74768?usp=email ) Change subject: mb/google/rex: Enable sending EOP from payload ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/74768?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5eda0a5c6d4c34cfcc2de898adde0b005d6edc1e Gerrit-Change-Number: 74768 Gerrit-PatchSet: 5 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 17:07:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/cmn/block/cse: Support sending EOP from payload
by Kapil Porwal (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Paul Menzel, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765?usp=email ) Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ...................................................................... Patch Set 7: (4 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/74765/comment/088a28d8_8cc26cea : PS4, Line 9: might require more time : to process the EOP command > Please document your measured numbers. This idea was conceptualized while implementing async EOP in coreboot so the processing time does not make much sense now. JFYI, This CL is the first step to move CSE operations to payload. In order to do so we must send EOP from payload because CSE doesn't respond to other commands after EOP. https://review.coreboot.org/c/coreboot/+/74765/comment/7a8d0683_e56554d0 : PS4, Line 10: Currently any boot time improvement in : coreboot leads to increase in EOP processing time > I do not fully understand this. […] same as above. https://review.coreboot.org/c/coreboot/+/74765/comment/ceb4b709_267ebe34 : PS4, Line 14: This improves boot time by ~10ms milliseconds. > Can the CSE firmware be updated to boot faster? same as above. https://review.coreboot.org/c/coreboot/+/74765/comment/41683665_19589dcb : PS4, Line 17: TEST=Verify sending EOP from depthcharge > On what devices? updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/74765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 Gerrit-Change-Number: 74765 Gerrit-PatchSet: 7 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: sridhar siricilla <siricillasridhar(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 16 Oct 2023 17:07:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS
by Eric Lai (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Subrata Banik, Tarun. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78387?usp=email ) Change subject: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78387/comment/b45b6d2f_c4c8e798 : PS1, Line 92: BMP_LOGO > > oh I mean maybe we don't need the guard? If we don't have boot logo, it will skip the panel init, […] oh probably add display init check in the .final in last patch? If not init then skip. -- To view, visit https://review.coreboot.org/c/coreboot/+/78387?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36af167afa902053a987602d494a8830ad9b1b1a Gerrit-Change-Number: 78387 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 17:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023