coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: mb/google/brya/var/dochi: update gpio settings
by Morris Hsu (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Bob Moragues, Bob Moragues, Lucas Chen, Nick Vaccaro, Ren Kuo, Subrata Banik, YH Lin. Hello Bob Moragues, Bob Moragues, David Wu, Lucas Chen, Nick Vaccaro, Ren Kuo, Subrata Banik, YH Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78384?usp=email to look at the new patch set (#2). Change subject: mb/google/brya/var/dochi: update gpio settings ...................................................................... mb/google/brya/var/dochi: update gpio settings Configure GPIOs according to schematics revision 20231013. BUG=b:299284564, b:298328847, b:299570339 TEST=emerge-brya coreboot Change-Id: I1ccab46b9f622fb98920d316c31800f39dc8ff95 Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/dochi/gpio.c 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/78384/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78384?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ccab46b9f622fb98920d316c31800f39dc8ff95 Gerrit-Change-Number: 78384 Gerrit-PatchSet: 2 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/brya/var/dochi: update gpio settings
by Morris Hsu (Code Review) 16 Oct '23

16 Oct '23

Morris Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78384?usp=email ) Change subject: mb/google/brya/var/dochi: update gpio settings ...................................................................... mb/google/brya/var/dochi: update gpio settings Configure GPIOs according to schematics revision 20231013. TEST=emerge-brya coreboot Change-Id: I1ccab46b9f622fb98920d316c31800f39dc8ff95 Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/dochi/gpio.c 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/78384/1 diff --git a/src/mainboard/google/brya/variants/dochi/gpio.c b/src/mainboard/google/brya/variants/dochi/gpio.c index 8c6fb09..ad1b334 100644 --- a/src/mainboard/google/brya/variants/dochi/gpio.c +++ b/src/mainboard/google/brya/variants/dochi/gpio.c @@ -13,6 +13,8 @@ PAD_NC(GPP_A7, NONE), /* A8 : SRCCLKREQ7# ==> NC */ PAD_NC(GPP_A8, NONE), + /* A11 : PMC_I2C_SDA ==> NC */ + PAD_NC(GPP_A11, NONE), /* A12 : SATAXPCIE1 ==> NC */ PAD_NC(GPP_A12, NONE), /* A15 : USB_OC2# ==> NC */ @@ -22,9 +24,16 @@ /* A20 : DDSP_HPD2 ==> NC */ PAD_NC(GPP_A20, NONE), + /* B2 : VRALERT# ==> NC */ + PAD_NC_LOCK(GPP_B2, NONE, LOCK_CONFIG), /* B3 : PROC_GP2 ==> NC */ PAD_NC_LOCK(GPP_B3, NONE, LOCK_CONFIG), + /* C3 : SML0CLK ==> NC */ + PAD_NC_LOCK(GPP_C3, NONE, LOCK_CONFIG), + /* C4 : SML0DATA ==> NC */ + PAD_NC_LOCK(GPP_C4, NONE, LOCK_CONFIG), + /* D3 : ISH_GP3 ==> NC */ PAD_NC_LOCK(GPP_D3, NONE, LOCK_CONFIG), /* D5 : SRCCLKREQ0# ==> SSD_CLKREQ_ODL */ @@ -37,6 +46,12 @@ PAD_NC(GPP_D8, NONE), /* D9 : ISH_SPI_CS# ==> NC */ PAD_NC_LOCK(GPP_D9, NONE, LOCK_CONFIG), + /* D13 : ISH_UART0_RXD ==> NC */ + PAD_NC_LOCK(GPP_D13, NONE, LOCK_CONFIG), + /* D14 : ISH_UART0_TXD ==> NC */ + PAD_NC_LOCK(GPP_D14, NONE, LOCK_CONFIG), + /* D15 : ISH_UART0_RTS# ==> NC */ + PAD_NC_LOCK(GPP_D15, NONE, LOCK_CONFIG), /* D16 : ISH_UART0_CTS# ==> NC */ PAD_NC_LOCK(GPP_D16, NONE, LOCK_CONFIG), /* D17 : UART1_RXD ==> APU_PEN_DETECT_ODL */ @@ -50,6 +65,8 @@ PAD_NC(GPP_E3, NONE), /* E4 : SATA_DEVSLP0 ==> NC */ PAD_NC(GPP_E4, NONE), + /* E5 : SATA_DEVSLP1 ==> NC */ + PAD_NC(GPP_E5, NONE), /* E7 : PROC_GP1 ==> NC */ PAD_NC(GPP_E7, NONE), /* E10 : THC0_SPI1_CS# ==> NC */ @@ -63,6 +80,8 @@ /* F6 : CNV_PA_BLANKING ==> NC */ PAD_NC(GPP_F6, NONE), + /* F19 : SRCCLKREQ6# ==> NC */ + PAD_NC(GPP_F19, NONE), /* F20 : EXT_PWR_GATE# ==> NC */ PAD_NC(GPP_F20, NONE), /* F21 : EXT_PWR_GATE2# ==> NC */ @@ -80,8 +99,8 @@ PAD_NC_LOCK(GPP_H12, NONE, LOCK_CONFIG), /* H13 : I2C7_SCL ==> NC */ PAD_NC_LOCK(GPP_H13, NONE, LOCK_CONFIG), - /* H19 : SRCCLKREQ4# ==> EMMC_CLKREQ_ODL */ - PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1), + /* H19 : SRCCLKREQ4# ==> NC */ + PAD_NC(GPP_H19, NONE), /* H20 : IMGCLKOUT1 ==> NC */ PAD_NC(GPP_H20, NONE), /* H21 : IMGCLKOUT2 ==> NC */ -- To view, visit https://review.coreboot.org/c/coreboot/+/78384?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ccab46b9f622fb98920d316c31800f39dc8ff95 Gerrit-Change-Number: 78384 Gerrit-PatchSet: 1 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/google/kahlee: Rework I2S/ACP ACPI for new Windows driver
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: CoolStar, Jason Nien, Martin Roth, Martin Roth, Matt DeVillier, Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78406?usp=email ) Change subject: mb/google/kahlee: Rework I2S/ACP ACPI for new Windows driver ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78406/comment/14547ae5_c66582e1 : PS2, Line 9: Supports a brand new ACP driver for STONEY / Grunt chromebooks. I’d be great if you added some version information. https://review.coreboot.org/c/coreboot/+/78406/comment/2a56cc66_67409175 : PS2, Line 20: Hide the Linux devices so that they don't clutter Windows device manager. Make this a separate commit? -- To view, visit https://review.coreboot.org/c/coreboot/+/78406?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I51527a1bfae3e12ce5cf1da8a3465bbc9ddfa76e Gerrit-Change-Number: 78406 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 06:58:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload: Add dma_allocator_range
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Julius Werner, Yi Chou, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78407?usp=email ) Change subject: libpayload: Add dma_allocator_range ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78407/comment/9a68b43b_77ec06a7 : PS1, Line 7: dma_allocator_range Please add (), so it’s clear it’s a function. https://review.coreboot.org/c/coreboot/+/78407/comment/e3fe3f8a_a2e94ce4 : PS1, Line 9: We will need this function to zero out everything allocated by the : dma allocator. Please elaborate. For example, what is the problem? File payloads/libpayload/libc/malloc.c: https://review.coreboot.org/c/coreboot/+/78407/comment/6c1fc943_a86da9ee : PS1, Line 126: void dma_allocator_range(void **start_out, size_t *size_out) : { : if (dma_initialized()) { : *start_out = dma->start; : *size_out = dma->end - dma->start; : } else { : *start_out = NULL; : *size_out = 0; : } : } Please add a comment. What is `out` supposed to be? -- To view, visit https://review.coreboot.org/c/coreboot/+/78407?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f3058dfd861ed44f716623967201b8cabe8d166 Gerrit-Change-Number: 78407 Gerrit-PatchSet: 1 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 06:56:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Eric Lai, Kapil Porwal, Tarun, Tyler Wang, YH Lin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email ) Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78216/comment/18c3cfae_8907c855 : PS5, Line 9: FAN_SETTING_1 Please elaborate what setting 1 is. https://review.coreboot.org/c/coreboot/+/78216/comment/86951226_108c84b9 : PS5, Line 12: TEST=emerge-rex coreboot Do you have access to the board? -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 5 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 06:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/ibm/power9/*: add file structure for SOC
by Paul Menzel (Code Review) 16 Oct '23

16 Oct '23

Attention is currently required from: Felix Held, Igor Bagnucki, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67062?usp=email ) Change subject: soc/ibm/power9/*: add file structure for SOC ...................................................................... Patch Set 19: (2 comments) File src/soc/ibm/power9/Kconfig: https://review.coreboot.org/c/coreboot/+/67062/comment/9055ad1f_be0e09f5 : PS19, Line 4: This SoC is the minimal template working on POWER9 : Talos II platform. Does this fit in one line? File src/soc/ibm/power9/timer.c: https://review.coreboot.org/c/coreboot/+/67062/comment/8001b09f_66cf656d : PS19, Line 7: // no need to do anything here Please indent with a tab? Maybe also explain why in the comment? -- To view, visit https://review.coreboot.org/c/coreboot/+/67062?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie74b1e34f9aebe151d0fdb0e95c003510fd864c3 Gerrit-Change-Number: 67062 Gerrit-PatchSet: 19 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Igor Bagnucki <bagnucki02(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Igor Bagnucki <bagnucki02(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 06:52:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Subrata Banik (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Eric Lai, Kapil Porwal, Tarun, Tyler Wang, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: let me know if u want me to merge this CL -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 5 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 05:58:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede/var/boxy: Wait up for 3s for HPD ready signal
by Joey Peng (Code Review) 15 Oct '23

15 Oct '23

Joey Peng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78146?usp=email ) Change subject: mb/google/dedede/var/boxy: Wait up for 3s for HPD ready signal ...................................................................... Abandoned Will use another solution: https://review.coreboot.org/c/coreboot/+/78294. -- To view, visit https://review.coreboot.org/c/coreboot/+/78146?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I208fdf8234886b2ef43a4b972e6682892238e8e9 Gerrit-Change-Number: 78146 Gerrit-PatchSet: 9 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Add FAN field in fw_config
by Tyler Wang (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: David Wu, Eran Mitrani, Eric Lai, Kapil Porwal, Tarun, YH Lin. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email ) Change subject: mb/google/rex/var/karis: Add FAN field in fw_config ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/rex/variants/karis/overridetree.cb: https://review.coreboot.org/c/coreboot/+/78216/comment/618dadd6_7c9d811e : PS5, Line 244: probe FAN FAN_SETTING_1 > Are you sure? this will turn off the all table if no FAN... If for no fan, you need create new one. […] Yes, if it has "no FAN" config, we will create new one for it. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/78216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b Gerrit-Change-Number: 78216 Gerrit-PatchSet: 5 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 05:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload: Add dma_allocator_range
by Yi Chou (Code Review) 15 Oct '23

15 Oct '23

Yi Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78407?usp=email ) Change subject: libpayload: Add dma_allocator_range ...................................................................... libpayload: Add dma_allocator_range We will need this function to zero out everything allocated by the dma allocator. BUG=b:248610274 TEST=emerge-cherry libpayload BRANCH=none Signed-off-by: Yi Chou <yich(a)google.com> Change-Id: I8f3058dfd861ed44f716623967201b8cabe8d166 --- M payloads/libpayload/include/stdlib.h M payloads/libpayload/libc/malloc.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/78407/1 diff --git a/payloads/libpayload/include/stdlib.h b/payloads/libpayload/include/stdlib.h index e129cd1..cb9addf 100644 --- a/payloads/libpayload/include/stdlib.h +++ b/payloads/libpayload/include/stdlib.h @@ -137,6 +137,7 @@ void init_dma_memory(void *start, u32 size); int dma_initialized(void); int dma_coherent(const void *ptr); +void dma_allocator_range(void **start_out, size_t *size_out); static inline void *xmalloc_work(size_t size, const char *file, const char *func, int line) diff --git a/payloads/libpayload/libc/malloc.c b/payloads/libpayload/libc/malloc.c index 1fc2ef1..e8aa4aa 100644 --- a/payloads/libpayload/libc/malloc.c +++ b/payloads/libpayload/libc/malloc.c @@ -123,6 +123,17 @@ return !dma_initialized() || (dma->start <= ptr && dma->end > ptr); } +void dma_allocator_range(void **start_out, size_t *size_out) +{ + if (dma_initialized()) { + *start_out = dma->start; + *size_out = dma->end - dma->start; + } else { + *start_out = NULL; + *size_out = 0; + } +} + /* Find free block of size >= len */ static hdrtype_t volatile *find_free_block(int len, struct memory_type *type) { -- To view, visit https://review.coreboot.org/c/coreboot/+/78407?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f3058dfd861ed44f716623967201b8cabe8d166 Gerrit-Change-Number: 78407 Gerrit-PatchSet: 1 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023