coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: Documentation: add Nitrokey to distributions
by Markus Meissner (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: Michał Żygowski, Patrick Georgi, Paul Menzel. Hello Michał Żygowski, Patrick Georgi, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78299?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Documentation: add Nitrokey to distributions ...................................................................... Documentation: add Nitrokey to distributions Nitrokey offers various products, which have coreboot pre-installed. Change-Id: I3ef25e0e1cb97eda5fd457bdb650f3ee3f00210a Signed-off-by: Markus Meissner <coder(a)safemailbox.de> --- M Documentation/distributions.md 1 file changed, 26 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/78299/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78299?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ef25e0e1cb97eda5fd457bdb650f3ee3f00210a Gerrit-Change-Number: 78299 Gerrit-PatchSet: 4 Gerrit-Owner: Markus Meissner Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: Documentation: add Nitrokey to distributions
by Markus Meissner (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: Michał Żygowski, Patrick Georgi, Paul Menzel. Markus Meissner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78299?usp=email ) Change subject: Documentation: add Nitrokey to distributions ...................................................................... Patch Set 3: (1 comment) File Documentation/distributions.md: https://review.coreboot.org/c/coreboot/+/78299/comment/7a4c3eaf_e13fa687 : PS3, Line 23: offers a range of laptops, PCs, HSM, and networking devices with coreboot and : [Dasharo](https://dasharo.com/). > Apologies for my ignorance, I guess I haven't checked your device offer deep enough. […] no need for apologies ;) happily updating it to `HSMs`, new patchset incoming... -- To view, visit https://review.coreboot.org/c/coreboot/+/78299?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ef25e0e1cb97eda5fd457bdb650f3ee3f00210a Gerrit-Change-Number: 78299 Gerrit-PatchSet: 3 Gerrit-Owner: Markus Meissner Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 15 Oct 2023 19:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Markus Meissner Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/common/data_fabric_helper: add pre-processor guards for ACPI
by Fred Reitberger (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78341?usp=email ) Change subject: soc/amd/common/data_fabric_helper: add pre-processor guards for ACPI ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78341?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec6e05bbe9fad7d78002560b78169dc293294af6 Gerrit-Change-Number: 78341 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 19:10:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/common/data_fabric/extended_mmio: fix compile errors
by Fred Reitberger (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78340?usp=email ) Change subject: soc/amd/common/data_fabric/extended_mmio: fix compile errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78340?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5495ebf0f157fd0c456ce44acaf1ab222a188dd Gerrit-Change-Number: 78340 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 19:10:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: ppc64: Kconfig switch for bootblock in SEEPROM, zero HRMOR
by Sergii Dmytruk (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: Arthur Heymans, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Michał Żygowski, ron minnich. Hello Krystian Hebel, Maciej Pijanowski, Martin L Roth, Michał Żygowski, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67067?usp=email to look at the new patch set (#21). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: ppc64: Kconfig switch for bootblock in SEEPROM, zero HRMOR ...................................................................... ppc64: Kconfig switch for bootblock in SEEPROM, zero HRMOR On PPC64 each address is logically OR'ed with HRMOR (Hypervisor Real Mode Offset Register) before it is dispatched to the underlying memory, meaning that memory space overlaps at the least significant bit set in HRMOR. coreboot is entered with HRMOR = 4GB-128MB both on hardware (when started by hostboot bootloader) and in Qemu in hb-mode. This means that memory overlaps every 128MB in this particular case. HRMOR can be explicitly ignored when MSB of an address is set, but this would require using different memory model for linking. If we zero HRMOR in bootblock, linking can be done against real address. This greatly simplifies memory layout and allows to forget about HRMOR from that point on. Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Signed-off-by: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Change-Id: I0170463968c91b943c4b0dc15fe73fa616a164da --- M src/arch/ppc64/Makefile.inc M src/arch/ppc64/bootblock_crt0.S M src/mainboard/emulation/qemu-power8/memlayout.ld M src/mainboard/emulation/qemu-power9/memlayout.ld M src/mainboard/raptor-cs/talos-2/Kconfig A src/mainboard/raptor-cs/talos-2/board-bootblock-in-seeprom.fmd A src/mainboard/raptor-cs/talos-2/board.fmd M src/mainboard/raptor-cs/talos-2/memlayout.ld M src/soc/ibm/power9/Makefile.inc 9 files changed, 344 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/67067/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/67067?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0170463968c91b943c4b0dc15fe73fa616a164da Gerrit-Change-Number: 67067 Gerrit-PatchSet: 21 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: security/tpm/: turn tis_{init,open} into tis_probe
by Sergii Dmytruk (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Krystian Hebel, Michał Żygowski. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76954?usp=email ) Change subject: security/tpm/: turn tis_{init,open} into tis_probe ...................................................................... Patch Set 5: (1 comment) Patchset: PS1: > This is a copy of previously reverted CB:68991, see https://review.coreboot. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/76954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I52ad8d69d50d449f031c36b15bf70ef07986946c Gerrit-Change-Number: 76954 Gerrit-PatchSet: 5 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 15:55:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/zork/morphius: Drop touchscreen detection
by Matt DeVillier (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: Jason Nien, Martin Roth. Hello Jason Nien, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78404?usp=email to look at the new patch set (#2). Change subject: mb/google/zork/morphius: Drop touchscreen detection ...................................................................... mb/google/zork/morphius: Drop touchscreen detection Some morphius boards seem to have trouble with the runtime detection, and since it only has one touchscreen option, and no SKUs lack a touchscreen, just assume it is present in all cases. TEST=build/boot morphius w/4k screen, verify touchscreen detected in cbmem and functional in Linux and Windows. Change-Id: I13e07e14b5a18fa1dd3b18950cf46e9d7821eedc Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/78404/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78404?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13e07e14b5a18fa1dd3b18950cf46e9d7821eedc Gerrit-Change-Number: 78404 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/zork/morphius: Drop touchscreen detection
by Matt DeVillier (Code Review) 15 Oct '23

15 Oct '23

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78404?usp=email ) Change subject: mb/google/zork/morphius: Drop touchscreen detection ...................................................................... mb/google/zork/morphius: Drop touchscreen detection Some morphius boards seem to have trouble with the runtime detection, and since it only has one touchscreen options, and no SKUs lack a touchscreen, just assume it is present in all cases. TEST=build/boot morphius w/4k screen, verify touchscreen detected in cbmem and functional in Linux and Windows. Change-Id: I13e07e14b5a18fa1dd3b18950cf46e9d7821eedc Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/78404/1 diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb index 9c07a40..c01d0f9 100644 --- a/src/mainboard/google/zork/variants/morphius/overridetree.cb +++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb @@ -120,7 +120,7 @@ register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen"" register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_12)" - register "generic.detect" = "1" + #register "generic.detect" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_90)" register "generic.enable_delay_ms" = "10" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" -- To view, visit https://review.coreboot.org/c/coreboot/+/78404?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13e07e14b5a18fa1dd3b18950cf46e9d7821eedc Gerrit-Change-Number: 78404 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: drivers/generic/bayhub: Add ACPI for BH720
by Matt DeVillier (Code Review) 15 Oct '23

15 Oct '23

Attention is currently required from: CoolStar. Hello CoolStar, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78403?usp=email to look at the new patch set (#3). Change subject: drivers/generic/bayhub: Add ACPI for BH720 ...................................................................... drivers/generic/bayhub: Add ACPI for BH720 The Bayhub BH720 eMMC bridge is a fixed internal device, and needs to me marked as non-removable in order for Windows to properly recognize/ utilize the device. Add the necessary ACPI to be generated at runtime. TEST=build/boot/install Win11 on google/kahlee (liara) Change-Id: I0815abf1d2dc5cfe785dc04670ab91f2a6a1af23 Signed-off-by: CoolStar <coolstarorganization(a)gmail.com> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/drivers/generic/bayhub/bh720.c 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/78403/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/78403?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0815abf1d2dc5cfe785dc04670ab91f2a6a1af23 Gerrit-Change-Number: 78403 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: drivers/generic/bayhub: Add ACPI for BH720
by Matt DeVillier (Code Review) 15 Oct '23

15 Oct '23

Hello CoolStar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78403?usp=email to look at the new patch set (#2). Change subject: drivers/generic/bayhub: Add ACPI for BH720 ...................................................................... drivers/generic/bayhub: Add ACPI for BH720 The Bayhub BH720 eMMC bridge is a fixed internal device, and needs to me marked as non-removable in order for Windows to properly recognize/ utilize the device. Add the necessary ACPI to be generated at runtime. TEST=build/boot/install Win11 on google/kahlee (liara) Change-Id: I0815abf1d2dc5cfe785dc04670ab91f2a6a1af23 Signed-off-by: CoolStar <coolstarorganization(a)gmail.com> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/drivers/generic/bayhub/bh720.c 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/78403/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78403?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0815abf1d2dc5cfe785dc04670ab91f2a6a1af23 Gerrit-Change-Number: 78403 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: CoolStar <coolstarorganization(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023