coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: ec/dell/mec5035: Add command to enable/disable radios
by Martin L Roth (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Felix Singer, Iru Cai, Nicholas Chin. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77534?usp=email ) Change subject: ec/dell/mec5035: Add command to enable/disable radios ...................................................................... Patch Set 6: (3 comments) File src/ec/dell/mec5035/mec5035.h: https://review.coreboot.org/c/coreboot/+/77534/comment/9033f4d5_c7b6f708 : PS6, Line 19: EN So is this an Enable, or a toggle? The commit message suggests it might be a toggle. File src/ec/dell/mec5035/mec5035.c: https://review.coreboot.org/c/coreboot/+/77534/comment/2083ab95_98b1c6bf : PS6, Line 91: dev The compiler will probably do the right thing here, but it wouldn't hurt to cast this to a u8 https://review.coreboot.org/c/coreboot/+/77534/comment/d7780c9f_3801ad3d : PS6, Line 92: 3 I know the other commands in this file just use bare values, but could this maybe be `sizeof(buf)`? Optionally, you could so something like #define RADIO_EN_CMD_SIZE 3 and use it in both places. -- To view, visit https://review.coreboot.org/c/coreboot/+/77534?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I173dc197d63cda232dd7ede0cb798ab0a364482b Gerrit-Change-Number: 77534 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 20:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/var/rex: Configure cpu power limits by battery status
by Subrata Banik (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Brandon Breitenstein, Caveh Jalali, Eran Mitrani, Hannah Williams, Jamie Ryu, Kapil Porwal, Sukumar Ghorai, Tarun, Tim Van Patten. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78322?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/rex/var/rex: Configure cpu power limits by battery status ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c: https://review.coreboot.org/c/coreboot/+/78322/comment/877c52a5_6b4cd5c6 : PS7, Line 47: google_chromeec_is_battery_level_enough https://review.coreboot.org/c/coreboot/+/78321/comment/bbdd9851_0307ceeb/ -- To view, visit https://review.coreboot.org/c/coreboot/+/78322?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I12fd40abda76c8e7522b06a5aee72665f32ddec8 Gerrit-Change-Number: 78322 Gerrit-PatchSet: 7 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 18:42:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add is_battery_level_enough to check battery status
by Subrata Banik (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Boris Mittelberg, Brandon Breitenstein, Caveh Jalali, Hannah Williams, Jamie Ryu, Kapil Porwal, Tim Van Patten. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78321?usp=email ) Change subject: ec/google/chromeec: Add is_battery_level_enough to check battery status ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File src/ec/google/chromeec/ec.h: https://review.coreboot.org/c/coreboot/+/78321/comment/bbdd9851_0307ceeb : PS6, Line 425: google_chromeec_is_battery_level_enough use `google_chromeec_is_battery_present_and_above_critical_threshold()` true: if the battery is present and battery voltage is above critical threshold. false: any of the above conditions is not true -- To view, visit https://review.coreboot.org/c/coreboot/+/78321?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib38be55bc42559bab4f12d5e8580ddc3e1a6acc1 Gerrit-Change-Number: 78321 Gerrit-PatchSet: 6 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 18:42:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex: Turn off CNVi 3.3v power at romstage
by Subrata Banik (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Bora Guvendik, Cliff Huang, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Tarun, Wonkyu Kim. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78122?usp=email ) Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hi Subrata, > > Good point. For karis, it is the same pin, I can make the change. However, > from ovis gpio.c, I cannot find the GPIO for WLAN 3.3v. Can you help check from the schematics? Thanks. I will let Eran (for Karis) and Jakub (Ovis) answer your question. Maybe a good starting point would be a platform mapping doc Karis: https://docs.google.com/spreadsheets/d/14hgnV8BNLwUqimPgofZN0H4zMK6ruE8s1b4… Ovis: https://docs.google.com/spreadsheets/d/1OyAGBNBZV7bBLirKg2ktcfhltAtS88wd3hU… -- To view, visit https://review.coreboot.org/c/coreboot/+/78122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0 Gerrit-Change-Number: 78122 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 18:13:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex: Turn off CNVi 3.3v power at romstage
by Cliff Huang (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78122?usp=email ) Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > can you please check the karis and ovis as well? Hi Subrata, Good point. For karis, it is the same pin, I can make the change. However, from ovis gpio.c, I cannot find the GPIO for WLAN 3.3v. Can you help check from the schematics? Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/78122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0 Gerrit-Change-Number: 78122 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 18:04:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
by Bill XIE (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Kyösti Mälkki, Nico Huber, Paul Menzel. Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78288?usp=email ) Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78288/comment/8ae7dfc2_497b4425 : PS5, Line 20: cmos_need_reset will be negated when acpi_is_wakeup_s3() returns true. > I didn't block it, I gave it +2 :) I don't have submit rights though. You did not block it :), but those comments marked as "unresolved" did. As they are mostly related to commit e12b313844da ("drivers/pc80/rtc/option.c: Allow CMOS defaults to extend to bank 1"), not the current one, I asked whether we can unblock the current commit by marking them as "resolved". -- To view, visit https://review.coreboot.org/c/coreboot/+/78288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I533e83f3b95f327b0e24f4d750f8812325b7770b Gerrit-Change-Number: 78288 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 14:29:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex: toggling NVMe PWR pin to reset SSD
by Paul Menzel (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Eran Mitrani, Ivy Jian, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71221?usp=email ) Change subject: mb/google/rex: toggling NVMe PWR pin to reset SSD ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71221/comment/c73e6779_8dbb217d : PS3, Line 7: mb/google/rex: toggling NVMe PWR pin to reset SSD Please use imperative mood: Toggle … https://review.coreboot.org/c/coreboot/+/71221/comment/e01c73f9_2399b489 : PS3, Line 11: as early stage as in early stage https://review.coreboot.org/c/coreboot/+/71221/comment/721570fb_22a1c339 : PS3, Line 15: TEST= Try reboot from OS console and check boot to OS again What variant and what NVMe disk? -- To view, visit https://review.coreboot.org/c/coreboot/+/71221?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f34e3f49e7fc388198ff85c8e119cb3f242a60e Gerrit-Change-Number: 71221 Gerrit-PatchSet: 3 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 13:07:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add is_battery_level_enough to check battery status
by Paul Menzel (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Boris Mittelberg, Brandon Breitenstein, Caveh Jalali, Hannah Williams, Jamie Ryu, Kapil Porwal, Tim Van Patten. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78321?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: ec/google/chromeec: Add is_battery_level_enough to check battery status ...................................................................... Patch Set 6: (1 comment) File src/ec/google/chromeec/ec.h: https://review.coreboot.org/c/coreboot/+/78321/comment/fe73f455_84ed7d2a : PS6, Line 425: int google_chromeec_is_battery_level_enough(void); Why not bool? -- To view, visit https://review.coreboot.org/c/coreboot/+/78321?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib38be55bc42559bab4f12d5e8580ddc3e1a6acc1 Gerrit-Change-Number: 78321 Gerrit-PatchSet: 6 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 11:04:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: x86: Add ramstage CBFS cache support
by Paul Menzel (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Maximilian Brune, Raul Rangel. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77885?usp=email ) Change subject: x86: Add ramstage CBFS cache support ...................................................................... Patch Set 28: (9 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/77885/comment/c8d03e2c_bd8bb44d : PS28, Line 7: cache cache scratchpad https://review.coreboot.org/c/coreboot/+/77885/comment/79a6134d_ebf84b07 : PS28, Line 8: A sentence about the motivation would be great. https://review.coreboot.org/c/coreboot/+/77885/comment/14f11ca1_493f3b7e : PS28, Line 17: Operating System I’d spell it lowercase. (Please fell free to ignore.) https://review.coreboot.org/c/coreboot/+/77885/comment/257f1490_e8b58e5f : PS28, Line 29: offer offer*s* https://review.coreboot.org/c/coreboot/+/77885/comment/57d16c53_7d220b7f : PS28, Line 35: defines define Patchset: PS28: Nice work. File src/arch/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/77885/comment/f3027476_e4afe240 : PS28, Line 167: Allocate the CBFS cache buffer as a C static buffer (in the : .bss section). The existing descriptions are very terse, https://review.coreboot.org/c/coreboot/+/77885/comment/5cbbc481_de64031b : PS28, Line 167: Allocate the CBFS cache buffer as a C static buffer (in the : .bss section). I know, the existing descriptions are very terse, but it’d be great if you could extend this little. https://review.coreboot.org/c/coreboot/+/77885/comment/eb26bc24_04355d3f : PS28, Line 167: Allocate the CBFS cache buffer as a C static buffer (in the : .bss section). I know, the existing descriptions are very terse, but it’d be great if you could extend this little. -- To view, visit https://review.coreboot.org/c/coreboot/+/77885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7fbb1b51cda9f84842992e365b16c5ced1010b89 Gerrit-Change-Number: 77885 Gerrit-PatchSet: 28 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sat, 14 Oct 2023 11:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: device/device.h: Fix outdated comment
by Felix Held (Code Review) 14 Oct '23

14 Oct '23

Attention is currently required from: Arthur Heymans. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78329?usp=email ) Change subject: device/device.h: Fix outdated comment ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78329?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02192c9a11c35d9625837a8a9f3ba798ff0ae611 Gerrit-Change-Number: 78329 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 14 Oct 2023 10:45:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023