Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76532?usp=email )
Change subject: soc/amd/genoa: Report device fabric resources to SSDT
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/genoa/device_fabric.c:
https://review.coreboot.org/c/coreboot/+/76532/comment/354887f1_c1e198eb :
PS4, Line 322: const struct {
: uint8_t fabric_id;
: const char *acpi_name;
: } acpi_names[] = {
: { 0x22, "S0B0"},
: { 0x23, "S0B1"},
: { 0x21, "S0B2"},
: { 0x20, "S0B3"},
: };
:
: for (int i = 0; ARRAY_SIZE(acpi_names); i++)
: if (acpi_names[i].fabric_id == dev->path.domain.domain)
: return acpi_names[i].acpi_name;
this code needs to be reworked, since we're using the domain numbers 0..3 and not the fabric IDs as domain numbers any more. so just have a const array with the 4 names, check if dev->path.domain.domain is < ARAY_SIZE(acpi_names) and in that case return acpi_names[dev->path.domain.domain], otherwise NULL
--
To view, visit https://review.coreboot.org/c/coreboot/+/76532?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I813c58c2bd30ecae56f47af60dde929238ac8bfb
Gerrit-Change-Number: 76532
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 13 Oct 2023 19:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Hello Fred Reitberger, Jason Glenesk, Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78341?usp=email
to look at the new patch set (#2).
Change subject: soc/amd/common/data_fabric_helper: add pre-processor guards for ACPI
......................................................................
soc/amd/common/data_fabric_helper: add pre-processor guards for ACPI
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Iec6e05bbe9fad7d78002560b78169dc293294af6
---
M src/soc/amd/common/block/data_fabric/data_fabric_helper.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/78341/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78341?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iec6e05bbe9fad7d78002560b78169dc293294af6
Gerrit-Change-Number: 78341
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76522?usp=email )
Change subject: vendorcode/amd/genoa: Parse APOB for DRAM layout
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/genoa/device_fabric.c:
PS4:
for this to work, in the genoa/domain.c file, a new genoa_domain_read_resources function needs to be added and used as read_resources function that first calls the amd_pci_domain_read_resources function and then adds the new code
// We only want to add the DRAM memory map once
if (dev->link_list->secondary == 0) {
idx = add_opensil_memmap(dev, idx);
}
Since idx isn't and can't be exposed outside of amd_pci_domain_read_resources without causing some other problems, i'd say that using a sufficiently large index argument (i'd call 0x10000 sufficiently large in this context) for add_opensil_memmap is likely the way to go
--
To view, visit https://review.coreboot.org/c/coreboot/+/76522?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5605499e39931e1a1592318310112666f8a0f144
Gerrit-Change-Number: 76522
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 13 Oct 2023 19:48:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76532?usp=email )
Change subject: soc/amd/genoa: Report device fabric resources to SSDT
......................................................................
Patch Set 4:
(2 comments)
File src/soc/amd/genoa/device_fabric.c:
PS4:
the new file for this is genoa/domain.c
https://review.coreboot.org/c/coreboot/+/76532/comment/357ba328_effd2f4e :
PS4, Line 421: df_fill_ssdt
amd_pci_domain_fill_ssdt is the new common function that should be used instead of the reimplementation above
--
To view, visit https://review.coreboot.org/c/coreboot/+/76532?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I813c58c2bd30ecae56f47af60dde929238ac8bfb
Gerrit-Change-Number: 76532
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 13 Oct 2023 19:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76521?usp=email )
Change subject: soc/amd/genoa: Set up PCI resource
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
apart from selecting the PSP 2 Kconfig, CB:78342 will replace this patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/76521?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f00b61624d7647fef4799517cb878ccb8e2e0af
Gerrit-Change-Number: 76521
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 13 Oct 2023 19:38:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78342?usp=email )
Change subject: soc/amd/genoa: add PCI domain resource reporting
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
this patch will replace CB:76521
--
To view, visit https://review.coreboot.org/c/coreboot/+/78342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifcd655ea6d5565668ffee36d0d022b2b711c0b00
Gerrit-Change-Number: 78342
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 13 Oct 2023 19:37:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Hello Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78342?usp=email
to look at the new patch set (#2).
Change subject: soc/amd/genoa: add PCI domain resource reporting
......................................................................
soc/amd/genoa: add PCI domain resource reporting
TEST=None
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: Ifcd655ea6d5565668ffee36d0d022b2b711c0b00
---
M src/soc/amd/genoa/Kconfig
M src/soc/amd/genoa/Makefile.inc
M src/soc/amd/genoa/chipset.cb
A src/soc/amd/genoa/domain.c
4 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/78342/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifcd655ea6d5565668ffee36d0d022b2b711c0b00
Gerrit-Change-Number: 78342
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset