coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Disable external fivr
by Kangheui Won (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Chen Wisley, Paul Menzel, Reka Norman, Wisley Chen, Eric Lai, Shou-Chieh Hsu. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71560 ) Change subject: mb/google/nissa/var/yaviks: Disable external fivr ...................................................................... Patch Set 8: Code-Review+2 (1 comment) File src/mainboard/google/brya/variants/yaviks/overridetree.cb: https://review.coreboot.org/c/coreboot/+/71560/comment/ad5c5b2f_e610b552 PS8, Line 26: .configure_ext_fivr = 1, > In the cb*66863's comment, mentioned that "Follow Intel suggest, and other project of doesn't have V […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/71560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id85570046c5b8e9d90a112793c1ec8604e6bf533 Gerrit-Change-Number: 71560 Gerrit-PatchSet: 8 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 01:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org> Comment-In-Reply-To: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Disable external fivr
by Wisley Chen (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Chen Wisley, Paul Menzel, Reka Norman, Eric Lai, Shou-Chieh Hsu. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71560 ) Change subject: mb/google/nissa/var/yaviks: Disable external fivr ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/brya/variants/yaviks/overridetree.cb: https://review.coreboot.org/c/coreboot/+/71560/comment/a526e5e0_2ff92fd9 PS8, Line 26: .configure_ext_fivr = 1, > Should we also set this to 0? In the cb*66863's comment, mentioned that "Follow Intel suggest, and other project of doesn't have V1p05 and Vnn also keep this, ex: brya0" . -- To view, visit https://review.coreboot.org/c/coreboot/+/71560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id85570046c5b8e9d90a112793c1ec8604e6bf533 Gerrit-Change-Number: 71560 Gerrit-PatchSet: 8 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 01:36:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/pc80/vga: Add API to write multi-line video message
by Jérémy Compostella (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71265 ) Change subject: drivers/pc80/vga: Add API to write multi-line video message ...................................................................... Patch Set 8: (2 comments) File src/drivers/pc80/vga/vga.c: https://review.coreboot.org/c/coreboot/+/71265/comment/e3786936_bc5ff384 PS8, Line 288: char str[VGA_COLUMNS * VGA_LINES] = {0}; : memcpy(str, string, strnlen(string, sizeof(str) - 1)); that seems overkill to allocate 2K of memory on the stack and have to go over the string twice compared to a simple 80 bytes buffer and and loop over a string. https://review.coreboot.org/c/coreboot/+/71265/comment/73cea6af_b4e18a5c PS8, Line 304: vga_write_at_offset(line++, 0, token); What happen when the number of lines exceed VGA_LINES ? I know that the other functions do not perform any check but considering that this function is a little bit more complex and receive a potentially long string, I believe a check would be worth it. -- To view, visit https://review.coreboot.org/c/coreboot/+/71265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib837e4deeba9b84038a91c93a68f03cee3474f9b Gerrit-Change-Number: 71265 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 01:34:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Disable external fivr
by Kangheui Won (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Chen Wisley, Paul Menzel, Reka Norman, Eric Lai, Shou-Chieh Hsu. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71560 ) Change subject: mb/google/nissa/var/yaviks: Disable external fivr ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/brya/variants/yaviks/overridetree.cb: https://review.coreboot.org/c/coreboot/+/71560/comment/5d689ee0_8c54117c PS8, Line 26: .configure_ext_fivr = 1, Should we also set this to 0? -- To view, visit https://review.coreboot.org/c/coreboot/+/71560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id85570046c5b8e9d90a112793c1ec8604e6bf533 Gerrit-Change-Number: 71560 Gerrit-PatchSet: 8 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 01:30:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gaelin: Use RPL FSP headers
by Nick Vaccaro (Code Review) 04 Jan '23

04 Jan '23

Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70746 ) Change subject: mb/google/brya/var/gaelin: Use RPL FSP headers ...................................................................... mb/google/brya/var/gaelin: Use RPL FSP headers Select SOC_INTEL_RAPTORLAKE to force coreboot to use the RPL FSP headers for FSP. Since we use RPL FSP and it will support ADL as well, we rename "Gaelin4ADL" to "Gaelin". BUG=b:258603624 BRANCH=firmware-brya-14505.B TEST=emerge-brask coreboot Cq-Depend: chrome-internal:5227091, chromium:4113361 Change-Id: Ie7349f3670aeec166228e7df55300cd30d0ca16c Signed-off-by: Mike Shih <mikeshih(a)msi.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70746 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Derek Huang <derekhuang(a)google.com> Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 31 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Mike Shih: Looks good to me, but someone else must approve Derek Huang: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 1fb78c0..bc754be 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -152,7 +152,7 @@ default 0x1 if BOARD_GOOGLE_LISBON default 0x1 if BOARD_GOOGLE_GLADIOS default 0x1 if BOARD_GOOGLE_MARASOV - default 0x1 if BOARD_GOOGLE_GAELIN4ADL + default 0x1 if BOARD_GOOGLE_GAELIN config DRIVER_TPM_I2C_ADDR hex @@ -216,7 +216,7 @@ default "Joxer" if BOARD_GOOGLE_JOXER default "Pujjo" if BOARD_GOOGLE_PUJJO default "Xivu" if BOARD_GOOGLE_XIVU - default "Gaelin4ADL" if BOARD_GOOGLE_GAELIN4ADL + default "Gaelin" if BOARD_GOOGLE_GAELIN default "Yaviks" if BOARD_GOOGLE_YAVIKS default "Lisbon" if BOARD_GOOGLE_LISBON default "Zydron" if BOARD_GOOGLE_ZYDRON @@ -257,7 +257,7 @@ default "joxer" if BOARD_GOOGLE_JOXER default "pujjo" if BOARD_GOOGLE_PUJJO default "xivu" if BOARD_GOOGLE_XIVU - default "gaelin" if BOARD_GOOGLE_GAELIN4ADL + default "gaelin" if BOARD_GOOGLE_GAELIN default "yaviks" if BOARD_GOOGLE_YAVIKS default "lisbon" if BOARD_GOOGLE_LISBON default "zydron" if BOARD_GOOGLE_ZYDRON diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 8e38735..7268501 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -275,9 +275,10 @@ select DRIVERS_GENESYSLOGIC_GL9750 select DRIVERS_INTEL_MIPI_CAMERA -config BOARD_GOOGLE_GAELIN4ADL - bool "-> Gaelin4ADL" +config BOARD_GOOGLE_GAELIN + bool "-> Gaelin" select BOARD_GOOGLE_BASEBOARD_BRASK + select SOC_INTEL_RAPTORLAKE config BOARD_GOOGLE_YAVIKS bool "-> Yaviks" -- To view, visit https://review.coreboot.org/c/coreboot/+/70746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7349f3670aeec166228e7df55300cd30d0ca16c Gerrit-Change-Number: 70746 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Shih <mikeshih(a)msi.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Mike Shih <mikeshih(a)msi.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bruce Chiang <brucechiang(a)msi.corp-partner.google.com> Gerrit-CC: Eason Chang <easonchang(a)msi.corp-partner.google.com> Gerrit-CC: Tony Tung <tonytung(a)msi.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gaelin: Use RPL FSP headers
by Nick Vaccaro (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Mike Shih, Zhuohao Lee. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70746 ) Change subject: mb/google/brya/var/gaelin: Use RPL FSP headers ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7349f3670aeec166228e7df55300cd30d0ca16c Gerrit-Change-Number: 70746 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Shih <mikeshih(a)msi.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Mike Shih <mikeshih(a)msi.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bruce Chiang <brucechiang(a)msi.corp-partner.google.com> Gerrit-CC: Eason Chang <easonchang(a)msi.corp-partner.google.com> Gerrit-CC: Tony Tung <tonytung(a)msi.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Mike Shih <mikeshih(a)msi.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 00:48:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/google/brya: remove northbridge.asl (replaced with acpi_gen)
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Eran Mitrani has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/65771 ) Change subject: mainboard/google/brya: remove northbridge.asl (replaced with acpi_gen) ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/65771 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I850616259578e942fa20ebdf309650b683b75853 Gerrit-Change-Number: 65771 Gerrit-PatchSet: 23 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[L] Change in coreboot[master]: soc/intel/alderlake: converge resource allocation and acpigen
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Eran Mitrani has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/65774 ) Change subject: soc/intel/alderlake: converge resource allocation and acpigen ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/65774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3fceaaa81b8ca745a02cba21472c7f2f48f0eb2 Gerrit-Change-Number: 65774 Gerrit-PatchSet: 19 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: soc/intel/common: add a hook for system_agent to fill SSDT
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Eran Mitrani has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/65769 ) Change subject: soc/intel/common: add a hook for system_agent to fill SSDT ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/65769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cac74928353ad949ad61d8e7a8095d04778c51c Gerrit-Change-Number: 65769 Gerrit-PatchSet: 11 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: soc/intel/common: Add functions for adding and reporting resources
by Eran Mitrani (Code Review) 04 Jan '23

04 Jan '23

Eran Mitrani has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/65773 ) Change subject: soc/intel/common: Add functions for adding and reporting resources ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/65773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I989b15910a5df1e2d93c6978c77825b900b2fe3c Gerrit-Change-Number: 65773 Gerrit-PatchSet: 19 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023