coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: soc/intel/common: Use CPUID_STRUCT_EXTENDED_FEATURE_FLAGS macro
by Sridhar Siricilla (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Martin Roth, Martin L Roth, Subrata Banik, Pratikkumar V Prajapati. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71646 ) Change subject: soc/intel/common: Use CPUID_STRUCT_EXTENDED_FEATURE_FLAGS macro ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If680ffff64e2e1dabded8c03c4042d349a11b635 Gerrit-Change-Number: 71646 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 03:48:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Add API to check Key Locker support
by Sridhar Siricilla (Code Review) 04 Jan '23

04 Jan '23

Sridhar Siricilla has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71117 ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/common: Add API to check Key Locker support ...................................................................... soc/intel/common: Add API to check Key Locker support Add is_keylocker_supported() API in common cpulib. This function checks if the CPU supports Key Locker feature. Returns true if Key Locker feature is supported otherwise false. Change-Id: Ide9e59a4f11a63df48838eab02c2c584cced12e1 Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71117 Reviewed-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/include/intelblocks/cpulib.h M src/soc/intel/common/block/include/intelblocks/msr.h 3 files changed, 38 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Sridhar Siricilla: Looks good to me, approved diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c index 0e78344..534feb1 100644 --- a/src/soc/intel/common/block/cpu/cpulib.c +++ b/src/soc/intel/common/block/cpu/cpulib.c @@ -533,3 +533,13 @@ msr = rdmsr(MTRR_CAP_MSR); /* Bit 12 is PRMRR enablement */ return ((cpuid_regs.ebx & SGX_SUPPORTED) && (msr.lo & MTRR_CAP_PRMRR)); } + +bool is_keylocker_supported(void) +{ + struct cpuid_result cpuid_regs; + msr_t msr; + + cpuid_regs = cpuid_ext(0x7, 0x0); /* ECX[23] is feature capability */ + msr = rdmsr(MTRR_CAP_MSR); /* Bit 12 is PRMRR enablement */ + return ((cpuid_regs.ecx & KEYLOCKER_SUPPORTED) && (msr.lo & MTRR_CAP_PRMRR)); +} diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h index 6c3aa56..c72e1ea 100644 --- a/src/soc/intel/common/block/include/intelblocks/cpulib.h +++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h @@ -217,4 +217,9 @@ */ bool is_sgx_supported(void); +/* + * This function checks if the CPU supports Key Locker feature. + * Returns true if Key Locker feature is supported otherwise false. + */ +bool is_keylocker_supported(void); #endif /* SOC_INTEL_COMMON_BLOCK_CPULIB_H */ diff --git a/src/soc/intel/common/block/include/intelblocks/msr.h b/src/soc/intel/common/block/include/intelblocks/msr.h index 47b9e4a..d4d8732 100644 --- a/src/soc/intel/common/block/include/intelblocks/msr.h +++ b/src/soc/intel/common/block/include/intelblocks/msr.h @@ -107,7 +107,10 @@ #define PRMRR_SUPPORTED (1<<12) #define SMRR_LOCK_SUPPORTED (1<<14) -#define SGX_SUPPORTED (1<<2) -#define TME_SUPPORTED (1<<13) +#define SGX_SUPPORTED (1<<2) +#define TME_SUPPORTED (1<<13) + +#define KEYLOCKER_SUPPORTED (1<<23) +#define KEYLOCKER_AESKL (1) #endif /* SOC_INTEL_COMMON_MSR_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/71117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide9e59a4f11a63df48838eab02c2c584cced12e1 Gerrit-Change-Number: 71117 Gerrit-PatchSet: 10 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: .gitmodules: Update goswid branch to v0.1
by Maximilian Brune (Code Review) 04 Jan '23

04 Jan '23

Maximilian Brune has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/71617 ) Change subject: .gitmodules: Update goswid branch to v0.1 ...................................................................... .gitmodules: Update goswid branch to v0.1 It is not really an update, since the same commit hash is targeted, but I am currently working on the goswid tool and don't want to accidentlly kill other peoples builds. Therefore I created a v0.1 tag to tie coreboot to a specific known working commit of goswid. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I9d14f7653465c6b9e72dd3661e991d13b76c24c4 --- M .gitmodules 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/71617/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d14f7653465c6b9e72dd3661e991d13b76c24c4 Gerrit-Change-Number: 71617 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: .gitmodules: Update goswid branch to v0.1
by build bot (Jenkins) (Code Review) 04 Jan '23

04 Jan '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71617 ) Change subject: .gitmodules: Update goswid branch to v0.1 ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167586): https://review.coreboot.org/c/coreboot/+/71617/comment/b2426d01_3bf16377 PS1, Line 9: It is not really an update, since the same commit hash is targeted, but 'accidently' may be misspelled - perhaps 'accidentally'? -- To view, visit https://review.coreboot.org/c/coreboot/+/71617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d14f7653465c6b9e72dd3661e991d13b76c24c4 Gerrit-Change-Number: 71617 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Jan 2023 03:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: .gitmodules: Update goswid branch to v0.1
by Maximilian Brune (Code Review) 04 Jan '23

04 Jan '23

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71617 ) Change subject: .gitmodules: Update goswid branch to v0.1 ...................................................................... .gitmodules: Update goswid branch to v0.1 It is not really an update, since the same commit hash is targeted, but I am currently working on the goswid tool and don't want to accidently kill other peoples builds. Therefore I created a v0.1 tag to tie coreboot to a specific known working commit of goswid. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I9d14f7653465c6b9e72dd3661e991d13b76c24c4 --- M .gitmodules 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/71617/1 diff --git a/.gitmodules b/.gitmodules index 6f62952..e7238e5 100644 --- a/.gitmodules +++ b/.gitmodules @@ -64,4 +64,4 @@ [submodule "util/goswid"] path = util/goswid url = ../goswid - branch = trunk + branch = v0.1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d14f7653465c6b9e72dd3661e991d13b76c24c4 Gerrit-Change-Number: 71617 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: drivers/pc80/vga: Add API to write multi-line video message
by Jérémy Compostella (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71265 ) Change subject: drivers/pc80/vga: Add API to write multi-line video message ...................................................................... Patch Set 8: (1 comment) File src/drivers/pc80/vga/vga.c: https://review.coreboot.org/c/coreboot/+/71265/comment/140ab0e5_d78079cd PS8, Line 268: for (i = 0; i < (VGA_COLUMNS - offset); i++) { What about potential exiting characters in the margin ? -- To view, visit https://review.coreboot.org/c/coreboot/+/71265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib837e4deeba9b84038a91c93a68f03cee3474f9b Gerrit-Change-Number: 71265 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 02:58:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/googmb/google/skyrim/var/winterhold: enable dxio_tx_vboost_enable ...
by build bot (Jenkins) (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Jason Nien, Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71647 ) Change subject: mb/googmb/google/skyrim/var/winterhold: enable dxio_tx_vboost_enable for PCIe optimization ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167583): https://review.coreboot.org/c/coreboot/+/71647/comment/a7a3f6b9_7d176b0c PS2, Line 6: Possible long commit subject (prefer a maximum 65 characters) -- To view, visit https://review.coreboot.org/c/coreboot/+/71647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6aad3d9118180d2ffdfba38abc80b175b6f103bd Gerrit-Change-Number: 71647 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 02:37:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Use CPUID_STRUCT_EXTENDED_FEATURE_FLAGS macro
by Pratikkumar V Prajapati (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Martin Roth, Martin L Roth, Subrata Banik, Sridhar Siricilla. Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71646 ) Change subject: soc/intel/common: Use CPUID_STRUCT_EXTENDED_FEATURE_FLAGS macro ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: i think creating another inline wrapper for cpuid_ext() for getting CPU Ext feature capabilities would be overkill. So i just used the macro. If community folks want a dedicated inline wrapper i can create something like this.. inline struct cpuid_result get_cpu_ext_cap( const uint32_t ecx)){ return cpuid_ext(CPUID_STRUCT_EXTENDED_FEATURE_FLAGS, ecx); } let me know! -- To view, visit https://review.coreboot.org/c/coreboot/+/71646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If680ffff64e2e1dabded8c03c4042d349a11b635 Gerrit-Change-Number: 71646 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 02:37:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/googmb/google/skyrim/var/winterhold: enable dxio_tx_vboost_enable ...
by Chris Wang (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Jason Nien, Martin Roth. Hello Jason Nien, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71647 to look at the new patch set (#2). Change subject: mb/googmb/google/skyrim/var/winterhold: enable dxio_tx_vboost_enable for PCIe optimization ...................................................................... mb/googmb/google/skyrim/var/winterhold: enable dxio_tx_vboost_enable for PCIe optimization Turn on the dxio_tx_vboost_enable for winterhold/whiterun in coreboot. It needs to confirm the PCIe Signal Integrity after enabled. BUG=b:259622787 BRANCH=none TEST=confirm the setting has been set correspondingly with checking the FSP log. Signed-off-by: Chris.Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: I6aad3d9118180d2ffdfba38abc80b175b6f103bd --- M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/71647/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6aad3d9118180d2ffdfba38abc80b175b6f103bd Gerrit-Change-Number: 71647 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/googmb/google/skyrim/var/winterhold: enable dxio_tx_vboost_enable ...
by build bot (Jenkins) (Code Review) 04 Jan '23

04 Jan '23

Attention is currently required from: Jason Nien, Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71647 ) Change subject: mb/googmb/google/skyrim/var/winterhold: enable dxio_tx_vboost_enable for PCIe optimization ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167581): https://review.coreboot.org/c/coreboot/+/71647/comment/354c04ee_bb884ef5 PS1, Line 6: Possible long commit subject (prefer a maximum 65 characters) -- To view, visit https://review.coreboot.org/c/coreboot/+/71647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6aad3d9118180d2ffdfba38abc80b175b6f103bd Gerrit-Change-Number: 71647 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 Jan 2023 02:30:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023