coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[M] Change in coreboot[master]: payloads/edk2: Add a recipe to make UniversalPayloadInfo
by build bot (Jenkins) (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Martin L Roth, Paul Menzel, Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65926 ) Change subject: payloads/edk2: Add a recipe to make UniversalPayloadInfo ...................................................................... Patch Set 27: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/65926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied4928508e74b86cf91b7df5e3b1091713d9fb32 Gerrit-Change-Number: 65926 Gerrit-PatchSet: 27 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Sep 2022 20:18:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe for UniversalPayload.elf
by Sean Rhodes (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Martin L Roth, Stefan Reinauer. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65922 ) Change subject: payloads/edk2: Add a recipe for UniversalPayload.elf ...................................................................... Patch Set 36: (1 comment) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/65922/comment/89245c70_6961fe04 PS34, Line 231: $(payload_entry) \ : $(WORKSPACE)/Build/UefiPayloadPkgX64/$(RELEASE_STR)_COREBOOT/FV/DXEFV.Fv \ : $(WORKSPACE)/Build/UniversalPayloadInfo.bin \ : print > Nit: Indent an extra level. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/65922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idff6b18392fd41c8766341c7933441b6b9ff6edf Gerrit-Change-Number: 65922 Gerrit-PatchSet: 36 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Sep 2022 20:18:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe to build a Universal Payload Entry point
by Sean Rhodes (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Bill XIE, Martin L Roth, Matt DeVillier, Stefan Reinauer, Arthur Heymans. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65920 ) Change subject: payloads/edk2: Add a recipe to build a Universal Payload Entry point ...................................................................... Patch Set 34: (3 comments) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/65920/comment/7240ca07_cdbc651d PS32, Line 195: prep > nit: indent an extra level to show that this is a prerequisite. Done https://review.coreboot.org/c/coreboot/+/65920/comment/c0d5061d_37613bed PS32, Line 207: ; > remove ';' - not needed. Done https://review.coreboot.org/c/coreboot/+/65920/comment/7ffc246c_490ece06 PS32, Line 207: > unindent? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/65920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I187d703a5d7bfd8efc25409bf79ef8ab0e92ae6c Gerrit-Change-Number: 65920 Gerrit-PatchSet: 34 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 04 Sep 2022 20:15:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: allocator_v4: Disable top-down mode by default
by Angel Pons (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67328 ) Change subject: allocator_v4: Disable top-down mode by default ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I982e6d7355b9e689de10357d6c16ed718705270e Gerrit-Change-Number: 67328 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 04 Sep 2022 20:04:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: allocator_v4: Disable top-down mode by default
by Nico Huber (Code Review) 04 Sep '22

04 Sep '22

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67328 ) Change subject: allocator_v4: Disable top-down mode by default ...................................................................... allocator_v4: Disable top-down mode by default The top-down allocation feature was merged prematurely before platforms that don't report their resources correctly were fixed. Let's turn it off by default. Change-Id: I982e6d7355b9e689de10357d6c16ed718705270e Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/device/Kconfig 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/67328/1 diff --git a/src/device/Kconfig b/src/device/Kconfig index 8d10c17f..ea42d6f 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -935,8 +935,11 @@ config RESOURCE_ALLOCATION_TOP_DOWN bool "Allocate resources from top down" if !PCIEXP_HOTPLUG_PREFETCH_MEM_ABOVE_4G - default y + default n depends on RESOURCE_ALLOCATOR_V4 + help + Should be the default, but many platforms don't report resources + correctly. Hence, the allocator might cause conflicts. config XHCI_UTILS def_bool n -- To view, visit https://review.coreboot.org/c/coreboot/+/67328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I982e6d7355b9e689de10357d6c16ed718705270e Gerrit-Change-Number: 67328 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: allocator_v4: Treat above 4G resources more natively
by 9elements QA (Code Review) 04 Sep '22

04 Sep '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65413 ) Change subject: allocator_v4: Treat above 4G resources more natively ...................................................................... Patch Set 9: Automatic boot test returned (PASS/FAIL/TOTAL): 12 / 4 / 16 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/122728 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/122727 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/122726 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/122725 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/122724 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/122723 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/122722 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/122721 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/122720 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/122719 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/122718 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/122717 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/122716 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/122715 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/122714 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/122713 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/65413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c7fcd1f5146f6cc287bd3aa5582da55bc5d6955 Gerrit-Change-Number: 65413 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Sep 2022 20:00:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Correct GPSI0 muxing for pads requiring NF8
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67317 ) Change subject: mb/google/rex: Correct GPSI0 muxing for pads requiring NF8 ...................................................................... mb/google/rex: Correct GPSI0 muxing for pads requiring NF8 GSPI0 pads required muxing to NF8. Support for extended native functions was added in commit b6c32d7fe4ea98ba8b3a10cb5ce46448801855b8 BUG=b:244610269 TEST=build and booted on Rex Change-Id: Iab4e0bc6890cd8e976c513fe87dda0da9b5f2ee0 Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67317 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Reviewed-by: Jamie Ryu <jamie.m.ryu(a)intel.com> --- M src/mainboard/google/rex/variants/rex0/gpio.c 1 file changed, 26 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Jamie Ryu: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/rex0/gpio.c b/src/mainboard/google/rex/variants/rex0/gpio.c index 8f4ea6c..23a0f5b 100644 --- a/src/mainboard/google/rex/variants/rex0/gpio.c +++ b/src/mainboard/google/rex/variants/rex0/gpio.c @@ -258,15 +258,15 @@ /* GPP_F13 : GSPI1_SOC_DI_FPMCU_DO_LS */ PAD_CFG_NF(GPP_F13, NONE, DEEP, NF5), /* GPP_F14 : GSPI_SOC_DO_TCHSCR_DI */ - PAD_NC(GPP_F14, NONE), + PAD_CFG_NF(GPP_F14, NONE, DEEP, NF8), /* GPP_F15 : [] ==> GSPI_SOC_DI_TCHSCR_DO */ - PAD_NC(GPP_F15, NONE), + PAD_CFG_NF(GPP_F15, NONE, DEEP, NF8), /* GPP_F16 : [] ==> GSPI_SOC_TCHSCR_CLK */ - PAD_NC(GPP_F16, NONE), + PAD_CFG_NF(GPP_F16, NONE, DEEP, NF8), /* GPP_F17 : [] ==> GSPI1_SOC_CS_L */ PAD_CFG_NF(GPP_F17, NONE, DEEP, NF5), /* GPP_F18 : [] ==> GSPI_SOC_TCHSCR_CS_L */ - PAD_NC(GPP_F18, NONE), + PAD_CFG_NF(GPP_F18, NONE, DEEP, NF8), /* GPP_F19 : [] ==> GPP_F19_STRAP */ PAD_NC(GPP_F19, NONE), /* GPP_F20 : [] ==> GPP_F20_STRAP */ -- To view, visit https://review.coreboot.org/c/coreboot/+/67317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab4e0bc6890cd8e976c513fe87dda0da9b5f2ee0 Gerrit-Change-Number: 67317 Gerrit-PatchSet: 3 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: soc/intel/alderlake: Remove dependency of FSP-S CpuMpPei Module
by Angel Pons (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Martin L Roth, Subrata Banik, Tim Wawrzynczak, Ronak Kanabar, Eric Lai, Werner Zeh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66706 ) Change subject: soc/intel/alderlake: Remove dependency of FSP-S CpuMpPei Module ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/66706/comment/fa66ade0_c78c682a PS5, Line 26: https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/CpuMpPei/CpuMpPei.… > Please make sure this is captured in archive.org and use the archive.org url in the commit. […] I think the link is no longer accurate, at least I can't make sense out of the line (it's just a closing brace). I guess you could quote the relevant snippet of code. -- To view, visit https://review.coreboot.org/c/coreboot/+/66706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebe0bcfda513e79e791df7ab54b357aa23d295c Gerrit-Change-Number: 66706 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sun, 04 Sep 2022 18:17:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/amdfwtool/amdfwread: Fix incorrect option index
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66553 ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: util/amdfwtool/amdfwread: Fix incorrect option index ...................................................................... util/amdfwtool/amdfwread: Fix incorrect option index index I/O argument to getopt_long is not the index to argv. Instead it is an index into the optlong array corresponding to the parsed option. Also getopt() uses a global variable optind to track the index of the next argument to be processed. Use the optindex variable as an index to extract the filename from argv. BUG=None TEST=Build and use amdfwread to read the Soft-fuse bits from Guybrush BIOS image. Observed no changes before and after the changes. Change-Id: I33c74a0c8e12c5af76954524cf7294b7541d286b Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/66553 Reviewed-by: Robert Zieba <robertzieba(a)google.com> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/amdfwtool/amdfwread.c 1 file changed, 29 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Robert Zieba: Looks good to me, but someone else must approve diff --git a/util/amdfwtool/amdfwread.c b/util/amdfwtool/amdfwread.c index 1a95c5c..c9da3d8 100644 --- a/util/amdfwtool/amdfwread.c +++ b/util/amdfwtool/amdfwread.c @@ -179,19 +179,18 @@ char *fw_file = NULL; int selected_functions = 0; - int index = 0; while (1) { - int opt = getopt_long(argc, argv, optstring, long_options, &index); + int opt = getopt_long(argc, argv, optstring, long_options, NULL); if (opt == -1) { - index++; - if (index >= argc) { - /* Print usage if we didn't get any arguments */ + if (optind != (argc - 1)) { + /* Print usage if one and only one option i.e. filename is + not found. */ print_usage(); return 0; } - fw_file = argv[index]; + fw_file = argv[optind]; break; } -- To view, visit https://review.coreboot.org/c/coreboot/+/66553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33c74a0c8e12c5af76954524cf7294b7541d286b Gerrit-Change-Number: 66553 Gerrit-PatchSet: 8 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold: Add gpio override settings
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Jason Nien, EricKY Cheng, Isaac Lee, Jon Murphy, Martin Roth, Eric Peers, Moises Garcia, Tim Van Patten, Karthikeyan Ramasubramanian. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67209 ) Change subject: mb/google/skyrim/var/winterhold: Add gpio override settings ...................................................................... Patch Set 5: (4 comments) File src/mainboard/google/skyrim/variants/winterhold/gpio.c: https://review.coreboot.org/c/coreboot/+/67209/comment/b90cae95_baf09d81 PS5, Line 7: ramstage*/ nit: add a space before '*/' https://review.coreboot.org/c/coreboot/+/67209/comment/6be65863_4dfae64e PS5, Line 16: Nit: remove extra space. (Normally i'd ignore this, but with the other changes, we might as well fix this too. https://review.coreboot.org/c/coreboot/+/67209/comment/2b5e684f_1e243c2f PS5, Line 19: // NC Remove, or move inside the other comment and add to all of the other comments> https://review.coreboot.org/c/coreboot/+/67209/comment/7e6969be_11e57396 PS5, Line 22: /* CLK_REQ1_L / EMMC */ remove? -- To view, visit https://review.coreboot.org/c/coreboot/+/67209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2086c326cbf46ba6378d18d37dcbbe9fafa6b2bc Gerrit-Change-Number: 67209 Gerrit-PatchSet: 5 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Comment-Date: Sun, 04 Sep 2022 17:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022