coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[S] Change in coreboot[master]: pciexp_device: Propagate above-4G flag to all hotplug devices
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66719 ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: pciexp_device: Propagate above-4G flag to all hotplug devices ...................................................................... pciexp_device: Propagate above-4G flag to all hotplug devices The `IORESOURCE_ABOVE_4G` flag was only explicitly set for our dummy device that reserves resources behind a hotplug port. The current re- source allocator implicitly extends this to all devices below the port, including real ones. Let's make that explicit, so future changes to the allocator can't break this rule. Change-Id: Id4c90b60682cf5c8949cde25362d286625b3e953 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/66719 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/device/device_util.c M src/device/pci_device.c M src/device/pciexp_device.c M src/include/device/device.h 4 files changed, 41 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Tim Wawrzynczak: Looks good to me, but someone else must approve Eric Lai: Looks good to me, but someone else must approve diff --git a/src/device/device_util.c b/src/device/device_util.c index 8097484..45dbccc 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -5,6 +5,7 @@ #include <device/path.h> #include <device/pci_def.h> #include <device/resource.h> +#include <stdbool.h> #include <stdlib.h> #include <string.h> @@ -939,6 +940,15 @@ return type_name; } +bool dev_path_hotplug(const struct device *dev) +{ + for (dev = dev->bus->dev; dev != dev->bus->dev; dev = dev->bus->dev) { + if (dev->hotplug_port) + return true; + } + return false; +} + void log_resource(const char *type, const struct device *dev, const struct resource *res, const char *srcfile, const int line) { diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 232328d..52107f2f 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -164,8 +164,12 @@ /* A Memory mapped base address. */ attr &= PCI_BASE_ADDRESS_MEM_ATTR_MASK; resource->flags |= IORESOURCE_MEM; - if (attr & PCI_BASE_ADDRESS_MEM_PREFETCH) + if (attr & PCI_BASE_ADDRESS_MEM_PREFETCH) { resource->flags |= IORESOURCE_PREFETCH; + if (CONFIG(PCIEXP_HOTPLUG_PREFETCH_MEM_ABOVE_4G) + && dev_path_hotplug(dev)) + resource->flags |= IORESOURCE_ABOVE_4G; + } attr &= PCI_BASE_ADDRESS_MEM_LIMIT_MASK; if (attr == PCI_BASE_ADDRESS_MEM_LIMIT_32) { /* 32bit limit. */ diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index c8ac391..6023497 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -646,6 +646,7 @@ void pciexp_hotplug_scan_bridge(struct device *dev) { + dev->hotplug_port = 1; dev->hotplug_buses = CONFIG_PCIEXP_HOTPLUG_BUSES; /* Normal PCIe Scan */ diff --git a/src/include/device/device.h b/src/include/device/device.h index 43ac66d..cd08f1d 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -128,6 +128,7 @@ unsigned int hidden : 1; /* set if this device is used even in minimum PCI cases */ unsigned int mandatory : 1; + unsigned int hotplug_port : 1; u8 command; uint16_t hotplug_buses; /* Number of hotplug buses to allocate */ @@ -207,6 +208,9 @@ bool is_dev_enabled(const struct device *const dev); bool is_devfn_enabled(unsigned int devfn); +/* Returns whether there is a hotplug port on the path to the given device. */ +extern bool dev_path_hotplug(const struct device *); + /* Option ROM helper functions */ void run_bios(struct device *dev, unsigned long addr); -- To view, visit https://review.coreboot.org/c/coreboot/+/66719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4c90b60682cf5c8949cde25362d286625b3e953 Gerrit-Change-Number: 66719 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe to build the ShimLayer
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Sean Rhodes, Stefan Reinauer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64485 ) Change subject: payloads/edk2: Add a recipe to build the ShimLayer ...................................................................... Patch Set 56: (2 comments) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/64485/comment/937e65bf_576aa389 PS56, Line 253: $(WORKSPACE)/Build/UniversalPayload.elf prep Nit: indent an extra level to show that this is a continuation of the previous line. https://review.coreboot.org/c/coreboot/+/64485/comment/5415415e_7c54d555 PS56, Line 254: ; change to && instead of ; - this prevents the next commands from running if the 'cd' fails for some reason. Same on the cd, and possibly for the source commands below. -- To view, visit https://review.coreboot.org/c/coreboot/+/64485 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I043271994f40813d9059a89420d4311d9d5802b1 Gerrit-Change-Number: 64485 Gerrit-PatchSet: 56 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Sep 2022 16:30:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe to build a Universal Payload Entry point
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Bill XIE, Sean Rhodes, Matt DeVillier, Stefan Reinauer, Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65920 ) Change subject: payloads/edk2: Add a recipe to build a Universal Payload Entry point ...................................................................... Patch Set 32: (1 comment) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/65920/comment/4b0c329b_7686c706 PS32, Line 195: prep nit: indent an extra level to show that this is a prerequisite. -- To view, visit https://review.coreboot.org/c/coreboot/+/65920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I187d703a5d7bfd8efc25409bf79ef8ab0e92ae6c Gerrit-Change-Number: 65920 Gerrit-PatchSet: 32 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 04 Sep 2022 16:26:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe for UniversalPayload.elf
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Sean Rhodes, Stefan Reinauer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65922 ) Change subject: payloads/edk2: Add a recipe for UniversalPayload.elf ...................................................................... Patch Set 34: (1 comment) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/65922/comment/43eb84b6_ed4bd62e PS34, Line 231: $(payload_entry) \ : $(WORKSPACE)/Build/UefiPayloadPkgX64/$(RELEASE_STR)_COREBOOT/FV/DXEFV.Fv \ : $(WORKSPACE)/Build/UniversalPayloadInfo.bin \ : print Nit: Indent an extra level. Right now it's hard to tell the difference between the rrereqs and the actual target build info. -- To view, visit https://review.coreboot.org/c/coreboot/+/65922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idff6b18392fd41c8766341c7933441b6b9ff6edf Gerrit-Change-Number: 65922 Gerrit-PatchSet: 34 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Sep 2022 16:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe to build a Universal Payload Entry point
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Bill XIE, Sean Rhodes, Matt DeVillier, Stefan Reinauer, Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65920 ) Change subject: payloads/edk2: Add a recipe to build a Universal Payload Entry point ...................................................................... Patch Set 32: (1 comment) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/65920/comment/fccdb93c_921c6e1f PS32, Line 207: ; remove ';' - not needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/65920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I187d703a5d7bfd8efc25409bf79ef8ab0e92ae6c Gerrit-Change-Number: 65920 Gerrit-PatchSet: 32 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 04 Sep 2022 16:21:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe for building Universal Payload
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Sean Rhodes, Paul Menzel, Stefan Reinauer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65921 ) Change subject: payloads/edk2: Add a recipe for building Universal Payload ...................................................................... Patch Set 31: (3 comments) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/65921/comment/18eec926_18e1aa9b PS31, Line 210: prep move to previous line? https://review.coreboot.org/c/coreboot/+/65921/comment/46186818_2d6f7e1c PS31, Line 221: Unindent? https://review.coreboot.org/c/coreboot/+/65921/comment/059485de_de45243c PS31, Line 221: ; \ remove '; \' - not needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/65921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05252a3949c4e567fe92453d11a14df7289fb6a Gerrit-Change-Number: 65921 Gerrit-PatchSet: 31 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Sep 2022 16:21:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe to build a Universal Payload Entry point
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Bill XIE, Sean Rhodes, Matt DeVillier, Stefan Reinauer, Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65920 ) Change subject: payloads/edk2: Add a recipe to build a Universal Payload Entry point ...................................................................... Patch Set 32: (1 comment) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/65920/comment/42c49905_10c7b0f1 PS32, Line 207: unindent? -- To view, visit https://review.coreboot.org/c/coreboot/+/65920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I187d703a5d7bfd8efc25409bf79ef8ab0e92ae6c Gerrit-Change-Number: 65920 Gerrit-PatchSet: 32 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 04 Sep 2022 16:19:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/prodrive/hermes: Use snake case for identifiers
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67274 ) Change subject: mb/prodrive/hermes: Use snake case for identifiers ...................................................................... mb/prodrive/hermes: Use snake case for identifiers There's no reason to use camel case for EEPROM region names or local variables. Use snake case for consistency with coreboot's code style. Change-Id: Id1200a0c778095b109d824a1ca4e3e69591e4165 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67274 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Christian Walter <christian.walter(a)9elements.com> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/prodrive/hermes/eeprom.c M src/mainboard/prodrive/hermes/eeprom.h 2 files changed, 35 insertions(+), 17 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Lean Sheng Tan: Looks good to me, approved Christian Walter: Looks good to me, approved diff --git a/src/mainboard/prodrive/hermes/eeprom.c b/src/mainboard/prodrive/hermes/eeprom.c index 5385a4a..7a92fe3 100644 --- a/src/mainboard/prodrive/hermes/eeprom.c +++ b/src/mainboard/prodrive/hermes/eeprom.c @@ -39,7 +39,7 @@ */ static bool get_board_settings_from_eeprom(struct eeprom_board_settings *board_cfg) { - const size_t board_settings_offset = offsetof(struct eeprom_layout, BoardSettings); + const size_t board_settings_offset = offsetof(struct eeprom_layout, board_settings); if (eeprom_read_buffer(board_cfg, board_settings_offset, sizeof(*board_cfg))) { printk(BIOS_ERR, "CFG EEPROM: Failed to read board settings\n"); @@ -72,7 +72,7 @@ struct eeprom_bmc_settings *get_bmc_settings(void) { - const size_t bmc_settings_offset = offsetof(struct eeprom_layout, BMCSettings); + const size_t bmc_settings_offset = offsetof(struct eeprom_layout, bmc_settings); static struct eeprom_bmc_settings bmc_cfg = {0}; /* 0: uninitialized, 1: settings are valid */ @@ -120,10 +120,10 @@ break; /* Write to UPD */ - uint8_t *writePointer = (uint8_t *)blob + i; - writePointer[0] = tmp[0]; + uint8_t *write_ptr = (uint8_t *)blob + i; + write_ptr[0] = tmp[0]; if (size - i > 1) - writePointer[1] = tmp[1]; + write_ptr[1] = tmp[1]; } /* Restore I2C_EN bit */ @@ -182,7 +182,7 @@ */ bool write_board_settings(const struct eeprom_board_layout *new_layout) { - const size_t off = offsetof(struct eeprom_layout, BoardLayout); + const size_t off = offsetof(struct eeprom_layout, board_layout); struct eeprom_board_layout old_layout = {0}; bool ret = false; bool changed = false; diff --git a/src/mainboard/prodrive/hermes/eeprom.h b/src/mainboard/prodrive/hermes/eeprom.h index ad41d02..2f7eac7 100644 --- a/src/mainboard/prodrive/hermes/eeprom.h +++ b/src/mainboard/prodrive/hermes/eeprom.h @@ -73,27 +73,27 @@ /* The EEPROM on address 0x57 has the following vendor defined layout: */ struct __packed eeprom_layout { union { - uint8_t RawFSPMUPD[0x600]; + uint8_t raw_fspm_upd[0x600]; FSPM_UPD mupd; }; union { - uint8_t RawFSPSUPD[0xc00]; + uint8_t raw_fsps_upd[0xc00]; FSPS_UPD supd; }; union { - uint8_t RawBoardLayout[0x400]; - struct eeprom_board_layout BoardLayout; + uint8_t raw_board_layout[0x400]; + struct eeprom_board_layout board_layout; }; char system_serial_number[HERMES_SERIAL_NUMBER_LENGTH]; char board_serial_number[HERMES_SERIAL_NUMBER_LENGTH]; - uint8_t BootOrder[0x8c0]; + uint8_t boot_order[0x8c0]; union { - uint8_t RawBoardSetting[0xf8]; - struct eeprom_board_settings BoardSettings; + uint8_t raw_board_settings[0xf8]; + struct eeprom_board_settings board_settings; }; union { - uint8_t RawBMCSetting[0x8]; - struct eeprom_bmc_settings BMCSettings; + uint8_t raw_bmc_settings[0x8]; + struct eeprom_bmc_settings bmc_settings; }; }; @@ -123,5 +123,5 @@ } \ } while (0) -#define READ_EEPROM_FSP_M(dest, opt_name) READ_EEPROM(FSPM_UPD, RawFSPMUPD, dest, opt_name) -#define READ_EEPROM_FSP_S(dest, opt_name) READ_EEPROM(FSPS_UPD, RawFSPSUPD, dest, opt_name) +#define READ_EEPROM_FSP_M(dest, opt_name) READ_EEPROM(FSPM_UPD, raw_fspm_upd, dest, opt_name) +#define READ_EEPROM_FSP_S(dest, opt_name) READ_EEPROM(FSPS_UPD, raw_fsps_upd, dest, opt_name) -- To view, visit https://review.coreboot.org/c/coreboot/+/67274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1200a0c778095b109d824a1ca4e3e69591e4165 Gerrit-Change-Number: 67274 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/prodrive/hermes: Use snake case for identifiers
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Patrick Rudolph, Angel Pons. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67274 ) Change subject: mb/prodrive/hermes: Use snake case for identifiers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1200a0c778095b109d824a1ca4e3e69591e4165 Gerrit-Change-Number: 67274 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Sep 2022 16:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl2: Limit SD-Card speed modes to DDR50
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Werner Zeh. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67169 ) Change subject: mb/siemens/mc_ehl2: Limit SD-Card speed modes to DDR50 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67169/comment/0a1b8314_350dd16e PS1, Line 12: chose choose -- To view, visit https://review.coreboot.org/c/coreboot/+/67169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc7f1466ec71f4218f6b957cadeeffadd069eb2d Gerrit-Change-Number: 67169 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sun, 04 Sep 2022 16:14:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022