coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: mainboard/msi/ms7d25: Fill board-specific SMBIOS data
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

1 0

Change in coreboot[master]: drivers/crb: Add SMBIOS hook to generate type 43 TPM Device
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Christian Walter. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64049 ) Change subject: drivers/crb: Add SMBIOS hook to generate type 43 TPM Device ...................................................................... Patch Set 6: Verified-1 (1 comment) File src/drivers/crb/tis.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150267): https://review.coreboot.org/c/coreboot/+/64049/comment/47179c6a_8785e46b PS6, Line 211: #endif trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/64049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05289f98969bd431017aff1aa77be5806d6f1838 Gerrit-Change-Number: 64049 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:08:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: smbios: Add API to generate SMBIOS type 43 TPM Device
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

1 0

Change in coreboot[master]: drivers/crb: Initialize Intel PTT control area
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63957 ) Change subject: drivers/crb: Initialize Intel PTT control area ...................................................................... Patch Set 7: Verified-1 (2 comments) File src/drivers/crb/tpm.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150265): https://review.coreboot.org/c/coreboot/+/63957/comment/cb2495d4_2485a632 PS7, Line 205: * some precious miliseconds which would be wasted in crb_activate_locality polling 'miliseconds' may be misspelled - perhaps 'milliseconds'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150265): https://review.coreboot.org/c/coreboot/+/63957/comment/20e5fcb8_57c25147 PS7, Line 264: * Initialize CRB adresses and sizes for PTT. It seems to be possible 'adresses' may be misspelled - perhaps 'addresses'? -- To view, visit https://review.coreboot.org/c/coreboot/+/63957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8e473ecc1a520851d6d48ccad9da35c6f91005d Gerrit-Change-Number: 63957 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:07:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/ptt: Use the correct detection method
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63956 ) Change subject: drivers/intel/ptt: Use the correct detection method ...................................................................... Patch Set 7: Verified-1 (1 comment) File src/security/intel/txt/txt_register.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150264): https://review.coreboot.org/c/coreboot/+/63956/comment/4e048a03_4e3bd071 PS7, Line 98: #define TXT_STS_FTIF (TXT_BASE + 0x800) trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/63956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a55c9f38f5bb94fb1186592446a28e675c1207c Gerrit-Change-Number: 63956 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:07:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake/iomap: Correct the ADL-S reserved range
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63929 ) Change subject: soc/intel/alderlake/iomap: Correct the ADL-S reserved range ...................................................................... Patch Set 7: Verified-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b1f79cc351de422acf182c27870c29dbe57fe4a Gerrit-Change-Number: 63929 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:06:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: superio/nuvoton/nct6687d: Add ramstage driver and ACPI
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63927 ) Change subject: superio/nuvoton/nct6687d: Add ramstage driver and ACPI ...................................................................... Patch Set 6: Verified-1 (2 comments) File src/superio/nuvoton/nct6687d/superio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150261): https://review.coreboot.org/c/coreboot/+/63927/comment/4407ceeb_fafa41f9 PS6, Line 42: printk(BIOS_INFO, "set power %s after power fail\n", power_status ? "on" : "off"); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150261): https://review.coreboot.org/c/coreboot/+/63927/comment/96d6dd40_b47ee2a4 PS6, Line 60: { NULL, NCT6687D_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1 | PNP_MSC0, trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/63927 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia489a39956c1448c7f11845ecc9e1df83ccb25ff Gerrit-Change-Number: 63927 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:06:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [VERY WIP]tests/cpu/x86/smm: Add unit tests
by Arthur Heymans (Code Review) 01 Jun '22

01 Jun '22

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63560 ) Change subject: [VERY WIP]tests/cpu/x86/smm: Add unit tests ...................................................................... Patch Set 21: Code-Review-2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7462fa6155b8f8085256a027692cbead0ca3f08e Gerrit-Change-Number: 63560 Gerrit-PatchSet: 21 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:06:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm_module_loader: Drop superfluous checks
by Arthur Heymans (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Kyösti Mälkki. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63480 to look at the new patch set (#22). Change subject: cpu/x86/smm_module_loader: Drop superfluous checks ...................................................................... cpu/x86/smm_module_loader: Drop superfluous checks Checking if the stack encroaches on the entry points is done in other parts of the code. Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 7 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/63480/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/63480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595 Gerrit-Change-Number: 63480 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake/vr_config.c: Add VR params for ADL-S
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63840 ) Change subject: soc/intel/alderlake/vr_config.c: Add VR params for ADL-S ...................................................................... Patch Set 7: Verified-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib50db521e4d127a773f903b45d4bec5c5cc180d4 Gerrit-Change-Number: 63840 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:05:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022