Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64050 )
Change subject: mainboard/msi/ms7d25: Fill board-specific SMBIOS data
......................................................................
Patch Set 9: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie64be21ff302274769b77550c29e58d4ea1376d1
Gerrit-Change-Number: 64050
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:21:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć, Christian Walter.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64049 )
Change subject: drivers/crb: Add SMBIOS hook to generate type 43 TPM Device
......................................................................
Patch Set 7: Verified-1
(1 comment)
File src/drivers/crb/tis.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150301):
https://review.coreboot.org/c/coreboot/+/64049/comment/b1e04ba2_9d0b2652
PS7, Line 211: #endif
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/64049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05289f98969bd431017aff1aa77be5806d6f1838
Gerrit-Change-Number: 64049
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:21:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64048 )
Change subject: smbios: Add API to generate SMBIOS type 43 TPM Device
......................................................................
Patch Set 7: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2db29f8bc4cfbc6648bb2cabad074d9ea583ca9
Gerrit-Change-Number: 64048
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:20:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63957 )
Change subject: drivers/crb: Initialize Intel PTT control area
......................................................................
Patch Set 8: Verified-1
(2 comments)
File src/drivers/crb/tpm.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150299):
https://review.coreboot.org/c/coreboot/+/63957/comment/324fc16d_809afd25
PS8, Line 205: * some precious miliseconds which would be wasted in crb_activate_locality polling
'miliseconds' may be misspelled - perhaps 'milliseconds'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150299):
https://review.coreboot.org/c/coreboot/+/63957/comment/6c0e2c83_67cd36ef
PS8, Line 264: * Initialize CRB adresses and sizes for PTT. It seems to be possible
'adresses' may be misspelled - perhaps 'addresses'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8e473ecc1a520851d6d48ccad9da35c6f91005d
Gerrit-Change-Number: 63957
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:20:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63956 )
Change subject: drivers/intel/ptt: Use the correct detection method
......................................................................
Patch Set 8: Verified-1
(1 comment)
File src/security/intel/txt/txt_register.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150298):
https://review.coreboot.org/c/coreboot/+/63956/comment/9e36a055_fb5c5bce
PS8, Line 98: #define TXT_STS_FTIF (TXT_BASE + 0x800)
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/63956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a55c9f38f5bb94fb1186592446a28e675c1207c
Gerrit-Change-Number: 63956
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć, Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63929 )
Change subject: soc/intel/alderlake/iomap: Correct the ADL-S reserved range
......................................................................
Patch Set 8: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63929
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1f79cc351de422acf182c27870c29dbe57fe4a
Gerrit-Change-Number: 63929
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:19:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63927 )
Change subject: superio/nuvoton/nct6687d: Add ramstage driver and ACPI
......................................................................
Patch Set 7: Verified-1
(2 comments)
File src/superio/nuvoton/nct6687d/superio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150295):
https://review.coreboot.org/c/coreboot/+/63927/comment/56f600ac_27cf13b2
PS7, Line 42: printk(BIOS_INFO, "set power %s after power fail\n", power_status ? "on" : "off");
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150295):
https://review.coreboot.org/c/coreboot/+/63927/comment/547bf739_2b9b9a0d
PS7, Line 60: { NULL, NCT6687D_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1 | PNP_MSC0,
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/63927
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia489a39956c1448c7f11845ecc9e1df83ccb25ff
Gerrit-Change-Number: 63927
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:18:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć, Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63840 )
Change subject: soc/intel/alderlake/vr_config.c: Add VR params for ADL-S
......................................................................
Patch Set 8: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib50db521e4d127a773f903b45d4bec5c5cc180d4
Gerrit-Change-Number: 63840
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:18:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć, Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63839 )
Change subject: soc/intel/alderlake/fsp_params.c: Add VccIn Aux Imon IccMax for ADL-S
......................................................................
Patch Set 7: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia95404e717787edbdb67c9e584e749526b973427
Gerrit-Change-Number: 63839
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:18:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć, Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63837 )
Change subject: soc/intel/alderlake: Do not pass IRQs for non-existent devices to FSP
......................................................................
Patch Set 7: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63837
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I055d4bbfd04a01fa9943278b6bbc9a31b9dfc628
Gerrit-Change-Number: 63837
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:17:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment