coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: soc/intel/alderlake/fsp_params.c: Fill PCI SSID parameters
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Kopeć, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63836 ) Change subject: soc/intel/alderlake/fsp_params.c: Fill PCI SSID parameters ...................................................................... Patch Set 7: Verified-1 (2 comments) File src/soc/intel/alderlake/fsp_params.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150290): https://review.coreboot.org/c/coreboot/+/63836/comment/a704d2de_9c74b0ab PS7, Line 889: uint64_t :4; space prohibited before that ':' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150290): https://review.coreboot.org/c/coreboot/+/63836/comment/2229f5bf_210a2702 PS7, Line 891: uint64_t :16; space prohibited before that ':' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/63836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a6d299ec40bac8e29d06926572e375d7d835e29 Gerrit-Change-Number: 63836 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:17:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/msi/ms7d25: Properly handle CnvDdrRfim parameter
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

1 0

Change in coreboot[master]: mb/msi/ms7d25: Configure PCIe Root Ports
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63656 ) Change subject: mb/msi/ms7d25: Configure PCIe Root Ports ...................................................................... Patch Set 11: Verified-1 (57 comments) File src/mainboard/msi/ms7d25/gpio.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/fce16af8_04bdd57d PS11, Line 142: _PAD_CFG_STRUCT(VGPIO_4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c0642d91_02d93b17 PS11, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/d94315d4_0bb22852 PS11, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ need consistent spacing around '|' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/5d328a45_d19ff14d PS11, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/090851c5_93f7740d PS11, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ need consistent spacing around '|' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/37ffd100_d1f331d7 PS11, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/f8474db4_a13a5044 PS11, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ need consistent spacing around '|' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/4eef7b87_7a9858a9 PS11, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/1900358c_37d0de4c PS11, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ need consistent spacing around '|' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c7e13fc5_a0cf74ad PS11, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/34e8f7da_5d8e7ab8 PS11, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ need consistent spacing around '|' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/fac9166b_82bd6055 PS11, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/18176197_73e36f2c PS11, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ need consistent spacing around '|' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/10eca28f_e704c691 PS11, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c8ef9924_8943d0d3 PS11, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ need consistent spacing around '|' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/7d28c7e1_0d77967d PS11, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/df5eb582_aab20445 PS11, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ need consistent spacing around '|' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c85e5ce4_4b87f4d4 PS11, Line 425: // _PAD_CFG_STRUCT(VGPIO_PCIE_0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/48df5e8d_5c98d0b3 PS11, Line 426: // _PAD_CFG_STRUCT(VGPIO_PCIE_1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/9b9ca027_1b6362bb PS11, Line 427: // _PAD_CFG_STRUCT(VGPIO_PCIE_2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/101e0bcd_025e9477 PS11, Line 428: // _PAD_CFG_STRUCT(VGPIO_PCIE_3, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/653436ae_a4f95e6c PS11, Line 429: // _PAD_CFG_STRUCT(VGPIO_PCIE_4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/a681cc9a_0bee8dc4 PS11, Line 430: // _PAD_CFG_STRUCT(VGPIO_PCIE_5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/7830f5c6_322fd306 PS11, Line 431: // _PAD_CFG_STRUCT(VGPIO_PCIE_6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c8719bb5_e60f5222 PS11, Line 432: // _PAD_CFG_STRUCT(VGPIO_PCIE_7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/af228507_82fe0038 PS11, Line 433: // _PAD_CFG_STRUCT(VGPIO_PCIE_8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/b16dc6d4_10f3439d PS11, Line 434: // _PAD_CFG_STRUCT(VGPIO_PCIE_9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/92617c4c_50e76f20 PS11, Line 435: // _PAD_CFG_STRUCT(VGPIO_PCIE_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/3cc6e619_8861d0ef PS11, Line 436: // _PAD_CFG_STRUCT(VGPIO_PCIE_11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/a2d02efe_e0685a9c PS11, Line 437: // _PAD_CFG_STRUCT(VGPIO_PCIE_12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/38c52aec_1af296d0 PS11, Line 438: // _PAD_CFG_STRUCT(VGPIO_PCIE_13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/fb229abe_f4ca0795 PS11, Line 439: // _PAD_CFG_STRUCT(VGPIO_PCIE_14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c9723e48_c2c91564 PS11, Line 440: // _PAD_CFG_STRUCT(VGPIO_PCIE_15, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/78c033d8_8ab885f0 PS11, Line 441: // _PAD_CFG_STRUCT(VGPIO_PCIE_64, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/f3d69c12_3cc837e7 PS11, Line 442: // _PAD_CFG_STRUCT(VGPIO_PCIE_65, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/59bd5c2b_8d739b0a PS11, Line 443: // _PAD_CFG_STRUCT(VGPIO_PCIE_66, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/56327865_45f91d72 PS11, Line 444: // _PAD_CFG_STRUCT(VGPIO_PCIE_67, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c32c8b3c_d73feeb4 PS11, Line 447: // _PAD_CFG_STRUCT(VGPIO_PCIE_16, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/74992595_eb9f9365 PS11, Line 448: // _PAD_CFG_STRUCT(VGPIO_PCIE_17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/5cfbfa0e_e826c58e PS11, Line 449: // _PAD_CFG_STRUCT(VGPIO_PCIE_18, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/0a00f6ec_050ebddc PS11, Line 450: // _PAD_CFG_STRUCT(VGPIO_PCIE_19, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/0fde2aec_2d8233ca PS11, Line 451: // _PAD_CFG_STRUCT(VGPIO_PCIE_20, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/aca225d4_409ce92c PS11, Line 452: // _PAD_CFG_STRUCT(VGPIO_PCIE_21, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/45259927_a9ea29d4 PS11, Line 453: // _PAD_CFG_STRUCT(VGPIO_PCIE_22, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/f5a356d5_1c768681 PS11, Line 454: // _PAD_CFG_STRUCT(VGPIO_PCIE_23, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/b6735ae0_b78cf45f PS11, Line 455: // _PAD_CFG_STRUCT(VGPIO_PCIE_24, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/35852db7_35561f78 PS11, Line 456: // _PAD_CFG_STRUCT(VGPIO_PCIE_25, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/62c85fcf_7f45a93d PS11, Line 457: // _PAD_CFG_STRUCT(VGPIO_PCIE_26, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/7f8c979d_a902e744 PS11, Line 458: // _PAD_CFG_STRUCT(VGPIO_PCIE_27, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/3bb8dd5f_fa5ef068 PS11, Line 459: // _PAD_CFG_STRUCT(VGPIO_PCIE_28, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/a7a557a3_7d02e818 PS11, Line 460: // _PAD_CFG_STRUCT(VGPIO_PCIE_29, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/5de6f9ef_12af8799 PS11, Line 461: // _PAD_CFG_STRUCT(VGPIO_PCIE_30, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/49750262_1c58de84 PS11, Line 462: // _PAD_CFG_STRUCT(VGPIO_PCIE_31, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/f1f560c4_c827bd90 PS11, Line 463: // _PAD_CFG_STRUCT(VGPIO_PCIE_68, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/1cd7da9b_5d1627a0 PS11, Line 464: // _PAD_CFG_STRUCT(VGPIO_PCIE_69, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/200314da_355e42b7 PS11, Line 465: // _PAD_CFG_STRUCT(VGPIO_PCIE_70, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c659aca7_b2edc4a9 PS11, Line 466: // _PAD_CFG_STRUCT(VGPIO_PCIE_71, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/63656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50199d2caf54509a72c5100acb770bf766327e7f Gerrit-Change-Number: 63656 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:14:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake/hsphy: Add support for HSPHY firmware loading
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Maulik V Vaghela, Jeremy Soller, Michał Kopeć, Tim Wawrzynczak, Paul Menzel, Ronak Kanabar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64074 ) Change subject: soc/intel/alderlake/hsphy: Add support for HSPHY firmware loading ...................................................................... Patch Set 5: (8 comments) File src/soc/intel/alderlake/hsphy.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283): https://review.coreboot.org/c/coreboot/+/64074/comment/d6b70ea9_d13eda29 PS5, Line 28: #define HSPHY_PAYLOAD_SIZE 32*KiB Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283): https://review.coreboot.org/c/coreboot/+/64074/comment/d9a2b4c3_7d183426 PS5, Line 40: #define HSPHY_MEM_VERIFIER_ERROR_STATUS (HSPHY_VERIFIER_BASE + 0x30) please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283): https://review.coreboot.org/c/coreboot/+/64074/comment/def07b78_93b28944 PS5, Line 67: }__packed; space required after that close brace '}' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283): https://review.coreboot.org/c/coreboot/+/64074/comment/493fe786_dd1f3b48 PS5, Line 159: printk (BIOS_ERR, "Hash alg %d not supported, try SHA384\n", hash_alg); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283): https://review.coreboot.org/c/coreboot/+/64074/comment/d9e3e603_59f2d5a3 PS5, Line 187: i += sizeof (*push_model); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283): https://review.coreboot.org/c/coreboot/+/64074/comment/dbbb28aa_4f880ab6 PS5, Line 195: i += sizeof (uint32_t); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283): https://review.coreboot.org/c/coreboot/+/64074/comment/7dae260f_9f5a0e41 PS5, Line 312: hsphy_ver = REGBAR32(CPU_PID_PCIE_PHYx16_0, HSPHY_FW_VERSION);; Statements terminations use 1 semicolon Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283): https://review.coreboot.org/c/coreboot/+/64074/comment/e8e91db3_5e7cbf8f PS5, Line 317: hsphy_ver = REGBAR32(CPU_PID_PCIE_PHYx16_1, HSPHY_FW_VERSION);; Statements terminations use 1 semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/64074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c6c11581e3d3d9bab0131fae6ef487cafe98080 Gerrit-Change-Number: 64074 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:14:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [VERY WIP]tests/cpu/x86/smm: Add unit tests
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63560 ) Change subject: [VERY WIP]tests/cpu/x86/smm: Add unit tests ...................................................................... Patch Set 20: Verified-1 (10 comments) File tests/cpu/x86/smm/smm_loader.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/78930b80_bf68675a PS20, Line 54: #define setup_rmodule(mod , c) \ space prohibited before that ',' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/72f77377_da062ec0 PS20, Line 54: #define setup_rmodule(mod , c) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/23091483_e8ab72da PS20, Line 59: hdr->payload_begin_offset = (uintptr_t)(stub_module->program) - (uintptr_t)stub_module; \ line length of 97 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/c01aa03b_d15117a9 PS20, Line 66: hdr->parameters_begin = (uintptr_t)&stub_module->params - (uintptr_t)stub_module->program; \ line length of 100 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/782fdba1_b6c1e959 PS20, Line 80: /* hdr->payload_begin_offset = (uintptr_t)(stub_module->program) - (uintptr_t)stub_module; */ line length of 101 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/08b2618a_754cda80 PS20, Line 87: /* hdr->parameters_begin = (uintptr_t)&stub_module->params - (uintptr_t)stub_module->program ; */ line length of 105 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/1e072aec_340b2fa5 PS20, Line 93: /* stub_module->program[i] = stub_string[i % sizeof(stub_string)]; */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/c8653a18_6030a958 PS20, Line 106: hdr->payload_begin_offset = (uintptr_t)(handler_module->program) - (uintptr_t)handler_module; line length of 101 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/ea6592ec_f5288029 PS20, Line 107: hdr->payload_end_offset = (uintptr_t)(handler_module->program) - (uintptr_t)handler_module + sizeof(handler_module->program); line length of 133 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150281): https://review.coreboot.org/c/coreboot/+/63560/comment/9267ba23_1d90e29a PS20, Line 113: hdr->parameters_begin = (uintptr_t)&handler_module->params - (uintptr_t)handler_module->program; line length of 104 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/63560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7462fa6155b8f8085256a027692cbead0ca3f08e Gerrit-Change-Number: 63560 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:13:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/msi/ms7d25: Enable CBFS serial number and UUID as default
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

1 0

Change in coreboot[master]: cpu/x86/smm_module_loader: Drop superfluous checks
by Arthur Heymans (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63480 ) Change subject: cpu/x86/smm_module_loader: Drop superfluous checks ...................................................................... Patch Set 22: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63480/comment/680103cc_047d2e78 PS20, Line 10: parts of the code. > > No need to describe it in commit message, but if you could add a gerrit review comments inline where the checks are now, please. > > It's done in the code that sets up everything (l430 in this CL). Also one of the next patches checks for overlaps on everything so it's certainly covered by that. -- To view, visit https://review.coreboot.org/c/coreboot/+/63480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595 Gerrit-Change-Number: 63480 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:10:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/msi/ms7d25: Add USB macros and port designation comments
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

1 0

Change in coreboot[master]: mainboard/msi/ms7d25: Add default vboot configuration
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

1 0

Change in coreboot[master]: drivers/mrc_cache: Do not verify TPM MRC hash if secdata is mocked
by build bot (Jenkins) (Code Review) 01 Jun '22

01 Jun '22

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022