coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: [VERY WIP]tests/cpu/x86/smm: Add unit tests
by Arthur Heymans (Code Review) 01 Jun '22

01 Jun '22

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63560 ) Change subject: [VERY WIP]tests/cpu/x86/smm: Add unit tests ...................................................................... Patch Set 23: Code-Review-2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7462fa6155b8f8085256a027692cbead0ca3f08e Gerrit-Change-Number: 63560 Gerrit-PatchSet: 23 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 12:02:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm_module_loader: Drop superfluous checks
by Arthur Heymans (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), Angel Pons, Kyösti Mälkki, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63480 to look at the new patch set (#23). Change subject: cpu/x86/smm_module_loader: Drop superfluous checks ...................................................................... cpu/x86/smm_module_loader: Drop superfluous checks Checking if the stack encroaches on the entry points is done in other parts of the code. Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 5 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/63480/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/63480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595 Gerrit-Change-Number: 63480 Gerrit-PatchSet: 23 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/apl: Update microcode in IFWI image
by Arthur Heymans (Code Review) 01 Jun '22

01 Jun '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64863 ) Change subject: soc/intel/apl: Update microcode in IFWI image ...................................................................... soc/intel/apl: Update microcode in IFWI image First find the matching CPUID then replace it in the IFWI. Tested on up/squared: latest microcode version is now reported in the bootblock. Change-Id: If4ade0f6c6f985291ab75878a9c8f5512b6a271e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/apollolake/Makefile.inc 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/64863/1 diff --git a/src/soc/intel/apollolake/Makefile.inc b/src/soc/intel/apollolake/Makefile.inc index 11da0b38..0303e41 100644 --- a/src/soc/intel/apollolake/Makefile.inc +++ b/src/soc/intel/apollolake/Makefile.inc @@ -136,14 +136,34 @@ # 2. Delete OBBP sub-partition, if present. # 3. Replace IBBL directory entry in IBBP sub-partition with currently # generated bootblock.bin. +# 4. Update microcode entries with matching CPUIDs (allow this to fail if +# for instance the microcode is not in the repo) # b. Using cbfstool: # 1. Write ifwi.bin.tmp to coreboot.rom using CONFIG_IFWI_FMAP_NAME. ifeq ($(CONFIG_NEED_IFWI),y) -$(call add_intermediate, write_ifwi, $(objcbfs)/bootblock.bin $(IFWITOOL)) +$(obj)/upatch%: $(IFWITOOL) $(call strip_quotes,$(CONFIG_IFWI_FILE_NAME)) + $(IFWITOOL) $(CONFIG_IFWI_FILE_NAME) extract -f $@.tmp -n UCOD -d -e $(notdir $@) + dd if=$@.tmp of=$@.cpuid bs=1 count=4 skip=12 + for bin in $(cpu_microcode_bins); do \ + if [ ! -f "$$bin" ]; then \ + echo "Microcode error: $$bin does not exist"; \ + NO_MICROCODE_FILE=1; \ + fi; \ + dd if=$$bin of=$(obj)/bin.cpuid bs=1 count=4 skip=12; \ + if cmp -s "$(obj)/bin.cpuid" "$@.cpuid"; then \ + cp $$bin $@; \ + break; \ + fi; \ + done; \ + rm $(obj)/bin.cpuid $@.cpuid $@.tmp + +$(call add_intermediate, write_ifwi, $(objcbfs)/bootblock.bin $(obj)/upatch1 $(obj)/upatch2 $(IFWITOOL)) @printf " IFWI Embedding %s in %s\n" $(objcbfs)/bootblock.bin $(CONFIG_IFWI_FMAP_NAME) $(IFWITOOL) $(CONFIG_IFWI_FILE_NAME) create -f $(objcbfs)/ifwi.bin.tmp $(IFWITOOL) $(objcbfs)/ifwi.bin.tmp delete -n OBBP $(IFWITOOL) $(objcbfs)/ifwi.bin.tmp replace -n IBBP -f $(objcbfs)/bootblock.bin -d -e IBBL + -$(IFWITOOL) $(objcbfs)/ifwi.bin.tmp replace -n UCOD -f $(obj)/upatch1 -d -e upatch1 + -$(IFWITOOL) $(objcbfs)/ifwi.bin.tmp replace -n UCOD -f $(obj)/upatch2 -d -e upatch2 $(CBFSTOOL) $< write -r $(CONFIG_IFWI_FMAP_NAME) -f $(objcbfs)/ifwi.bin.tmp --fill-upward endif -- To view, visit https://review.coreboot.org/c/coreboot/+/64863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4ade0f6c6f985291ab75878a9c8f5512b6a271e Gerrit-Change-Number: 64863 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: cpu/x86/smm: Use struct region to check overlapping sections
by Kyösti Mälkki (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Paul Menzel, Arthur Heymans, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63602 ) Change subject: cpu/x86/smm: Use struct region to check overlapping sections ...................................................................... Patch Set 22: (1 comment) File src/cpu/x86/smm/smm_module_loader.c: https://review.coreboot.org/c/coreboot/+/63602/comment/f0803876_a1549947 PS21, Line 371: for (region_counter; region_counter < SMM_REGIONS_ARRAY_SIZE; region_counter++) > IMHO region_counter; here without assignment to zero looks a bit odd. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Gerrit-Change-Number: 63602 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:48:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm_module_loader: Drop superfluous checks
by Kyösti Mälkki (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63480 ) Change subject: cpu/x86/smm_module_loader: Drop superfluous checks ...................................................................... Patch Set 22: (1 comment) File src/cpu/x86/smm/smm_module_loader.c: https://review.coreboot.org/c/coreboot/+/63480/comment/14955f32_85b7df64 PS22, Line 294: smm_stub_place_staggered_entry_points(params); Potential follow-up: if (params->num_concurrent_save_states > 1) smm_place_entry_code(params->num_concurrent_save_states); -- To view, visit https://review.coreboot.org/c/coreboot/+/63480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595 Gerrit-Change-Number: 63480 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: intelblocks/gpio.c: Handle NULL return values from child functions
by Eric Lai (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64857 ) Change subject: intelblocks/gpio.c: Handle NULL return values from child functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97fad72cdd92f70c7c5e6fdd23fbecf535a6e388 Gerrit-Change-Number: 64857 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:42:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Use struct region to check overlapping sections
by Kyösti Mälkki (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Paul Menzel, Arthur Heymans, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63602 ) Change subject: cpu/x86/smm: Use struct region to check overlapping sections ...................................................................... Patch Set 22: (1 comment) File src/cpu/x86/smm/smm_module_loader.c: https://review.coreboot.org/c/coreboot/+/63602/comment/37f986e3_72daeb35 PS21, Line 371: for (region_counter; region_counter < SMM_REGIONS_ARRAY_SIZE; region_counter++) IMHO region_counter; here without assignment to zero looks a bit odd. -- To view, visit https://review.coreboot.org/c/coreboot/+/63602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925 Gerrit-Change-Number: 63602 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: driver/intel/fsp2_0: Disable NULL deref code when calling FSP
by Uwe Poeche (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Paul Menzel, Mario Scheithauer, Arthur Heymans, Andrey Petrov. Uwe Poeche has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64426 ) Change subject: driver/intel/fsp2_0: Disable NULL deref code when calling FSP ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: With this patch we get rid the number of log error messages on our siemens/ehl boards "Null dereference at eip:". Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/64426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia49dde68d45b71e231aaf32a0e6fd847f0e06146 Gerrit-Change-Number: 64426 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Zieba <robertzieba(a)google.com> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:40:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cmn/cse: Implement heci_init() to initialize HECI devices
by Sean Rhodes (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Subrata Banik. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64855 ) Change subject: soc/intel/cmn/cse: Implement heci_init() to initialize HECI devices ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia25e18a20cc749fc7eee39b0b591d41540fc14c9 Gerrit-Change-Number: 64855 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:36:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: Rename heci_init to cse_init
by Sean Rhodes (Code Review) 01 Jun '22

01 Jun '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64854 ) Change subject: soc/intel: Rename heci_init to cse_init ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7edd55ccdcd70b244615fa06f81803a0ae6ce80 Gerrit-Change-Number: 64854 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 11:35:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022