coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6166 discussions

Change in coreboot[master]: util/release: Update genrelnotes with the latest version
by Martin L Roth (Code Review) 02 May '22

02 May '22

Attention is currently required from: Patrick Georgi. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62440 ) Change subject: util/release: Update genrelnotes with the latest version ...................................................................... Patch Set 3: (2 comments) File util/release/genrelnotes: https://review.coreboot.org/c/coreboot/+/62440/comment/983d600a_7ce3d173 PS2, Line 249: * > "${base}"* to have it expand? Done, thanks. https://review.coreboot.org/c/coreboot/+/62440/comment/aee5273d_adb2b3af PS2, Line 349: tigerlake > is this intentional? Nope, I missed updating that in the copy/paste. -- To view, visit https://review.coreboot.org/c/coreboot/+/62440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2204793a5d1cc5792d0720d2bbfb172bb6020dd4 Gerrit-Change-Number: 62440 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 May 2022 17:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: intel/common/../systemagent: Add sa_get_mchbar_base api
by Wonkyu Kim (Code Review) 02 May '22

02 May '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Arthur Heymans, Michael Niewöhner. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63615 ) Change subject: intel/common/../systemagent: Add sa_get_mchbar_base api ...................................................................... Patch Set 16: (1 comment) Patchset: PS16: > > @Subrata, I'm not worried about #2 because if one forgets to enable MCHBAR early the resulting iss […] @Subrata and @Angel, Can we summarize solution? 1. Remove init part in case of MCBAR is not enabled in sa_get_mchbar_base API? or 2. use MCH_BASE_ADDRESS in ioc.c And enable in soc bootblock For #2, it's already implemented before but we updated while we adding this logic. https://review.coreboot.org/c/coreboot/+/63198/12/src/soc/intel/common/bloc… -- To view, visit https://review.coreboot.org/c/coreboot/+/63615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4c7af3ea8c2b2b6afcc76e1165fadbe15e0bceb Gerrit-Change-Number: 63615 Gerrit-PatchSet: 16 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 02 May 2022 17:48:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in em100[master]: makechips.sh: Build makedpfw if not present
by Martin L Roth (Code Review) 02 May '22

02 May '22

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/em100/+/62938 ) Change subject: makechips.sh: Build makedpfw if not present ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I accidentally pushed this patch directly into the git repo after making the requested changes on the previous patch. Sorry about that. :-/ I can revert and submit it through gerrit again as a new patch if you'd like. -- To view, visit https://review.coreboot.org/c/em100/+/62938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If5dd121a4977126c456162de7d4328d69e741902 Gerrit-Change-Number: 62938 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 May 2022 17:47:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in em100[master]: makechips.sh: Clean up shellcheck errors and formatting
by Martin L Roth (Code Review) 02 May '22

02 May '22

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/em100/+/62937 ) Change subject: makechips.sh: Clean up shellcheck errors and formatting ...................................................................... Patch Set 2: (7 comments) Patchset: PS2: I accidentally pushed this patch directly into the git repo after making the requested changes. Sorry about that. :-/ I can revert and submit it through gerrit again as a new patch if you'd like. File makechips.sh: https://review.coreboot.org/c/em100/+/62937/comment/a6714f16_c0b8f7ea PS1, Line 33: FILE > ${FILE}? Done https://review.coreboot.org/c/em100/+/62937/comment/074182d4_ccc5193b PS1, Line 36: FILE > ${FILE}? Done https://review.coreboot.org/c/em100/+/62937/comment/f8c479ff_8e825d0b PS1, Line 37: URL > ${URL}? ${FILE}? Done https://review.coreboot.org/c/em100/+/62937/comment/df52c5c6_a8ede487 PS1, Line 40: FILE > ${FILE} ? Done https://review.coreboot.org/c/em100/+/62937/comment/c582d2e7_0b522d14 PS1, Line 46: VERSION > should this be ${VERSION} ? Done https://review.coreboot.org/c/em100/+/62937/comment/2f35b192_55877361 PS1, Line 57: i > ${i} ? Done -- To view, visit https://review.coreboot.org/c/em100/+/62937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: Ia756d67d0a0464971e395189027b01787b6b19bd Gerrit-Change-Number: 62937 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 May 2022 17:47:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in em100[master]: makechips.sh: Build makedpfw if not present
by Martin L Roth (Code Review) 02 May '22

02 May '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/em100/+/62938 ) Change subject: makechips.sh: Build makedpfw if not present ...................................................................... makechips.sh: Build makedpfw if not present Check for makedpfw and build it if it hasn't been built yet. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: If5dd121a4977126c456162de7d4328d69e741902 --- M makechips.sh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Stefan Reinauer: Looks good to me, approved diff --git a/makechips.sh b/makechips.sh index 8010644..5e3531d 100755 --- a/makechips.sh +++ b/makechips.sh @@ -28,6 +28,10 @@ WD="$(cd "$(dirname "$(eval echo "$0")")" || exit 1; pwd)" TD="${WD}/em100_home" +if [[ ! -f "${WD}/makedpfw" ]]; then + make makedpfw +fi + cd "${TEMP}" || exit 1 if [ -r "${WD}/${FILE}" ]; then echo " Copying ${FILE}..." null-- To view, visit https://review.coreboot.org/c/em100/+/62938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If5dd121a4977126c456162de7d4328d69e741902 Gerrit-Change-Number: 62938 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in em100[master]: makechips.sh: Clean up shellcheck errors and formatting
by Martin L Roth (Code Review) 02 May '22

02 May '22

Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/em100/+/62937 to look at the new patch set (#2). Change subject: makechips.sh: Clean up shellcheck errors and formatting ...................................................................... makechips.sh: Clean up shellcheck errors and formatting Clean up shellcheck errors Add braces around variable names Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ia756d67d0a0464971e395189027b01787b6b19bd --- M makechips.sh 1 file changed, 23 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/37/62937/2 -- To view, visit https://review.coreboot.org/c/em100/+/62937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: Ia756d67d0a0464971e395189027b01787b6b19bd Gerrit-Change-Number: 62937 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in em100[master]: makechips.sh: Reformat script with shfmt
by Martin L Roth (Code Review) 02 May '22

02 May '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/em100/+/62939 ) Change subject: makechips.sh: Reformat script with shfmt ...................................................................... Abandoned shfmt is being more intrusive than I'd like. -- To view, visit https://review.coreboot.org/c/em100/+/62939 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I92c1044f93e0322fe13ea3804371203e321293d9 Gerrit-Change-Number: 62939 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: util/inteltool: suggest booting with iomem=relaxed
by Peter Lemenkov (Code Review) 02 May '22

02 May '22

Attention is currently required from: Stefan Reinauer. Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63999 ) Change subject: util/inteltool: suggest booting with iomem=relaxed ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63999/comment/3cae9e20_b1510cb1 PS1, Line 7: intemletool > inteltool Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib80efd7d1ba516cb0ae4bdb86f95877855195ce0 Gerrit-Change-Number: 63999 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 May 2022 17:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: suggest booting with iomem=relaxed
by Peter Lemenkov (Code Review) 02 May '22

02 May '22

Attention is currently required from: Peter Lemenkov. Hello Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63999 to look at the new patch set (#2). Change subject: util/inteltool: suggest booting with iomem=relaxed ...................................................................... util/inteltool: suggest booting with iomem=relaxed Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> Change-Id: Ib80efd7d1ba516cb0ae4bdb86f95877855195ce0 --- M util/inteltool/rootcmplx.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/63999/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib80efd7d1ba516cb0ae4bdb86f95877855195ce0 Gerrit-Change-Number: 63999 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Update intel-sec-tools submodule to upstream master
by Martin L Roth (Code Review) 02 May '22

02 May '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60822 ) Change subject: Update intel-sec-tools submodule to upstream master ...................................................................... Abandoned out of date. -- To view, visit https://review.coreboot.org/c/coreboot/+/60822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65c69d716a829ea38145d5e075089d1bdf151593 Gerrit-Change-Number: 60822 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022