coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6166 discussions

Change in coreboot[master]: drivers/wifi/generic: Add new device ID
by Bora Guvendik (Code Review) 02 May '22

02 May '22

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64001 ) Change subject: drivers/wifi/generic: Add new device ID ...................................................................... drivers/wifi/generic: Add new device ID New device id 0x51f1 is added. Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: I695309d529a117bad68fc89a7f136e69cecb95d9 --- M src/drivers/wifi/generic/generic.c M src/include/device/pci_ids.h 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/64001/1 diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index 1187b332..a66656e 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -118,6 +118,7 @@ /* Garfield Peak */ PCI_DID_GrP_6SERIES_1_WIFI, PCI_DID_GrP_6SERIES_2_WIFI, + PCI_DID_GrP_6SERIES_3_WIFI, 0 }; diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 3176986..79decbe 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -4419,6 +4419,7 @@ #define PCI_DID_TyP_6SERIES_WIFI 0x2725 #define PCI_DID_GrP_6SERIES_1_WIFI 0x51f0 #define PCI_DID_GrP_6SERIES_2_WIFI 0x7af0 +#define PCI_DID_GrP_6SERIES_3_WIFI 0x51f1 #define PCI_DID_INTEL_TGL_IPU 0x9a19 #define PCI_DID_INTEL_TGL_H_IPU 0x9a39 -- To view, visit https://review.coreboot.org/c/coreboot/+/64001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I695309d529a117bad68fc89a7f136e69cecb95d9 Gerrit-Change-Number: 64001 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/driver/intel/mipi_camera: Update ACPI entry to provide silicon info
by Bora Guvendik (Code Review) 02 May '22

02 May '22

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64000 ) Change subject: src/driver/intel/mipi_camera: Update ACPI entry to provide silicon info ...................................................................... src/driver/intel/mipi_camera: Update ACPI entry to provide silicon info CPUID_RAPTORLAKE_P_J0 is ES. Add it to generate is_es = 1 in ACPI Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: Ib8d57f7fb0b3d15bc4bcdeae47bfbdde17e13118 --- M src/drivers/intel/mipi_camera/camera.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/64000/1 diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index 5e3c4bb..f7e19ef 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -139,7 +139,7 @@ if (CONFIG(ACPI_ADL_IPU_ES_SUPPORT)) { u32 cpu_id = cpu_get_cpuid(); if (cpu_id == CPUID_ALDERLAKE_J0 || cpu_id == CPUID_ALDERLAKE_Q0 || - cpu_id == CPUID_ALDERLAKE_N_A0) + cpu_id == CPUID_ALDERLAKE_N_A0 || cpu_id == CPUID_RAPTORLAKE_P_J0) acpi_dp_add_integer(dsd, "is_es", 1); else acpi_dp_add_integer(dsd, "is_es", 0); -- To view, visit https://review.coreboot.org/c/coreboot/+/64000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8d57f7fb0b3d15bc4bcdeae47bfbdde17e13118 Gerrit-Change-Number: 64000 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: sc7280: Increase SPI frequency to 50 MHz
by Paul Menzel (Code Review) 02 May '22

02 May '22

Attention is currently required from: Shelley Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63948 ) Change subject: sc7280: Increase SPI frequency to 50 MHz ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63948/comment/e2e4809b_1c55e299 PS2, Line 10: to 50 MHz from 37.5 MHz to 50 Mhz https://review.coreboot.org/c/coreboot/+/63948/comment/7a085138_1bc714ed PS2, Line 14: TEST=build and boot BIOS with this config on herobrine boards Any noticeable speedup? -- To view, visit https://review.coreboot.org/c/coreboot/+/63948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84420d7d8ab0cb979fc606fcf05147197bc51c35 Gerrit-Change-Number: 63948 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Mon, 02 May 2022 18:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Hook up FSP hyper-threading setting to option API
by Subrata Banik (Code Review) 02 May '22

02 May '22

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Michael Niewöhner. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60547 ) Change subject: soc/intel/alderlake: Hook up FSP hyper-threading setting to option API ...................................................................... Patch Set 11: (1 comment) Patchset: PS6: > Could you test this please? what kind of test you are looking Felix ? -- To view, visit https://review.coreboot.org/c/coreboot/+/60547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I520a936b4c3a8997ba2c6bea0126b3bbcc5d68ce Gerrit-Change-Number: 60547 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 02 May 2022 18:32:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/infra/builders.md: Fix markdown inssues
by Martin L Roth (Code Review) 02 May '22

02 May '22

Attention is currently required from: Felix Singer, Angel Pons. Hello Felix Singer, build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63804 to look at the new patch set (#2). Change subject: Documentation/infra/builders.md: Fix markdown inssues ...................................................................... Documentation/infra/builders.md: Fix markdown inssues This fixes the following issues found by the markdown lint tool, mdl: MD014 Dollar signs used before commands without showing output MD026 Trailing punctuation in header MD030 Spaces after list markers MD031 Fenced code blocks should be surrounded by blank lines MD040 Fenced code blocks should have a language specified Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I82317f51c003b2c23d64c3cbbcecbf9a39d5d509 --- M Documentation/infrastructure/builders.md 1 file changed, 55 insertions(+), 54 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/63804/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82317f51c003b2c23d64c3cbbcecbf9a39d5d509 Gerrit-Change-Number: 63804 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/infra/builders.md: Fix markdown inssues
by Martin L Roth (Code Review) 02 May '22

02 May '22

Attention is currently required from: Felix Singer, Angel Pons. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63804 ) Change subject: Documentation/infra/builders.md: Fix markdown inssues ...................................................................... Patch Set 1: (1 comment) File Documentation/infrastructure/builders.md: https://review.coreboot.org/c/coreboot/+/63804/comment/66bb5b21_fcedcae1 PS1, Line 52: Gleefulbuilder - 64 thread, 64GiB RAM > The leading asterisk is gone, does it matter? Yeah, it does. Let me look this over again. ... It looks like the errors had gone away because I completely messed up the markdown. -- To view, visit https://review.coreboot.org/c/coreboot/+/63804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82317f51c003b2c23d64c3cbbcecbf9a39d5d509 Gerrit-Change-Number: 63804 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 02 May 2022 18:32:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: Add EC Mux device
by Prashant Malani (Code Review) 02 May '22

02 May '22

Attention is currently required from: Tim Wawrzynczak, Paul Menzel. Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63792 ) Change subject: ec/google/chromeec: Add EC Mux device ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > > Sure. Which config would be apropriate? `configs/config.google_volteer.build_test_purposes` ? […] OK. Just to clarify, if I add the devices to the override.cb then I *dont* need to select the Kconfig? File src/ec/google/chromeec/mux/Kconfig: https://review.coreboot.org/c/coreboot/+/63792/comment/933a8884_b3f17ed5 PS1, Line 8: which is used > I also marked *which*. It’s a contact clause [1]. Anyway, feel free to improve or leave as is. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/63792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2022810292783583ee5f09ce29a63b96686dbb8 Gerrit-Change-Number: 63792 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 02 May 2022 18:31:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Prashant Malani <pmalani(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Update maximum PCIe and TBT ports and clocks
by Subrata Banik (Code Review) 02 May '22

02 May '22

Attention is currently required from: Michał Żygowski, John Zhao. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63457 ) Change subject: soc/intel/alderlake: Update maximum PCIe and TBT ports and clocks ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I408c815d5a43c081beb3f84d795c2b863ce33eb2 Gerrit-Change-Number: 63457 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Comment-Date: Mon, 02 May 2022 18:26:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add list of boards maintained on each branch
by Martin L Roth (Code Review) 02 May '22

02 May '22

Attention is currently required from: Paul Menzel, Angel Pons, Arthur Heymans, Werner Zeh. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63797 ) Change subject: Documentation: Add list of boards maintained on each branch ...................................................................... Patch Set 2: (2 comments) File Documentation/releases/boards_supported_on_branches.md: https://review.coreboot.org/c/coreboot/+/63797/comment/b9acff53_6b5ace88 PS2, Line 8: release > or commit Done https://review.coreboot.org/c/coreboot/+/63797/comment/9e0bf19d_635b98ca PS2, Line 17: can also be created on request. > Maybe it should also be mentioned, that commits can be backported to these branches? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee25db13e2c1b0b9131fd2032a26ece45aba4f42 Gerrit-Change-Number: 63797 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 02 May 2022 18:23:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add list of boards maintained on each branch
by Martin L Roth (Code Review) 02 May '22

02 May '22

Attention is currently required from: Martin L Roth, Angel Pons, Arthur Heymans, Werner Zeh. Hello build bot (Jenkins), Paul Menzel, Angel Pons, Lean Sheng Tan, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63797 to look at the new patch set (#3). Change subject: Documentation: Add list of boards maintained on each branch ...................................................................... Documentation: Add list of boards maintained on each branch This documents the boards that have been removed from the master branch, and which branch to check out to build or work on them. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iee25db13e2c1b0b9131fd2032a26ece45aba4f42 --- A Documentation/releases/boards_supported_on_branches.md 1 file changed, 326 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/63797/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee25db13e2c1b0b9131fd2032a26ece45aba4f42 Gerrit-Change-Number: 63797 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022