coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support
by Michael Niewöhner (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 ) Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Would you mind basing this on CB:59548, where the structure is as it should be already? I'll push an update File src/mainboard/clevo/tgl-u/bootblock.c: https://review.coreboot.org/c/coreboot/+/62498/comment/da18137b_fa8e3359 PS1, Line 16: if (onoff) { : gpio_set(DGPU_RST_N, 0); : mdelay(4); : gpio_set(DGPU_PWR_EN, 1); : mdelay(4); : gpio_set(DGPU_RST_N, 1); : } else { : gpio_set(DGPU_RST_N, 0); : mdelay(4); : gpio_set(DGPU_PWR_EN, 0); hmm, this looks like non-board-specific, generic code, that should be located in src/driver somewhere -- To view, visit https://review.coreboot.org/c/coreboot/+/62498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Gerrit-Change-Number: 62498 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 19:31:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: treewide: Drop unused Kconfig symbols
by Felix Singer (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Lance Zhao, Patrick Rudolph, Elyes Haouas, Felix Held. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62362 ) Change subject: treewide: Drop unused Kconfig symbols ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96380d4567356c81e17de469fd78cec2fcb7e5c9 Gerrit-Change-Number: 62362 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Mar 2022 19:28:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: Change DDR4 Interleave to Non-Interleave
by Tim Wawrzynczak (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: YH Lin, Zoey Wu, Zhuohao Lee, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62478 ) Change subject: mb/google/brask/variants/moli: Change DDR4 Interleave to Non-Interleave ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/moli/memory.c: https://review.coreboot.org/c/coreboot/+/62478/comment/b9d2d047_08d5da9b PS1, Line 13: You will still need to return this config, e.g. ``` const struct mb_cfg *variant_memory_params(void) { return &ddr4_mem_config; } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/62478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab153f16a3b729e7fa9daaa3dbfbccc70e6d789d Gerrit-Change-Number: 62478 Gerrit-PatchSet: 1 Gerrit-Owner: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Mar 2022 19:16:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpi/acpi: drop weak cpu_get_lapic_addr implementation
by Raul Rangel (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62502 ) Change subject: acpi/acpi: drop weak cpu_get_lapic_addr implementation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffcd8c80260f9a7d81dda41a0ad08bffc7620c33 Gerrit-Change-Number: 62502 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Mar 2022 18:28:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpi/acpi: Use mmio read32 when reading HPET ID
by Raul Rangel (Code Review) 01 Mar '22

01 Mar '22

Raul Rangel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/51304 ) Change subject: acpi/acpi: Use mmio read32 when reading HPET ID ...................................................................... Abandoned Replaced by CB:62297 -- To view, visit https://review.coreboot.org/c/coreboot/+/51304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57427ec45d43a94d5e35463eced3f6d30aab7ef8 Gerrit-Change-Number: 51304 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/amd/common/fsp/fsp_validate.c: print warning instead of error
by Name of user not set (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Marshall Dawson, Paul Menzel, Fred Reitberger, Rob Barnes, Julian Schroeder. Name of user not set #1003801 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62349 ) Change subject: soc/amd/common/fsp/fsp_validate.c: print warning instead of error ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62349/comment/627118c9_a300a05e PS2, Line 10: warning instead of an error. > Why? Is that for CI testing, or is it expected to have such FSP binaries? The FSP spec, IIRC, doesn't require valid image revision info. The older AMD FSPs attempt to provide one but fail and instead put in '1'. I fixed that since but older FSP binaries will still be around for a while. Patchset: PS1: > > No Signed-off-by line in commit message done -- To view, visit https://review.coreboot.org/c/coreboot/+/62349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9c5a387b81205fe93382778090260e41e261776 Gerrit-Change-Number: 62349 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1003801 Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 18:19:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/riscv: Fix build with binutils 2.38
by Elyes Haouas (Code Review) 01 Mar '22

01 Mar '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62491 ) Change subject: arch/riscv: Fix build with binutils 2.38 ...................................................................... Abandoned old binutils do not support 'zicsr' 'zifencei' extensions. Please see 61767 -- To view, visit https://review.coreboot.org/c/coreboot/+/62491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac002a9eab58313f6ecce77a98371c1ad8bf2fe2 Gerrit-Change-Number: 62491 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: crossgcc: Upgrade binutils from 2.37 to 2.38
by Elyes Haouas (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Martin Roth, Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61767 to look at the new patch set (#11). Change subject: crossgcc: Upgrade binutils from 2.37 to 2.38 ...................................................................... crossgcc: Upgrade binutils from 2.37 to 2.38 mips patch is not needed anymore as mips is removed from coreboot. Change-Id: I94a11e52be878b13eae9f00f7d6dc1ab2053693e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/riscv/Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/binutils-2.37_mips-gold.patch R util/crossgcc/patches/binutils-2.38_as-ipxe.patch R util/crossgcc/patches/binutils-2.38_no-bfd-doc.patch R util/crossgcc/patches/binutils-2.38_no-makeinfo.patch D util/crossgcc/sum/binutils-2.37.tar.xz.cksum A util/crossgcc/sum/binutils-2.38.tar.xz.cksum 8 files changed, 51 insertions(+), 88 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/61767/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/61767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94a11e52be878b13eae9f00f7d6dc1ab2053693e Gerrit-Change-Number: 61767 Gerrit-PatchSet: 11 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: acpi/acpi: drop weak cpu_get_lapic_addr implementation
by Felix Held (Code Review) 01 Mar '22

01 Mar '22

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62502 ) Change subject: acpi/acpi: drop weak cpu_get_lapic_addr implementation ...................................................................... acpi/acpi: drop weak cpu_get_lapic_addr implementation All SoCs/chipsets that select ARCH_X86 will end up using the implementation in cpu/x86/lapic/lapic.c, so to avoid confusion, drop the unused weak implementation that returns a different value. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Iffcd8c80260f9a7d81dda41a0ad08bffc7620c33 --- M src/acpi/acpi.c 1 file changed, 0 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/62502/1 diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 4e2b8df..f7545b2 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -224,15 +224,6 @@ return lapic_nmi->length; } -__weak uintptr_t cpu_get_lapic_addr(void) -{ - /* - * If an architecture does not support LAPIC, this weak implementation returns LAPIC - * addr as 0. - */ - return 0; -} - void acpi_create_madt(acpi_madt_t *madt) { acpi_header_t *header = &(madt->header); -- To view, visit https://review.coreboot.org/c/coreboot/+/62502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffcd8c80260f9a7d81dda41a0ad08bffc7620c33 Gerrit-Change-Number: 62502 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/glados: Drop TPM PIRQ
by Matt DeVillier (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Nico Huber, Tim Wawrzynczak. Hello build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62444 to look at the new patch set (#2). Change subject: mb/google/glados: Drop TPM PIRQ ...................................................................... mb/google/glados: Drop TPM PIRQ The Infineon TPM 1.2 used on glados boards doesn't use a PIRQ; Linux only works with 'tpm.tis_interrupts=0" and Windows fails to init the TPM citing a lack of available resources. With the PIRQ removed, both Linux and Windows are happy / the TPM is available for use. Test: build/boot Linux 5.16.x and Windows 11 on google/chell Change-Id: I544695505291bbebe062df636cc8ddd139c08c2b Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/glados/Kconfig M src/mainboard/google/glados/variants/asuka/include/variant/gpio.h M src/mainboard/google/glados/variants/caroline/include/variant/gpio.h M src/mainboard/google/glados/variants/cave/include/variant/gpio.h M src/mainboard/google/glados/variants/chell/include/variant/gpio.h M src/mainboard/google/glados/variants/glados/include/variant/gpio.h M src/mainboard/google/glados/variants/lars/include/variant/gpio.h M src/mainboard/google/glados/variants/sentry/include/variant/gpio.h 8 files changed, 7 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/62444/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I544695505291bbebe062df636cc8ddd139c08c2b Gerrit-Change-Number: 62444 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022