coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/nissa: Add fmd file for nissa
by Reka Norman (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Rizwan Qureshi, Krishna P Bhat D. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62372 ) Change subject: mb/google/nissa: Add fmd file for nissa ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: LGTM, thanks for putting this together. I think this will need a Cq-Depend on a CL updating the CSE binary size, otherwise `emerge-nissa coreboot` will fail. I can upload a CL. -- To view, visit https://review.coreboot.org/c/coreboot/+/62372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24b1c19cb71a54fc916a12668f72193f9689e755 Gerrit-Change-Number: 62372 Gerrit-PatchSet: 4 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 23:12:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: Drop TPM PIRQ
by Tim Wawrzynczak (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Nico Huber, Matt DeVillier. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62444 ) Change subject: mb/google/glados: Drop TPM PIRQ ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: What is ACPI reporting for the IRQ # then? -- To view, visit https://review.coreboot.org/c/coreboot/+/62444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I544695505291bbebe062df636cc8ddd139c08c2b Gerrit-Change-Number: 62444 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 23:09:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add companion device name to WWAN PCIe generic device
by Cliff Huang (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Bora Guvendik, Selma Bensaid. Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62330 to look at the new patch set (#7). Change subject: mb/google/brya: Add companion device name to WWAN PCIe generic device ...................................................................... mb/google/brya: Add companion device name to WWAN PCIe generic device This is to merge PCIe ACPI code to WWAN device. Also, PCI and RTD3 devices are moved to overridetree.cb where WWAN is present. BUG=b:221250331 BRANCH=firmwaBRANCH=firmware-brya-14505.Bre-brya-14505.B TEST= Check that _DSD is added to WWAN device in SSDT for the variants. Check that RTD3 is added to WWAN device in SSDT for the variants. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f --- M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb M src/mainboard/google/brya/variants/brya0/overridetree.cb M src/mainboard/google/brya/variants/brya4es/overridetree.cb M src/mainboard/google/brya/variants/redrix/overridetree.cb M src/mainboard/google/brya/variants/redrix4es/overridetree.cb 5 files changed, 104 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/62330/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/62330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f Gerrit-Change-Number: 62330 Gerrit-PatchSet: 7 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/pcie/generic: Add support to generate code under companion de...
by Cliff Huang (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Paul Menzel. Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62301 to look at the new patch set (#5). Change subject: drivers/pcie/generic: Add support to generate code under companion device instead ...................................................................... drivers/pcie/generic: Add support to generate code under companion device instead Only one ACPI device should be added to a PCIe root port. For the root ports which already have device created, the generated code from this driver needs to be merged to th existing device. By default, this driver will create new device named DEV0. This change allows to generate code under an existing device. ex: (generate code under PXSX): Scope (\_SB.PCI0.RP01.PXSX) { Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") Package (0x01) { Package (0x02) { "UntrustedDevice", One } } }) } BUG=b:221250331 BRANCH=firmwaBRANCH=firmware-brya-14505.Bre-brya-14505.B Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I80634bbfc2927f26f2a55a9c244eca517c437079 --- M src/drivers/pcie/generic/chip.h M src/drivers/pcie/generic/generic.c 2 files changed, 20 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/62301/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80634bbfc2927f26f2a55a9c244eca517c437079 Gerrit-Change-Number: 62301 Gerrit-PatchSet: 5 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Add companion device name to WWAN PCIe generic device
by Cliff Huang (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Bora Guvendik, Selma Bensaid. Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62330 to look at the new patch set (#6). Change subject: mb/google/brya: Add companion device name to WWAN PCIe generic device ...................................................................... mb/google/brya: Add companion device name to WWAN PCIe generic device This is to merge PCIe ACPI code to WWAN device. Also, PCI and RTD3 devices are moved to overridetree.cb where WWAN is present. BUG=b:221250331 BRANCH=firmwaBRANCH=firmware-brya-14505.Bre-brya-14505.B TEST= Check that _DSD is added to WWAN device in SSDT for the variants. Check that RTD3 is added to WWAN device in SSDT for the variants. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f --- M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb M src/mainboard/google/brya/variants/brya0/overridetree.cb M src/mainboard/google/brya/variants/brya4es/overridetree.cb M src/mainboard/google/brya/variants/redrix/overridetree.cb M src/mainboard/google/brya/variants/redrix4es/overridetree.cb 5 files changed, 104 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/62330/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/62330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f Gerrit-Change-Number: 62330 Gerrit-PatchSet: 6 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: timestamps: Rename timestamps to make names more consistent
by Tim Wawrzynczak (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Raul Rangel, Jakub Czapiga, Angel Pons, Julius Werner, Andrey Petrov, Patrick Rudolph, Jason Glenesk, Damien Zammit, Lee Leahy, Marshall Dawson, Fred Reitberger, Yu-Ping Wu, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62019 ) Change subject: timestamps: Rename timestamps to make names more consistent ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I533e32392224d9b67c37e6a67987b09bf1cf51c6 Gerrit-Change-Number: 62019 Gerrit-PatchSet: 8 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Mar 2022 21:48:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/mainboard: Add QEMU POWER9 to index site
by Felix Singer (Code Review) 01 Mar '22

01 Mar '22

Hello build bot (Jenkins), Matt DeVillier, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62451 to look at the new patch set (#5). Change subject: Documentation/mainboard: Add QEMU POWER9 to index site ...................................................................... Documentation/mainboard: Add QEMU POWER9 to index site The QEMU POWER9 target is supported since coreboot version 4.15. Documentation is available in the tree, but it's not referenced from the mainboard index page. Fix that. Change-Id: Ic3b98735840c146cb0bfb122df0e6f762c2beeca Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/mainboard/index.md 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/62451/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3b98735840c146cb0bfb122df0e6f762c2beeca Gerrit-Change-Number: 62451 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/mainboard: Add Supermicro X9SAE to index site
by Felix Singer (Code Review) 01 Mar '22

01 Mar '22

Hello build bot (Jenkins), Matt DeVillier, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62449 to look at the new patch set (#4). Change subject: Documentation/mainboard: Add Supermicro X9SAE to index site ...................................................................... Documentation/mainboard: Add Supermicro X9SAE to index site The Supermicro X9SAE target is supported since coreboot version 4.15. Documentation is available in the tree, but it's not referenced from the mainboard index page. Fix that. Change-Id: I5d3d0b5b935f1a3ea353a3d9e39208db7c7895ef Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/mainboard/index.md 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/62449/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d3d0b5b935f1a3ea353a3d9e39208db7c7895ef Gerrit-Change-Number: 62449 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation: Fix spelling of "QEMU"
by Felix Singer (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), Matt DeVillier, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62450 to look at the new patch set (#5). Change subject: Documentation: Fix spelling of "QEMU" ...................................................................... Documentation: Fix spelling of "QEMU" Fix spelling and use the one from their website qemu.org. Change-Id: I36a88985ce3a7c59b732c1ca3198d86a591de6bd Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/mainboard/emulation/qemu-riscv.md M Documentation/mainboard/index.md 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/62450/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36a88985ce3a7c59b732c1ca3198d86a591de6bd Gerrit-Change-Number: 62450 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation: Fix spelling of "Supermicro"
by Felix Singer (Code Review) 01 Mar '22

01 Mar '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Matt DeVillier, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62448 to look at the new patch set (#2). Change subject: Documentation: Fix spelling of "Supermicro" ...................................................................... Documentation: Fix spelling of "Supermicro" Fix the spelling and use the one from their website supermicro.com Change-Id: Id630d9d130082fb38f9151e0dfb6f6fbb5a2789d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/releases/coreboot-4.15-relnotes.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/62448/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id630d9d130082fb38f9151e0dfb6f6fbb5a2789d Gerrit-Change-Number: 62448 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022