Raul Rangel has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62349 )
Change subject: soc/amd/common/fsp/fsp_validate.c: print warning instead of error
......................................................................
soc/amd/common/fsp/fsp_validate.c: print warning instead of error
If an AMD FSP binary has no valid image revision information, print a
warning instead of an error.
Change-Id: Ie9c5a387b81205fe93382778090260e41e261776
Signed-off-by: Julian Schroeder <julianmarcusschroeder(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62349
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-by: Jason Glenesk <jason.glenesk(a)gmail.com>
Reviewed-by: Raul Rangel <rrangel(a)chromium.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/soc/amd/common/fsp/fsp_validate.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
Raul Rangel: Looks good to me, approved
Jason Glenesk: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/fsp/fsp_validate.c b/src/soc/amd/common/fsp/fsp_validate.c
index d9ff502..0ce59b3 100644
--- a/src/soc/amd/common/fsp/fsp_validate.c
+++ b/src/soc/amd/common/fsp/fsp_validate.c
@@ -27,7 +27,7 @@
/* a coding bug on the AMD FSP side makes this value 1 in
older versions of the FSP.*/
if (hdr->image_revision == 1) {
- printk(BIOS_ERR, "No AMD FSP image revision information available\n");
+ printk(BIOS_WARNING, "No AMD FSP image revision information available\n");
return;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/62349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9c5a387b81205fe93382778090260e41e261776
Gerrit-Change-Number: 62349
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1003801
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: merged
Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao, Nikolai Vyssotski, Rob Barnes, Karthik Ramasubramanian, Karthikeyan Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62482 )
Change subject: amdfwtool: Clear struct match before regular expression matching
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
the regcomp manpage says "Each rm_so element that is not -1 indicates the start offset of the next largest substring match within the string." so I wonder if the default value should be -1 instead of 0
--
To view, visit https://review.coreboot.org/c/coreboot/+/62482
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If14e0923fbb1648d83784eb5dc1411c93227db5a
Gerrit-Change-Number: 62482
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <karthikmit2005(a)gmail.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Attention: Karthikeyan Ramasubramanian <karthikmit2005(a)gmail.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 20:40:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Marshall Dawson, Paul Menzel, Fred Reitberger, Rob Barnes, Julian Schroeder.
Name of user not set #1003801 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62349 )
Change subject: soc/amd/common/fsp/fsp_validate.c: print warning instead of error
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62349/comment/45c66055_94733056
PS2, Line 10: warning instead of an error.
> The FSP spec, IIRC, doesn't require valid image revision info. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/62349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9c5a387b81205fe93382778090260e41e261776
Gerrit-Change-Number: 62349
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1003801
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Julian Schroeder <julianmarcusschroeder(a)gmail.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 20:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Name of user not set #1003801
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Michał Żygowski, Michał Kopeć, Stefan Reinauer.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62497 )
Change subject: payloads/tianocore: Allow custom build parameters for custom builds
......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62497/comment/ecfaa453_d31e2934
PS1, Line 7: for custom builds
I'd just drop that
https://review.coreboot.org/c/coreboot/+/62497/comment/68e0a8f3_f588457a
PS1, Line 9:
,
https://review.coreboot.org/c/coreboot/+/62497/comment/724fc117_2630308a
PS1, Line 9: allowed
what do you mean by allowed?
https://review.coreboot.org/c/coreboot/+/62497/comment/0e3e0544_43342aba
PS1, Line 10: na
a
https://review.coreboot.org/c/coreboot/+/62497/comment/714054b8_bc7d9e17
PS1, Line 11: comamnd
command
Patchset:
PS1:
This change could be separated from the patch train, so we can get it in faster :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/62497
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I025459ae94592103b4be0c68b422100b7c649d34
Gerrit-Change-Number: 62497
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Tue, 01 Mar 2022 20:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62496 )
Change subject: drivers/gfx/nvidia: Add Optimus driver based on Intel PCIe RTD3
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
so, we have two drivers for the same thing now, I guess? :/ CB:57034
--
To view, visit https://review.coreboot.org/c/coreboot/+/62496
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bc6ec7a6a3e18417537b1f092a29972e9875282
Gerrit-Change-Number: 62496
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 20:28:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć, Christian Walter.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62493 )
Change subject: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62493/comment/64557b8b_4f3b6404
PS1, Line 13: TEST=Boot Windows 11 on Clevo NV41MZ and see the TPm is detected
what about Linux?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62493
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0b3136e3eb8eb1bb132132a5f3a7034bdd3b424
Gerrit-Change-Number: 62493
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 20:25:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Dtrain Hsu, Nick Vaccaro, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62364 )
Change subject: mb/google/brya/var/kinox: update gpio settings
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62364
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I939bc5f8963e9cba762adeb4828729fd14e29520
Gerrit-Change-Number: 62364
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Tue, 01 Mar 2022 20:08:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Ren Kuo, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62466 )
Change subject: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 sku
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62466/comment/154d456d_1cbd5835
PS2, Line 9: Update TDP PL1, PL2, and PL4 for U28 sku
suggestion:
```
Based on testing results from the thermal team, they have decided
to update PL1, PL2 and PL4 for U28 SKUs.
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/62466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82e2dbacd6cbc39390eb28f27ca9db48d6c215c
Gerrit-Change-Number: 62466
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 19:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62347 )
Change subject: soc/amd/common/psp_verstage: Save transfer buffer during S0i3 resume
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62347
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d3b34c90e0e18609b0c6a0cdedab35aeefbd84b
Gerrit-Change-Number: 62347
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 01 Mar 2022 19:33:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment