Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58334 )
Change subject: soc/amd/common: move FCH IOAPIC and HPET init from SMBUs to LPC device
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> same question for sb/amd/agesa
maybe i'll do that in another patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/58334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I585afd463c1c00cd87ced0617e7802503c5deba5
Gerrit-Change-Number: 58334
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:27:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Name of user not set #1004172 has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62418 )
Change subject: payload/tianocore: Add option to build 9elements's UefiPayloadPkg fork
......................................................................
Abandoned
This is not needed, this can make by user will be compilling choice repositories using custom repo.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62418
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I932ebe03f9162c29109a3ea54133fa8ff5f28bad
Gerrit-Change-Number: 62418
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1004172
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon
Attention is currently required from: Arthur Heymans, Julius Werner, ron minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry
......................................................................
Patch Set 5:
(15 comments)
File util/cbfstool/linux_trampoline.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/25e5c410_798025c1
PS5, Line 6: 0xcb, 0x0f, 0x84, 0xc5, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83,
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/3097ff32_205be5eb
PS5, Line 6: 0xcb, 0x0f, 0x84, 0xc5, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/54423820_39b9fe5f
PS5, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2f, 0x83, 0x7f,
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/7f389419_2c1e29be
PS5, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2f, 0x83, 0x7f,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/16f0c88d_36100031
PS5, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x12, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43,
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/7edd22f0_f1034959
PS5, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x12, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/ea5dd1a7_207c6b52
PS5, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0xeb, 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04,
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/b9b7cda9_5ebd1e54
PS5, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0xeb, 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/db96eb85_8b531c89
PS5, Line 15: 0x49, 0x0f, 0x85, 0x78, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff,
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/1b6779bf_e55faeee
PS5, Line 15: 0x49, 0x0f, 0x85, 0x78, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/f0e6fd13_ccd49e51
PS5, Line 16: 0xff, 0x00, 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00,
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/a3f7c56c_b5c41935
PS5, Line 16: 0xff, 0x00, 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/d9f4b84d_21a071ef
PS5, Line 17: 0x00, 0xc7, 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01,
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/7496677a_eb6fd592
PS5, Line 17: 0x00, 0xc7, 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071):
https://review.coreboot.org/c/coreboot/+/62574/comment/400d4f44_99f34232
PS5, Line 18: 0x10, 0xbe, 0x00, 0x00, 0x09, 0x00, 0xff, 0x25, 0x14, 0x02, 0x09, 0x00, 0xf4, 0xeb, 0xfd
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/62574
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I688b94608b03b0177c42d2834c7e3beb802ae686
Gerrit-Change-Number: 62574
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:24:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Nikolai Vyssotski, Rob Barnes, Karthik Ramasubramanian, Karthikeyan Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62482 )
Change subject: amdfwtool: Clear struct match before regular expression matching
......................................................................
Patch Set 7:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/62482/comment/144fdd4a_3038571c
PS7, Line 483: regmatch_t match[N_MATCHES] = {0};
should all elements be initialized to -1 here too? is_valid_entry will overwrite all before those get read, but that would be more consistent
--
To view, visit https://review.coreboot.org/c/coreboot/+/62482
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If14e0923fbb1648d83784eb5dc1411c93227db5a
Gerrit-Change-Number: 62482
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <karthikmit2005(a)gmail.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Attention: Karthikeyan Ramasubramanian <karthikmit2005(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:21:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Julius Werner, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry
......................................................................
Patch Set 5:
(1 comment)
File util/cbfstool/linux_trampoline.c:
https://review.coreboot.org/c/coreboot/+/62574/comment/d5611543_f0495b88
PS4, Line 1: /* This file is automatically generated. Do not manually change */
> Totally off-topic, but should we automate this a bit better (so that we no longer have to check in an opaque hex array and just hope the committer did the right thing)? This sort of thing can be done neatly with the `.incbin` assembly directive (e.g. see https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/rockc… and https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/rockc… for an example).
Same with the flex/bison stuff inside sconfig?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62574
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I688b94608b03b0177c42d2834c7e3beb802ae686
Gerrit-Change-Number: 62574
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62576 )
Change subject: libpayload: Parse the ACPI RSDP table entry
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583cda63c3f0b58f8d198ed5ecea7c4619c7a897
Gerrit-Change-Number: 62576
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:05:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, ron minnich.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry
......................................................................
Patch Set 5:
(1 comment)
File util/cbfstool/linux_trampoline.c:
https://review.coreboot.org/c/coreboot/+/62574/comment/d5bcb3bc_704065a5
PS4, Line 1: /* This file is automatically generated. Do not manually change */
Totally off-topic, but should we automate this a bit better (so that we no longer have to check in an opaque hex array and just hope the committer did the right thing)? This sort of thing can be done neatly with the `.incbin` assembly directive (e.g. see https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/rockc… and https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/rockc… for an example).
--
To view, visit https://review.coreboot.org/c/coreboot/+/62574
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I688b94608b03b0177c42d2834c7e3beb802ae686
Gerrit-Change-Number: 62574
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:04:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62573 )
Change subject: coreboot_tables.c: Expose the ACPI RSDP
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/a7729233_fd83e9fe
PS1, Line 537: lb_add_acpi_rsdp(head);
> > Sorry, I said "something like" because I was too lazy to look it up. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62573
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I591312a2c48f0cbbb03b2787e4b365e9c932afff
Gerrit-Change-Number: 62573
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:02:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, ron minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File util/cbfstool/linux_trampoline.S:
https://review.coreboot.org/c/coreboot/+/62574/comment/41f13e67_2d0309a0
PS4, Line 100: je .endScan
> > Why not a simple `jmp`? We know it's right on this path, isn't it? […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/62574
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I688b94608b03b0177c42d2834c7e3beb802ae686
Gerrit-Change-Number: 62574
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 23:01:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment