Attention is currently required from: Arthur Heymans, Julius Werner, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry ......................................................................
Patch Set 5:
(15 comments)
File util/cbfstool/linux_trampoline.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/25e5c410_798025c1 PS5, Line 6: 0xcb, 0x0f, 0x84, 0xc5, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/3097ff32_205be5eb PS5, Line 6: 0xcb, 0x0f, 0x84, 0xc5, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/54423820_39b9fe5f PS5, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2f, 0x83, 0x7f, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/7f389419_2c1e29be PS5, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2f, 0x83, 0x7f, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/16f0c88d_36100031 PS5, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x12, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/7edd22f0_f1034959 PS5, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x12, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/ea5dd1a7_207c6b52 PS5, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0xeb, 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/b9b7cda9_5ebd1e54 PS5, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0xeb, 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/db96eb85_8b531c89 PS5, Line 15: 0x49, 0x0f, 0x85, 0x78, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/1b6779bf_e55faeee PS5, Line 15: 0x49, 0x0f, 0x85, 0x78, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/f0e6fd13_ccd49e51 PS5, Line 16: 0xff, 0x00, 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/a3f7c56c_b5c41935 PS5, Line 16: 0xff, 0x00, 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/d9f4b84d_21a071ef PS5, Line 17: 0x00, 0xc7, 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/7496677a_eb6fd592 PS5, Line 17: 0x00, 0xc7, 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143071): https://review.coreboot.org/c/coreboot/+/62574/comment/400d4f44_99f34232 PS5, Line 18: 0x10, 0xbe, 0x00, 0x00, 0x09, 0x00, 0xff, 0x25, 0x14, 0x02, 0x09, 0x00, 0xf4, 0xeb, 0xfd please, no spaces at the start of a line