coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Elyes Haouas (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Felix Singer. Elyes Haouas has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/60704 ) Change subject: mb/aopen/dxplplusu/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... Removed Code-Review+2 by Elyes Haouas <ehaouas(a)noos.fr> -- To view, visit https://review.coreboot.org/c/coreboot/+/60704 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae3343e66906a8123b3d8de2b67948f286e4ad32 Gerrit-Change-Number: 60704 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: deleteVote

1 0

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Elyes Haouas (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Felix Singer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60704 ) Change subject: mb/aopen/dxplplusu/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Please see https://review.coreboot.org/q/topic:Get_rid_of_old_asl_syntax+status:open Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/60704 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae3343e66906a8123b3d8de2b67948f286e4ad32 Gerrit-Change-Number: 60704 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 07 Mar 2022 15:35:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: kconfig_lint: Fix rule for duplicate options in choice blocks
by Angel Pons (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Felix Singer, Nico Huber, Martin Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58397 ) Change subject: kconfig_lint: Fix rule for duplicate options in choice blocks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/58397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57733ecae20558ccebe6ac800812c755ff7cb1a8 Gerrit-Change-Number: 58397 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 15:34:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/Kconfig: Drop LINEAR_FRAMEBUFFER kludge
by Angel Pons (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58398 ) Change subject: device/Kconfig: Drop LINEAR_FRAMEBUFFER kludge ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Huh, I'm surprised you can have two symbols with the same name inside a choice. Does it still work when both linear framebuffer types are supported? -- To view, visit https://review.coreboot.org/c/coreboot/+/58398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iead41e26da897a4f2a02d71e8e2678a292e34cb4 Gerrit-Change-Number: 58398 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 15:33:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch/scout: Add i2c HID driver
by Tim Wawrzynczak (Code Review) 07 Mar '22

07 Mar '22

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62591 ) Change subject: mb/google/hatch/scout: Add i2c HID driver ...................................................................... mb/google/hatch/scout: Add i2c HID driver Add HID driver for i2c-1 for Ilitek touchscreen. BRANCH=None BUG=b:187289163 TEST=Build and flash coreboot; confirm an entry for hidraw for I2C-1 for Ilitek touchscreen. Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Signed-off-by: Rehan Ghori <rehang(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62591 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/hatch/variants/scout/gpio.c M src/mainboard/google/hatch/variants/scout/overridetree.cb 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/hatch/variants/scout/gpio.c b/src/mainboard/google/hatch/variants/scout/gpio.c index 218d3db..5515436 100644 --- a/src/mainboard/google/hatch/variants/scout/gpio.c +++ b/src/mainboard/google/hatch/variants/scout/gpio.c @@ -66,6 +66,8 @@ PAD_CFG_GPI_APIC(GPP_D14, NONE, PLTRST, LEVEL, INVERT), /* D15 : USI_RST_L */ PAD_CFG_GPO(GPP_D15, 1, DEEP), + /* D16 TOUCH_INT */ + PAD_CFG_GPI_IRQ_WAKE(GPP_D16, NONE, PLTRST, LEVEL, INVERT), /* E2 : Not connected */ PAD_NC(GPP_E2, NONE), diff --git a/src/mainboard/google/hatch/variants/scout/overridetree.cb b/src/mainboard/google/hatch/variants/scout/overridetree.cb index 1312966..8e6bc77 100644 --- a/src/mainboard/google/hatch/variants/scout/overridetree.cb +++ b/src/mainboard/google/hatch/variants/scout/overridetree.cb @@ -381,7 +381,21 @@ device pci 15.0 off # RFU - Reserved for Future Use. end # I2C #0 - device pci 15.1 on end # I2C #1, USI (Touch screen) + device pci 15.1 on # I2C #1, USI (Touch screen) + chip drivers/i2c/hid + register "generic.hid" = ""ILTK0001"" + register "generic.desc" = ""ILITEK Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "600" + register "generic.wake" = "GPE0_DW2_16" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 41 on end + end + end device pci 15.2 on end # I2C #2, SCALER device pci 15.3 on end # I2C #3, TPU device pci 16.0 on end # Management Engine Interface 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Gerrit-Change-Number: 62591 Gerrit-PatchSet: 8 Gerrit-Owner: Rehan Ghori <rehang(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/tpm/spi: Refactor out some cr50-specific logic
by Tim Wawrzynczak (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Subrata Banik, Christian Walter, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61977 ) Change subject: drivers/tpm/spi: Refactor out some cr50-specific logic ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: ping 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/61977 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie68618cbe026a2b9221f93d0fe41d0b2054e8091 Gerrit-Change-Number: 61977 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Mar 2022 15:23:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Add driver to configure PCIe
by Angel Pons (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu, Jianjun Wang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56792 ) Change subject: soc/mediatek/mt8195: Add driver to configure PCIe ...................................................................... Patch Set 19: Code-Review+1 (1 comment) File src/soc/mediatek/mt8195/pcie.c: https://review.coreboot.org/c/coreboot/+/56792/comment/19162497_d341a67f PS19, Line 23: /* MMIO range (64MB): 0x20000000 ~ 0x24000000 */ : /* Some devices still need io ranges, reserve 16MB for compatibility */ : static struct mtk_pcie_mmio_res pcie_mmio_res_io = { : .cpu_addr = 0x20000000, : .pci_addr = 0x20000000, : .size = 16 * MiB, : .type = IORESOURCE_IO, : }; : : static struct mtk_pcie_mmio_res pcie_mmio_res_mem = { : .cpu_addr = 0x21000000, : .pci_addr = 0x21000000, : .size = 48 * MiB, : .type = IORESOURCE_MEM, : }; These can be const, but CB:56791 needs to be updated to avoid compile-time errors about dropping "const" qualifier. -- To view, visit https://review.coreboot.org/c/coreboot/+/56792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6799c53b03a33be91157ea088d829beb4272976 Gerrit-Change-Number: 56792 Gerrit-PatchSet: 19 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 15:22:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Add PCIe support
by Angel Pons (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Hung-Te Lin, Arthur Heymans, Shelley Chen, Furquan Shaikh, Paul Menzel, Jianjun Wang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56791 ) Change subject: soc/mediatek: Add PCIe support ...................................................................... Patch Set 18: (1 comment) File src/soc/mediatek/common/include/soc/pcie_common.h: https://review.coreboot.org/c/coreboot/+/56791/comment/3cee4f5c_29956215 PS18, Line 20: struct mtk_pcie_mmio_res *mmio_res_io; : struct mtk_pcie_mmio_res *mmio_res_mem; I think you can use read-only pointers (pointers to const) here: const struct mtk_pcie_mmio_res *mmio_res_io; const struct mtk_pcie_mmio_res *mmio_res_mem; These are pointers to `const struct mtk_pcie_mmio_res`. This allows constifying the structs in CB:56792 without getting compile-time errors. -- To view, visit https://review.coreboot.org/c/coreboot/+/56791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9b6adaafa20aeee136372ec9564273f86776da0 Gerrit-Change-Number: 56791 Gerrit-PatchSet: 18 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 15:21:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: .mailmap: Add a .mailmap file for git
by Elyes Haouas (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Felix Singer, Martin Roth, Patrick Georgi, Maxim Polyakov. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61725 ) Change subject: .mailmap: Add a .mailmap file for git ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f9b9bccc9322799234475a1cebf9808edd25693 Gerrit-Change-Number: 61725 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 15:20:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/g505s/irq_tables.c: Use ALIGN_UP macro
by Elyes Haouas (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Mike Banon, Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61919 ) Change subject: mb/lenovo/g505s/irq_tables.c: Use ALIGN_UP macro ...................................................................... Patch Set 1: (1 comment) File src/mainboard/lenovo/g505s/irq_tables.c: https://review.coreboot.org/c/coreboot/+/61919/comment/09f2461a_7a670205 PS1, Line 80: if (sum != pirq->checksum) : pirq->checksum = sum; > the assignment can be done unconditionally and the check be dropped. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/61919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2bd5e09f51918fe4c7e954edf54ab4d9bc629fd1 Gerrit-Change-Number: 61919 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 15:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022