coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/brya/variants/baseboard/brask: Turn off NFC power in S0ix
by Eric Lai (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Tim Wawrzynczak, Alan Huang. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63191 ) Change subject: mb/google/brya/variants/baseboard/brask: Turn off NFC power in S0ix ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/brask/variant.c: https://review.coreboot.org/c/coreboot/+/63191/comment/37aa0c3b_ab0df62e PS2, Line 7: #include <soc/gpio.h> We probably can remove this. -- To view, visit https://review.coreboot.org/c/coreboot/+/63191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69588c82dfde1744c45c7aff3ac05b80bb16a8f3 Gerrit-Change-Number: 63191 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 02:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: qualcomm/sc7280: Add support for edp and mdp driver
by Ravi Kumar Bokka (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Ravi Kumar Bokka. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62370 to look at the new patch set (#5). Change subject: qualcomm/sc7280: Add support for edp and mdp driver ...................................................................... qualcomm/sc7280: Add support for edp and mdp driver - Add support for edp aux read and write. - Update edp panel properties based on edid read. - Configure edp controller and edp phy. BUG=b:182963902,b:216687885 TEST=Validated on qualcomm sc7280 development board. Signed-off-by: Vinod Polimera <quic_vpolimer(a)quicinc.com> Change-Id: I6368e3064548eaead5046b5ca6cd31e1fd498187 --- M src/mainboard/google/herobrine/mainboard.c M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc A src/soc/qualcomm/sc7280/display/edp_aux.c A src/soc/qualcomm/sc7280/display/edp_ctrl.c A src/soc/qualcomm/sc7280/display/edp_phy_7nm.c A src/soc/qualcomm/sc7280/display/mdss.c A src/soc/qualcomm/sc7280/include/soc/display/edp_aux.h A src/soc/qualcomm/sc7280/include/soc/display/edp_ctrl.h A src/soc/qualcomm/sc7280/include/soc/display/edp_phy.h A src/soc/qualcomm/sc7280/include/soc/display/edp_reg.h A src/soc/qualcomm/sc7280/include/soc/display/mdssreg.h 12 files changed, 3,139 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/62370/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6368e3064548eaead5046b5ca6cd31e1fd498187 Gerrit-Change-Number: 62370 Gerrit-PatchSet: 5 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/qualcomm/common: verify size of memchipinfo structure
by Ravi Kumar Bokka (Code Review) 30 Mar '22

30 Mar '22

1 0

Change in coreboot[master]: mb/google/brya/var/banshee: Update the GPP_D12 as USB_C3_LSX_RX
by Frank Wu (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: John Su, YH Lin, Dtrain Hsu, Ian Feng, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Amanda Hwang. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63174 ) Change subject: mb/google/brya/var/banshee: Update the GPP_D12 as USB_C3_LSX_RX ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Hi Google, Could you review and merge the CL? We would like to have the official CPFE FW for next build. -- To view, visit https://review.coreboot.org/c/coreboot/+/63174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38caa76c855e683eb0587eb67ee9abc91af4545d Gerrit-Change-Number: 63174 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 02:10:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/early_init: Fix function return type
by Jianjun Wang (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu, Felix Held. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63190 ) Change subject: soc/mediatek/early_init: Fix function return type ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63190/comment/000fd2b9_848c7df6 PS1, Line 7: soc/mediatek: Fix function type and initialize structure to zero > soc/mediatek/early_init: Fix function return type Done https://review.coreboot.org/c/coreboot/+/63190/comment/026c92d3_a93216cc PS1, Line 9: function type > return type of early_init_get_elapsed_time_us() Done https://review.coreboot.org/c/coreboot/+/63190/comment/ee5ef75d_5c5175bd PS1, Line 9: , and : initialize structure to zero to replace memset. > Move to a separate paragraph. […] Done File src/soc/mediatek/common/early_init.c: https://review.coreboot.org/c/coreboot/+/63190/comment/1556367d_7902b03a PS1, Line 34: early_init_get_elapsed_time_us > What about the caller of this (perst_time_us and min_perst_time_us in soc/mediatek/common/pcie. […] Right, Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/63190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c361828362c2dfec91358ad8a420f5360243da0 Gerrit-Change-Number: 63190 Gerrit-PatchSet: 2 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 02:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/early_init: Fix function return type
by Jianjun Wang (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Hung-Te Lin, Paul Menzel, Jianjun Wang, Felix Held. Hello Hung-Te Lin, build bot (Jenkins), Paul Menzel, Yu-Ping Wu, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63190 to look at the new patch set (#2). Change subject: soc/mediatek/early_init: Fix function return type ...................................................................... soc/mediatek/early_init: Fix function return type Fix return type of early_init_get_elapsed_time_us() to comply with the data type of return value. Also replace memset() with struct initializer. Signed-off-by: Jianjun Wang <jianjun.wang(a)mediatek.com> Fixes: commit 41faa22 (soc/mediatek: Add early_init for passing data across stages) Change-Id: I7c361828362c2dfec91358ad8a420f5360243da0 --- M src/soc/mediatek/common/early_init.c M src/soc/mediatek/common/include/soc/early_init.h M src/soc/mediatek/common/pcie.c 3 files changed, 5 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/63190/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c361828362c2dfec91358ad8a420f5360243da0 Gerrit-Change-Number: 63190 Gerrit-PatchSet: 2 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload: Export PCIe config info from coreboot to libpayload
by Yu-Ping Wu (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Ravi Kumar Bokka, mturney mturney, Arthur Heymans, Furquan Shaikh, Kyösti Mälkki, Prasad Malisetty. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57614 ) Change subject: libpayload: Export PCIe config info from coreboot to libpayload ...................................................................... Patch Set 40: (1 comment) File src/lib/coreboot_table.c: https://review.coreboot.org/c/coreboot/+/57614/comment/f4337613_06386add PS28, Line 505: | > use a logical or, not a bitwise one. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ca2be55b98c8d1b86576072078cdda02ac55940 Gerrit-Change-Number: 57614 Gerrit-PatchSet: 40 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 02:07:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/baseboard/brask: Turn off NFC power in S0ix
by Alan Huang (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Tim Wawrzynczak, Eric Lai. Hello build bot (Jenkins), Tim Wawrzynczak, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63191 to look at the new patch set (#2). Change subject: mb/google/brya/variants/baseboard/brask: Turn off NFC power in S0ix ...................................................................... mb/google/brya/variants/baseboard/brask: Turn off NFC power in S0ix Turn off the NFC power which is controlled by GPP_D3 to save power in S0ix states. For an USB device, the S0ix hook is needed for the on/off operations to take place. BUG=b:202737385 BRANCH=firmware-brya-14505.B TEST=measure the voltage of GPP_D3 in S0ix states Signed-off-by: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Change-Id: I69588c82dfde1744c45c7aff3ac05b80bb16a8f3 --- M src/mainboard/google/brya/variants/brask/include/variant/gpio.h M src/mainboard/google/brya/variants/brask/variant.c 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/63191/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69588c82dfde1744c45c7aff3ac05b80bb16a8f3 Gerrit-Change-Number: 63191 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload/pci: Split PCI interfaces as common and chip related
by Jianjun Wang (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Shelley Chen, Hung-Te Lin, Angel Pons, Yu-Ping Wu. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56789 ) Change subject: libpayload/pci: Split PCI interfaces as common and chip related ...................................................................... Patch Set 37: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56789/comment/488a0380_67129793 PS37, Line 7: libpayload/pci: Split PCI interfaces as common and chip related > libpayload/pci: Add support for MMIO Can we use "Add support for map bus"? It's more like we are adding map bus feature in this change. MMIO sounds more like the ECAM that accesses the configuration space through MMIO space. -- To view, visit https://review.coreboot.org/c/coreboot/+/56789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie74801bd4f3de51cbb574e86cd9bb09931152554 Gerrit-Change-Number: 56789 Gerrit-PatchSet: 37 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 02:01:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Fix function type and initialize structure to zero
by Yu-Ping Wu (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Hung-Te Lin, Paul Menzel, Jianjun Wang, Felix Held. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63190 ) Change subject: soc/mediatek: Fix function type and initialize structure to zero ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63190/comment/c6c99fd6_d96ef2d2 PS1, Line 7: soc/mediatek: Fix function type and initialize structure to zero soc/mediatek/early_init: Fix function return type https://review.coreboot.org/c/coreboot/+/63190/comment/559807ca_8174aa6d PS1, Line 9: function type return type of early_init_get_elapsed_time_us() https://review.coreboot.org/c/coreboot/+/63190/comment/438672b9_4b22a867 PS1, Line 9: , and : initialize structure to zero to replace memset. Move to a separate paragraph. Also replace memset() with struct initializer. File src/soc/mediatek/common/early_init.c: https://review.coreboot.org/c/coreboot/+/63190/comment/a85e6ee9_ed494624 PS1, Line 34: early_init_get_elapsed_time_us What about the caller of this (perst_time_us and min_perst_time_us in soc/mediatek/common/pcie.c)? -- To view, visit https://review.coreboot.org/c/coreboot/+/63190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c361828362c2dfec91358ad8a420f5360243da0 Gerrit-Change-Number: 63190 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 01:59:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022