coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7066 discussions

Change in coreboot[master]: console: Add loglevel prefix to interactive consoles
by Raul Rangel (Code Review) 03 Feb '22

03 Feb '22

Attention is currently required from: Nico Huber, Patrick Georgi, Julius Werner, Kyösti Mälkki. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61306 ) Change subject: console: Add loglevel prefix to interactive consoles ...................................................................... Patch Set 4: (1 comment) File src/console/console.c: https://review.coreboot.org/c/coreboot/+/61306/comment/cb9f4357_aa1ba2b4 PS3, Line 27: line_start > No, I don't think that works... […] You would need to expose `prefix_tx_byte`, or probably better renamed to `interactive_console_tx_byte`. -- To view, visit https://review.coreboot.org/c/coreboot/+/61306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83413475400821f8097ef1819a293ee8926bb0b Gerrit-Change-Number: 61306 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Feb 2022 00:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: console: Add ANSI escape sequences for highlighting
by Julius Werner (Code Review) 03 Feb '22

03 Feb '22

1 0

Change in coreboot[master]: console: Add loglevel prefix to interactive consoles
by Julius Werner (Code Review) 03 Feb '22

03 Feb '22

Attention is currently required from: Raul Rangel, Nico Huber, Patrick Georgi, Kyösti Mälkki. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61306 ) Change subject: console: Add loglevel prefix to interactive consoles ...................................................................... Patch Set 3: (3 comments) File src/commonlib/include/commonlib/loglevel.h: https://review.coreboot.org/c/coreboot/+/61306/comment/79715c51_6bded319 PS3, Line 170: EMERG > Maybe we can add color codes too! […] Right... see the next commit message on why I experimented with but in the end chose not to use color. I want this to "just work" for people without having to understand the details or futz with their terminal, so this seemed like the most reliable way to do it. Also, the problem with color is always that everyone has different terminal preferences, and you can't pick a color scheme that looks good on all backgrounds. If there's enough interest someone could certainly easily add a color option behind a separate Kconfig. Would probably make sense to have at least a "light" and a "dark" theme, then. File src/console/console.c: https://review.coreboot.org/c/coreboot/+/61306/comment/f2fdc53a_de86165e PS3, Line 27: line_start > Let's move this function into printk.c (wrap_putchar). […] No, I don't think that works... I'm trying to deliberately make a distinction between "interactive" and "stored" consoles here, so I don't waste our tight CBMEM console buffers by printing the whole "[DEBUG] " in every line. This file is the only one that has distinction between the underlying consoles, so I think I need to put it here. https://review.coreboot.org/c/coreboot/+/61306/comment/244314ba_48f59923 PS3, Line 60: 0 > nit: false Oops, right. Done. -- To view, visit https://review.coreboot.org/c/coreboot/+/61306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83413475400821f8097ef1819a293ee8926bb0b Gerrit-Change-Number: 61306 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Feb 2022 00:35:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: console: Add ANSI escape sequences for highlighting
by Julius Werner (Code Review) 03 Feb '22

03 Feb '22

Attention is currently required from: Nico Huber, Patrick Georgi, Julius Werner, Kyösti Mälkki. Hello build bot (Jenkins), Raul Rangel, Nico Huber, Patrick Georgi, Kyösti Mälkki, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61307 to look at the new patch set (#4). Change subject: console: Add ANSI escape sequences for highlighting ...................................................................... console: Add ANSI escape sequences for highlighting This patch adds ANSI escape sequences to highlight a log line based on its loglevel to the output of "interactive" consoles that are meant to be displayed on a terminal (e.g. UART). This should help make errors and warnings stand out better among the usual spew of debug messages. For users whose terminal or use case doesn't support these sequences for some reason (or who simply don't like them), they can be disabled with a Kconfig. While ANSI escape sequences can be used to add color, minicom (the presumably most common terminal emulator for UART endpoints?) doesn't support color output unless explicitly enabled (via -c command line flag), and other terminal emulators may have similar restrictions, so in an effort to make this as widely useful by default as possible I have chosen not to use color codes and implement this highlighting via bolding, underlining and inverting alone (which seem to go through in all cases). If desired, support for separate color highlighting could be added via Kconfig later. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: I868f4026918bc0e967c32e14bcf3ac05816415e8 --- M src/commonlib/include/commonlib/loglevel.h M src/console/Kconfig M src/console/console.c 3 files changed, 54 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/61307/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/61307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I868f4026918bc0e967c32e14bcf3ac05816415e8 Gerrit-Change-Number: 61307 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: console: Add loglevel prefix to interactive consoles
by Julius Werner (Code Review) 03 Feb '22

03 Feb '22

Attention is currently required from: Nico Huber, Patrick Georgi, Julius Werner, Kyösti Mälkki. Hello build bot (Jenkins), Raul Rangel, Nico Huber, Patrick Georgi, Kyösti Mälkki, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61306 to look at the new patch set (#4). Change subject: console: Add loglevel prefix to interactive consoles ...................................................................... console: Add loglevel prefix to interactive consoles In an attempt to make loglevels more visible (and therefore useful, hopefully), this patch adds a prefix indicating the log level to every line sent to an "interactive" console (such as a UART). If the code contains a `printk(BIOS_DEBUG, "This is a debug message!\n"), it will now show up as [DEBUG] This is a debug message! on the UART output. "Stored" consoles (such as in CBMEM) will get a similar but more space-efficient feature in a later CL. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: Ic83413475400821f8097ef1819a293ee8926bb0b --- M src/commonlib/include/commonlib/loglevel.h M src/console/console.c M src/console/printk.c M src/include/console/console.h 4 files changed, 68 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/61306/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/61306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83413475400821f8097ef1819a293ee8926bb0b Gerrit-Change-Number: 61306 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/ifdtool: add platform_v1 to reduce common ifd tool change
by Wonkyu Kim (Code Review) 03 Feb '22

03 Feb '22

Wonkyu Kim has removed Stefan Reinauer from this change. ( https://review.coreboot.org/c/coreboot/+/61576 ) Change subject: util/ifdtool: add platform_v1 to reduce common ifd tool change ...................................................................... Removed reviewer Stefan Reinauer. -- To view, visit https://review.coreboot.org/c/coreboot/+/61576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22 Gerrit-Change-Number: 61576 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/brya: Add custom PLD fields to devicetree for brya variants
by Won Chung (Code Review) 02 Feb '22

02 Feb '22

Attention is currently required from: Tim Wawrzynczak, Benson Leung, Prashant Malani. Hello build bot (Jenkins), Tim Wawrzynczak, Benson Leung, Prashant Malani, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61571 to look at the new patch set (#3). Change subject: mb/google/brya: Add custom PLD fields to devicetree for brya variants ...................................................................... mb/google/brya: Add custom PLD fields to devicetree for brya variants BUG=b:216490477 TEST=emerge-brya coreboot Signed-off-by: Won Chung <wonchung(a)google.com> Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51 --- M src/mainboard/google/brya/variants/anahera/overridetree.cb M src/mainboard/google/brya/variants/anahera4es/overridetree.cb M src/mainboard/google/brya/variants/gimble/overridetree.cb M src/mainboard/google/brya/variants/gimble4es/overridetree.cb M src/mainboard/google/brya/variants/kano/overridetree.cb M src/mainboard/google/brya/variants/primus/overridetree.cb M src/mainboard/google/brya/variants/primus4es/overridetree.cb M src/mainboard/google/brya/variants/redrix/overridetree.cb M src/mainboard/google/brya/variants/redrix4es/overridetree.cb M src/mainboard/google/brya/variants/taeko/overridetree.cb M src/mainboard/google/brya/variants/taeko4es/overridetree.cb 11 files changed, 518 insertions(+), 74 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/61571/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/61571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51 Gerrit-Change-Number: 61571 Gerrit-PatchSet: 3 Gerrit-Owner: Won Chung <wonchung(a)google.com> Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org> Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Benson Leung <bleung(a)chromium.org> Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: HACK: Enable color in console
by build bot (Jenkins) (Code Review) 02 Feb '22

02 Feb '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61575 ) Change subject: HACK: Enable color in console ...................................................................... Patch Set 1: (2 comments) File src/console/printk.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139812): https://review.coreboot.org/c/coreboot/+/61575/comment/cc264710_3dd693c8 PS1, Line 82: int i, log_this, color=0; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139812): https://review.coreboot.org/c/coreboot/+/61575/comment/e5c405e6_1aaecfa0 PS1, Line 102: print_color(msg_level,"\x1b[31;33m"); space required after that ',' (ctx:VxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/61575 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6639bf5202525b5fb32e57b9120450a33afed2b Gerrit-Change-Number: 61575 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Feb 2022 23:46:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: add platform_v1 to reduce common ifd tool change
by Wonkyu Kim (Code Review) 02 Feb '22

02 Feb '22

Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61576 ) Change subject: util/ifdtool: add platform_v1 to reduce common ifd tool change ...................................................................... util/ifdtool: add platform_v1 to reduce common ifd tool change TGL, ADL has same ifd tool and future platforms may also use same tool. As TGL, ADL use own names for enabling ifd tool, we need to update ifd tool code for new platforms even if ifd tool is not changed. For avoid unnessary change, use generic platform name(platform_v1) for support future platforms. Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com> Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22 --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/61576/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index ca5d3b8..061d352 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -224,6 +224,7 @@ return CHIPSET_300_SERIES_CANNON_POINT; case PLATFORM_TGL: case PLATFORM_ADL: + case PLATFORM_V1: return CHIPSET_500_600_SERIES_TIGER_ALDER_POINT; case PLATFORM_ICL: return CHIPSET_400_SERIES_ICE_POINT; @@ -253,6 +254,7 @@ PLATFORM_EHL, PLATFORM_ADL, PLATFORM_SKLKBL, + PLATFORM_V1, }; unsigned int i; @@ -1178,6 +1180,7 @@ case PLATFORM_JSL: case PLATFORM_EHL: case PLATFORM_ADL: + case PLATFORM_V1: /* CPU/BIOS can read descriptor and BIOS. */ fmba->flmstr1 |= (1 << REGION_DESC) << rd_shift; fmba->flmstr1 |= (1 << REGION_BIOS) << rd_shift; @@ -1635,6 +1638,7 @@ " ehl - Elkhart Lake\n" " glk - Gemini Lake\n" " icl - Ice Lake\n" + " pv1 - Intel platform v1(intel core 11th and later)\n" " jsl - Jasper Lake\n" " sklkbl - Sky Lake/Kaby Lake\n" " tgl - Tiger Lake\n" @@ -1891,6 +1895,8 @@ platform = PLATFORM_TGL; } else if (!strcmp(optarg, "adl")) { platform = PLATFORM_ADL; + } else if (!strcmp(optarg, "pv1")) { + platform = PLATFORM_V1; } else { fprintf(stderr, "Unknown platform: %s\n", optarg); exit(EXIT_FAILURE); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index 4f63e20..d00eb793 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -58,6 +58,7 @@ PLATFORM_SKLKBL, PLATFORM_TGL, PLATFORM_ADL, + PLATFORM_V1, }; #define LAYOUT_LINELEN 80 -- To view, visit https://review.coreboot.org/c/coreboot/+/61576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22 Gerrit-Change-Number: 61576 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush: Enable PSP port 80s
by Raul Rangel (Code Review) 02 Feb '22

02 Feb '22

Raul Rangel has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61535 ) Change subject: mb/google/guybrush: Enable PSP port 80s ...................................................................... mb/google/guybrush: Enable PSP port 80s Let's re-enable PSP post codes when running PSP verstage. The original reason we disabled POST codes was that it was causing problems during eSPI init in bootblock. Since we now init eSPI in PSP verstage, it's safe to re-enable them. We can now see post codes during S0i3 enter and exit. This will help when debugging resume or suspend hangs. Port 80 writes on suspend: ef000020 ef00ed00 ef00ed01 ef000021 <--new Port 80 writes on resume: 05 eea80025 eea90000 eea90100 eea90200 eea50000 eeae0000 eeae0004 eeaf0000 eeb00000 eec00000 eec00100 eec10000 eec40000 eec40500 eec40200 eefc0000 eefc0100 eec50000 ea00e0fc ea00abc1 ea00e60b ea00e60c ea00abe1 ea00abe2 ea00abe4 ea00abe5 ea00abeb ea00abec ea00abed ea00abee ea00abef ea00e10f ea00e098 ea00e099 ea00abf0 ea00abf2 ea00e10e ea00e60c ea00e101 ea00e090 ea00e091 ea00e098 ea00e099 ea00e098 ea00e099 ea00e100 ea00e60c ea00e0b0 ea00e0b4 ea00e0b7 ea00e60c ea00e0c2 ea00e0c4 ea00e0d3 ea00e60c ea00e10d ea00e0c1 ea00e10c ea00e60c ea00e0c4 e000 eec60000 eec20000 eec20800 b40000 eeb50000 eefc0000 eefc0300 ee070000 eed90000 eed90700 eeda0600 eedd0000 eecb0000 eecf0000 eecf0200 eee30000 eee30900 eee40000 ef000025 BUG=b:215425753 TEST=Boot/suspend/resume guybrush and verify post codes are printed Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ie759f66be2b8ffac19145491a227752d4762a5b9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61535 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Rob Barnes <robbarnes(a)google.com> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/guybrush/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Rob Barnes: Looks good to me, approved diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index b2ce989..43cbdde 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -41,7 +41,7 @@ select PCIEXP_CLK_PM select PCIEXP_COMMON_CLOCK select PCIEXP_L1_SUB_STATE - select PSP_DISABLE_POSTCODES + select PSP_DISABLE_POSTCODES if !VBOOT_STARTS_BEFORE_BOOTBLOCK select PSP_S0I3_RESUME_VERSTAGE if VBOOT_STARTS_BEFORE_BOOTBLOCK select SOC_AMD_CEZANNE select SOC_AMD_COMMON_BLOCK_GRAPHICS_ATIF -- To view, visit https://review.coreboot.org/c/coreboot/+/61535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie759f66be2b8ffac19145491a227752d4762a5b9 Gerrit-Change-Number: 61535 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022