February 2022 - coreboot-gerrit

Change in coreboot[master]: soc/amd/sabrina/Kconfig: remove TODO from SOC_AMD_COMMON_BLOCK_I2C
by Raul Rangel (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61592 ) Change subject: soc/amd/sabrina/Kconfig: remove TODO from SOC_AMD_COMMON_BLOCK_I2C ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90732aa98518010686f73f80bee229b13e9bc89c Gerrit-Change-Number: 61592 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:54:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/designware/dw_i2c: improve CONTROL_SPEED_FS definition
by Raul Rangel (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61591 ) Change subject: drivers/i2c/designware/dw_i2c: improve CONTROL_SPEED_FS definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0881dfcd7703ab6a70a9b1a355d5a93771aebc6 Gerrit-Change-Number: 61591 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:54:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/i2c/i23c_pad_ctr: add & use I23C pad configuration
by Raul Rangel (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61570 ) Change subject: soc/amd/common/block/i2c/i23c_pad_ctr: add & use I23C pad configuration ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/soc/amd/common/block/i2c/Kconfig: https://review.coreboot.org/c/coreboot/+/61570/comment/27c51219_4cd76cef PS2, Line 15: I3C I never even knew this was a thing! -- To view, visit https://review.coreboot.org/c/coreboot/+/61570 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie210c3437f2608d1e9fb99dcb151fc4190721375 Gerrit-Change-Number: 61570 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:53:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Specify Build Directory
by Martin Roth (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Sean Rhodes, Matt DeVillier, Stefan Reinauer. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61572 ) Change subject: payloads/tianocore: Specify Build Directory ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/61572/comment/f701dcfa_f832c3f9 PS1, Line 9: Pass build directory of `Build/coreboot` so all variants will output to the reflow to < 75 characters? Patchset: PS1: If we can have it build somewhere other than the project directory, that'd probably be useful. coreboot's makefile has the variable ${obj} which can be adjusted. Maybe we look at making all of the payloads build in coreboot/build/payloads/<PAYLOAD_NAMD> by default. Not necessary now, and I'm not trying to voluntell you to do this, just a thought. -- To view, visit https://review.coreboot.org/c/coreboot/+/61572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I055f7fb13c7b5f7f1703230e329160da2ef3f137 Gerrit-Change-Number: 61572 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:52:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/haswell: Report SMBIOS memory speed in MT/s
by Angel Pons (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Nico Huber, Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61504 ) Change subject: nb/intel/haswell: Report SMBIOS memory speed in MT/s ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/61504/comment/0d78ca43_5c9ebc9b PS1, Line 7: frequency > speed ? SMBIOS spec agrees with you, updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/61504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If34827fee582ef10057e7540b9d23d8c74bd2a32 Gerrit-Change-Number: 61504 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:52:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/haswell: Report SMBIOS memory speed in MT/s
by Angel Pons (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61504 to look at the new patch set (#2). Change subject: nb/intel/haswell: Report SMBIOS memory speed in MT/s ...................................................................... nb/intel/haswell: Report SMBIOS memory speed in MT/s The memory speed values in SMBIOS tables are expressed in MT/s, not MHz. Adjust the reported frequency values accordingly. Change-Id: If34827fee582ef10057e7540b9d23d8c74bd2a32 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/haswell/haswell_mrc/raminit.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/61504/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If34827fee582ef10057e7540b9d23d8c74bd2a32 Gerrit-Change-Number: 61504 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/graphics: Create Kconfig for shifting graphic memory base
by Ethan Tsao (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Nico Huber, Ethan Tsao, Wonkyu Kim, Ravishankar Sarawadi, Tim Wawrzynczak, Paul Menzel, Raj Astekar, Patrick Rudolph. Hello build bot (Jenkins), Wonkyu Kim, Subrata Banik, Ravishankar Sarawadi, Tim Wawrzynczak, Paul Menzel, Raj Astekar, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61389 to look at the new patch set (#15). Change subject: soc/intel/graphics: Create Kconfig for shifting graphic memory base ...................................................................... soc/intel/graphics: Create Kconfig for shifting graphic memory base create SOC_INTEL_GFX_MEMBASE_OFFSET for platform to shift graphic memory base if required, because it may vary by platfrom. BUG=b:216756721 TEST= Check default offset for existing platform and update platform specific offset in KConfig under soc folder. Change-Id: I6b1e34ada9b895dabcdc8116d2470e8831ed0a9e Signed-off-by: Ethan Tsao <ethan.tsao(a)intel.com> --- M src/soc/intel/common/block/graphics/Kconfig M src/soc/intel/common/block/graphics/graphics.c 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/61389/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/61389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b1e34ada9b895dabcdc8116d2470e8831ed0a9e Gerrit-Change-Number: 61389 Gerrit-PatchSet: 15 Gerrit-Owner: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/external/GRUB2: make modules configurable
by Martin Roth (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Marty E. Plummer. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23339 ) Change subject: payloads/external/GRUB2: make modules configurable ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Needs to be rebased, but let's get this merged if it still makes sense. -- To view, visit https://review.coreboot.org/c/coreboot/+/23339 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9203f164277a53946bb29ef2f2bc4b45a48b52cf Gerrit-Change-Number: 23339 Gerrit-PatchSet: 6 Gerrit-Owner: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:38:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Rework Makefile
by Martin Roth (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Sean Rhodes, Andy Pont, Stefan Reinauer. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61550 ) Change subject: payloads/tianocore: Rework Makefile ...................................................................... Patch Set 8: (6 comments) File payloads/external/tianocore/Kconfig: https://review.coreboot.org/c/coreboot/+/61550/comment/f490f9d2_4c2a5df2 PS8, Line 9: config TIANOCORE_REPOSITORY : string "URL to git repository for edk2" : default "https://github.com/tianocore/edk2" if TIANOCORE_UPSTREAM : default "https://github.com/mrchromebox/edk2" I think this should default to "https://review.coreboot.org/edk2", which should in theory be a superset of the mrchromebox repo. https://review.coreboot.org/c/coreboot/+/61550/comment/9c8ea935_2c60fd8f PS8, Line 14: TIANOCORE_TAG since this doesn't need to be a tag, maybe TIANOCORE_TAG_OR_REV ? https://review.coreboot.org/c/coreboot/+/61550/comment/d8119693_a6b23b06 PS8, Line 82: Disabling this option, which will reserve memory above 4G, I think this could be phrased better - Though it's probable that nobody will misunderstand, It seems to be saying that disabling the option will enable the memory above 4G. maybe "Disabling memory above 4G is useful..." https://review.coreboot.org/c/coreboot/+/61550/comment/4976f313_48eb7d36 PS8, Line 128: without an internal with an external display? https://review.coreboot.org/c/coreboot/+/61550/comment/cafd8529_a9edcc83 PS8, Line 136: by ~220KB. This will probably change in the future, so maybe say something like "as of Jan 2022, this increases..." File payloads/external/tianocore/Makefile: https://review.coreboot.org/c/coreboot/+/61550/comment/f86e5aee_ebe8a030 PS8, Line 26: -D A Nit: I think we usually prefer to have -D options without the space. I don't think it's particularly important, and I see that it wasn't that way in the old makefile, but I thought I'd mention it. -- To view, visit https://review.coreboot.org/c/coreboot/+/61550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic52e0afa7744f4a902274c41aed59ca23fd9f5fc Gerrit-Change-Number: 61550 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:37:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/haswell: Report SMBIOS memory frequency in MT/s
by HAOUAS Elyes (Code Review) Feb. 3, 2022

Feb. 3, 2022

Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61504 ) Change subject: nb/intel/haswell: Report SMBIOS memory frequency in MT/s ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/61504/comment/6b7dc776_e2bdbd77 PS1, Line 7: frequency speed ? -- To view, visit https://review.coreboot.org/c/coreboot/+/61504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If34827fee582ef10057e7540b9d23d8c74bd2a32 Gerrit-Change-Number: 61504 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:36:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0