Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu.
Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70181 )
Change subject: soc/mediatek/mt8188: Add display data path for MIPI output
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70181/comment/edb5e564_d07feb34
PS1, Line 7: Add MIPI panel support for firmware display
> Add display data path for MIPI output
Done
https://review.coreboot.org/c/coreboot/+/70181/comment/facf6ccf_52fde9d5
PS1, Line 9: For geralt project, we also support MIPI panel as our firmware
: display. So add this patch to configure ddp to choose eDP display or
: MIPI panel display.
> fit 72 per line
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/70181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06f38b1889811274588c26e9284da4d502acf38b
Gerrit-Change-Number: 70181
Gerrit-PatchSet: 3
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 06:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70184
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8188: Add support for MIPI panel
......................................................................
soc/mediatek/mt8188: Add support for MIPI panel
We need to add DSI and MIPI_TX settings to support MIPI panel.
BUG=b:244208960
TEST=emerge-geralt coreboot
Change-Id: Ib430939b4fa2d517d006b4c23d399754ef4583ff
Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com>
---
M src/soc/mediatek/mt8188/Makefile.inc
M src/soc/mediatek/mt8188/include/soc/addressmap.h
A src/soc/mediatek/mt8188/include/soc/dsi.h
3 files changed, 74 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/70184/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/70184
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib430939b4fa2d517d006b4c23d399754ef4583ff
Gerrit-Change-Number: 70184
Gerrit-PatchSet: 3
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Xi Chen, Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu.
Hello Xi Chen, Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70183
to look at the new patch set (#3).
Change subject: soc/mediatek: Fix DSI register definition for MT8186
......................................................................
soc/mediatek: Fix DSI register definition for MT8186
The DSI CMDQ offset of MT8186 is different from previous SoCs.
Therefore, we define two versions for DSI register header files. The v1
is for MT8173/MT8183/MT8192 and the v2 is for MT8186/MT8188.
BUG=b:244208960
TEST=build pass
BRANCH=corsola
Change-Id: I3d13ca03b72554ab7be2b194db32a4f961f38dad
Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com>
---
M src/soc/mediatek/common/include/soc/dsi_common.h
A src/soc/mediatek/common/include/soc/dsi_register_v1.h
A src/soc/mediatek/common/include/soc/dsi_register_v2.h
M src/soc/mediatek/mt8173/include/soc/dsi.h
M src/soc/mediatek/mt8183/include/soc/dsi.h
M src/soc/mediatek/mt8186/include/soc/dsi.h
M src/soc/mediatek/mt8192/include/soc/dsi.h
7 files changed, 134 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/70183/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/70183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d13ca03b72554ab7be2b194db32a4f961f38dad
Gerrit-Change-Number: 70183
Gerrit-PatchSet: 3
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu.
Hello Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70181
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8188: Add display data path for MIPI output
......................................................................
soc/mediatek/mt8188: Add display data path for MIPI output
For geralt project, we also support MIPI panel as our firmware display.
So add this patch to configure ddp to choose eDP display or MIPI panel
display.
BUG=b:244208960
TEST=test firmware display pass for both eDP and MIPI panel on MT8188
EVB.
Change-Id: I06f38b1889811274588c26e9284da4d502acf38b
Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com>
---
M src/mainboard/google/geralt/display.c
M src/soc/mediatek/mt8188/ddp.c
M src/soc/mediatek/mt8188/include/soc/ddp.h
3 files changed, 55 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/70181/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/70181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06f38b1889811274588c26e9284da4d502acf38b
Gerrit-Change-Number: 70181
Gerrit-PatchSet: 3
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu.
Hello Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70184
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8188: Add support for MIPI panel
......................................................................
soc/mediatek/mt8188: Add support for MIPI panel
We need to add DSI and MIPI_TX settings to support MIPI panel.
BUG=b:244208960
TEST=emerge-geralt coreboot
Change-Id: Ib430939b4fa2d517d006b4c23d399754ef4583ff
Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com>
---
M src/soc/mediatek/mt8188/Makefile.inc
M src/soc/mediatek/mt8188/include/soc/addressmap.h
A src/soc/mediatek/mt8188/include/soc/dsi.h
3 files changed, 74 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/70184/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70184
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib430939b4fa2d517d006b4c23d399754ef4583ff
Gerrit-Change-Number: 70184
Gerrit-PatchSet: 2
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Xi Chen, Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu.
Hello Xi Chen, Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70183
to look at the new patch set (#2).
Change subject: soc/mediatek: Fix DSI register definition for MT8186
......................................................................
soc/mediatek: Fix DSI register definition for MT8186
The DSI CMDQ offset of MT8186 is different from previous SoCs.
Therefore, we define two versions for DSI register header files. The v1
is for MT8173/MT8183/MT8192 and the v2 is for MT8186/MT8188.
BUG=b:244208960
TEST=build pass
BRANCH=corsola
Change-Id: I3d13ca03b72554ab7be2b194db32a4f961f38dad
Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com>
---
M src/soc/mediatek/common/include/soc/dsi_common.h
A src/soc/mediatek/common/include/soc/dsi_register_v1.h
A src/soc/mediatek/common/include/soc/dsi_register_v2.h
M src/soc/mediatek/mt8173/include/soc/dsi.h
M src/soc/mediatek/mt8183/include/soc/dsi.h
M src/soc/mediatek/mt8186/include/soc/dsi.h
M src/soc/mediatek/mt8192/include/soc/dsi.h
7 files changed, 134 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/70183/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d13ca03b72554ab7be2b194db32a4f961f38dad
Gerrit-Change-Number: 70183
Gerrit-PatchSet: 2
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu.
Hello Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70181
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8188: Add MIPI panel support for firmware display
......................................................................
soc/mediatek/mt8188: Add MIPI panel support for firmware display
For geralt project, we also support MIPI panel as our firmware display.
So add this patch to configure ddp to choose eDP display or MIPI panel
display.
BUG=b:244208960
TEST=test firmware display pass for both eDP and MIPI panel on MT8188
EVB.
Change-Id: I06f38b1889811274588c26e9284da4d502acf38b
Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com>
---
M src/mainboard/google/geralt/display.c
M src/soc/mediatek/mt8188/ddp.c
M src/soc/mediatek/mt8188/include/soc/ddp.h
3 files changed, 55 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/70181/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06f38b1889811274588c26e9284da4d502acf38b
Gerrit-Change-Number: 70181
Gerrit-PatchSet: 2
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset