coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[S] Change in coreboot[master]: drivers/generic/nau8315: Allow custom _HID from config
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Van Chen, Frank Wu, Alan Lee, Dtrain Hsu, Ian Feng, John Hsu, David Lin, Amanda Hwang. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 ) Change subject: drivers/generic/nau8315: Allow custom _HID from config ...................................................................... Patch Set 1: (2 comments) File src/drivers/generic/nau8315/chip.h: https://review.coreboot.org/c/coreboot/+/69965/comment/f2addf78_80c554d6 PS1, Line 7: const char *hid; > Hi Eric, […] correct. File src/drivers/generic/nau8315/nau8315.c: https://review.coreboot.org/c/coreboot/+/69965/comment/677329cc_290d7a30 PS1, Line 29: acpigen_write_name_string("_HID", config->hid); > As #7 description, […] "_HID", nau_hid[config->hid], which you can set enum in device tree. -- To view, visit https://review.coreboot.org/c/coreboot/+/69965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956 Gerrit-Change-Number: 69965 Gerrit-PatchSet: 1 Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com> Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: David Lin <CTLIN0(a)nuvoton.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add support for MIPI panel
by Rex-BC Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70184 ) Change subject: soc/mediatek/mt8188: Add support for MIPI panel ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib430939b4fa2d517d006b4c23d399754ef4583ff Gerrit-Change-Number: 70184 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:28:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/generic/nau8315: Allow custom _HID from config
by David Lin (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Van Chen, Frank Wu, Alan Lee, Dtrain Hsu, Ian Feng, John Hsu, Eric Lai, Amanda Hwang. David Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 ) Change subject: drivers/generic/nau8315: Allow custom _HID from config ...................................................................... Patch Set 1: (2 comments) File src/drivers/generic/nau8315/chip.h: https://review.coreboot.org/c/coreboot/+/69965/comment/76b1ef2b_83f0f9bd PS1, Line 7: const char *hid; > ex: […] Hi Eric, Your idea is to list all support components and assign an array to maintain the the _HID(ACPI ID), right? enum { NAU8825, NAU8315, NAU8318, MAX_HID, } hid; const char* nauhid[MAX_HID]={"10508825", "NVTN2010", "NVTN2012"}; File src/drivers/generic/nau8315/nau8315.c: https://review.coreboot.org/c/coreboot/+/69965/comment/beab67ff_10b42b8c PS1, Line 29: acpigen_write_name_string("_HID", config->hid); > nau_hid[NAU8315]; […] As #7 description, so config->hid = nau_hid[NAU8318]; May I learn the method is applied to all vendors? Besides, does it exist hardcode due to one driver is just fill in one id? so the original method from devicetreee.cb to assign _HID should be more flexible? -- To view, visit https://review.coreboot.org/c/coreboot/+/69965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956 Gerrit-Change-Number: 69965 Gerrit-PatchSet: 1 Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com> Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:25:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/model_206ax: Remove fake lapic device
by Kyösti Mälkki (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Arthur Heymans, Tristan Corrick, Angel Pons, Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59316 ) Change subject: cpu/intel/model_206ax: Remove fake lapic device ...................................................................... Patch Set 20: Code-Review+2 (1 comment) File src/cpu/intel/model_206ax/acpi.c: https://review.coreboot.org/c/coreboot/+/59316/comment/51630d5f_3d975319 PS18, Line 100: struct cpu_intel_model_206ax_config *conf = dev->bus->dev->chip_info; > > Could any of the pointers be NULL? It would be nice to check them just in case. […] Toplevel chip_info would be a pointer to different type of struct, northbridge_intel_sandybridge_config, though? -- To view, visit https://review.coreboot.org/c/coreboot/+/59316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3b1c4ca027e2905535e137691c3e3e60417dbf3 Gerrit-Change-Number: 59316 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:20:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek: Fix DSI register definition for MT8186
by Liju-Clr Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70183 ) Change subject: soc/mediatek: Fix DSI register definition for MT8186 ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70183/comment/4804ad41_80b77a7c PS1, Line 9: for > of Done https://review.coreboot.org/c/coreboot/+/70183/comment/0635ade2_8c44c919 PS1, Line 10: version > versions Done -- To view, visit https://review.coreboot.org/c/coreboot/+/70183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d13ca03b72554ab7be2b194db32a4f961f38dad Gerrit-Change-Number: 70183 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:17:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add display data path for MIPI output
by Liju-Clr Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70181 ) Change subject: soc/mediatek/mt8188: Add display data path for MIPI output ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70181/comment/edb5e564_d07feb34 PS1, Line 7: Add MIPI panel support for firmware display > Add display data path for MIPI output Done https://review.coreboot.org/c/coreboot/+/70181/comment/facf6ccf_52fde9d5 PS1, Line 9: For geralt project, we also support MIPI panel as our firmware : display. So add this patch to configure ddp to choose eDP display or : MIPI panel display. > fit 72 per line Done -- To view, visit https://review.coreboot.org/c/coreboot/+/70181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06f38b1889811274588c26e9284da4d502acf38b Gerrit-Change-Number: 70181 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:17:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add support for MIPI panel
by Liju-Clr Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70184 to look at the new patch set (#3). Change subject: soc/mediatek/mt8188: Add support for MIPI panel ...................................................................... soc/mediatek/mt8188: Add support for MIPI panel We need to add DSI and MIPI_TX settings to support MIPI panel. BUG=b:244208960 TEST=emerge-geralt coreboot Change-Id: Ib430939b4fa2d517d006b4c23d399754ef4583ff Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> --- M src/soc/mediatek/mt8188/Makefile.inc M src/soc/mediatek/mt8188/include/soc/addressmap.h A src/soc/mediatek/mt8188/include/soc/dsi.h 3 files changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/70184/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/70184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib430939b4fa2d517d006b4c23d399754ef4583ff Gerrit-Change-Number: 70184 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/mediatek: Fix DSI register definition for MT8186
by Liju-Clr Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu. Hello Xi Chen, Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70183 to look at the new patch set (#3). Change subject: soc/mediatek: Fix DSI register definition for MT8186 ...................................................................... soc/mediatek: Fix DSI register definition for MT8186 The DSI CMDQ offset of MT8186 is different from previous SoCs. Therefore, we define two versions for DSI register header files. The v1 is for MT8173/MT8183/MT8192 and the v2 is for MT8186/MT8188. BUG=b:244208960 TEST=build pass BRANCH=corsola Change-Id: I3d13ca03b72554ab7be2b194db32a4f961f38dad Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> --- M src/soc/mediatek/common/include/soc/dsi_common.h A src/soc/mediatek/common/include/soc/dsi_register_v1.h A src/soc/mediatek/common/include/soc/dsi_register_v2.h M src/soc/mediatek/mt8173/include/soc/dsi.h M src/soc/mediatek/mt8183/include/soc/dsi.h M src/soc/mediatek/mt8186/include/soc/dsi.h M src/soc/mediatek/mt8192/include/soc/dsi.h 7 files changed, 134 insertions(+), 45 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/70183/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/70183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d13ca03b72554ab7be2b194db32a4f961f38dad Gerrit-Change-Number: 70183 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add display data path for MIPI output
by Liju-Clr Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu. Hello Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70181 to look at the new patch set (#3). Change subject: soc/mediatek/mt8188: Add display data path for MIPI output ...................................................................... soc/mediatek/mt8188: Add display data path for MIPI output For geralt project, we also support MIPI panel as our firmware display. So add this patch to configure ddp to choose eDP display or MIPI panel display. BUG=b:244208960 TEST=test firmware display pass for both eDP and MIPI panel on MT8188 EVB. Change-Id: I06f38b1889811274588c26e9284da4d502acf38b Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> --- M src/mainboard/google/geralt/display.c M src/soc/mediatek/mt8188/ddp.c M src/soc/mediatek/mt8188/include/soc/ddp.h 3 files changed, 55 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/70181/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/70181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06f38b1889811274588c26e9284da4d502acf38b Gerrit-Change-Number: 70181 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add support for MIPI panel
by Liju-Clr Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70184 ) Change subject: soc/mediatek/mt8188: Add support for MIPI panel ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70184/comment/3b555a10_9b1a6a42 PS1, Line 7: Add DSI support > `Add support for MIPI panel` ? Done https://review.coreboot.org/c/coreboot/+/70184/comment/f9aa7690_fd647ca2 PS1, Line 9: For MT8188, we > We Done https://review.coreboot.org/c/coreboot/+/70184/comment/c98b38da_e740f760 PS1, Line 9: setting > settings Done https://review.coreboot.org/c/coreboot/+/70184/comment/b990de40_f404e99f PS1, Line 13: emerge-geralt coreboot build pass > emerge-geralt coreboot Done -- To view, visit https://review.coreboot.org/c/coreboot/+/70184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib430939b4fa2d517d006b4c23d399754ef4583ff Gerrit-Change-Number: 70184 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:11:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022