coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: soc/mediatek: Fix DSI register definition for MT8186
by Yu-Ping Wu (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70183 ) Change subject: soc/mediatek: Fix DSI register definition for MT8186 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d13ca03b72554ab7be2b194db32a4f961f38dad Gerrit-Change-Number: 70183 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 07:30:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Add display data path for MIPI output
by Yu-Ping Wu (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70181 ) Change subject: soc/mediatek/mt8188: Add display data path for MIPI output ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06f38b1889811274588c26e9284da4d502acf38b Gerrit-Change-Number: 70181 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 07:30:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: lint/checkpatch: Update Check for illegal assignment in if conditional
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70203 ) Change subject: lint/checkpatch: Update Check for illegal assignment in if conditional ...................................................................... lint/checkpatch: Update Check for illegal assignment in if conditional This reduce the difference with linux v6.1-rc7. Change-Id: I74709e68a62f9a88275ea67beba2933af0f3f519 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/checkpatch.pl 1 file changed, 52 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/70203/1 diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 296ab13..744c350 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -5228,10 +5228,34 @@ defined($stat) && defined($cond) && $line =~ /\b(?:if|while|for)\s*$/ && $line !~ /^.\s*#/) { my ($s, $c) = ($stat, $cond); + my $fixed_assign_in_if = 0; if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) { - ERROR("ASSIGN_IN_IF", - "do not use assignment in if condition\n" . $herecurr); + if (ERROR("ASSIGN_IN_IF", + "do not use assignment in if condition\n" . $herecurr) && + $fix && $perl_version_ok) { + if ($rawline =~ /^\+(\s+)if\s*\(\s*(\!)?\s*\(\s*(($Lval)\s*=\s*$LvalOrFunc)\s*$\s*(?:($Compare)\s*($FuncArg))?\s*\)\s*(\{)?\s*$/) { + my $space = $1; + my $not = $2; + my $statement = $3; + my $assigned = $4; + my $test = $8; + my $against = $9; + my $brace = $15; + fix_delete_line($fixlinenr, $rawline); + fix_insert_line($fixlinenr, "$space$statement;"); + my $newline = "${space}if ("; + $newline .= '!' if defined($not); + $newline .= '(' if (defined $not && defined($test) && defined($against)); + $newline .= "$assigned"; + $newline .= " $test $against" if (defined($test) && defined($against)); + $newline .= ')' if (defined $not && defined($test) && defined($against)); + $newline .= ')'; + $newline .= " {" if (defined($brace)); + fix_insert_line($fixlinenr + 1, $newline); + $fixed_assign_in_if = 1; + } + } } # Find out what is on the end of the line after the @@ -5253,8 +5277,20 @@ $stat_real = "[...]\n$stat_real"; } - ERROR("TRAILING_STATEMENTS", - "trailing statements should be on next line\n" . $herecurr . $stat_real); + if (ERROR("TRAILING_STATEMENTS", + "trailing statements should be on next line\n" . $herecurr . $stat_real) && + !$fixed_assign_in_if && + $cond_lines == 0 && + $fix && $perl_version_ok && + $fixed[$fixlinenr] =~ /^\+(\s*)((?:if|while|for)\s*$balanced_parens)\s*(.*)$/) { + my $indent = $1; + my $test = $2; + my $rest = rtrim($4); + if ($rest =~ /;$/) { + $fixed[$fixlinenr] = "\+$indent$test"; + fix_insert_line($fixlinenr + 1, "$indent\t$rest"); + } + } } } -- To view, visit https://review.coreboot.org/c/coreboot/+/70203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74709e68a62f9a88275ea67beba2933af0f3f519 Gerrit-Change-Number: 70203 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: lint/checkpatch: Add check for const static or static <non ptr type>
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70202 ) Change subject: lint/checkpatch: Add check for const static or static <non ptr type> ...................................................................... lint/checkpatch: Add check for const static or static <non ptr type> This reduce the difference with linux v6.1-rc7. Change-Id: Ib4b37e130f2edbfe0385f0707a8c910a244bcfc7 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/checkpatch.pl 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/70202/1 diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 03b6851..296ab13 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -4276,6 +4276,18 @@ } } +# check for const static or static <non ptr type> const declarations +# prefer 'static const <foo>' over 'const static <foo>' and 'static <foo> const' + if ($sline =~ /^\+\s*const\s+static\s+($Type)\b/ || + $sline =~ /^\+\s*static\s+($BasicType)\s+const\b/) { + if (WARN("STATIC_CONST", + "Move const after static - use 'static const $1'\n" . $herecurr) && + $fix) { + $fixed[$fixlinenr] =~ s/\bconst\s+static\b/static const/; + $fixed[$fixlinenr] =~ s/\bstatic\s+($BasicType)\s+const\b/static const $1/; + } + } + # check for non-global char *foo[] = {"bar", ...} declarations. if ($line =~ /^.\s+(?:static\s+|const\s+)?char\s+\*\s*\w+\s*\[\s*\]\s*=\s*\{/) { WARN("STATIC_CONST_CHAR_ARRAY", -- To view, visit https://review.coreboot.org/c/coreboot/+/70202 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4b37e130f2edbfe0385f0707a8c910a244bcfc7 Gerrit-Change-Number: 70202 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: lint/checkpatch: Add check for initialized const char arrays
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70201 ) Change subject: lint/checkpatch: Add check for initialized const char arrays ...................................................................... lint/checkpatch: Add check for initialized const char arrays This reduce the difference with linux v6.1-rc7. Change-Id: I9f0e9f12a177c32b401fda74cbb30c5c259b3744 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/drivers/intel/fsp1_1/raminit.c M src/drivers/uart/uart8250io.c M src/drivers/uart/uart8250mem.c M src/lib/ubsan.c M util/lint/checkpatch.pl 5 files changed, 30 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/70201/1 diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c index 7da85d4..4c316a9 100644 --- a/src/drivers/intel/fsp1_1/raminit.c +++ b/src/drivers/intel/fsp1_1/raminit.c @@ -128,7 +128,7 @@ } else { fsp_reserved_bytes = fsp_memory->ResourceLength; printk(BIOS_DEBUG, "Reserving 0x%016lx bytes for FSP\n", - (unsigned long int)fsp_reserved_bytes); + (unsigned long)fsp_reserved_bytes); } /* Display SMM area */ diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c index a7fc346..89ec229 100644 --- a/src/drivers/uart/uart8250io.c +++ b/src/drivers/uart/uart8250io.c @@ -26,14 +26,14 @@ static void uart8250_tx_byte(unsigned int base_port, unsigned char data) { - unsigned long int i = SINGLE_CHAR_TIMEOUT; + unsigned long i = SINGLE_CHAR_TIMEOUT; while (i-- && !uart8250_can_tx_byte(base_port)); outb(data, base_port + UART8250_TBR); } static void uart8250_tx_flush(unsigned int base_port) { - unsigned long int i = FIFO_TIMEOUT; + unsigned long i = FIFO_TIMEOUT; while (i-- && !(inb(base_port + UART8250_LSR) & UART8250_LSR_TEMT)); } @@ -44,7 +44,7 @@ static unsigned char uart8250_rx_byte(unsigned int base_port) { - unsigned long int i = SINGLE_CHAR_TIMEOUT; + unsigned long i = SINGLE_CHAR_TIMEOUT; while (i && !uart8250_can_rx_byte(base_port)) i--; diff --git a/src/drivers/uart/uart8250mem.c b/src/drivers/uart/uart8250mem.c index 19677a8..fcf031e 100644 --- a/src/drivers/uart/uart8250mem.c +++ b/src/drivers/uart/uart8250mem.c @@ -46,7 +46,7 @@ static void uart8250_mem_tx_byte(void *base, unsigned char data) { - unsigned long int i = SINGLE_CHAR_TIMEOUT; + unsigned long i = SINGLE_CHAR_TIMEOUT; while (i-- && !uart8250_mem_can_tx_byte(base)) udelay(1); uart8250_write(base, UART8250_TBR, data); @@ -54,7 +54,7 @@ static void uart8250_mem_tx_flush(void *base) { - unsigned long int i = FIFO_TIMEOUT; + unsigned long i = FIFO_TIMEOUT; while (i-- && !(uart8250_read(base, UART8250_LSR) & UART8250_LSR_TEMT)) udelay(1); } @@ -66,7 +66,7 @@ static unsigned char uart8250_mem_rx_byte(void *base) { - unsigned long int i = SINGLE_CHAR_TIMEOUT; + unsigned long i = SINGLE_CHAR_TIMEOUT; while (i && !uart8250_mem_can_rx_byte(base)) { udelay(1); i--; diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c index 1037b1b..894214ca 100644 --- a/src/lib/ubsan.c +++ b/src/lib/ubsan.c @@ -40,8 +40,8 @@ if (!location || !location->filename) location = &unknown_location; printk(BIOS_ERR, "%s %s:%lu:%lu\n", violation, location->filename, - (unsigned long int)location->line, - (unsigned long int)location->column); + (unsigned long)location->line, + (unsigned long)location->column); die("ubsan: unrecoverable error.\n"); } diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 8756f46..03b6851 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -4248,6 +4248,15 @@ $herecurr); } +# check for initialized const char arrays that should be static const + if ($line =~ /^\+\s*const\s+(char|unsigned\s+char|_*u8|(?:[us]_)?int8_t)\s+\w+\s*\[\s*(?:\w+\s*)?\]\s*=\s*"/) { + if (WARN("STATIC_CONST_CHAR_ARRAY", + "const array should probably be static const\n" . $herecurr) && + $fix) { + $fixed[$fixlinenr] =~ s/(^.\s*)const\b/${1}static const/; + } + } + # check for static char foo[] = "bar" declarations. if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) { WARN("STATIC_CONST_CHAR_ARRAY", -- To view, visit https://review.coreboot.org/c/coreboot/+/70201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f0e9f12a177c32b401fda74cbb30c5c259b3744 Gerrit-Change-Number: 70201 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: lint/checkpatch: Add check for unnecessary <signed> int declarations
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70200 ) Change subject: lint/checkpatch: Add check for unnecessary <signed> int declarations ...................................................................... lint/checkpatch: Add check for unnecessary <signed> int declarations This reduce the difference with linux v6.1-rc7. Change-Id: I64bbc09b531ea217514601386dd517af92aa40f1 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/checkpatch.pl 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/70200/1 diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index e88461f..8756f46 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -4221,6 +4221,26 @@ "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr); } +# check for unnecessary <signed> int declarations of short/long/long long + while ($sline =~ m{\b($TypeMisordered(\s*\*)*|$C90_int_types)\b}g) { + my $type = trim($1); + next if ($type !~ /\bint\b/); + next if ($type !~ /\b(?:short|long\s+long|long)\b/); + my $new_type = $type; + $new_type =~ s/\b\s*int\s*\b/ /; + $new_type =~ s/\b\s*(?:un)?signed\b\s*/ /; + $new_type =~ s/^const\s+//; + $new_type = "unsigned $new_type" if ($type =~ /\bunsigned\b/); + $new_type = "const $new_type" if ($type =~ /^const\b/); + $new_type =~ s/\s+/ /g; + $new_type = trim($new_type); + if (WARN("UNNECESSARY_INT", + "Prefer '$new_type' over '$type' as the int is unnecessary\n" . $herecurr) && + $fix) { + $fixed[$fixlinenr] =~ s/\b\Q$type\E\b/$new_type/; + } + } + # check for static const char * arrays. if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) { WARN("STATIC_CONST_CHAR_ARRAY", -- To view, visit https://review.coreboot.org/c/coreboot/+/70200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64bbc09b531ea217514601386dd517af92aa40f1 Gerrit-Change-Number: 70200 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drivers/generic/nau8315: Allow custom _HID from config
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Van Chen, Frank Wu, Alan Lee, Dtrain Hsu, Ian Feng, John Hsu, David Lin, Amanda Hwang. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 ) Change subject: drivers/generic/nau8315: Allow custom _HID from config ...................................................................... Patch Set 1: (1 comment) File src/drivers/generic/nau8315/nau8315.c: https://review.coreboot.org/c/coreboot/+/69965/comment/e7ca932a_122fed29 PS1, Line 29: acpigen_write_name_string("_HID", config->hid); > Yes, it should get index from devicetree.cb and translate to actually _HID string. […] We can do it in the same patch or you can submit new one. Since I don't know the chip IC name you want. not many device tree need to change I think. -- To view, visit https://review.coreboot.org/c/coreboot/+/69965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956 Gerrit-Change-Number: 69965 Gerrit-PatchSet: 1 Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com> Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:55:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: David Lin <CTLIN0(a)nuvoton.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/generic/nau8315: Allow custom _HID from config
by David Lin (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Van Chen, Frank Wu, Alan Lee, Dtrain Hsu, Ian Feng, John Hsu, Eric Lai, Amanda Hwang. David Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 ) Change subject: drivers/generic/nau8315: Allow custom _HID from config ...................................................................... Patch Set 1: (2 comments) File src/drivers/generic/nau8315/chip.h: https://review.coreboot.org/c/coreboot/+/69965/comment/f07cc834_2388ab19 PS1, Line 7: const char *hid; > correct. I agree your suggestion. File src/drivers/generic/nau8315/nau8315.c: https://review.coreboot.org/c/coreboot/+/69965/comment/0477e340_e49840e1 PS1, Line 29: acpigen_write_name_string("_HID", config->hid); > "_HID", nau_hid[config->hid], which you can set enum in device tree. Yes, it should get index from devicetree.cb and translate to actually _HID string. So would you handle the follow up revise? -- To view, visit https://review.coreboot.org/c/coreboot/+/69965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956 Gerrit-Change-Number: 69965 Gerrit-PatchSet: 1 Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com> Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:49:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: David Lin <CTLIN0(a)nuvoton.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/acpi: Implement DTTS Proposal
by build bot (Jenkins) (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Raul Rangel, Jason Nien, Matt DeVillier, Paul Menzel, Eric Lai, Martin Roth, Tim Van Patten, Eric Peers, LeilaCY Lin, Jason Glenesk, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 ) Change subject: soc/amd/common/acpi: Implement DTTS Proposal ...................................................................... Patch Set 76: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164972): https://review.coreboot.org/c/coreboot/+/68471/comment/388277e3_76502b04 PS76, Line 14: mode. Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/68471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I866e5e497e2936984e713029b5f0b6d54cbc9622 Gerrit-Change-Number: 68471 Gerrit-PatchSet: 76 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:45:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/common: provide a list of D-states to enter LPM
by Subrata Banik (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Tarun Tuli, Eran Mitrani. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 ) Change subject: soc/intel/common: provide a list of D-states to enter LPM ...................................................................... Patch Set 3: (2 comments) File src/soc/intel/common/block/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/70166/comment/28ca55df_685a3586 PS3, Line 450: min_pci_sleep_states shouldn't we do a NULL check here ? File src/soc/intel/common/block/include/intelblocks/acpi.h: https://review.coreboot.org/c/coreboot/+/70166/comment/62262d61_ed1eb9a4 PS3, Line 138: typedef I would avoid doing typedef -- To view, visit https://review.coreboot.org/c/coreboot/+/70166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752 Gerrit-Change-Number: 70166 Gerrit-PatchSet: 3 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 06:40:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022