coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[S] Change in coreboot[master]: Makefile.inc: Use 'Wmissing-include-dirs' command option
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Martin L Roth. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70251 ) Change subject: Makefile.inc: Use 'Wmissing-include-dirs' command option ...................................................................... Makefile.inc: Use 'Wmissing-include-dirs' command option Change-Id: I5a30c3830f30509deaaadc6eaeab0e17bc08565c Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/70251/1 diff --git a/Makefile.inc b/Makefile.inc index f27d4ed..2b282c9 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -415,7 +415,7 @@ CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla -Wold-style-definition -CFLAGS_common += -Wdangling-else -Wduplicated-branches +CFLAGS_common += -Wdangling-else -Wduplicated-branches -Wmissing-include-dirs CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie ifeq ($(CONFIG_COMPILER_GCC),y) -- To view, visit https://review.coreboot.org/c/coreboot/+/70251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a30c3830f30509deaaadc6eaeab0e17bc08565c Gerrit-Change-Number: 70251 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Makefile.inc: Add 'Wduplicated-branches' command option
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70250 ) Change subject: Makefile.inc: Add 'Wduplicated-branches' command option ...................................................................... Makefile.inc: Add 'Wduplicated-branches' command option Change-Id: Ifa16c79f60a5f1506c489d89c94d775c50cc4c80 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/70250/1 diff --git a/Makefile.inc b/Makefile.inc index 3eaabaf..f27d4ed 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -415,7 +415,7 @@ CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla -Wold-style-definition -CFLAGS_common += -Wdangling-else +CFLAGS_common += -Wdangling-else -Wduplicated-branches CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie ifeq ($(CONFIG_COMPILER_GCC),y) -- To view, visit https://review.coreboot.org/c/coreboot/+/70250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa16c79f60a5f1506c489d89c94d775c50cc4c80 Gerrit-Change-Number: 70250 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya: Set power limit values for kano and zydron
by David Wu (Code Review) 01 Dec '22

01 Dec '22

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70238 ) Change subject: mb/google/brya: Set power limit values for kano and zydron ...................................................................... mb/google/brya: Set power limit values for kano and zydron Add the RPL CPU power limits to kano and zydron's power limit table. BUG=b:261127266 BRANCH=brya TEST="emerge-brya coreboot chromeos-bootimage", flash zydron with image-zydron.serial.bin and verify zydron boots successfully to kernel. Change-Id: I369c5d7a9a3db0c3e7184a23b0f159ed715b5a50 Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/kano/ramstage.c M src/mainboard/google/brya/variants/zydron/ramstage.c 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/70238/1 diff --git a/src/mainboard/google/brya/variants/kano/ramstage.c b/src/mainboard/google/brya/variants/kano/ramstage.c index aa48a9d..c0f126f 100644 --- a/src/mainboard/google/brya/variants/kano/ramstage.c +++ b/src/mainboard/google/brya/variants/kano/ramstage.c @@ -9,6 +9,8 @@ { PCI_DID_INTEL_ADL_P_ID_6, 15, 12000, 15000, 40000, 40000, 105000 }, { PCI_DID_INTEL_ADL_P_ID_5, 28, 18000, 20000, 43000, 43000, 105000 }, { PCI_DID_INTEL_ADL_P_ID_3, 28, 18000, 20000, 43000, 43000, 105000 }, + { PCI_DID_INTEL_RPL_P_ID_3, 15, 12000, 15000, 40000, 40000, 114000 }, + { PCI_DID_INTEL_RPL_P_ID_4, 15, 12000, 15000, 40000, 40000, 114000 }, }; void variant_devtree_update(void) diff --git a/src/mainboard/google/brya/variants/zydron/ramstage.c b/src/mainboard/google/brya/variants/zydron/ramstage.c index aa48a9d..c0f126f 100644 --- a/src/mainboard/google/brya/variants/zydron/ramstage.c +++ b/src/mainboard/google/brya/variants/zydron/ramstage.c @@ -9,6 +9,8 @@ { PCI_DID_INTEL_ADL_P_ID_6, 15, 12000, 15000, 40000, 40000, 105000 }, { PCI_DID_INTEL_ADL_P_ID_5, 28, 18000, 20000, 43000, 43000, 105000 }, { PCI_DID_INTEL_ADL_P_ID_3, 28, 18000, 20000, 43000, 43000, 105000 }, + { PCI_DID_INTEL_RPL_P_ID_3, 15, 12000, 15000, 40000, 40000, 114000 }, + { PCI_DID_INTEL_RPL_P_ID_4, 15, 12000, 15000, 40000, 40000, 114000 }, }; void variant_devtree_update(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/70238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I369c5d7a9a3db0c3e7184a23b0f159ed715b5a50 Gerrit-Change-Number: 70238 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/crossgcc: Update GCC from 11.2 to 11.3
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Nico Huber, Martin L Roth, Julius Werner, Arthur Heymans. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70221 ) Change subject: util/crossgcc: Update GCC from 11.2 to 11.3 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Awesome it builds :D -- To view, visit https://review.coreboot.org/c/coreboot/+/70221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663 Gerrit-Change-Number: 70221 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 02 Dec 2022 05:52:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [test]mb/google/brya/var/marasov: avoid boot to OS and then reboot roop
by Frank Chu (Code Review) 01 Dec '22

01 Dec '22

Frank Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70237 ) Change subject: [test]mb/google/brya/var/marasov: avoid boot to OS and then reboot roop ...................................................................... [test]mb/google/brya/var/marasov: avoid boot to OS and then reboot roop BUG=b:260565911 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot chromeos-bootimage Signed-off-by: Frank Chu <Frank_Chu(a)pegatron.corp-partner.google.com> Change-Id: Id1c41bfdca9b752e3f027e6b071629d67aa06761 --- M src/mainboard/google/brya/variants/marasov/overridetree.cb 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/70237/1 diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb index 70787c6..4214a0f 100644 --- a/src/mainboard/google/brya/variants/marasov/overridetree.cb +++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb @@ -49,9 +49,6 @@ }, }" register "sagv" = "SaGv_Enabled" - register "serial_io_i2c_mode" = "{ - [PchSerialIoIndexI2C2] = PchSerialIoDisabled, - }" register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C0 register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Disable USB2_Port 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1c41bfdca9b752e3f027e6b071629d67aa06761 Gerrit-Change-Number: 70237 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/elkhartlake: Move TCO_NO_REBOOT flag support
by Kyösti Mälkki (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Lean Sheng Tan, Werner Zeh. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70151 ) Change subject: soc/intel/elkhartlake: Move TCO_NO_REBOOT flag support ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Is this bit really generic enough across all platforms? I remember back than that it is not, see CB […] If there is a PCI device not supporting bus-mastering and the related PCI command register bit is hard-wired to 0, you would not suggest creating and using a custom pci_def.h (?) file for that chipset just to remove PCI_COMMAND_MASTER? Can't the solution be not calling the function that sets such bit? So far I have not come across separate TCO register specs document from intel to refer to. If some platform leaves a bit reserved or undocumented, does that justify copy-pasting most of TCO support source? Or worse, adjust the names just a bit because preprocessor complaints on conflicts. -- To view, visit https://review.coreboot.org/c/coreboot/+/70151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa08e99761eb735eb2f733b86527867d74ced7d8 Gerrit-Change-Number: 70151 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 05:27:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: Use 'Wold-style-definition'
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Martin L Roth. Hello Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70205 to look at the new patch set (#6). Change subject: Makefile.inc: Use 'Wold-style-definition' ...................................................................... Makefile.inc: Use 'Wold-style-definition' Warn when a definition is using '()' instead of '(void)'. Use of ‘()’ is considered an old-style definition in C1x standards, but probably not in C2x. Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/70205/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/70205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Gerrit-Change-Number: 70205 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Makefile.inc: Use 'Wold-style-definition'
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Martin L Roth. Hello Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70205 to look at the new patch set (#5). Change subject: Makefile.inc: Use 'Wold-style-definition' ...................................................................... Makefile.inc: Use 'Wold-style-definition' Warn when a definition is using '()' instead of '(void)'. Use of ‘()’ is considered an old-style definition in C1x standards, but probably not for C2x. Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/70205/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/70205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Gerrit-Change-Number: 70205 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Makefile.inc: Use 'Wold-style-definition'
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Martin L Roth. Hello Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70205 to look at the new patch set (#4). Change subject: Makefile.inc: Use 'Wold-style-definition' ...................................................................... Makefile.inc: Use 'Wold-style-definition' Warn when a definition is using '()' is used instead of '(void)'. Use of ‘()’ is considered an old-style definition in C1x standards, but probably not for C2x. Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/70205/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/70205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Gerrit-Change-Number: 70205 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update fw_config STORAGE field
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Kevin Chiu, Tarun Tuli, Nick Vaccaro, Ricky Chang. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70223 ) Change subject: mb/google/brya/var/gladios: Update fw_config STORAGE field ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: hmmm, why need this? Since the PCIE is different, and it will turn off if PCI scan nothing. -- To view, visit https://review.coreboot.org/c/coreboot/+/70223 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27baa2ca8c2b334fb81aa87b22c3b7c028c38cd8 Gerrit-Change-Number: 70223 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 05:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022