coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[S] Change in coreboot[master]: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70171 ) Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad ...................................................................... mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad Adjust scl_lcnt, scl_hcnt, sda_hold value for I2C5 to meet touchpad SPEC. BUG=b:260540852 BRANCH=firmware-brya-14505.B TEST=build, checked TP function work normally, and measure the timing meet SPEC tLOW ~1.72 us tHIGH ~0.63 us tHD ~0.69 us fscl 383 kHz Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70171 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Reviewed-by: YH Lin <yueherngl(a)google.com> Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/brya/variants/anahera/overridetree.cb 1 file changed, 33 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified YH Lin: Looks good to me, approved Nick Vaccaro: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb index df7f632..1773e0e 100644 --- a/src/mainboard/google/brya/variants/anahera/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb @@ -66,7 +66,12 @@ .speed = I2C_SPEED_FAST, .rise_time_ns = 650, .fall_time_ns = 400, - .data_hold_time_ns = 50, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 170, + .scl_hcnt = 70, + .sda_hold = 40, + } }, }" register "tcc_offset" = "3" # TCC of 97C -- To view, visit https://review.coreboot.org/c/coreboot/+/70171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Gerrit-Change-Number: 70171 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: google/veyron: Fix add type to function definition
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Paul Menzel, Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70138 ) Change subject: google/veyron: Fix add type to function definition ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70138/comment/255b1460_8cfccd03 PS1, Line 7: Fix add > One of the two? or maybe: "Fix old style function definition"? -- To view, visit https://review.coreboot.org/c/coreboot/+/70138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2efb42e653b0deb56ba6b0c9789764a9cabc552e Gerrit-Change-Number: 70138 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 02 Dec 2022 05:16:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: Use 'Wold-style-definition'
by build bot (Jenkins) (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Martin L Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70205 ) Change subject: Makefile.inc: Use 'Wold-style-definition' ...................................................................... Patch Set 3: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165041): https://review.coreboot.org/c/coreboot/+/70205/comment/1f77cd57_4a88a5d1 PS3, Line 12: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/70205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Gerrit-Change-Number: 70205 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 05:14:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src/ec/intel: Create common code for board_id implementation
by Harsha B R (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Martin L Roth, Subrata Banik, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar. Hello build bot (Jenkins), Martin L Roth, Subrata Banik, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70227 to look at the new patch set (#3). Change subject: src/ec/intel: Create common code for board_id implementation ...................................................................... src/ec/intel: Create common code for board_id implementation This patch creates initial common code structure for board_id implementation for intel rvp platforms. Board_id helps in identifying the platform with respect to CHROME_EC and INTEL_EC (Windows_EC). Changes include 1. Create initial board_id.c and board_id.h 2. Modify the Makefile to include src/ec/intel directory BUG=b:260654043 TEST=Able to build with the patch and boot the mtlrvp platform with the subsequent patches in the train Signed-off-by: Harsha B R <harsha.b.r(a)intel.com> Change-Id: If133f6a72b8c3e1d8811a11f91e4556beb8c16e0 --- M Makefile.inc A src/ec/intel/Makefile.inc A src/ec/intel/board_id.c A src/ec/intel/board_id.h M src/mainboard/intel/mtlrvp/Kconfig 5 files changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/70227/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/70227 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If133f6a72b8c3e1d8811a11f91e4556beb8c16e0 Gerrit-Change-Number: 70227 Gerrit-PatchSet: 3 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-CC: Usha P <usha.p(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Makefile.inc: Use 'Wold-style-definition'
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Martin L Roth. Hello Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70205 to look at the new patch set (#2). Change subject: Makefile.inc: Use 'Wold-style-definition' ...................................................................... Makefile.inc: Use 'Wold-style-definition' Warn when a definition is using '()' is used instead of '(void)'. Use of ‘()’ is considered an old-style definition in C1x standards, but probably not for C2x. Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/70205/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Gerrit-Change-Number: 70205 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/rex: Add MPTS method for WWAN over PCIe
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70229 ) Change subject: mb/google/rex: Add MPTS method for WWAN over PCIe ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: BTW, we should think the https://review.coreboot.org/c/coreboot/+/70146 as well. In Brya, I add the wwan_power.asl as WA. We can come up a way for the both PCIE and USB wwan. -- To view, visit https://review.coreboot.org/c/coreboot/+/70229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ade63cfe0586aee9f03ba816b2590f14dcb610 Gerrit-Change-Number: 70229 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 05:09:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add probed fw_configs to SMBIOS OEM strings
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70228 ) Change subject: mb/google/rex: Add probed fw_configs to SMBIOS OEM strings ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6cb35eb9c0fbe32764ca76bb7a929cc92fc38404 Gerrit-Change-Number: 70228 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 05:06:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: sb/intel/common: Rename and inline {read,write}_pmbaseX()
by Kyösti Mälkki (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Werner Zeh. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70049 ) Change subject: sb/intel/common: Rename and inline {read,write}_pmbaseX() ...................................................................... Patch Set 4: (1 comment) File src/southbridge/intel/common/pmbase.h: https://review.coreboot.org/c/coreboot/+/70049/comment/899e2bbe_65b5d401 PS4, Line 14: #elif CONFIG(TCO_SPACE_NOT_YET_SPLIT) : /* Must let TCO registers 0x60..0x80 through. */ : #define PMSIZE 0x80 : #elif CONFIG(SOC_INTEL_COMMON_BLOCK_TCO_ENABLE_THROUGH_SMBUS) : /* TCO registers 0x60..0x80 moved, these are now GPEs. */ : #define PMSIZE 0x80 > What about […] Well removal of TCO_SPACE_NOT_YET_SPLIT is already in the queue. Once split, TCO registers would no longer use pm_ but tco_ variants, like what soc/intel had already introduced to the tree. We pickup DEFAULT_PMBASE or ACPI_BASE_ADDRESS from <soc/iomap.h> so I might just place the PMSIZE definitions there. -- To view, visit https://review.coreboot.org/c/coreboot/+/70049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3b88e93b9dca298585e6906f92842f4cafab2e2 Gerrit-Change-Number: 70049 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 05:04:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/acpi.c: update ACPI table revisions
by Jonathan Zhang (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Angel Pons. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70245 ) Change subject: acpi/acpi.c: update ACPI table revisions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looks like right now only Xeon uses these two tables? CEDT table is needed when the processor supports CXL root port. All recent server processors (Intel, AMD, ARM) start to support CXL. SRAT table is needed when the system has affinity domains (such as multi socket systems and CXL system). -- To view, visit https://review.coreboot.org/c/coreboot/+/70245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecc3a9892b0f8093013b2a426749e2ec5c00803b Gerrit-Change-Number: 70245 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 04:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/ipmi: Retry ipmi_get_device_id in ipmi_kcs_init
by Jonathan Zhang (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Patrick Rudolph, Johnny Lin, Paul Menzel, Christian Walter, Nill Ge, TangYiwei, Shelly Chang. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69310 ) Change subject: drivers/ipmi: Retry ipmi_get_device_id in ipmi_kcs_init ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b972c905fb0f8223570212432a4a10bd715f3f7 Gerrit-Change-Number: 69310 Gerrit-PatchSet: 3 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: TangYiwei Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 04:41:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022