coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Disable LLVM_INCLUDE_{TESTS,EXAMPLES}
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69942 ) Change subject: util/crossgcc/buildgcc: Disable LLVM_INCLUDE_{TESTS,EXAMPLES} ...................................................................... util/crossgcc/buildgcc: Disable LLVM_INCLUDE_{TESTS,EXAMPLES} Building of LLVM tests and examples is enabled by default, but they are not necessary. Thus disable them. Change-Id: I58b09e276967e97856da65e5876b27f0bae3f0cc Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69942 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 4662742..6eeb6e7 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -849,6 +849,8 @@ -DCLANG_VENDOR="coreboot toolchain v$CROSSGCC_VERSION - " \ -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt" \ -DLLVM_INCLUDE_BENCHMARKS="OFF" \ + -DLLVM_INCLUDE_TESTS="OFF" \ + -DLLVM_INCLUDE_EXAMPLES="OFF" \ -DCMAKE_BUILD_TYPE=Release \ -DLLVM_TARGETS_TO_BUILD="AArch64;ARM;PowerPC;RISCV;X86" \ ../llvm || touch .failed -- To view, visit https://review.coreboot.org/c/coreboot/+/69942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58b09e276967e97856da65e5876b27f0bae3f0cc Gerrit-Change-Number: 69942 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: util/crossgcc/buildgcc: Use one line per configure option
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69941 ) Change subject: util/crossgcc/buildgcc: Use one line per configure option ...................................................................... util/crossgcc/buildgcc: Use one line per configure option To improve the readability and visibility of the configure options, move each of them to a separate line. Change-Id: Ifc39e4d0849d220d85e1d9ce92fc008fec610694 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69941 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc 1 file changed, 90 insertions(+), 38 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 0272691..4662742 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -624,9 +624,11 @@ # shellcheck disable=SC2086 CC="$(hostcc host)" CXX="$(hostcxx host)" \ - ../${GMP_DIR}/configure --disable-shared --enable-fat \ - --prefix="$TARGETDIR" $OPTIONS \ - || touch .failed + ../${GMP_DIR}/configure \ + --disable-shared \ + --enable-fat \ + --prefix="$TARGETDIR" \ + $OPTIONS || touch .failed # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed $MAKE install DESTDIR=$DESTDIR || touch .failed @@ -639,10 +641,12 @@ build_MPFR() { test "$UNAME" = "Darwin" && CFLAGS="$CFLAGS -force_cpusubtype_ALL" CC="$(hostcc host)" CXX="$(hostcxx host)" \ - ../${MPFR_DIR}/configure --disable-shared --prefix="$TARGETDIR" \ + ../${MPFR_DIR}/configure \ + --disable-shared \ + --prefix="$TARGETDIR" \ --infodir="$TARGETDIR/info" \ - --with-gmp="$DESTDIR$TARGETDIR" CFLAGS="$HOSTCFLAGS" || \ - touch .failed + --with-gmp="$DESTDIR$TARGETDIR" \ + CFLAGS="$HOSTCFLAGS" || touch .failed # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed $MAKE install DESTDIR=$DESTDIR || touch .failed @@ -657,10 +661,13 @@ build_MPC() { CC="$(hostcc host)" CXX="$(hostcxx host)" \ - ../${MPC_DIR}/configure --disable-shared --prefix="$TARGETDIR" \ - --infodir="$TARGETDIR/info" --with-mpfr="$DESTDIR$TARGETDIR" \ - --with-gmp="$DESTDIR$TARGETDIR" CFLAGS="$HOSTCFLAGS" || \ - touch .failed + ../${MPC_DIR}/configure \ + --disable-shared \ + --prefix="$TARGETDIR" \ + --infodir="$TARGETDIR/info" \ + --with-mpfr="$DESTDIR$TARGETDIR" \ + --with-gmp="$DESTDIR$TARGETDIR" \ + CFLAGS="$HOSTCFLAGS" || touch .failed # work around build problem of libmpfr.la if [ "$DESTDIR" != "" ]; then @@ -685,14 +692,18 @@ fi # shellcheck disable=SC2086 CC="$(hostcc target)" CXX="$(hostcxx target)" \ - ../binutils-${BINUTILS_VERSION}/configure --prefix="$TARGETDIR" \ - --target=${TARGETARCH} --enable-targets=${TARGETARCH}${ADDITIONALTARGET} \ - --disable-werror --disable-nls --enable-lto \ - --enable-gold --enable-multilib \ + ../binutils-${BINUTILS_VERSION}/configure \ + --prefix="$TARGETDIR" \ + --target=${TARGETARCH} \ + --enable-targets=${TARGETARCH}${ADDITIONALTARGET} \ + --disable-werror \ + --disable-nls \ + --enable-lto \ + --enable-gold \ + --enable-multilib \ ${BINUTILS_OPTIONS} \ CFLAGS="$HOSTCFLAGS" \ - CXXFLAGS="$HOSTCFLAGS" \ - || touch .failed + CXXFLAGS="$HOSTCFLAGS" || touch .failed # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed $MAKE install DESTDIR=$DESTDIR || touch .failed @@ -708,14 +719,21 @@ CXXFLAGS_FOR_BUILD="$HOSTCFLAGS" \ CXXFLAGS_FOR_TARGET="$HOSTCFLAGS -fPIC" \ ../gcc-${GCC_VERSION}/configure \ - --prefix="$TARGETDIR" --libexecdir="$TARGETDIR/lib" \ + --prefix="$TARGETDIR" \ + --libexecdir="$TARGETDIR/lib" \ --enable-bootstrap \ - --disable-werror --disable-nls \ - --disable-shared --disable-multilib \ - --disable-libssp --disable-libquadmath --disable-libcc1 \ + --disable-werror \ + --disable-nls \ + --disable-shared \ + --disable-multilib \ + --disable-libssp \ + --disable-libquadmath \ + --disable-libcc1 \ --disable-libsanitizer \ - ${GCC_OPTIONS} --enable-languages="${LANGUAGES}" \ - --with-gmp="$DESTDIR$TARGETDIR" --with-mpfr="$DESTDIR$TARGETDIR" \ + ${GCC_OPTIONS} \ + --enable-languages="${LANGUAGES}" \ + --with-gmp="$DESTDIR$TARGETDIR" \ + --with-mpfr="$DESTDIR$TARGETDIR" \ --with-mpc="$DESTDIR$TARGETDIR" \ --with-pkgversion="coreboot bootstrap v$CROSSGCC_VERSION" \ && \ @@ -750,19 +768,35 @@ CXXFLAGS="$HOSTCFLAGS $CLANGCXXFLAGS" \ CXXFLAGS_FOR_BUILD="$HOSTCFLAGS $CLANGCXXFLAGS" \ ../gcc-${GCC_VERSION}/configure \ - --prefix="$TARGETDIR" --libexecdir="$TARGETDIR/lib" \ - --target=${TARGETARCH} --disable-werror --disable-shared \ - --enable-lto --enable-plugins --enable-gold --enable-ld=default \ - --disable-libssp --disable-bootstrap --disable-nls \ - --disable-libquadmath --without-headers \ + --prefix="$TARGETDIR" \ + --libexecdir="$TARGETDIR/lib" \ + --target=${TARGETARCH} \ + --disable-werror \ + --disable-shared \ + --enable-lto \ + --enable-plugins \ + --enable-gold \ + --enable-ld=default \ + --disable-libssp \ + --disable-bootstrap \ + --disable-nls \ + --disable-libquadmath \ + --without-headers \ --disable-threads \ - --enable-interwork --enable-multilib --enable-targets=all \ - --disable-libatomic --disable-libcc1 --disable-decimal-float \ - ${GCC_OPTIONS} --enable-languages="${LANGUAGES}" \ + --enable-interwork \ + --enable-multilib \ + --enable-targets=all \ + --disable-libatomic \ + --disable-libcc1 \ + --disable-decimal-float \ + ${GCC_OPTIONS} \ + --enable-languages="${LANGUAGES}" \ --with-system-zlib \ - --with-gmp="$DESTDIR$TARGETDIR" --with-mpfr="$DESTDIR$TARGETDIR" \ + --with-gmp="$DESTDIR$TARGETDIR" \ + --with-mpfr="$DESTDIR$TARGETDIR" \ --with-mpc="$DESTDIR$TARGETDIR" \ - --with-gnu-as --with-gnu-ld \ + --with-gnu-as \ + --with-gnu-ld \ --with-pkgversion="coreboot toolchain v$CROSSGCC_VERSION" \ && \ mkdir -p gcc/$TARGETARCH && \ @@ -810,10 +844,12 @@ ln -nsf "$CRT_DIR" ../compiler-rt ln -nsf "$LLVMCMAKE_DIR" ../cmake - $CMAKE -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX="$DESTDIR$TARGETDIR" \ + $CMAKE -G "Unix Makefiles" \ + -DCMAKE_INSTALL_PREFIX="$DESTDIR$TARGETDIR" \ -DCLANG_VENDOR="coreboot toolchain v$CROSSGCC_VERSION - " \ -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt" \ - -DLLVM_INCLUDE_BENCHMARKS="OFF" -DCMAKE_BUILD_TYPE=Release \ + -DLLVM_INCLUDE_BENCHMARKS="OFF" \ + -DCMAKE_BUILD_TYPE=Release \ -DLLVM_TARGETS_TO_BUILD="AArch64;ARM;PowerPC;RISCV;X86" \ ../llvm || touch .failed # shellcheck disable=SC2086 @@ -835,8 +871,8 @@ build_CMAKE() { CC="$(hostcc host)" CXX="$(hostcxx host)" CFLAGS="$HOSTCFLAGS" \ - ../${CMAKE_DIR}/configure --prefix="$TARGETDIR" \ - || touch .failed + ../${CMAKE_DIR}/configure \ + --prefix="$TARGETDIR" || touch .failed # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed $MAKE install DESTDIR=$DESTDIR || touch .failed @@ -844,8 +880,8 @@ build_NASM() { CC="$(hostcc host)" CXX="$(hostcxx host)" CFLAGS="$HOSTCFLAGS" - ../${NASM_DIR}/configure --prefix="$TARGETDIR" \ - || touch .failed + ../${NASM_DIR}/configure \ + --prefix="$TARGETDIR" || touch .failed # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed $MAKE install DESTDIR=$DESTDIR || touch .failed -- To view, visit https://review.coreboot.org/c/coreboot/+/69941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc39e4d0849d220d85e1d9ce92fc008fec610694 Gerrit-Change-Number: 69941 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Put configure option before target dir
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69940 ) Change subject: util/crossgcc/buildgcc: Put configure option before target dir ...................................................................... util/crossgcc/buildgcc: Put configure option before target dir Change-Id: If1b724f9c9b4d2a8ce166946794c1c0882ad1653 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69940 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Elyes Haouas: Looks good to me, approved diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 5b26922..0272691 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -813,8 +813,9 @@ $CMAKE -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX="$DESTDIR$TARGETDIR" \ -DCLANG_VENDOR="coreboot toolchain v$CROSSGCC_VERSION - " \ -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt" \ - -DLLVM_INCLUDE_BENCHMARKS="OFF" -DCMAKE_BUILD_TYPE=Release ../llvm \ - -DLLVM_TARGETS_TO_BUILD="AArch64;ARM;PowerPC;RISCV;X86" || touch .failed + -DLLVM_INCLUDE_BENCHMARKS="OFF" -DCMAKE_BUILD_TYPE=Release \ + -DLLVM_TARGETS_TO_BUILD="AArch64;ARM;PowerPC;RISCV;X86" \ + ../llvm || touch .failed # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed $MAKE install || touch .failed -- To view, visit https://review.coreboot.org/c/coreboot/+/69940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b724f9c9b4d2a8ce166946794c1c0882ad1653 Gerrit-Change-Number: 69940 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: security/tpm: remove tis_close()
by Julius Werner (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Michał Żygowski, Christian Walter, Krystian Hebel, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68989 ) Change subject: security/tpm: remove tis_close() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9df76adfc21fca9fa1d1af7c40635ec0684ceb0f Gerrit-Change-Number: 68989 Gerrit-PatchSet: 2 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 06:52:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Disable LLVM_INCLUDE_{TESTS,EXAMPLES}
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69942 ) Change subject: util/crossgcc/buildgcc: Disable LLVM_INCLUDE_{TESTS,EXAMPLES} ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58b09e276967e97856da65e5876b27f0bae3f0cc Gerrit-Change-Number: 69942 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 02 Dec 2022 06:47:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Put configure option before target dir
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Felix Singer, Paul Menzel. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69940 ) Change subject: util/crossgcc/buildgcc: Put configure option before target dir ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b724f9c9b4d2a8ce166946794c1c0882ad1653 Gerrit-Change-Number: 69940 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 02 Dec 2022 06:47:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: coreboot_tables: Make existing alignment conventions more explicit
by Julius Werner (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Peter Stuge, Julius Werner, Martin Roth, ron minnich. Hello build bot (Jenkins), Peter Stuge, Martin Roth, ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70158 to look at the new patch set (#2). Change subject: coreboot_tables: Make existing alignment conventions more explicit ...................................................................... coreboot_tables: Make existing alignment conventions more explicit There seem to be some recurring vague concerns about the alignment of coreboot table entries. While the existing implementation has been producing tables with a well-defined alignment (4 bytes) for a long time, the code doesn't always make it very clear. This patch adds an explicit constant to codify that alignment, assertions to check it after each entry, and adds explicit padding to the few entry structures that were relying on compiler padding to return a correct sizeof() value. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: Iaeef29ef255047a855066469e03b5481812e5975 --- M src/commonlib/include/commonlib/coreboot_tables.h M src/lib/coreboot_table.c M tests/lib/coreboot_table-test.c 3 files changed, 40 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/70158/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaeef29ef255047a855066469e03b5481812e5975 Gerrit-Change-Number: 70158 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Peter Stuge <peter(a)stuge.se> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/crossgcc/buildgcc: Use one line per configure option
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Felix Singer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69941 ) Change subject: util/crossgcc/buildgcc: Use one line per configure option ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc39e4d0849d220d85e1d9ce92fc008fec610694 Gerrit-Change-Number: 69941 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Fri, 02 Dec 2022 06:46:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/crossgcc: Update binutils from 2.37 to 2.39
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Felix Singer, Julius Werner. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66920 ) Change subject: util/crossgcc: Update binutils from 2.37 to 2.39 ...................................................................... Patch Set 21: (1 comment) Patchset: PS21: Let give a try to CB:70252 would you rebase on it? -- To view, visit https://review.coreboot.org/c/coreboot/+/66920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34a20a999f7ea624c1add4750fcd116166953dd8 Gerrit-Change-Number: 66920 Gerrit-PatchSet: 21 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Dec 2022 06:43:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: tests: Ignore RWX segment warning
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70252 ) Change subject: tests: Ignore RWX segment warning ...................................................................... tests: Ignore RWX segment warning Ignore RWX segment warning for binutils 2.39. Change-Id: I593eea3bcac8e9e46883b73b25a31e20b4c27c51 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M tests/Makefile.common 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/70252/1 diff --git a/tests/Makefile.common b/tests/Makefile.common index 595f870..964521c 100644 --- a/tests/Makefile.common +++ b/tests/Makefile.common @@ -65,6 +65,9 @@ TEST_LDFLAGS := -L$(cmockaobj)/src -lcmocka -Wl,-rpath=$(cmockaobj)/src TEST_LDFLAGS += -Wl,--gc-sections +# binutils workaround: Disabling warnings about executable stacks and segments +TEST_LDFLAGS += --no-warn-rwx-segments + # Some memlayout symbols don't work with userspace relocation -- disable it. TEST_CFLAGS += -fno-pie -fno-pic TEST_LDFLAGS += -no-pie -- To view, visit https://review.coreboot.org/c/coreboot/+/70252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I593eea3bcac8e9e46883b73b25a31e20b4c27c51 Gerrit-Change-Number: 70252 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022