coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: soc/intel/xeon_sp: Add DMAR IOAPIC entries based on HW
by Jonathan Zhang (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70270 ) Change subject: soc/intel/xeon_sp: Add DMAR IOAPIC entries based on HW ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: Cherry picked and sanity tested on OCP CraterLake server. -- To view, visit https://review.coreboot.org/c/coreboot/+/70270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If90873ac94261e424d1713bdab137eaceb256bba Gerrit-Change-Number: 70270 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 17:39:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Add a method to generate IOAPIC DRAM entries from hw
by Jonathan Zhang (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Lance Zhao, Subrata Banik, Tim Wawrzynczak, Arthur Heymans, Werner Zeh, Kyösti Mälkki. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70267 ) Change subject: acpi/acpi.c: Add a method to generate IOAPIC DRAM entries from hw ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: Cherry picked and sanity tested on OCP CraterLake server. -- To view, visit https://review.coreboot.org/c/coreboot/+/70267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I214557bbe963d1086f35f96efb1cb47950099eb3 Gerrit-Change-Number: 70267 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 17:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp: Read ioapic configuration from hardware
by Jonathan Zhang (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70265 ) Change subject: soc/intel/xeon_sp: Read ioapic configuration from hardware ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Patchset: PS9: Hi Arthur, I suppose you tested this on DeltaLake? I did a sanity test on CraterLake with our rebase code base, looks fine to me. -- To view, visit https://review.coreboot.org/c/coreboot/+/70265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6423ddc139d742879d791b054ea082768749c0a7 Gerrit-Change-Number: 70265 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 17:37:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: [RFC] Pcode mailbox unavailable before FSP silicon
by Jérémy Compostella (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Anil Kumar K, Tarun Tuli, Nico Huber, Jeremy Compostella, Angel Pons. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/69341 ) Change subject: [RFC] Pcode mailbox unavailable before FSP silicon ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/69341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I0514e404a7b580d1e35af7b39c1bd77183f11058 Gerrit-Change-Number: 69341 Gerrit-PatchSet: 3 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)intel.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 17:24:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: google/skyrim/Kconfig: Enable DPTC for Morthal
by Tim Van Patten (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Jason Nien, Martin Roth, Tim Van Patten. Hello build bot (Jenkins), Raul Rangel, Jason Nien, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70216 to look at the new patch set (#2). Change subject: google/skyrim/Kconfig: Enable DPTC for Morthal ...................................................................... google/skyrim/Kconfig: Enable DPTC for Morthal Enable SOC_AMD_COMMON_BLOCK_ACPI_DPTC for Morthal boards, to enable support for the low/no battery boot feature. BUG=b:217911928 TEST=build_packages --board=skyrim chromeos-bootimage --autosetgov Change-Id: I3eb6bee6601e34420a90f33f8f2c45cf3fe37f9b Signed-off-by: Tim Van Patten <timvp(a)google.com> --- M src/mainboard/google/skyrim/Kconfig.name 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/70216/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eb6bee6601e34420a90f33f8f2c45cf3fe37f9b Gerrit-Change-Number: 70216 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: google/skyrim/Kconfig: Enable DPTC for Frostflow
by Tim Van Patten (Code Review) 02 Dec '22

02 Dec '22

Tim Van Patten has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/70215 ) Change subject: google/skyrim/Kconfig: Enable DPTC for Frostflow ...................................................................... Abandoned Already landed: 69931: mb/google/skyrim/var/frostflow: Enable DPTC support | https://review.coreboot.org/c/coreboot/+/69931 -- To view, visit https://review.coreboot.org/c/coreboot/+/70215 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2fb5c711a01a995c805eb4509f7b04bb41588365 Gerrit-Change-Number: 70215 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/amd/mayan: Improve naming of EC FW
by Fred Reitberger (Code Review) 02 Dec '22

02 Dec '22

Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70206 ) Change subject: mb/amd/mayan: Improve naming of EC FW ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70206/comment/24f5e7e0_d7692c6b PS1, Line 7: Correct > not sure if correct or improve would be better here Either should work. I think "improve" is better here. -- To view, visit https://review.coreboot.org/c/coreboot/+/70206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic789df11160e3ffe7b7294b11e1fa80e3c3961ed Gerrit-Change-Number: 70206 Gerrit-PatchSet: 2 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Dec 2022 16:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/amd/mayan: Correct naming of EC FW
by Felix Held (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70206 ) Change subject: mb/amd/mayan: Correct naming of EC FW ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70206/comment/796b9dc1_16afd1ed PS1, Line 7: Correct not sure if correct or improve would be better here -- To view, visit https://review.coreboot.org/c/coreboot/+/70206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic789df11160e3ffe7b7294b11e1fa80e3c3961ed Gerrit-Change-Number: 70206 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 16:27:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: MAINTAINERS: Add AMD mayan reference board
by Felix Held (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Jason Glenesk, Martin Roth, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70217 ) Change subject: MAINTAINERS: Add AMD mayan reference board ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85d4d4fe11f0b579c2327f3d1dfce90229ca9dc9 Gerrit-Change-Number: 70217 Gerrit-PatchSet: 2 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 16:26:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: superio/ite/it8772f/chip.h: Use 'bool' when appropriate
by Felix Held (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Elyes Haouas. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70253 ) Change subject: superio/ite/it8772f/chip.h: Use 'bool' when appropriate ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20c3298a920396718f0dc036e57faf8e46b82b2c Gerrit-Change-Number: 70253 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 02 Dec 2022 16:25:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022