Attention is currently required from: Eran Mitrani, Subrata Banik.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70166
to look at the new patch set (#12).
Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM
......................................................................
soc/intel/{adl, common}: provide a list of D-states to enter LPM
This was done previously for ADL. moving the code to common so
it can be leveraged for other platforms (e.g. MTL)
TEST=Built and tested on anahera by verifying SSDT contents
Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Signed-off-by: Eran Mitrani <mitrani(a)google.com>
---
M src/include/acpi/acpi.h
M src/soc/intel/alderlake/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/block/acpi/pep.c
M src/soc/intel/common/block/include/intelblocks/acpi.h
5 files changed, 206 insertions(+), 165 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/70166/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 12
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eran Mitrani, Subrata Banik.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70166
to look at the new patch set (#11).
Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM
......................................................................
soc/intel/{adl, common}: provide a list of D-states to enter LPM
This was done previously for ADL. moving the code to common so
it can be leveraged for other platforms (e.g. MTL)
TEST=Built and tested on anahera by verifying SSDT contents
Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Signed-off-by: Eran Mitrani <mitrani(a)google.com>
---
M src/include/acpi/acpi.h
M src/soc/intel/alderlake/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/block/acpi/pep.c
M src/soc/intel/common/block/include/intelblocks/acpi.h
5 files changed, 207 insertions(+), 165 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/70166/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 11
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, ritul guru, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70207 )
Change subject: mb/amd/mayan/gpio: Configure mayan GPIOs
......................................................................
Patch Set 2:
(4 comments)
File src/mainboard/amd/mayan/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/70207/comment/0d5c27bd_37b81d57
PS1, Line 39:
> do the gpios 78 and 79 (nvme ssd aux reset) also need to be configured in bootblock?
Done
File src/mainboard/amd/mayan/gpio.c:
https://review.coreboot.org/c/coreboot/+/70207/comment/61223999_69af4345
PS1, Line 112: /* Unused */
> is it unused or not available on the package?
Done
https://review.coreboot.org/c/coreboot/+/70207/comment/add16781_9070a5ea
PS1, Line 158: PAD_SCI(GPIO_139, PULL_UP, EDGE_LOW),
> this isn't a gevent capable gpio
Done
https://review.coreboot.org/c/coreboot/+/70207/comment/1afdb6ee_4872636d
PS1, Line 187: PAD_SCI(GPIO_157, PULL_UP, EDGE_LOW),
> this isn't a gevent capable gpio
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/70207
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I283afc716487fd8fa6d455194c382d87a3e6860b
Gerrit-Change-Number: 70207
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 02 Dec 2022 20:53:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Subrata Banik.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM
......................................................................
Patch Set 10:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165127):
https://review.coreboot.org/c/coreboot/+/70166/comment/de43ad0e_9191c849
PS10, Line 466: if ((dev->bus->secondary != 0 ) || (!states_arr))
space prohibited before that close parenthesis ')'
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 10
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 20:52:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Subrata Banik.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70166
to look at the new patch set (#10).
Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM
......................................................................
soc/intel/{adl, common}: provide a list of D-states to enter LPM
This was done previously for ADL. moving the code to common so
it can be leveraged for other platforms (e.g. MTL)
TEST=Built and tested on anahera by verifying SSDT contents
Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Signed-off-by: Eran Mitrani <mitrani(a)google.com>
---
M src/include/acpi/acpi.h
M src/soc/intel/alderlake/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/block/acpi/pep.c
M src/soc/intel/common/block/include/intelblocks/acpi.h
5 files changed, 207 insertions(+), 165 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/70166/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 10
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, ritul guru, Fred Reitberger.
Hello build bot (Jenkins), Jason Glenesk, ritul guru, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70207
to look at the new patch set (#2).
Change subject: mb/amd/mayan/gpio: Configure mayan GPIOs
......................................................................
mb/amd/mayan/gpio: Configure mayan GPIOs
Configure mayan GPIOs per schematic 105-D59700-00A Rev 1.00
Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com>
Change-Id: I283afc716487fd8fa6d455194c382d87a3e6860b
---
M src/mainboard/amd/mayan/early_gpio.c
M src/mainboard/amd/mayan/gpio.c
2 files changed, 252 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/70207/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70207
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I283afc716487fd8fa6d455194c382d87a3e6860b
Gerrit-Change-Number: 70207
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eran Mitrani, Subrata Banik.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/{adl,common}: provide a list of D-states to enter LPM
......................................................................
Patch Set 9:
(4 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/98d284b6_36d4a3c6
PS9, Line 31: LPI_REVISION_0
We should set explicit values for these in the enums. Or make them defines?
https://review.coreboot.org/c/coreboot/+/70166/comment/5c7285cd_f5f38bac
PS9, Line 35: LPI_DISANBLED,
LPI_DISABLED
https://review.coreboot.org/c/coreboot/+/70166/comment/d26297df_0200cdeb
PS9, Line 479: return the number of devices included
it seems we aren't returning anything
https://review.coreboot.org/c/coreboot/+/70166/comment/66e42291_13e1e5a7
PS9, Line 493: acpi_gen_default_lpi_constraints();
I think this can be cleaned up. If we are returning, we don't need the else.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 9
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 20:43:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/{adl,common}: provide a list of D-states to enter LPM
......................................................................
Patch Set 9:
(3 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/ca62edc2_7f6bd562
PS9, Line 458: states_arr
This check can be moved to the place where the variable `states_arr` is being used i.e. after line number 467.
https://review.coreboot.org/c/coreboot/+/70166/comment/c50f413e_87dcd0eb
PS9, Line 467: NONE
`ACPI_DEVICE_SLEEP_NONE`?
https://review.coreboot.org/c/coreboot/+/70166/comment/34d44b4b_41fdfedf
PS9, Line 494: return
it is not required anymore.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 9
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 20:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70166
to look at the new patch set (#9).
Change subject: soc/intel/{adl,common}: provide a list of D-states to enter LPM
......................................................................
soc/intel/{adl,common}: provide a list of D-states to enter LPM
This was done previously for ADL. moving the code to common so
it can be leveraged for other platforms (e.g. MTL)
TEST=Built and tested on anahera by verifying SSDT contents
Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Signed-off-by: Eran Mitrani <mitrani(a)google.com>
---
M src/include/acpi/acpi.h
M src/soc/intel/alderlake/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/block/acpi/pep.c
M src/soc/intel/common/block/include/intelblocks/acpi.h
5 files changed, 207 insertions(+), 165 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/70166/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 9
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset