coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: acpi: Helper functions to add certain _DSD properties
by Tarun Tuli (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Lance Zhao, Subrata Banik, Kapil Porwal, Tim Wawrzynczak. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70063 ) Change subject: acpi: Helper functions to add certain _DSD properties ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5bb432dd4e8f320d2c0d7f378dc2d7b3a770b541 Gerrit-Change-Number: 70063 Gerrit-PatchSet: 10 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 21:27:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Drop `board_id` check while configuring GPIO
by Tarun Tuli (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Subrata Banik, Eric Lai. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70224 ) Change subject: mb/google/rex: Drop `board_id` check while configuring GPIO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96cafd1c904001cbf4199977e9e721afe5eab470 Gerrit-Change-Number: 70224 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 21:25:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/{adl, common}: provide a list of D-states to enter LPM
by Tarun Tuli (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 ) Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM ...................................................................... Patch Set 12: (1 comment) File src/soc/intel/alderlake/acpi.c: https://review.coreboot.org/c/coreboot/+/70166/comment/8e3dbe35_5717c709 PS12, Line 226: struct min_sleep_state *get_min_sleep_state_array(size_t *size) > Wondering if we can get rid of these weak implementations. […] thinking about this more, im really not sure it makes things any cleaner. -- To view, visit https://review.coreboot.org/c/coreboot/+/70166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752 Gerrit-Change-Number: 70166 Gerrit-PatchSet: 12 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 21:16:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/{adl, common}: provide a list of D-states to enter LPM
by Tarun Tuli (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 ) Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM ...................................................................... Patch Set 12: (1 comment) File src/soc/intel/common/block/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/70166/comment/c78e82d9_b01edea5 PS9, Line 31: LPI_REVISION_0 > I removed the explicit values per Subrata's comment.. imho, I think it's important to have them incase anyone ever adds other things. In these cases, these values have specific meanings (values) in the specification and if someone inserts something, we could now be sending across the wrong values. @subrata, wdyt? -- To view, visit https://review.coreboot.org/c/coreboot/+/70166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752 Gerrit-Change-Number: 70166 Gerrit-PatchSet: 12 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 21:14:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Eran Mitrani <mitrani(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Drop `board_id` check while configuring GPIO
by Kapil Porwal (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Eric Lai. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70224 ) Change subject: mb/google/rex: Drop `board_id` check while configuring GPIO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96cafd1c904001cbf4199977e9e721afe5eab470 Gerrit-Change-Number: 70224 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 21:10:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/{adl, common}: provide a list of D-states to enter LPM
by Tarun Tuli (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 ) Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM ...................................................................... Patch Set 12: (1 comment) File src/soc/intel/alderlake/acpi.c: https://review.coreboot.org/c/coreboot/+/70166/comment/c68b6d4c_9ee021d1 PS12, Line 226: struct min_sleep_state *get_min_sleep_state_array(size_t *size) Wondering if we can get rid of these weak implementations. Perhaps instead the SoC specific code can just populate a list with its states. That list just happens to remain empty in the case that this functionality isn't setup for a particular platform. -- To view, visit https://review.coreboot.org/c/coreboot/+/70166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752 Gerrit-Change-Number: 70166 Gerrit-PatchSet: 12 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 21:04:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/amd/birman/gpio: Change non-GEvent GPIOs to PAD_INT
by Fred Reitberger (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Jason Glenesk, Felix Held. Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70282 ) Change subject: mb/amd/birman/gpio: Change non-GEvent GPIOs to PAD_INT ...................................................................... mb/amd/birman/gpio: Change non-GEvent GPIOs to PAD_INT Two GPIOs were set as SCI, but are not GEvent capable pins on morgana. Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I00dc1b2595c047ce6898b394061d119ac8680755 --- M src/mainboard/amd/birman/early_gpio.c M src/mainboard/amd/birman/gpio.c 2 files changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/70282/1 diff --git a/src/mainboard/amd/birman/early_gpio.c b/src/mainboard/amd/birman/early_gpio.c index 89f7ef9..a337e1e 100644 --- a/src/mainboard/amd/birman/early_gpio.c +++ b/src/mainboard/amd/birman/early_gpio.c @@ -23,7 +23,7 @@ /* ESPI_ALERT_L */ PAD_NF(GPIO_22, ESPI_ALERT_D1, PULL_NONE), /* TPM IRQ */ - PAD_SCI(GPIO_130, PULL_UP, EDGE_LOW), + PAD_INT(GPIO_130, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), /* SPI_ROM_REQ */ PAD_NF(GPIO_67, SPI_ROM_REQ, PULL_NONE), /* SPI_ROM_GNT */ diff --git a/src/mainboard/amd/birman/gpio.c b/src/mainboard/amd/birman/gpio.c index 50cf9db..d70fefd 100644 --- a/src/mainboard/amd/birman/gpio.c +++ b/src/mainboard/amd/birman/gpio.c @@ -65,7 +65,7 @@ /* ESPI_CS_L */ PAD_NF(GPIO_30, ESPI_CS_L, PULL_NONE), /* INT_CLKREQ_L */ - PAD_SCI(GPIO_31, PULL_UP, EDGE_LOW), + PAD_INT(GPIO_31, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), /* LPC_RST_L */ PAD_NF(GPIO_32, LPC_RST_L, PULL_NONE), /* GPIO_33 - GPIO_37: Not available */ @@ -138,7 +138,7 @@ PAD_NF(GPIO_116, CLK_REQ2_L, PULL_NONE), /* GPIO_117 - GPIO_129: Not available */ /* TPM IRQ */ - PAD_SCI(GPIO_130, PULL_UP, EDGE_LOW), + PAD_INT(GPIO_130, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), /* CLK_REQ3_L */ PAD_NF(GPIO_131, CLK_REQ3_L, PULL_NONE), /* CLK_REQ4_L */ -- To view, visit https://review.coreboot.org/c/coreboot/+/70282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00dc1b2595c047ce6898b394061d119ac8680755 Gerrit-Change-Number: 70282 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/common/block/include/gpio_defs.h: Fix documentation
by Fred Reitberger (Code Review) 02 Dec '22

02 Dec '22

Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70281 ) Change subject: soc/amd/common/block/include/gpio_defs.h: Fix documentation ...................................................................... soc/amd/common/block/include/gpio_defs.h: Fix documentation Fixing documentation of PAD_INT macro and replacing spaces with a tab to match the rest of the documentation. Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I72a2578ce21dd10b3beb65c706440c3379f216d6 --- M src/soc/amd/common/block/include/amdblocks/gpio_defs.h 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/70281/1 diff --git a/src/soc/amd/common/block/include/amdblocks/gpio_defs.h b/src/soc/amd/common/block/include/amdblocks/gpio_defs.h index 718a45c..c9d060d 100644 --- a/src/soc/amd/common/block/include/amdblocks/gpio_defs.h +++ b/src/soc/amd/common/block/include/amdblocks/gpio_defs.h @@ -160,7 +160,7 @@ * pin the pin to be programmed * pull pull up, pull down or no pull * trigger LEVEL_LOW, LEVEL_HIGH, EDGE_LOW, EDGE_HIGH, BOTH_EDGES - * action STATUS, DELIVER, STATUS_DELIVER + * action STATUS, DELIVER, STATUS_DELIVERY * PAD_SCI The pin is a SCI source * pin the pin to be programmed * pull pull up, pull down or no pull @@ -168,7 +168,7 @@ * PAD_SMI The pin is a SMI source * pin the pin to be programmed * pull pull up, pull down or no pull - * event trigger LEVEL_LOW, LEVEL_HIGH + * event trigger LEVEL_LOW, LEVEL_HIGH * PAD_NF_SCI Define native alternate function and confiure SCI source * pin the pin to be programmed * function the native function -- To view, visit https://review.coreboot.org/c/coreboot/+/70281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72a2578ce21dd10b3beb65c706440c3379f216d6 Gerrit-Change-Number: 70281 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: soc/intel/{adl, common}: provide a list of D-states to enter LPM
by Eran Mitrani (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 ) Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM ...................................................................... Patch Set 12: (6 comments) File src/soc/intel/common/block/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/70166/comment/c21f9880_9ade67e0 PS9, Line 31: LPI_REVISION_0 > We should set explicit values for these in the enums. […] I removed the explicit values per Subrata's comment.. https://review.coreboot.org/c/coreboot/+/70166/comment/f6817c90_14605613 PS9, Line 35: LPI_DISANBLED, > LPI_DISABLED Done https://review.coreboot.org/c/coreboot/+/70166/comment/7599c56b_cee69e92 PS9, Line 458: states_arr > This check can be moved to the place where the variable `states_arr` is being used i.e. […] Done https://review.coreboot.org/c/coreboot/+/70166/comment/74b375cd_d074057f PS9, Line 467: NONE > `ACPI_DEVICE_SLEEP_NONE`? Done https://review.coreboot.org/c/coreboot/+/70166/comment/d3610756_cba80007 PS9, Line 479: return the number of devices included > it seems we aren't returning anything Done https://review.coreboot.org/c/coreboot/+/70166/comment/d50c1202_cf075068 PS9, Line 493: acpi_gen_default_lpi_constraints(); > I think this can be cleaned up. If we are returning, we don't need the else. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/70166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752 Gerrit-Change-Number: 70166 Gerrit-PatchSet: 12 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 20:59:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/{adl, common}: provide a list of D-states to enter LPM
by Kapil Porwal (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Eran Mitrani, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 ) Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752 Gerrit-Change-Number: 70166 Gerrit-PatchSet: 12 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 20:59:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022