Attention is currently required from: Kane Chen, Sridhar Siricilla, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69189 )
Change subject: soc/intel/common/block/pcie/rtd3: Skip Power On if _STA returns 1
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> this function pcie_rtd3_acpi_method_status will create below acpi code
>
> it will return 1 if power pin is up
>
>
> Method (_STA, 0, NotSerialized) // _STA: Status
> {
> 0x6E = \_SB.PCI0.GTXS /* External reference */
> Local0
> Local1 = Zero
> If ((Local0 == Local1))
> {
> Return (Zero)
> }
> Else
> {
> Return (One)
> }
> }
ah, i missed acpigen_write_return_op(ONE_OP);
--
To view, visit https://review.coreboot.org/c/coreboot/+/69189
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I296ce1b85417a5dbaca558511cd7fc51a3a38c84
Gerrit-Change-Number: 69189
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:35:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Sridhar Siricilla, Nick Vaccaro.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69189 )
Change subject: soc/intel/common/block/pcie/rtd3: Skip Power On if _STA returns 1
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Do you know where we are setting the _STA for RTD3 power resource to `1`? […]
this function pcie_rtd3_acpi_method_status will create below acpi code
it will return 1 if power pin is up
Method (_STA, 0, NotSerialized) // _STA: Status
{
0x6E = \_SB.PCI0.GTXS /* External reference */
Local0
Local1 = Zero
If ((Local0 == Local1))
{
Return (Zero)
}
Else
{
Return (One)
}
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/69189
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I296ce1b85417a5dbaca558511cd7fc51a3a38c84
Gerrit-Change-Number: 69189
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Jason Nien, Martin Roth.
Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69191 )
Change subject: mb/google: Probe p-sensor only for selected variants
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69191/comment/92a7f978_2c315fa4
PS2, Line 12:
> Can you mention why this is necessary - we want to be able to select the legacy driver per-variant.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic00e0d9eafcef2c9eaf32571fecf6190777cec36
Gerrit-Change-Number: 69191
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:30:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Victor Ding, Jason Nien, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69192 )
Change subject: drivers/i2c/sx9324: Add support for Linux's SX9324 driver
......................................................................
Patch Set 5: Verified+1
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162364):
https://review.coreboot.org/c/coreboot/+/69192/comment/5f15465d_8b3eeebb
PS5, Line 9: SX9324 driver is updated per Linux's documentation found at
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/69192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42cd6841c3a270c242ed2e739db245e858eadb3b
Gerrit-Change-Number: 69192
Gerrit-PatchSet: 5
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Victor Ding <victording(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Victor Ding, Jason Nien, Martin Roth.
Hello build bot (Jenkins), Tarun Tuli, Jason Nien, Reka Norman, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69192
to look at the new patch set (#5).
Change subject: drivers/i2c/sx9324: Add support for Linux's SX9324 driver
......................................................................
drivers/i2c/sx9324: Add support for Linux's SX9324 driver
SX9324 driver is updated per Linux's documentation found at
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Doc…
Supporting logic for the deprecated SX932x driver is hence guarded by
DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER
This patch by itself does not introduce functional changes to any board.
BUG=b:242662878
TEST=Dump ACPI SSDT then verify _DSD entries related to the legacy
SX932x driver are identical w/ and w/o this patch
Change-Id: I42cd6841c3a270c242ed2e739db245e858eadb3b
Signed-off-by: Victor Ding <victording(a)google.com>
---
M src/drivers/i2c/sx9324/Kconfig
M src/drivers/i2c/sx9324/chip.h
M src/drivers/i2c/sx9324/registers.h
M src/drivers/i2c/sx9324/sx9324.c
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/dedede/Kconfig.name
M src/mainboard/google/zork/Kconfig.name
7 files changed, 201 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/69192/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42cd6841c3a270c242ed2e739db245e858eadb3b
Gerrit-Change-Number: 69192
Gerrit-PatchSet: 5
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Victor Ding <victording(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Victor Ding, Jason Nien, Martin Roth.
Hello build bot (Jenkins), Tarun Tuli, Jason Nien, Reka Norman, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69191
to look at the new patch set (#3).
Change subject: mb/google: Probe p-sensor only for selected variants
......................................................................
mb/google: Probe p-sensor only for selected variants
Only a subset of variants has proximity sensors.
This patch by itself does not introduce functional changes to any board.
It is mainly to ease migrating SX9324 from the legacy driver to the
linux one - allowing gradual migration variant by variant.
BUG=b:242662878
TEST=Dump ACPI SSDT then verify they are identical w/ and w/o this patch
Change-Id: Ic00e0d9eafcef2c9eaf32571fecf6190777cec36
Signed-off-by: Victor Ding <victording(a)google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/Kconfig.name
M src/mainboard/google/zork/Kconfig
M src/mainboard/google/zork/Kconfig.name
6 files changed, 31 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/69191/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/69191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic00e0d9eafcef2c9eaf32571fecf6190777cec36
Gerrit-Change-Number: 69191
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Victor Ding <victording(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kane Chen, Sridhar Siricilla, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69189 )
Change subject: soc/intel/common/block/pcie/rtd3: Skip Power On if _STA returns 1
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Do you know where we are setting the _STA for RTD3 power resource to `1`?
I could only see `acpigen_write_method("_STA", 0);` being set inside the rtd3 status method.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69189
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I296ce1b85417a5dbaca558511cd7fc51a3a38c84
Gerrit-Change-Number: 69189
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment