coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: mb/msi/ms7d25: Add support for DDR5 variant
by Michał Żygowski (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Felix Singer, Paul Menzel, Michał Kopeć, Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68448 ) Change subject: mb/msi/ms7d25: Add support for DDR5 variant ...................................................................... Patch Set 7: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68448/comment/254ac595_afb4be99 PS7, Line 10: difference is the board's DDR5 memory design. > The only difference seems to be the PCB revision. From internet pictures, the DDR4 version is rev. […] Why not, in the dmidecode outputs, I can see that the original firmware initialized the revision to 2.0 in SMBIOS tables. I will recheck in the lab what is imprinted on the board. Patchset: PS7: > Do you know if GPIO settings are the same for both board revisions? (DDR4 and DDR5) They are the same. It has been checked. File configs/config.dell_precision_t1650: PS7: > Oopsie? Yeah.. `$ history`: 2052 git add configs/ configs/config.msi_ms7d25_ddr5 -- To view, visit https://review.coreboot.org/c/coreboot/+/68448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I652a879d1616df4708fe4690797ad98384897f53 Gerrit-Change-Number: 68448 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:21:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: fix multiple jobs build issue
by build bot (Jenkins) (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Martin L Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69819 ) Change subject: Makefile.inc: fix multiple jobs build issue ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164052): https://review.coreboot.org/c/coreboot/+/69819/comment/61043b61_8f449cca PS1, Line 13: 'satisifed' may be misspelled - perhaps 'satisfied'? -- To view, visit https://review.coreboot.org/c/coreboot/+/69819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a70beedf2eb1c018c5ff98163904253f9a87a61 Gerrit-Change-Number: 69819 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:08:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: fix multiple jobs build issue
by Michał Żygowski (Code Review) 18 Nov '22

18 Nov '22

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69819 ) Change subject: Makefile.inc: fix multiple jobs build issue ...................................................................... Makefile.inc: fix multiple jobs build issue Certain C source files for coreboot stages require fmap_config.h to be present. When building coreboot using multiple jobs the dependency is not always satisifed due to race condition and results in make error. Workaround it by adding fmap_config.h to stage C deps. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I3a70beedf2eb1c018c5ff98163904253f9a87a61 --- M Makefile.inc 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/69819/1 diff --git a/Makefile.inc b/Makefile.inc index b4c2cdf..7ba6354 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -646,6 +646,14 @@ postcar-c-deps+=$(DEVICETREE_STATIC_C) smm-c-deps+=$(DEVICETREE_STATIC_C) +# Ensure fmap_config.h are created before any objects are compiled +ramstage-c-deps+=$(obj)/fmap_config.h +romstage-c-deps+=$(obj)/fmap_config.h +verstage-c-deps+=$(obj)/fmap_config.h +bootblock-c-deps+=$(obj)/fmap_config.h +postcar-c-deps+=$(obj)/fmap_config.h +smm-c-deps+=$(obj)/fmap_config.h + .PHONY: devicetree devicetree: $(DEVICETREE_STATIC_C) -- To view, visit https://review.coreboot.org/c/coreboot/+/69819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a70beedf2eb1c018c5ff98163904253f9a87a61 Gerrit-Change-Number: 69819 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: [RFC] Pull ligfxinit in romstage
by Angel Pons (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Andrey Petrov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 ) Change subject: [RFC] Pull ligfxinit in romstage ...................................................................... Patch Set 1: (1 comment) File src/arch/x86/car.ld: https://review.coreboot.org/c/coreboot/+/69757/comment/d38df034_976742f1 PS1, Line 122: > From the GNAT reference manual (`info gnat_rm`, 2.97 Pragma Linker_Section): […] Hmmm, don't we have some arcane magic for C code to put zero-initialized variables in a special section that gets zeroed out before the code gets executed? (`.bss` maybe?) Or does this not apply to Ada? -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:00:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/msi/ms7d25: Add support for DDR5 variant
by Angel Pons (Code Review) 18 Nov '22

18 Nov '22

1 0

[S] Change in coreboot[master]: mainboard/msi/ms7d25: Configure NCT6687D pin for PECI
by Angel Pons (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68711 ) Change subject: mainboard/msi/ms7d25: Configure NCT6687D pin for PECI ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90f142a1a9ee27dd061fc71b791bd4c7df97da6b Gerrit-Change-Number: 68711 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 14:54:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/msi/ms7d25: Add support for DDR5 variant
by Angel Pons (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Michał Kopeć. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68448 ) Change subject: mb/msi/ms7d25: Add support for DDR5 variant ...................................................................... Patch Set 7: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68448/comment/368c0c35_f416d7f7 PS7, Line 10: difference is the board's DDR5 memory design. The only difference seems to be the PCB revision. From internet pictures, the DDR4 version is rev. 1.1 and the DDR5 version is rev. 2.1 (there could be other revisions): https://imgur.com/a/SaKdFs4 Do you think it'd be a good idea to set the mainboard revision (or mainboard version) field in SMBIOS accordingly? File configs/config.dell_precision_t1650: PS7: Oopsie? File src/mainboard/msi/ms7d25/Kconfig: https://review.coreboot.org/c/coreboot/+/68448/comment/9ede2728_bb1c4b5b PS7, Line 35: default "Default string" Hmmm File src/mainboard/msi/ms7d25/romstage_fsp_params.c: https://review.coreboot.org/c/coreboot/+/68448/comment/c31bb7db_67e33d3b PS7, Line 15: .UserBd = BOARD_TYPE_DESKTOP_2DPC, No longer FIXME? Makes sense -- To view, visit https://review.coreboot.org/c/coreboot/+/68448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I652a879d1616df4708fe4690797ad98384897f53 Gerrit-Change-Number: 68448 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 14:53:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/msi/ms7d25/devicetree.cb: Disable SATA DEVSLP temporarily
by Michał Żygowski (Code Review) 18 Nov '22

18 Nov '22

Michał Żygowski has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68712 ) Change subject: mainboard/msi/ms7d25/devicetree.cb: Disable SATA DEVSLP temporarily ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/68712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b809851cefa339d172b95803aa8f49b441eddba Gerrit-Change-Number: 68712 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: payloads/external/edk2: Add option to clone edk2-platforms repo
by Michał Żygowski (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Martin L Roth, Paul Menzel, Stefan Reinauer. Hello build bot (Jenkins), Martin L Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68872 to look at the new patch set (#3). Change subject: payloads/external/edk2: Add option to clone edk2-platforms repo ...................................................................... payloads/external/edk2: Add option to clone edk2-platforms repo Add possibility to clone edk2-platforms repository. Some edk2 repositories may use modules from edk2-platforms which contains various feature packages for Intel platforms, e.g VT-d driver if DMA protection is enabled. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Iabd0793dfdcb95260046dc992ff30ef581159db9 --- M payloads/external/Makefile.inc M payloads/external/edk2/Kconfig M payloads/external/edk2/Makefile 3 files changed, 76 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/68872/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabd0793dfdcb95260046dc992ff30ef581159db9 Gerrit-Change-Number: 68872 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: [RFC] Pull ligfxinit in romstage
by Nico Huber (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Andrey Petrov. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 ) Change subject: [RFC] Pull ligfxinit in romstage ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: Very nice to see such quick progress! :D File src/arch/x86/car.ld: https://review.coreboot.org/c/coreboot/+/69757/comment/b6a5ab07_c326512a PS1, Line 122: > This "illegal globals" check is because global variables in these sections don't get initialized in […] From the GNAT reference manual (`info gnat_rm`, 2.97 Pragma Linker_Section): The compiler normally places library-level entities in standard sections depending on the class: procedures and functions generally go in the ‘.text’ section, initialized variables in the ‘.data’ section and uninitialized variables in the ‘.bss’ section. So the problem is not only the initial value but having an initialization (not having one might drive human readers and GNATprove crazy) even if it's `0` or `False`. Not sure if there is linker magic to filter 0-data from `.data`? File src/drivers/intel/fsp2_0/memory_init.c: https://review.coreboot.org/c/coreboot/+/69757/comment/f1b69ec8_35936498 PS1, Line 348: gma_gfxinit(&lightup_ok); > We might need to make this more flexible, so that you can initialize a VGA textmode framebuffer in r […] That's assuming we'd want to continue booting. But let's assume we do. The best thing to do would be to pass the state `GMA.Pipe_Configs` to ramstage, so it doesn't have to start from scratch. But for a start it would suffice to give `GMA.Initialize()` a `Clean_State => True` in ramstage if it already ran in romstage. -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 14:44:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022