coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional
by Subrata Banik (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Andrey Petrov, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60402 ) Change subject: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional ...................................................................... Patch Set 6: (2 comments) File src/drivers/intel/fsp2_0/notify.c: https://review.coreboot.org/c/coreboot/+/60402/comment/843c6b64_99be6dd5 PS6, Line 12: if (phase == AFTER_PCI_ENUM && CONFIG(SKIP_FSP_NOTIFY_PHASE_AFTER_PCI_ENUM)) : return false; : else if (phase == READY_TO_BOOT && CONFIG(SKIP_FSP_NOTIFY_PHASE_READY_TO_BOOT)) : return false; : else if (phase == END_OF_FIRMWARE && CONFIG(SKIP_FSP_NOTIFY_PHASE_END_OF_FIRMWARE)) : return false; : else : return true; > Idea: Use a switch statement? […] Ack https://review.coreboot.org/c/coreboot/+/60402/comment/d5f3b95a_1ce2c1bd PS6, Line 41: timestamp_add_now(TS_FSP_BEFORE_ENUMERATE); : post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE); > Maybe we could have a struct to store the per-phase information. I'll try to do something. this is good idea and then you can pass the structure variable to the below function call as below? struct fsp_notify_info { unsigned int phase; unsigned int ts; unsigned int post_code } info[] = { { .phase = AFTER_PCI_ENUM, .ts = TS_FSP_BEFORE_FINALIZE, .post_code = POST_FSP_NOTIFY_BEFORE_FINALIZE, }, { .phase = READY_TO_BOOT, .ts = TS_FSP_BEFORE_ENUMERATE, .post_code = POST_FSP_NOTIFY_BEFORE_ENUMERATE, }, { .phase = END_OF_FIRMWARE, .ts = TS_FSP_BEFORE_END_OF_FIRMWARE, .post_code = POST_FSP_NOTIFY_BEFORE_END_OF_FIRMWARE, } } for (int i = 0; i < ARRAY_SIZE(info); i++) { if (phase == info[i].phase) { timestamp_add_now(info[i].ts); post_code(info[i].post_code); } } -- To view, visit https://review.coreboot.org/c/coreboot/+/60402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia95e9ec25ae797f2ac8e1c74145cf21e59867d64 Gerrit-Change-Number: 60402 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 14:55:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: pci_device.c: Don't guard `pci_dev_disable_bus_master()`
by Felix Held (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Felix Singer, Angel Pons. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60599 ) Change subject: pci_device.c: Don't guard `pci_dev_disable_bus_master()` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I813e0f72c3c624c73ab9ecbe7512359608ace927 Gerrit-Change-Number: 60599 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 14:55:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin/acpi: Replace Index() with ASL 2.0 syntax
by 9elements QA (Code Review) 01 Jan '22

01 Jan '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60561 ) Change subject: ec/starlabs/merlin/acpi: Replace Index() with ASL 2.0 syntax ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/86903 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/86902 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/86901 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/86900 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/86899 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/86898 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/86897 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/86896 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88cb974ed808b602a9398c9c3e363cb145420528 Gerrit-Change-Number: 60561 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 01 Jan 2022 14:52:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/blk/crashlog: Drop some new lines
by Subrata Banik (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Felix Singer, Elyes HAOUAS, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60622 ) Change subject: soc/intel/common/blk/crashlog: Drop some new lines ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60622/comment/6756aa61_371756ad PS1, Line 7: soc/intel/common: Remove unnecessary new lines throughout the crashlog.c > How about: […] Thanks for the suggestion. Marking it close now. Wishing you a very happy new year. -- To view, visit https://review.coreboot.org/c/coreboot/+/60622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0920f563d6fdf9414eab86796cedcac83173dba3 Gerrit-Change-Number: 60622 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Elyes HAOUAS Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 01 Jan 2022 14:43:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/blk/crashlog: Drop some new lines
by Subrata Banik (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Felix Singer, Elyes HAOUAS, Subrata Banik, Patrick Rudolph. Hello Felix Singer, Elyes HAOUAS, build bot (Jenkins), Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60622 to look at the new patch set (#2). Change subject: soc/intel/common/blk/crashlog: Drop some new lines ...................................................................... soc/intel/common/blk/crashlog: Drop some new lines Remove unnecessary new lines in crashlog code. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I0920f563d6fdf9414eab86796cedcac83173dba3 --- M src/soc/intel/common/block/crashlog/crashlog.c 1 file changed, 0 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/60622/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0920f563d6fdf9414eab86796cedcac83173dba3 Gerrit-Change-Number: 60622 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Elyes HAOUAS Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vendorcode/intel/fsp/elkhartlake: Drop obsolete headers
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60541 ) Change subject: vendorcode/intel/fsp/elkhartlake: Drop obsolete headers ...................................................................... vendorcode/intel/fsp/elkhartlake: Drop obsolete headers Elkhart Lake was hooked up to the FSP repo with commit 79fcadb3c46 (soc/intel/elkhartlake: Use FSP from FSP repo by default) making these headers obsolete. Thus, drop them. Change-Id: I2d6a4d4614ae21d5b8e77eceb85baa13e491c2ae Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60541 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspUpd.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspsUpd.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FsptUpd.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/MemInfoHob.h 6 files changed, 0 insertions(+), 8,501 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d6a4d4614ae21d5b8e77eceb85baa13e491c2ae Gerrit-Change-Number: 60541 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/jecht/acpi: Replace LNot() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60598 ) Change subject: mb/google/jecht/acpi: Replace LNot() with ASL 2.0 syntax ...................................................................... mb/google/jecht/acpi: Replace LNot() with ASL 2.0 syntax Replace `LNot (a)` with `!a`. Change-Id: I4a9165b4610d7d035509b7f10eed0d9847afca1f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60598 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 4 files changed, 20 insertions(+), 20 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl index c04b37e..c8808dd 100644 --- a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl @@ -165,7 +165,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (0, \FLVL) Store (FAN0_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -192,7 +192,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (1, \FLVL) Store (FAN1_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -219,7 +219,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (2, \FLVL) Store (FAN2_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -246,7 +246,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (3, \FLVL) Store (FAN3_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -273,7 +273,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (4, \FLVL) Store (FAN4_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) diff --git a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl index c04b37e..c8808dd 100644 --- a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl @@ -165,7 +165,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (0, \FLVL) Store (FAN0_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -192,7 +192,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (1, \FLVL) Store (FAN1_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -219,7 +219,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (2, \FLVL) Store (FAN2_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -246,7 +246,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (3, \FLVL) Store (FAN3_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -273,7 +273,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (4, \FLVL) Store (FAN4_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) diff --git a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl index c04b37e..c8808dd 100644 --- a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl @@ -165,7 +165,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (0, \FLVL) Store (FAN0_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -192,7 +192,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (1, \FLVL) Store (FAN1_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -219,7 +219,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (2, \FLVL) Store (FAN2_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -246,7 +246,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (3, \FLVL) Store (FAN3_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -273,7 +273,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (4, \FLVL) Store (FAN4_PWM, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index 5fe7a18..2a7b3f0 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -273,7 +273,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (0, \FLVL) Store (F0PW, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -300,7 +300,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (1, \FLVL) Store (F1PW, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -327,7 +327,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (2, \FLVL) Store (F2PW, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -354,7 +354,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (3, \FLVL) Store (F3PW, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) @@ -381,7 +381,7 @@ } } Method (_ON) { - If (LNot (_STA ())) { + If (! _STA ()) { Store (4, \FLVL) Store (F4PW, \_SB.PCI0.LPCB.SIO.ENVC.F2PS) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a9165b4610d7d035509b7f10eed0d9847afca1f Gerrit-Change-Number: 60598 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Replace LNot() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60597 ) Change subject: ec/smsc/mec1308/acpi: Replace LNot() with ASL 2.0 syntax ...................................................................... ec/smsc/mec1308/acpi: Replace LNot() with ASL 2.0 syntax Replace `LNot (a)` with `!a`. Change-Id: I16e30f4a774c8ffca3bdbbf57c9a0c6f6d3ca72c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60597 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index 59d6c4f..0cc41a1 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -148,7 +148,7 @@ Local1++ } - If (BFWK && ACEX && LNot (Local0)) { + If (BFWK && ACEX && !Local0) { // On AC power and battery is neither charging // nor discharging. Linux expects a full battery // to report same capacity as last full charge. 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16e30f4a774c8ffca3bdbbf57c9a0c6f6d3ca72c Gerrit-Change-Number: 60597 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: superio/winbond/w83627hf/acpi: Replace LNot() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60596 ) Change subject: superio/winbond/w83627hf/acpi: Replace LNot() with ASL 2.0 syntax ...................................................................... superio/winbond/w83627hf/acpi: Replace LNot() with ASL 2.0 syntax Replace `LNot (a)` with `!a`. Change-Id: I9f08cc180614e7d966256b2944745b0bc1d29865 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60596 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/superio/winbond/w83627hf/acpi/superio.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl index 326b717..cc4bb87 100644 --- a/src/superio/winbond/w83627hf/acpi/superio.asl +++ b/src/superio/winbond/w83627hf/acpi/superio.asl @@ -306,7 +306,7 @@ EXIT_CONFIG_MODE () ShiftLeft(Local1, 8, Local1) Or(Local1, Local2, Local1) - If (LNot(Local0)) { + If (!Local0) { Return (FDE) } @@ -724,7 +724,7 @@ { Store (0x00, Local0) ENTER_CONFIG_MODE (3) - If (LNot(And(OPT2, 0x30))) + If (!And(OPT2, 0x30)) { If (ACTR) { Store (0x0F, Local0) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f08cc180614e7d966256b2944745b0bc1d29865 Gerrit-Change-Number: 60596 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace LNot() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60595 ) Change subject: ec/quanta/it8518/acpi: Replace LNot() with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace LNot() with ASL 2.0 syntax Replace `LNot (a)` with `!a`. Change-Id: I98ac7a9c1cd16609cf6bd38e1bd9bf8cf54817fb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60595 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 5b51c89..4fcc30c 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -275,7 +275,7 @@ } Else { - If (LNot (AND (Local0, 2))) + If (!(AND (Local0, 2))) { // Battery is not charging Store (Zero, Local1) @@ -306,7 +306,7 @@ Store (ECRC, Local1) } - If (BFWK && ACPW && LNot (Local0)) + If (BFWK && ACPW && !Local0) { // On AC power and battery is neither charging // nor discharging. Linux expects a full battery 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60595 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98ac7a9c1cd16609cf6bd38e1bd9bf8cf54817fb Gerrit-Change-Number: 60595 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022