coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace Decrement() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60586 ) Change subject: mb/aopen/dxplplusu/acpi: Replace Decrement() with ASL 2.0 syntax ...................................................................... mb/aopen/dxplplusu/acpi: Replace Decrement() with ASL 2.0 syntax Replace `Decrement (a)` with `a--`. Change-Id: I4320d86ce91e7070dc10fcefff6cbc0956be9788 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60586 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl index d258ec9..f8c7b2e 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl @@ -49,7 +49,7 @@ CreateDWordField (MSBF, \_SB.MBRS._Y1D._LEN, MEM2) And (\_SB.PCI0.TOLM, 0xF800, Local1) ShiftRight (Local1, 0x04, Local1) - Decrement (Local1) + Local1-- If (LGreater (Local1, 0x10)) { Local1 -= 0x0F -- To view, visit https://review.coreboot.org/c/coreboot/+/60586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4320d86ce91e7070dc10fcefff6cbc0956be9788 Gerrit-Change-Number: 60586 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace Increment() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60585 ) Change subject: mb/aopen/dxplplusu/acpi: Replace Increment() with ASL 2.0 syntax ...................................................................... mb/aopen/dxplplusu/acpi: Replace Increment() with ASL 2.0 syntax Replace `Increment(a)` with `a++`. Change-Id: I52315e71a51de5c85f11d68854dfe68a474d5cbe Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60585 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl index 29a8170..d258ec9 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl @@ -37,7 +37,7 @@ CreateQWordField (MSBF, \_SB.MBRS._Y1C._LEN, LELM) And (\_SB.PCI0.RLAR, 0x03FF, Local1) - Increment (Local1) + Local1++ If (LGreater (Local1, 0x40)) { ShiftLeft (Local1, 0x1A, LELM) -- To view, visit https://review.coreboot.org/c/coreboot/+/60585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52315e71a51de5c85f11d68854dfe68a474d5cbe Gerrit-Change-Number: 60585 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/quanta/ene_kb3940q/acpi: Replace Increment() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60584 ) Change subject: ec/quanta/ene_kb3940q/acpi: Replace Increment() with ASL 2.0 syntax ...................................................................... ec/quanta/ene_kb3940q/acpi: Replace Increment() with ASL 2.0 syntax Replace `Increment(a)` with `a++`. Change-Id: Ic009a868e98cc23dff16154244d65080c1edfa22 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60584 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/quanta/ene_kb3940q/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/quanta/ene_kb3940q/acpi/ec.asl b/src/ec/quanta/ene_kb3940q/acpi/ec.asl index 6d22f9a..12f0809 100644 --- a/src/ec/quanta/ene_kb3940q/acpi/ec.asl +++ b/src/ec/quanta/ene_kb3940q/acpi/ec.asl @@ -180,7 +180,7 @@ Local1 = PPCM - 1 If(LLess(Local0, Local1)) { - Increment(Local0) + Local0++ \PPCN () } -- To view, visit https://review.coreboot.org/c/coreboot/+/60584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic009a868e98cc23dff16154244d65080c1edfa22 Gerrit-Change-Number: 60584 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Increment() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60583 ) Change subject: ec/quanta/it8518/acpi: Replace Increment() with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace Increment() with ASL 2.0 syntax Replace `Increment(a)` with `a++`. Change-Id: I5de24042a1a69975c980f6ef10babf6f478b8d69 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60583 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/quanta/it8518/acpi/ec.asl 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/quanta/it8518/acpi/ec.asl b/src/ec/quanta/it8518/acpi/ec.asl index ea6f730..3d1e244 100644 --- a/src/ec/quanta/it8518/acpi/ec.asl +++ b/src/ec/quanta/it8518/acpi/ec.asl @@ -556,8 +556,7 @@ // TODO Which temperature corresponds to the CPU? Store (TMP0, Local0) /* So that we don't get a warning that Local0 is unused. */ - Increment (Local0) - + Local0++ } /* Attention Codes -- To view, visit https://review.coreboot.org/c/coreboot/+/60583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5de24042a1a69975c980f6ef10babf6f478b8d69 Gerrit-Change-Number: 60583 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Replace Increment() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60582 ) Change subject: ec/smsc/mec1308/acpi: Replace Increment() with ASL 2.0 syntax ...................................................................... ec/smsc/mec1308/acpi: Replace Increment() with ASL 2.0 syntax Replace `Increment(a)` with `a++`. Change-Id: Ib2154767cfc547ca9bd0a23937d50689be13fbcf Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60582 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/smsc/mec1308/acpi/battery.asl M src/ec/smsc/mec1308/acpi/ec.asl 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index 2aa5ace..59d6c4f 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -135,7 +135,7 @@ Store (SWAB (BTPR), Local1) If (LNotEqual (Local1, 0xFFFFFFFF) && LGreaterEqual (Local1, 0x8000)) { Xor (Local1, 0xFFFF, Local1) - Increment (Local1) + Local1++ } Store (Local1, PBST[1]) @@ -145,7 +145,7 @@ Store (SWAB (BTRA), Local1) If (LNotEqual (Local1, 0xFFFFFFFF) && LGreaterEqual (Local1, 0x8000)) { Xor (Local1, 0xFFFF, Local1) - Increment (Local1) + Local1++ } If (BFWK && ACEX && LNot (Local0)) { diff --git a/src/ec/smsc/mec1308/acpi/ec.asl b/src/ec/smsc/mec1308/acpi/ec.asl index c7b180d..23b4c69 100644 --- a/src/ec/smsc/mec1308/acpi/ec.asl +++ b/src/ec/smsc/mec1308/acpi/ec.asl @@ -69,7 +69,7 @@ // Force a read of CPU temperature Store (CPUT, Local0) /* So that we don't get a warning that Local0 is unused. */ - Increment (Local0) + Local0++ } PowerResource (FNP0, 0, 0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2154767cfc547ca9bd0a23937d50689be13fbcf Gerrit-Change-Number: 60582 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Increment() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60581 ) Change subject: soc/intel/apollolake/acpi: Replace Increment() with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Increment() with ASL 2.0 syntax Replace `Increment(a)` with `a++`. Change-Id: I40d5df41e2e077cb9d3e7f3945f0dbae18382a28 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60581 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/apollolake/acpi/pcie_port.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/apollolake/acpi/pcie_port.asl b/src/soc/intel/apollolake/acpi/pcie_port.asl index 710051b..34e2a73 100644 --- a/src/soc/intel/apollolake/acpi/pcie_port.asl +++ b/src/soc/intel/apollolake/acpi/pcie_port.asl @@ -75,7 +75,7 @@ Break } Sleep (16) - Increment (Local0) + Local0++ } } /* End PDS condition check */ } @@ -95,7 +95,7 @@ Break } Sleep (16) - Increment (Local0) + Local0++ } Store (1, BDQA) /* Set BLKDQDA to 1 */ Store (1, BPLL) /* Set BLKPLLEN to 1 */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40d5df41e2e077cb9d3e7f3945f0dbae18382a28 Gerrit-Change-Number: 60581 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace Increment() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60580 ) Change subject: drivers/intel/gma/acpi: Replace Increment() with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace Increment() with ASL 2.0 syntax Replace `Increment(a)` with `a++`. Change-Id: If0c11f43713bf7afec6dd600289776eefd1331e8 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60580 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/drivers/intel/gma/acpi/common.asl M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl index 02169ae..0cf28fa 100644 --- a/src/drivers/intel/gma/acpi/common.asl +++ b/src/drivers/intel/gma/acpi/common.asl @@ -58,7 +58,7 @@ Store (BRID (XBQC ()), Local0) If (LNotEqual (Local0, SizeOf(BRIG) - 1)) { - Increment (Local0) + Local0++ } XBCM (DerefOf (BRIG[Local0])) } diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index f0e6c31..99d2bc5 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -134,7 +134,7 @@ } } - Increment (Local1) + Local1++ } /* Didn't find greater/equal value: use the last */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c11f43713bf7afec6dd600289776eefd1331e8 Gerrit-Change-Number: 60580 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: arch/x86/acpi: Replace Increment() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60579 ) Change subject: arch/x86/acpi: Replace Increment() with ASL 2.0 syntax ...................................................................... arch/x86/acpi: Replace Increment() with ASL 2.0 syntax Replace `Increment(a)` with `a++`. Change-Id: I45ce13509f3e93d7d8cd69689604f24b926bcfbc Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60579 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/arch/x86/acpi/debug.asl M src/arch/x86/acpi/globutil.asl 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/arch/x86/acpi/debug.asl b/src/arch/x86/acpi/debug.asl index fd071f8..60f1595 100644 --- a/src/arch/x86/acpi/debug.asl +++ b/src/arch/x86/acpi/debug.asl @@ -153,7 +153,7 @@ return (0) } OUTC(Local0) - Increment(Local1) + Local1++ } } return (0) diff --git a/src/arch/x86/acpi/globutil.asl b/src/arch/x86/acpi/globutil.asl index 3a7144d..e47b7f2 100644 --- a/src/arch/x86/acpi/globutil.asl +++ b/src/arch/x86/acpi/globutil.asl @@ -50,7 +50,7 @@ Return(Ones) } } - Increment(Local4) + Local4++ } if (LLess(Local4, Local5)) { Return(One) @@ -82,7 +82,7 @@ Derefof(Local1[Local2]))) { Return(0) } - Increment(Local2) + Local2++ } Return(One) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60579 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45ce13509f3e93d7d8cd69689604f24b926bcfbc Gerrit-Change-Number: 60579 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace LOr() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60578 ) Change subject: mb/aopen/dxplplusu/acpi: Replace LOr() with ASL 2.0 syntax ...................................................................... mb/aopen/dxplplusu/acpi: Replace LOr() with ASL 2.0 syntax Replace `LOr (a, b)` with `a || b`. Change-Id: Ib563f8ce5873e53c94992d81e78118a1194fc9af Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60578 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/aopen/dxplplusu/acpi/superio.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/aopen/dxplplusu/acpi/superio.asl b/src/mainboard/aopen/dxplplusu/acpi/superio.asl index 9889032..d3ae867 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/superio.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/superio.asl @@ -144,7 +144,7 @@ Store (0x00, LED1) } - If (LOr (LEqual (Arg0, 0x01), LEqual (Arg0, 0x02))) + If (LEqual (Arg0, 0x01) || LEqual (Arg0, 0x02)) { Store (0x01, LED1) } @@ -154,7 +154,7 @@ Store (0x02, LED1) } - If (LOr (LEqual (Arg0, 0x04), LEqual (Arg0, 0x05))) + If (LEqual (Arg0, 0x04) || LEqual (Arg0, 0x05)) { Store (0x03, LED1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib563f8ce5873e53c94992d81e78118a1194fc9af Gerrit-Change-Number: 60578 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/jecht: Replace LOr() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60577 ) Change subject: mb/google/jecht: Replace LOr() with ASL 2.0 syntax ...................................................................... mb/google/jecht: Replace LOr() with ASL 2.0 syntax Replace `LOr (a, b)` with `a || b`. Change-Id: Ib34e8af6668e3c875fabd1fa84862109afa94d18 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60577 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl index e156306..c04b37e 100644 --- a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl @@ -69,7 +69,7 @@ } // Check for invalid readings - If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { + If (LEqual (Local0, 255) || LEqual (Local0, 0)) { Return (CTOK (FAN0_THRESHOLD_ON)) } diff --git a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl index e156306..c04b37e 100644 --- a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl @@ -69,7 +69,7 @@ } // Check for invalid readings - If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { + If (LEqual (Local0, 255) || LEqual (Local0, 0)) { Return (CTOK (FAN0_THRESHOLD_ON)) } diff --git a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl index e156306..c04b37e 100644 --- a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl @@ -69,7 +69,7 @@ } // Check for invalid readings - If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { + If (LEqual (Local0, 255) || LEqual (Local0, 0)) { Return (CTOK (FAN0_THRESHOLD_ON)) } diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index 050e2d5..5fe7a18 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -112,7 +112,7 @@ } // Check for invalid readings - If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { + If (LEqual (Local0, 255) || LEqual (Local0, 0)) { Store (THERMAL_POLICY_0_THRESHOLD_ON, Local0) } @@ -177,7 +177,7 @@ } // Check for invalid readings - If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { + If (LEqual (Local0, 255) || LEqual (Local0, 0)) { Return (CTOK (FAN0_0_THRESHOLD_ON)) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib34e8af6668e3c875fabd1fa84862109afa94d18 Gerrit-Change-Number: 60577 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022